93045 2012-08-02 16:29:48 -0700 Consider removing PlatformEvent::GestureDoubleTap 2013-03-20 12:32:13 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93044 1 rbyers rbyers esprehn+autocc miletus ojan.autocc rbyers rjkroege sadrul tdanderson tonikitoo webkit.review.bot oldest_to_newest 685971 0 rbyers 2012-08-02 16:29:48 -0700 In bug 93044, support is added for handling double tap gestures based on a 'tap count' supplied with the GestureTap. This makes GestureDoubleTap somewhat redundant and not very useful. We should probably remove it. 855459 1 193178 miletus 2013-03-14 13:45:29 -0700 Created attachment 193178 Patch 855605 2 193178 rbyers 2013-03-14 17:42:39 -0700 Comment on attachment 193178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193178&action=review Looks good, but I've got one suggestion for making this a little cleaner. > Source/WebCore/ChangeLog:3 > + Consider removing PlatformEvent::GestureDoubleTap Update bug title to 'remove' now that we're sure it can be done > Source/WebKit/chromium/src/WebInputEventConversion.cpp:190 > + m_type = PlatformEvent::NoType; This is a little odd. Ideally we could just ensure that PlatformEvent::GestureDoubleTap never got here in the first place. I know it's used in chromium WebKit for Android (where it probably doesn't make sense to use GestureTap with a tap count check since the semantics are different on Android - DoubleTap is not preceeded by a Tap event since Tap is delayed 300ms). Perhaps we could cut it off there and never try to create a PlatformGestureEvent for it at all (relying on the ASSERT_NOT_REACHED below as a backstop)? That would also require landing the Aura gesture-recognizer side change first (removing ET_GESTURE_DOUBLE_TAP) since we're still dispatching that (even though it's redundant). 856098 3 193336 miletus 2013-03-15 10:47:52 -0700 Created attachment 193336 Patch 856104 4 193178 miletus 2013-03-15 10:58:45 -0700 Comment on attachment 193178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193178&action=review >> Source/WebKit/chromium/src/WebInputEventConversion.cpp:190 >> + m_type = PlatformEvent::NoType; > > This is a little odd. Ideally we could just ensure that PlatformEvent::GestureDoubleTap never got here in the first place. I know it's used in chromium WebKit for Android (where it probably doesn't make sense to use GestureTap with a tap count check since the semantics are different on Android - DoubleTap is not preceeded by a Tap event since Tap is delayed 300ms). Perhaps we could cut it off there and never try to create a PlatformGestureEvent for it at all (relying on the ASSERT_NOT_REACHED below as a backstop)? > > That would also require landing the Aura gesture-recognizer side change first (removing ET_GESTURE_DOUBLE_TAP) since we're still dispatching that (even though it's redundant). Right, in the new patch I drop the WebInputEvent::GestureDoubleTap in WebViewImpl so no GestureDoubleTap will reach WebCore. Also a chromium patch is under review that will remove the path that can generate WebInputEvent::GestureDoubleTap so to make this WebInpuEvent -> PlatformEvent conversion safe. 856135 5 rbyers 2013-03-15 11:28:57 -0700 Looks good to me. You'll need a reviewer to take a look though. Perhaps tonikitoo? I don' think any other port was using GestureDoubleTap, but EWS will tell us for sure now that we'll get build errors if anyone tries to use PlatformEvent::GestureDoubleTap. 859612 6 193336 webkit.review.bot 2013-03-20 12:29:42 -0700 Comment on attachment 193336 Patch Clearing flags on attachment: 193336 Committed r146378: <http://trac.webkit.org/changeset/146378> 859613 7 webkit.review.bot 2013-03-20 12:29:45 -0700 All reviewed patches have been landed. Closing bug. 193178 2013-03-14 13:45:29 -0700 2013-03-15 10:58:45 -0700 Patch bug-93045-20130314164125.patch text/plain 6360 miletus U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdiYTI4YTE1OGRiNzhj ZjI1OTM1OGQzNDAzOWI0NGI2NjI3Yzc3ZC4uYzQ3YjlkZWQyMGZjM2EwM2I2NmI1ZGYzMGFlMzE2 ZWYwNGQ3MWU4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAzLTE0ICBZdWZl bmcgU2hlbiAgPG1pbGV0dXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvbnNpZGVyIHJlbW92 aW5nIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVEb3VibGVUYXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURvdWJsZVRh cCBpcyBub3QgY3VycmVudGx5CisgICAgICAgIHVzZWQgaW4gV2ViQ29yZSBhbmQgcmVwbGFjZWQg YnkgR2VzdHVyZVRhcCB3aXRoCisgICAgICAgIHRhcCBjb3VudCAyLCBzbyByZW1vdmUgaXQuCisK KyAgICAgICAgVGVzdDogV2UgYXJlIHJlbW92aW5nIHNvbWV0aGluZyB0aGF0IGlzIG5vdCB1c2Vk LCBzbworICAgICAgICBubyBuZXcgdGVzdC4gQWxsIGV4aXN0aW5nIHRlc3RzIHBhc3MuCisKKyAg ICAgICAgKiBkb20vR2VzdHVyZUV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdlc3R1cmVF dmVudDo6Y3JlYXRlKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVFdmVudCk6CisgICAgICAgICog cGxhdGZvcm0vUGxhdGZvcm1FdmVudC5oOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Bv cHVwQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyOjpoYW5k bGVHZXN0dXJlRXZlbnQpOgorCiAyMDEzLTAzLTE0ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gR3JhZGllbnQ6IGRvbid0IHVzZSB0 aGUgZGVmYXVsdCBzZXRQbGF0Zm9ybUdyYWRpZW50U3BhY2VUcmFuc2Zvcm0oKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwppbmRleCA1YmI2NDViY2FmNmFhOTlmNGM2NzkxYzAwYTFlMmYzNmYyNDNi MzVkLi4xODA0NDNiYzJkMzQxNDM2M2NkNjcwYjM4NGU3OGM0OGNhYTMwMDVmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE0ICBZdWZlbmcgU2hl biAgPG1pbGV0dXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvbnNpZGVyIHJlbW92aW5nIFBs YXRmb3JtRXZlbnQ6Okdlc3R1cmVEb3VibGVUYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURvdWJsZVRhcCBpcyBu b3QgY3VycmVudGx5CisgICAgICAgIHVzZWQgaW4gV2ViQ29yZSBhbmQgd2UgYXJlIHJlbW92aW5n IGl0LiBGb3IgdGhlCisgICAgICAgIGNvbXBsZXRuZXNzIG9mIGNvbnZlcnRpbmcgYWxsIFdlYkdl c3R1cmVFdmVudCB0bworICAgICAgICBQbGF0Zm9ybUV2ZW50LCB3ZSBjb252ZXJ0IEdlc3R1cmVE b3VibGVUYXAgdG8KKyAgICAgICAgTm9UeXBlLgorCisgICAgICAgICogc3JjL1dlYklucHV0RXZl bnRDb252ZXJzaW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1HZXN0dXJlRXZlbnRC dWlsZGVyOjpQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXIpOgorCiAyMDEzLTAzLTE0ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLiAgUm9sbGVkIENocm9taXVtIERFUFMgdG8gcjE4ODAwNC4gIFJlcXVlc3RlZCBieQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vR2VzdHVyZUV2ZW50LmNwcAppbmRleCBlMDY3MWY4OWFiMTM0MWU2YjhlNWFiZDM4 YWUwZjAxMTQ0YzIxYTQzLi41NTQxYWM2YmZhYTdhMWUxN2NiYzhmYjVjOWJiNWNiYzM4YTkwY2M1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vR2VzdHVyZUV2ZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vR2VzdHVyZUV2ZW50LmNwcApAQCAtNTMsNyArNTMsNiBAQCBQYXNz UmVmUHRyPEdlc3R1cmVFdmVudD4gR2VzdHVyZUV2ZW50OjpjcmVhdGUoUGFzc1JlZlB0cjxBYnN0 cmFjdFZpZXc+IHZpZXcsIGNvbgogICAgICAgICBldmVudFR5cGUgPSBldmVudE5hbWVzKCkuZ2Vz dHVyZXRhcEV2ZW50OyBicmVhazsKICAgICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXBE b3duOgogICAgICAgICBldmVudFR5cGUgPSBldmVudE5hbWVzKCkuZ2VzdHVyZXRhcGRvd25FdmVu dDsgYnJlYWs7Ci0gICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlRG91YmxlVGFwOgogICAg IGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVR3b0ZpbmdlclRhcDoKICAgICBjYXNlIFBsYXRm b3JtRXZlbnQ6Okdlc3R1cmVMb25nUHJlc3M6CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0 dXJlUGluY2hCZWdpbjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBmZjE0 NDk3NGJjYjI1NmJhMDU5OGUwOWJmNjJiZjUwYWU4ZDMzYWYxLi4yZWJlMzIxOWYzZGVjNzUzZTc2 ODA5NGU0ODgzZDU1MWM2NmRiZWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CkBAIC0yNDU0LDkgKzI0NTQsNyBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVRh cERvd24oKQogCiBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFBs YXRmb3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZlbnQpCiB7Ci0gICAgLy8gV2UgZG9uJ3QgdXNl IERvdWJsZVRhcCBhdCB0aGUgbW9tZW50LCBpdCdzIG1vc3RseSByZWR1bmRhbnQgd2l0aCB0YXAg c2luY2UgdGFwIG5vdyBjb250YWlucwotICAgIC8vIGEgdGFwIGNvdW50LiBGSVhNRTogV2Ugc2hv dWxkIHByb2JhYmx5IHJlbW92ZSBHZXN0dXJlRG91YmxlVGFwIChodHRwOi8vd2tiLnVnLzkzMDQ1 KS4KLSAgICBpZiAoZ2VzdHVyZUV2ZW50LnR5cGUoKSA9PSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJl RG91YmxlVGFwKQorICAgIGlmIChnZXN0dXJlRXZlbnQudHlwZSgpID09IFBsYXRmb3JtRXZlbnQ6 Ok5vVHlwZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgTm9kZSogZXZlbnRUYXJnZXQg PSAwOwpAQCAtMjU0MCw3ICsyNTM4LDYgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1 cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogICAgICAg ICByZXR1cm4gaGFuZGxlR2VzdHVyZUxvbmdUYXAoZ2VzdHVyZUV2ZW50KTsKICAgICBjYXNlIFBs YXRmb3JtRXZlbnQ6Okdlc3R1cmVUd29GaW5nZXJUYXA6CiAgICAgICAgIHJldHVybiBoYW5kbGVH ZXN0dXJlVHdvRmluZ2VyVGFwKGdlc3R1cmVFdmVudCk7Ci0gICAgY2FzZSBQbGF0Zm9ybUV2ZW50 OjpHZXN0dXJlRG91YmxlVGFwOgogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVBpbmNo QmVnaW46CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlUGluY2hFbmQ6CiAgICAgY2Fz ZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlUGluY2hVcGRhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybUV2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QbGF0Zm9ybUV2ZW50LmgKaW5kZXggMjU0N2EyZWEwYWExNTM0Y2IxMjdjNTI0OWQyMjEyNDMx M2QzMDA1OS4uMzFhZjA0MTkwYzBmY2QyMzUzZWYwMmU0MDk4MzRiNWM3NGQwYWVhMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1FdmVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtRXZlbnQuaApAQCAtNTYsNyArNTYsNiBAQCBwdWJs aWM6CiAgICAgICAgIEdlc3R1cmVUYXAsCiAgICAgICAgIEdlc3R1cmVUYXBEb3duLAogICAgICAg ICBHZXN0dXJlVGFwRG93bkNhbmNlbCwKLSAgICAgICAgR2VzdHVyZURvdWJsZVRhcCwKICAgICAg ICAgR2VzdHVyZVR3b0ZpbmdlclRhcCwKICAgICAgICAgR2VzdHVyZUxvbmdQcmVzcywKICAgICAg ICAgR2VzdHVyZUxvbmdUYXAsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9Qb3B1cENvbnRhaW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9Qb3B1cENvbnRhaW5lci5jcHAKaW5kZXggOWZiNDNjMzk2NjRmYjFmYjhlYWJkZWZkNDY3 MDFjZDAxZGJmMzAyYi4uNWI0MmQ4NjQ4ZDUxZDY1YjNlZDIwYWEwMTBmYTdjODIwNzdkYzk4YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBDb250YWlu ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwQ29udGFp bmVyLmNwcApAQCAtMzE5LDggKzMxOSw2IEBAIGJvb2wgUG9wdXBDb250YWluZXI6OmhhbmRsZUdl c3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50CiAgICAg ICAgIGhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KGZha2VNb3VzZVVwKTsKICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgfQotICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURvdWJsZVRhcDoK LSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlU2Nyb2xsVXBk YXRlOgogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVNjcm9sbFVwZGF0ZVdpdGhvdXRQ cm9wYWdhdGlvbjogewogICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnQgc3ludGhldGljV2hlZWxF dmVudChnZXN0dXJlRXZlbnQucG9zaXRpb24oKSwgZ2VzdHVyZUV2ZW50Lmdsb2JhbFBvc2l0aW9u KCksIGdlc3R1cmVFdmVudC5kZWx0YVgoKSwgZ2VzdHVyZUV2ZW50LmRlbHRhWSgpLCBnZXN0dXJl RXZlbnQuZGVsdGFYKCkgLyAxMjAuMGYsIGdlc3R1cmVFdmVudC5kZWx0YVkoKSAvIDEyMC4wZiwg U2Nyb2xsQnlQaXhlbFdoZWVsRXZlbnQsIGdlc3R1cmVFdmVudC5zaGlmdEtleSgpLCBnZXN0dXJl RXZlbnQuY3RybEtleSgpLCBnZXN0dXJlRXZlbnQuYWx0S2V5KCksIGdlc3R1cmVFdmVudC5tZXRh S2V5KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRF dmVudENvbnZlcnNpb24uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRF dmVudENvbnZlcnNpb24uY3BwCmluZGV4IDcxZWUwYjYwMTg1ZjFlMjE3ODA1NmQzNzY5YzIyZmJh NjZmNmRlMDcuLjI5MDNlNzdkNDMwMzAxZDI4OWE4NzViYWQ4ZDIxZGViNzcxMzE5YjIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVy c2lvbi5jcHAKQEAgLTE4Nyw3ICsxODcsNyBAQCBQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXI6 OlBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcihXaWRnZXQqIHdpZGdldCwgY29uc3QgVwogICAg ICAgICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwRG93bkNhbmNlbDsKICAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlRG91YmxlVGFwOgotICAg ICAgICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlRG91YmxlVGFwOworICAgICAgICBt X3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpOb1R5cGU7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2Ug V2ViSW5wdXRFdmVudDo6R2VzdHVyZVR3b0ZpbmdlclRhcDoKICAgICAgICAgbV90eXBlID0gUGxh dGZvcm1FdmVudDo6R2VzdHVyZVR3b0ZpbmdlclRhcDsK 193336 2013-03-15 10:47:52 -0700 2013-03-20 12:29:42 -0700 Patch bug-93045-20130315134347.patch text/plain 7435 miletus U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdiYTI4YTE1OGRiNzhj ZjI1OTM1OGQzNDAzOWI0NGI2NjI3Yzc3ZC4uYjJmOWFhYzlmYWYxYmJhOGI0YjVhNTY3MmQwY2Zm NzZlNzEwM2NhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAzLTE0ICBZdWZl bmcgU2hlbiAgPG1pbGV0dXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBQbGF0Zm9y bUV2ZW50OjpHZXN0dXJlRG91YmxlVGFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MzA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVEb3VibGVUYXAgaXMgbm90IGN1 cnJlbnRseQorICAgICAgICB1c2VkIGluIFdlYkNvcmUgYW5kIHJlcGxhY2VkIGJ5IEdlc3R1cmVU YXAgd2l0aAorICAgICAgICB0YXAgY291bnQgMiwgc28gcmVtb3ZlIGl0LgorCisgICAgICAgIFRl c3Q6IFdlIGFyZSByZW1vdmluZyBzb21ldGhpbmcgdGhhdCBpcyBub3QgdXNlZCwgc28KKyAgICAg ICAgbm8gbmV3IHRlc3QuIEFsbCBleGlzdGluZyB0ZXN0cyBwYXNzLgorCisgICAgICAgICogZG9t L0dlc3R1cmVFdmVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHZXN0dXJlRXZlbnQ6OmNyZWF0 ZSk6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlRXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL1Bs YXRmb3JtRXZlbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cENvbnRhaW5l ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENvbnRhaW5lcjo6aGFuZGxlR2VzdHVyZUV2 ZW50KToKKwogMjAxMy0wMy0xNCAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0JsYWNrQmVycnldIEdyYWRpZW50OiBkb24ndCB1c2UgdGhlIGRlZmF1bHQg c2V0UGxhdGZvcm1HcmFkaWVudFNwYWNlVHJhbnNmb3JtKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggNWJiNjQ1YmNhZjZhYTk5ZjRjNjc5MWMwMGExZTJmMzZmMjQzYjM1ZC4uNWY4Zjc5 ODA1ZWIzMTJjNjM1MDg3NjkxZTY2MTA4YTg4ZThjYWM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMy0xNCAgWXVmZW5nIFNoZW4gIDxtaWxldHVz QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURv dWJsZVRhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTMwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ bGF0Zm9ybUV2ZW50OjpHZXN0dXJlRG91YmxlVGFwIGlzIG5vdCBjdXJyZW50bHkKKyAgICAgICAg dXNlZCBpbiBXZWJDb3JlIHNvIHJlbW92ZSBpdC4KKworICAgICAgICAqIHNyYy9XZWJJbnB1dEV2 ZW50Q29udmVyc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsYXRmb3JtR2VzdHVyZUV2ZW50 QnVpbGRlcjo6UGxhdGZvcm1HZXN0dXJlRXZlbnRCdWlsZGVyKToKKwogMjAxMy0wMy0xNCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4gIFJvbGxlZCBDaHJvbWl1bSBERVBTIHRvIHIxODgwMDQuICBSZXF1ZXN0ZWQgYnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9HZXN0dXJlRXZlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKaW5kZXggZTA2NzFmODlhYjEzNDFlNmI4ZTVhYmQz OGFlMGYwMTE0NGMyMWE0My4uNTU0MWFjNmJmYWE3YTFlMTdjYmM4ZmI1YzliYjVjYmMzOGE5MGNj NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKQEAgLTUzLDcgKzUzLDYgQEAgUGFz c1JlZlB0cjxHZXN0dXJlRXZlbnQ+IEdlc3R1cmVFdmVudDo6Y3JlYXRlKFBhc3NSZWZQdHI8QWJz dHJhY3RWaWV3PiB2aWV3LCBjb24KICAgICAgICAgZXZlbnRUeXBlID0gZXZlbnROYW1lcygpLmdl c3R1cmV0YXBFdmVudDsgYnJlYWs7CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFw RG93bjoKICAgICAgICAgZXZlbnRUeXBlID0gZXZlbnROYW1lcygpLmdlc3R1cmV0YXBkb3duRXZl bnQ7IGJyZWFrOwotICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURvdWJsZVRhcDoKICAg ICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUd29GaW5nZXJUYXA6CiAgICAgY2FzZSBQbGF0 Zm9ybUV2ZW50OjpHZXN0dXJlTG9uZ1ByZXNzOgogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2Vz dHVyZVBpbmNoQmVnaW46CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFu ZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggZmYx NDQ5NzRiY2IyNTZiYTA1OThlMDliZjYyYmY1MGFlOGQzM2FmMS4uMWY5NTYxZjZlYzI4Nzk4ZmNj YWNhOTc1NTlmNTlkNGI2N2NkNTAyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cApAQCAtMjQ1NCwxMSArMjQ1NCw2IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJl VGFwRG93bigpCiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3Qg UGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkKIHsKLSAgICAvLyBXZSBkb24ndCB1 c2UgRG91YmxlVGFwIGF0IHRoZSBtb21lbnQsIGl0J3MgbW9zdGx5IHJlZHVuZGFudCB3aXRoIHRh cCBzaW5jZSB0YXAgbm93IGNvbnRhaW5zCi0gICAgLy8gYSB0YXAgY291bnQuIEZJWE1FOiBXZSBz aG91bGQgcHJvYmFibHkgcmVtb3ZlIEdlc3R1cmVEb3VibGVUYXAgKGh0dHA6Ly93a2IudWcvOTMw NDUpLgotICAgIGlmIChnZXN0dXJlRXZlbnQudHlwZSgpID09IFBsYXRmb3JtRXZlbnQ6Okdlc3R1 cmVEb3VibGVUYXApCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIE5vZGUqIGV2ZW50VGFy Z2V0ID0gMDsKICAgICBTY3JvbGxiYXIqIHNjcm9sbGJhciA9IDA7CiAgICAgaWYgKGdlc3R1cmVF dmVudC50eXBlKCkgPT0gUGxhdGZvcm1FdmVudDo6R2VzdHVyZVNjcm9sbEVuZApAQCAtMjU0MCw3 ICsyNTM1LDYgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBQ bGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogICAgICAgICByZXR1cm4gaGFuZGxl R2VzdHVyZUxvbmdUYXAoZ2VzdHVyZUV2ZW50KTsKICAgICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdl c3R1cmVUd29GaW5nZXJUYXA6CiAgICAgICAgIHJldHVybiBoYW5kbGVHZXN0dXJlVHdvRmluZ2Vy VGFwKGdlc3R1cmVFdmVudCk7Ci0gICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlRG91Ymxl VGFwOgogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVBpbmNoQmVnaW46CiAgICAgY2Fz ZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlUGluY2hFbmQ6CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50 OjpHZXN0dXJlUGluY2hVcGRhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QbGF0Zm9ybUV2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybUV2ZW50 LmgKaW5kZXggMjU0N2EyZWEwYWExNTM0Y2IxMjdjNTI0OWQyMjEyNDMxM2QzMDA1OS4uMzFhZjA0 MTkwYzBmY2QyMzUzZWYwMmU0MDk4MzRiNWM3NGQwYWVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1FdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1BsYXRmb3JtRXZlbnQuaApAQCAtNTYsNyArNTYsNiBAQCBwdWJsaWM6CiAgICAgICAgIEdl c3R1cmVUYXAsCiAgICAgICAgIEdlc3R1cmVUYXBEb3duLAogICAgICAgICBHZXN0dXJlVGFwRG93 bkNhbmNlbCwKLSAgICAgICAgR2VzdHVyZURvdWJsZVRhcCwKICAgICAgICAgR2VzdHVyZVR3b0Zp bmdlclRhcCwKICAgICAgICAgR2VzdHVyZUxvbmdQcmVzcywKICAgICAgICAgR2VzdHVyZUxvbmdU YXAsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cENv bnRhaW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cENvbnRh aW5lci5jcHAKaW5kZXggOWZiNDNjMzk2NjRmYjFmYjhlYWJkZWZkNDY3MDFjZDAxZGJmMzAyYi4u NWI0MmQ4NjQ4ZDUxZDY1YjNlZDIwYWEwMTBmYTdjODIwNzdkYzk4YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBDb250YWluZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwQ29udGFpbmVyLmNwcApAQCAtMzE5 LDggKzMxOSw2IEBAIGJvb2wgUG9wdXBDb250YWluZXI6OmhhbmRsZUdlc3R1cmVFdmVudChjb25z dCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50CiAgICAgICAgIGhhbmRsZU1vdXNl UmVsZWFzZUV2ZW50KGZha2VNb3VzZVVwKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQot ICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZURvdWJsZVRhcDoKLSAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlU2Nyb2xsVXBkYXRlOgogICAgIGNhc2Ug UGxhdGZvcm1FdmVudDo6R2VzdHVyZVNjcm9sbFVwZGF0ZVdpdGhvdXRQcm9wYWdhdGlvbjogewog ICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnQgc3ludGhldGljV2hlZWxFdmVudChnZXN0dXJlRXZl bnQucG9zaXRpb24oKSwgZ2VzdHVyZUV2ZW50Lmdsb2JhbFBvc2l0aW9uKCksIGdlc3R1cmVFdmVu dC5kZWx0YVgoKSwgZ2VzdHVyZUV2ZW50LmRlbHRhWSgpLCBnZXN0dXJlRXZlbnQuZGVsdGFYKCkg LyAxMjAuMGYsIGdlc3R1cmVFdmVudC5kZWx0YVkoKSAvIDEyMC4wZiwgU2Nyb2xsQnlQaXhlbFdo ZWVsRXZlbnQsIGdlc3R1cmVFdmVudC5zaGlmdEtleSgpLCBnZXN0dXJlRXZlbnQuY3RybEtleSgp LCBnZXN0dXJlRXZlbnQuYWx0S2V5KCksIGdlc3R1cmVFdmVudC5tZXRhS2V5KCkpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24u Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24u Y3BwCmluZGV4IDcxZWUwYjYwMTg1ZjFlMjE3ODA1NmQzNzY5YzIyZmJhNjZmNmRlMDcuLjQ1MzQw YmQwNDA2MGVhZTQwNjRjMThiZWI5NDc3MDBjNzkzM2I3OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKQEAgLTE4 Niw5ICsxODYsNiBAQCBQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXI6OlBsYXRmb3JtR2VzdHVy ZUV2ZW50QnVpbGRlcihXaWRnZXQqIHdpZGdldCwgY29uc3QgVwogICAgIGNhc2UgV2ViSW5wdXRF dmVudDo6R2VzdHVyZVRhcENhbmNlbDoKICAgICAgICAgbV90eXBlID0gUGxhdGZvcm1FdmVudDo6 R2VzdHVyZVRhcERvd25DYW5jZWw7CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgV2ViSW5wdXRF dmVudDo6R2VzdHVyZURvdWJsZVRhcDoKLSAgICAgICAgbV90eXBlID0gUGxhdGZvcm1FdmVudDo6 R2VzdHVyZURvdWJsZVRhcDsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBXZWJJbnB1dEV2ZW50 OjpHZXN0dXJlVHdvRmluZ2VyVGFwOgogICAgICAgICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpH ZXN0dXJlVHdvRmluZ2VyVGFwOwogICAgICAgICBtX2FyZWEgPSBleHBhbmRlZEludFNpemUoRmxv YXRTaXplKGUuZGF0YS50d29GaW5nZXJUYXAuZmlyc3RGaW5nZXJXaWR0aCAvIHNjYWxlLCBlLmRh dGEudHdvRmluZ2VyVGFwLmZpcnN0RmluZ2VySGVpZ2h0IC8gc2NhbGUpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA2NDBhYTZiODVlMGNlNTVjOWNk ODUzYzBmZDZkYzQzYzI2MDE5MjBjLi5jMmExOWFlNjIyZWM2NjNhZjhiYWE5MGU5NDBhOGI5M2Y3 OGU1NGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBA IC04MjcsOSArODI3LDExIEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUdlc3R1cmVFdmVudChj b25zdCBXZWJHZXN0dXJlRXZlbnQmIGV2ZW50KQogICAgICAgICBpZiAobV93ZWJTZXR0aW5ncy0+ ZG91YmxlVGFwVG9ab29tRW5hYmxlZCgpICYmIG1fbWluaW11bVBhZ2VTY2FsZUZhY3RvciAhPSBt X21heGltdW1QYWdlU2NhbGVGYWN0b3IpIHsKICAgICAgICAgICAgIG1fY2xpZW50LT5jYW5jZWxT Y2hlZHVsZWRDb250ZW50SW50ZW50cygpOwogICAgICAgICAgICAgYW5pbWF0ZVpvb21Bcm91bmRQ b2ludChwbGF0Zm9ybUV2ZW50LnBvc2l0aW9uKCksIERvdWJsZVRhcCk7Ci0gICAgICAgICAgICBl dmVudFN3YWxsb3dlZCA9IHRydWU7Ci0gICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorICAg ICAgICAvLyBHZXN0dXJlRG91YmxlVGFwIGlzIGN1cnJlbnRseSBvbmx5IHVzZWQgYnkgQW5kcm9p ZCBmb3Igem9vbWluZy4gRm9yIFdlYkNvcmUsCisgICAgICAgIC8vIEdlc3R1cmVUYXAgd2l0aCB0 YXAgY291bnQgPSAyIGlzIHVzZWQgaW5zdGVhZC4gU28gd2UgZHJvcCBHZXN0dXJlRG91YmxlVGFw IGhlcmUuCisgICAgICAgIGV2ZW50U3dhbGxvd2VkID0gdHJ1ZTsKKyAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlU2Nyb2xsQmVnaW46CiAgICAgY2FzZSBXZWJJ bnB1dEV2ZW50OjpHZXN0dXJlUGluY2hCZWdpbjoKICAgICAgICAgbV9jbGllbnQtPmNhbmNlbFNj aGVkdWxlZENvbnRlbnRJbnRlbnRzKCk7Cg==