93040 2012-08-02 16:16:10 -0700 [BlackBerry] Upstream GraphicsLayerClient::contentsVisible() 2012-08-03 06:21:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93036 1 anilsson anilsson anilsson eric manyoso rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 685956 0 anilsson 2012-08-02 16:16:10 -0700 Our LayerTiler uses both proactive and reactive rendering to populate tiles. If contentsVisible() is accurate, it will cause the right tiles to be rendered. Failing that, when a dirty tile is found to be visible on the compositing thread, a render job is scheduled. 685976 1 156199 anilsson 2012-08-02 16:36:10 -0700 Created attachment 156199 Patch 686074 2 156199 webkit.review.bot 2012-08-02 18:15:15 -0700 Comment on attachment 156199 Patch Clearing flags on attachment: 156199 Committed r124544: <http://trac.webkit.org/changeset/124544> 686075 3 webkit.review.bot 2012-08-02 18:15:18 -0700 All reviewed patches have been landed. Closing bug. 686608 4 156199 tonikitoo 2012-08-03 05:48:34 -0700 Comment on attachment 156199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156199&action=review Post-land comments: > Source/WebCore/platform/graphics/GraphicsLayerClient.h:89 > + virtual bool contentsVisible(const GraphicsLayer*, const IntRect& contentRect) const = 0; but it would be preferable to add a default blank implementation here, instead of a pure virtual method, and get rid of the #if platform(bb)? > Source/WebCore/rendering/RenderLayerBacking.cpp:1632 > + IntRect visibleContentRect(view->visibleContentRect()); > + FloatQuad absoluteContentQuad = renderer()->localToAbsoluteQuad(FloatRect(localContentRect)); > + return absoluteContentQuad.enclosingBoundingBox().intersects(visibleContentRect); does this work for subframes? 686615 5 anilsson 2012-08-03 05:57:36 -0700 Gnnh, I forgot to add the declaration to RenderLayerBacking.h 686620 6 156199 anilsson 2012-08-03 06:04:09 -0700 Comment on attachment 156199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156199&action=review >> Source/WebCore/platform/graphics/GraphicsLayerClient.h:89 >> + virtual bool contentsVisible(const GraphicsLayer*, const IntRect& contentRect) const = 0; > > but it would be preferable to add a default blank implementation here, instead of a pure virtual method, and get rid of the #if platform(bb)? There's a default implementation coming in https://bugs.webkit.org/show_bug.cgi?id=93036, however it's still not enabling it for all platforms. >> Source/WebCore/rendering/RenderLayerBacking.cpp:1632 >> + return absoluteContentQuad.enclosingBoundingBox().intersects(visibleContentRect); > > does this work for subframes? I think this is actually returns true too often, which is better than too seldom - if my thinking is correct, this will return true if the layer is visible in the subframe's viewport, even if the whole viewport is scrolled off screen. 686624 7 tonikitoo 2012-08-03 06:09:24 -0700 > > does this work for subframes? > > I think this is actually returns true too often, which is better than too seldom - if my thinking is correct, this will return true if the layer is visible in the subframe's viewport, even if the whole viewport is scrolled off screen. I do not think it clips against its parent viewport. 686632 8 anilsson 2012-08-03 06:21:24 -0700 (In reply to comment #7) > > > does this work for subframes? > > > > I think this is actually returns true too often, which is better than too seldom - if my thinking is correct, this will return true if the layer is visible in the subframe's viewport, even if the whole viewport is scrolled off screen. > > I do not think it clips against its parent viewport. Exactly, I guess that was what I was trying to say. So it will return true too often (false positive) but that's ok considering the use case - when to populate tiles. ,maybe there is benefit from making it more accurate, though. 156199 2012-08-02 16:36:10 -0700 2012-08-03 06:04:09 -0700 Patch bug-93040-20120803013550.patch text/plain 2906 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y3MTVlNTQ0ZTVhMDIx Mzk3NTYzMjRmYTE3Y2RiMTY4YTM1MDAyOS4uNTJmMmJjY2Y3MzA2ZTU2ODMyMzU3NTc2OGIyYzg4 NjUxMmJjMGQyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTAyICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gVXBz dHJlYW0gR3JhcGhpY3NMYXllckNsaWVudDo6Y29udGVudHNWaXNpYmxlKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDQwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3VyIExheWVyVGlsZXIgdXNlcyBi b3RoIHByb2FjdGl2ZSBhbmQgcmVhY3RpdmUgcmVuZGVyaW5nIHRvIHBvcHVsYXRlCisgICAgICAg IHRpbGVzLiBJZiBjb250ZW50c1Zpc2libGUoKSBpcyBhY2N1cmF0ZSwgaXQgd2lsbCBjYXVzZSB0 aGUgcmlnaHQgdGlsZXMKKyAgICAgICAgdG8gYmUgcmVuZGVyZWQuIEZhaWxpbmcgdGhhdCwgd2hl biBhIGRpcnR5IHRpbGUgaXMgZm91bmQgdG8gYmUgdmlzaWJsZQorICAgICAgICBvbiB0aGUgY29t cG9zaXRpbmcgdGhyZWFkLCBhIHJlbmRlciBqb2IgaXMgc2NoZWR1bGVkLgorCisgICAgICAgIFRo aXMgaXMgbm90IGN1cnJlbnRseSB0ZXN0YWJsZSB1c2luZyBCbGFja0JlcnJ5IHRlc3RpbmcgaW5m cmFzdHJ1Y3R1cmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVy Q2xpZW50Lmg6CisgICAgICAgIChHcmFwaGljc0xheWVyQ2xpZW50KTogTmV3IEJsYWNrQmVycnkt c3BlY2lmaWMgbWV0aG9kICJjb250ZW50c1Zpc2libGUiIGFkZGVkLgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNvbnRlbnRzVmlzaWJsZSk6IEJsYWNrQmVy cnktc3BlY2lmaWMgaW1wbGVtZW50YXRpb24uCisKIDIwMTItMDgtMDIgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgc2NyaXB0cyBpbiBmb3JtYWN0aW9uIHNob3Vs ZCBiZSBzdHJpcHBlZCB1cG9uIHBhc3RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyQ2xpZW50LmgKaW5kZXggNzA0OWU0MjI2YjZlZWQ3 M2YxOWNmNzUyNmZlMjQzYjhlZGJlZGY4My4uOGMwOGY0OWU1YjgyNDhiOGE0NTAzZmQ3NWYzYjFj NjMwNGM0NWY5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NMYXllckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzTGF5ZXJDbGllbnQuaApAQCAtODQsNiArODQsMTAgQEAgcHVibGljOgogICAg IC8vIHdoaWxlIHBhaW50aW5nLgogICAgIHZpcnR1YWwgdm9pZCB2ZXJpZnlOb3RQYWludGluZygp IHsgfQogI2VuZGlmCisKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgIHZpcnR1YWwgYm9v bCBjb250ZW50c1Zpc2libGUoY29uc3QgR3JhcGhpY3NMYXllciosIGNvbnN0IEludFJlY3QmIGNv bnRlbnRSZWN0KSBjb25zdCA9IDA7CisjZW5kaWYKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAK aW5kZXggNTdiODNlMzUyODUxMjUxMTE0ODgzYmQ0ZmYzMTRkZWUxODZkZTVkMi4uZTExMGE0ZDVk NTBhYTlmYWEwMTY4ZGI4MmI5NDQ4YTU3MjAxMjVhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTE2MTksNiArMTYxOSwyMCBAQCBk b3VibGUgUmVuZGVyTGF5ZXJCYWNraW5nOjpiYWNraW5nU3RvcmVNZW1vcnlFc3RpbWF0ZSgpIGNv bnN0CiAgICAgcmV0dXJuIGJhY2tpbmdNZW1vcnk7CiB9CiAKKyNpZiBQTEFURk9STShCTEFDS0JF UlJZKQorYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6OmNvbnRlbnRzVmlzaWJsZShjb25zdCBHcmFw aGljc0xheWVyKiwgY29uc3QgSW50UmVjdCYgbG9jYWxDb250ZW50UmVjdCkgY29uc3QKK3sKKyAg ICBGcmFtZSogZnJhbWUgPSByZW5kZXJlcigpLT5mcmFtZSgpOworICAgIEZyYW1lVmlldyogdmll dyA9IGZyYW1lID8gZnJhbWUtPnZpZXcoKSA6IDA7CisgICAgaWYgKCF2aWV3KQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICBJbnRSZWN0IHZpc2libGVDb250ZW50UmVjdCh2aWV3LT52aXNp YmxlQ29udGVudFJlY3QoKSk7CisgICAgRmxvYXRRdWFkIGFic29sdXRlQ29udGVudFF1YWQgPSBy ZW5kZXJlcigpLT5sb2NhbFRvQWJzb2x1dGVRdWFkKEZsb2F0UmVjdChsb2NhbENvbnRlbnRSZWN0 KSk7CisgICAgcmV0dXJuIGFic29sdXRlQ29udGVudFF1YWQuZW5jbG9zaW5nQm91bmRpbmdCb3go KS5pbnRlcnNlY3RzKHZpc2libGVDb250ZW50UmVjdCk7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQo=