9304 2006-06-04 11:34:37 -0700 Minor cleanup in JavaScriptCore 2006-06-04 20:04:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren gavin.sharp oldest_to_newest 44650 0 ggaren 2006-06-04 11:34:37 -0700 Patch coming. 44651 1 8695 ggaren 2006-06-04 11:36:41 -0700 Created attachment 8695 Patch 44701 2 8695 mjs 2006-06-04 16:02:41 -0700 Comment on attachment 8695 Patch Removing the declarations is right, but I don't think the change to 3 to 4 is necessary. Characters that require 4 bytes in UTF-8 also require a surrogate pair in UTF-16, which is treated as two characters. 44704 3 8695 mjs 2006-06-04 16:07:15 -0700 Comment on attachment 8695 Patch r- (but fine with me if it turns out I am wrong about the UTF8 thing) 44732 4 ggaren 2006-06-04 20:01:40 -0700 Thanks for the info about UTF-8; I hadn't considered that. I'm going to land just the header change. 44733 5 ggaren 2006-06-04 20:04:33 -0700 Committed revision 14731. 8695 2006-06-04 11:36:41 -0700 2006-06-04 16:07:15 -0700 Patch patch-cleanup.txt text/plain 1620 ggaren SW5kZXg6IGtqcy92YWx1ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy92YWx1ZS5oCShyZXZpc2lvbiAx NDY0MykKKysrIGtqcy92YWx1ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsMTQgKzE1Nyw3IEBA IHByaXZhdGU6CiAgICAgYm9vbCBtX21hcmtlZCA6IDE7CiB9OwogCi1KU1ZhbHVlICpqc1VuZGVm aW5lZCgpOwotSlNWYWx1ZSAqanNOdWxsKCk7Ci0KLUpTVmFsdWUgKmpzQm9vbGVhbihib29sKTsK LQogSlNWYWx1ZSAqanNOdW1iZXJDZWxsKGRvdWJsZSk7Ci1KU1ZhbHVlICpqc051bWJlcihkb3Vi bGUpOwotSlNWYWx1ZSAqanNOYU4oKTsKIAogSlNDZWxsICpqc1N0cmluZyhjb25zdCBVU3RyaW5n ICYpOyAvLyByZXR1cm5zIGVtcHR5IHN0cmluZyBpZiBwYXNzZWQgbnVsbCBzdHJpbmcKIEpTQ2Vs bCAqanNTdHJpbmcoY29uc3QgY2hhciAqID0gIiIpOyAvLyByZXR1cm5zIGVtcHR5IHN0cmluZyBp ZiBwYXNzZWQgMApJbmRleDoga2pzL3VzdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy91c3Ry aW5nLmNwcAkocmV2aXNpb24gMTQ2NDMpCisrKyBranMvdXN0cmluZy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEyNzcsNyArMTI3Nyw3IEBAIENTdHJpbmcgVVN0cmluZzo6VVRGOFN0cmluZygpIGNv bnN0CiB7CiAgIC8vIEFsbG9jYXRlIGEgYnVmZmVyIGJpZyBlbm91Z2ggdG8gaG9sZCBhbGwgdGhl IGNoYXJhY3RlcnMuCiAgIGNvbnN0IGludCBsZW5ndGggPSBzaXplKCk7Ci0gIFZlY3RvcjxjaGFy LCAxMDI0PiBidWZmZXIobGVuZ3RoICogMyk7CisgIFZlY3RvcjxjaGFyLCAxMDI0PiBidWZmZXIo bGVuZ3RoICogNCk7CiAKICAgLy8gQ29udmVydCB0byBydW5zIG9mIDgtYml0IGNoYXJhY3RlcnMu CiAgIGNoYXIgKnAgPSBidWZmZXIuYmVnaW4oKTsKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzE3KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMDYtMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVu QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIC0gTWlub3IgY2xlYW51cAorCisgICAgICAgICoga2pzL3VzdHJpbmcuY3Bw OgorICAgICAgICAoS0pTOjpVU3RyaW5nOjpVVEY4U3RyaW5nKTogQ2hhbmdlZCBidWZmZXIgc2l6 ZSB0byBsZW5ndGggKiA0IGluc3RlYWQKKyAgICAgICAgb2YgbGVuZ3RoICogMywgYmVjYXVzZSB0 aGUgbWF4aW11bSBzaXplIG9mIGEgVVRGOCBjaGFyYWN0ZXIgaXMgNCBieXRlcy4KKyAgICAgICAg KiBranMvdmFsdWUuaDogUmVtb3ZlZCByZWR1bmRhbnQgZGVjbGFyYXRpb25zLgorCiAyMDA2LTA2 LTAyICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IGdnYXJlbi4K