93039 2012-08-02 15:59:44 -0700 test-webkitpy can fail on a clean checkout 2012-08-02 16:09:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan rniwa tony webkit.review.bot oldest_to_newest 685939 0 dpranke 2012-08-02 15:59:44 -0700 test-webkitpy can fail on a clean checkout 685941 1 156189 dpranke 2012-08-02 16:00:52 -0700 Created attachment 156189 Patch 685945 2 156190 dpranke 2012-08-02 16:04:35 -0700 Created attachment 156190 add comment about naming, clean up hook creation 685947 3 156190 abarth 2012-08-02 16:06:02 -0700 Comment on attachment 156190 add comment about naming, clean up hook creation View in context: https://bugs.webkit.org/attachment.cgi?id=156190&action=review > Tools/Scripts/webkitpy/test/main.py:128 > + from webkitpy.thirdparty import autoinstall_everything autoinstall_everything -> autoinstall_all_the_things !!! 685950 4 dpranke 2012-08-02 16:09:21 -0700 Committed r124523: <http://trac.webkit.org/changeset/124523> 156189 2012-08-02 16:00:52 -0700 2012-08-02 16:04:33 -0700 Patch bug-93039-20120802160032.patch text/plain 3194 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODRiNGYyNzdlODQyZGQzY2VmNDZiNzM5ZmE2Y2MyOTc4 NGM2NjU5MC4uYzNiY2MyMzcxMjUwMmM0NmJkNTk1MWNjMmQwZTMwNjQwYTBiZWMxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIy IEBACiAyMDEyLTA4LTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHkgY2FuIGZhaWwgb24gYSBjbGVhbiBjaGVja291dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMwMzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCB3ZSBydW4g dGVzdHMgaW4gcGFyYWxsZWwgdGhhdCBjYW4gY2F1c2UgdGhlIGluc3RhbGxlcgorICAgICAgICB0 byB0cnkgYW5kIGluc3RhbGwgcGFja2FnZXMgaW4gcGFyYWxsZWwgKGV2ZW4gdGhlIHNhbWUgcGFj a2FnZSksCisgICAgICAgIGFuZCB0aGF0IHByb2JhYmx5IHdvbid0IHdvcmsuIFdlIGZpeCB0aGlz IGJ5IGF1dG9pbnN0YWxsaW5nCisgICAgICAgIGV2ZXJ5dGhpbmcgdXAgZnJvbnQgKHNlcmlhbGx5 KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5OgorICAgICAgICAo VGVzdGVyLl9ydW5fdGVzdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0 eS9fX2luaXRfXy5weToKKyAgICAgICAgKGF1dG9pbnN0YWxsX2V2ZXJ5dGhpbmcpOgorCisyMDEy LTA4LTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIHRl c3Qtd2Via2l0cHk6IHNvbWUgdGVzdHMgbmVlZCB0byBydW4gYnkgdGhlbXNlbHZlcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI5MjYKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rlc3QvbWFpbi5weQppbmRleCA3MTY0NTkyZWI5NmEyZDcxZjg4NzNlMzA4N2Fk ZjFlNGE0NDNhZmM3Li4yNDlmZGMwYzRjYzdkMDE1YzE3OTQwNDBhNDVmZTQ5OGFmMDA0NjYyIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQpAQCAtMTE5LDE4ICsxMTksMjAgQEAgY2xh c3MgVGVzdGVyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fdGVzdHMobmFtZXMp CiAKICAgICBkZWYgX3J1bl90ZXN0cyhzZWxmLCBuYW1lcyk6CisgICAgICAgICMgTWFrZSBzdXJl IFBZVEhPTlBBVEggaXMgc2V0IHVwIHByb3Blcmx5LgorICAgICAgICBzeXMucGF0aCA9IHNlbGYu ZmluZGVyLmFkZGl0aW9uYWxfcGF0aHMoc3lzLnBhdGgpICsgc3lzLnBhdGgKKworICAgICAgICAj IFdlIGF1dG9pbnN0YWxsIGV2ZXJ5dGhpbmcgdXAgc28gdGhhdCB3ZSBjYW4gcnVuIHRlc3RzIGNv bmN1cnJlbnRseQorICAgICAgICAjIGFuZCBub3QgaGF2ZSB0byB3b3JyeSBhYm91dCBhdXRvaW5z dGFsbGluZyBwYWNrYWdlcyBjb25jdXJyZW50bHkuCisgICAgICAgIHNlbGYucHJpbnRlci53cml0 ZV91cGRhdGUoIkNoZWNraW5nIGF1dG9pbnN0YWxsZWQgcGFja2FnZXMgLi4uIikKKyAgICAgICAg ZnJvbSB3ZWJraXRweS50aGlyZHBhcnR5IGltcG9ydCBhdXRvaW5zdGFsbF9ldmVyeXRoaW5nCisg ICAgICAgIGF1dG9pbnN0YWxsX2V2ZXJ5dGhpbmcoKQorCiAgICAgICAgIGlmIHNlbGYuX29wdGlv bnMuY292ZXJhZ2U6Ci0gICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgaW1wb3J0IHdl YmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5jb3ZlcmFnZSBhcyBjb3ZlcmFnZQotICAg ICAgICAgICAgZXhjZXB0IEltcG9ydEVycm9yOgotICAgICAgICAgICAgICAgIF9sb2cuZXJyb3Io IkZhaWxlZCB0byBpbXBvcnQgJ2NvdmVyYWdlJzsgY2FuJ3QgZ2VuZXJhdGUgY292ZXJhZ2UgbnVt YmVycy4iKQotICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAgICAgICAgICAgaW1wb3J0 IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5jb3ZlcmFnZSBhcyBjb3ZlcmFnZQog ICAgICAgICAgICAgY292ID0gY292ZXJhZ2UuY292ZXJhZ2UoKQogICAgICAgICAgICAgY292LnN0 YXJ0KCkKIAotICAgICAgICAjIE1ha2Ugc3VyZSBQWVRIT05QQVRIIGlzIHNldCB1cCBwcm9wZXJs eS4KLSAgICAgICAgc3lzLnBhdGggPSBzZWxmLmZpbmRlci5hZGRpdGlvbmFsX3BhdGhzKHN5cy5w YXRoKSArIHN5cy5wYXRoCi0KICAgICAgICAgc2VsZi5wcmludGVyLndyaXRlX3VwZGF0ZSgiQ2hl Y2tpbmcgaW1wb3J0cyAuLi4iKQogICAgICAgICBpZiBub3Qgc2VsZi5fY2hlY2tfaW1wb3J0cyhu YW1lcyk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQppbmRleCBiMWVkZDRkMGJkMDYwZDY0ODkxMTIzMDZk YzkyZjA3MTg2NTY2MzVjLi5iYjgwMzU4OTU5NDQwOGE4NTVjMTk4ZDc5OWEyMWMyMzUwNmRhN2Fj IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CkBA IC0xNTYsMyArMTU2LDkgQEAgY2xhc3MgQXV0b2luc3RhbGxJbXBvcnRIb29rKG9iamVjdCk6CiAK IAogc3lzLm1ldGFfcGF0aC5hcHBlbmQoQXV0b2luc3RhbGxJbXBvcnRIb29rKCkpCisKK2RlZiBh dXRvaW5zdGFsbF9ldmVyeXRoaW5nKCk6CisgICAgaG9vayA9IEF1dG9pbnN0YWxsSW1wb3J0SG9v aygpCisgICAgaW5zdGFsbF9tZXRob2RzID0gW21ldGhvZCBmb3IgbWV0aG9kIGluIGRpcihob29r Ll9fY2xhc3NfXykgaWYgbWV0aG9kLnN0YXJ0c3dpdGgoJ19pbnN0YWxsXycpXQorICAgIGZvciBt ZXRob2QgaW4gaW5zdGFsbF9tZXRob2RzOgorICAgICAgICBnZXRhdHRyKGhvb2ssIG1ldGhvZCko KQo= 156190 2012-08-02 16:04:35 -0700 2012-08-02 16:06:01 -0700 add comment about naming, clean up hook creation bug-93039-20120802160416.patch text/plain 3674 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODRiNGYyNzdlODQyZGQzY2VmNDZiNzM5ZmE2Y2MyOTc4 NGM2NjU5MC4uYzNiY2MyMzcxMjUwMmM0NmJkNTk1MWNjMmQwZTMwNjQwYTBiZWMxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIy IEBACiAyMDEyLTA4LTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHkgY2FuIGZhaWwgb24gYSBjbGVhbiBjaGVja291dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMwMzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCB3ZSBydW4g dGVzdHMgaW4gcGFyYWxsZWwgdGhhdCBjYW4gY2F1c2UgdGhlIGluc3RhbGxlcgorICAgICAgICB0 byB0cnkgYW5kIGluc3RhbGwgcGFja2FnZXMgaW4gcGFyYWxsZWwgKGV2ZW4gdGhlIHNhbWUgcGFj a2FnZSksCisgICAgICAgIGFuZCB0aGF0IHByb2JhYmx5IHdvbid0IHdvcmsuIFdlIGZpeCB0aGlz IGJ5IGF1dG9pbnN0YWxsaW5nCisgICAgICAgIGV2ZXJ5dGhpbmcgdXAgZnJvbnQgKHNlcmlhbGx5 KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5OgorICAgICAgICAo VGVzdGVyLl9ydW5fdGVzdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0 eS9fX2luaXRfXy5weToKKyAgICAgICAgKGF1dG9pbnN0YWxsX2V2ZXJ5dGhpbmcpOgorCisyMDEy LTA4LTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIHRl c3Qtd2Via2l0cHk6IHNvbWUgdGVzdHMgbmVlZCB0byBydW4gYnkgdGhlbXNlbHZlcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI5MjYKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rlc3QvbWFpbi5weQppbmRleCA3MTY0NTkyZWI5NmEyZDcxZjg4NzNlMzA4N2Fk ZjFlNGE0NDNhZmM3Li4yNDlmZGMwYzRjYzdkMDE1YzE3OTQwNDBhNDVmZTQ5OGFmMDA0NjYyIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQpAQCAtMTE5LDE4ICsxMTksMjAgQEAgY2xh c3MgVGVzdGVyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fdGVzdHMobmFtZXMp CiAKICAgICBkZWYgX3J1bl90ZXN0cyhzZWxmLCBuYW1lcyk6CisgICAgICAgICMgTWFrZSBzdXJl IFBZVEhPTlBBVEggaXMgc2V0IHVwIHByb3Blcmx5LgorICAgICAgICBzeXMucGF0aCA9IHNlbGYu ZmluZGVyLmFkZGl0aW9uYWxfcGF0aHMoc3lzLnBhdGgpICsgc3lzLnBhdGgKKworICAgICAgICAj IFdlIGF1dG9pbnN0YWxsIGV2ZXJ5dGhpbmcgdXAgc28gdGhhdCB3ZSBjYW4gcnVuIHRlc3RzIGNv bmN1cnJlbnRseQorICAgICAgICAjIGFuZCBub3QgaGF2ZSB0byB3b3JyeSBhYm91dCBhdXRvaW5z dGFsbGluZyBwYWNrYWdlcyBjb25jdXJyZW50bHkuCisgICAgICAgIHNlbGYucHJpbnRlci53cml0 ZV91cGRhdGUoIkNoZWNraW5nIGF1dG9pbnN0YWxsZWQgcGFja2FnZXMgLi4uIikKKyAgICAgICAg ZnJvbSB3ZWJraXRweS50aGlyZHBhcnR5IGltcG9ydCBhdXRvaW5zdGFsbF9ldmVyeXRoaW5nCisg ICAgICAgIGF1dG9pbnN0YWxsX2V2ZXJ5dGhpbmcoKQorCiAgICAgICAgIGlmIHNlbGYuX29wdGlv bnMuY292ZXJhZ2U6Ci0gICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgaW1wb3J0IHdl YmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5jb3ZlcmFnZSBhcyBjb3ZlcmFnZQotICAg ICAgICAgICAgZXhjZXB0IEltcG9ydEVycm9yOgotICAgICAgICAgICAgICAgIF9sb2cuZXJyb3Io IkZhaWxlZCB0byBpbXBvcnQgJ2NvdmVyYWdlJzsgY2FuJ3QgZ2VuZXJhdGUgY292ZXJhZ2UgbnVt YmVycy4iKQotICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAgICAgICAgICAgaW1wb3J0 IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5jb3ZlcmFnZSBhcyBjb3ZlcmFnZQog ICAgICAgICAgICAgY292ID0gY292ZXJhZ2UuY292ZXJhZ2UoKQogICAgICAgICAgICAgY292LnN0 YXJ0KCkKIAotICAgICAgICAjIE1ha2Ugc3VyZSBQWVRIT05QQVRIIGlzIHNldCB1cCBwcm9wZXJs eS4KLSAgICAgICAgc3lzLnBhdGggPSBzZWxmLmZpbmRlci5hZGRpdGlvbmFsX3BhdGhzKHN5cy5w YXRoKSArIHN5cy5wYXRoCi0KICAgICAgICAgc2VsZi5wcmludGVyLndyaXRlX3VwZGF0ZSgiQ2hl Y2tpbmcgaW1wb3J0cyAuLi4iKQogICAgICAgICBpZiBub3Qgc2VsZi5fY2hlY2tfaW1wb3J0cyhu YW1lcyk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQppbmRleCBiMWVkZDRkMGJkMDYwZDY0ODkxMTIzMDZk YzkyZjA3MTg2NTY2MzVjLi4zMjFhNDgzMzJlYjFlMGFiN2EwOTc2MGUyZDI3NTFjNGMzMTFlNGE4 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CkBA IC03MCw2ICs3MCw4IEBAIGNsYXNzIEF1dG9pbnN0YWxsSW1wb3J0SG9vayhvYmplY3QpOgogICAg ICAgICBpZiAnLmF1dG9pbnN0YWxsZWQnIG5vdCBpbiBmdWxsbmFtZToKICAgICAgICAgICAgIHJl dHVybgogCisgICAgICAgICMgTm90ZTogYWxsIG9mIHRoZSBtZXRob2RzIG11c3QgZm9sbG93IHRo ZSAiX2luc3RhbGxfWFhYIiBjb252ZW50aW9uIGluCisgICAgICAgICMgb3JkZXIgZm9yIGF1dG9p bnN0YWxsX2V2ZXJ5dGhpbmcoKSwgYmVsb3csIHRvIHdvcmsgcHJvcGVybHkuCiAgICAgICAgIGlm ICcubWVjaGFuaXplJyBpbiBmdWxsbmFtZToKICAgICAgICAgICAgIHNlbGYuX2luc3RhbGxfbWVj aGFuaXplKCkKICAgICAgICAgZWxpZiAnLnBlcDgnIGluIGZ1bGxuYW1lOgpAQCAtMTU1LDQgKzE1 NywxMSBAQCBjbGFzcyBBdXRvaW5zdGFsbEltcG9ydEhvb2sob2JqZWN0KToKICAgICAgICAgaW5z dGFsbGVyLmluc3RhbGwodXJsPXVybCwgdXJsX3N1YnBhdGg9dXJsX3N1YnBhdGgpCiAKIAotc3lz Lm1ldGFfcGF0aC5hcHBlbmQoQXV0b2luc3RhbGxJbXBvcnRIb29rKCkpCitfaG9vayA9IEF1dG9p bnN0YWxsSW1wb3J0SG9vaygpCitzeXMubWV0YV9wYXRoLmFwcGVuZChfaG9vaykKKworCitkZWYg YXV0b2luc3RhbGxfZXZlcnl0aGluZygpOgorICAgIGluc3RhbGxfbWV0aG9kcyA9IFttZXRob2Qg Zm9yIG1ldGhvZCBpbiBkaXIoX2hvb2suX19jbGFzc19fKSBpZiBtZXRob2Quc3RhcnRzd2l0aCgn X2luc3RhbGxfJyldCisgICAgZm9yIG1ldGhvZCBpbiBpbnN0YWxsX21ldGhvZHM6CisgICAgICAg IGdldGF0dHIoX2hvb2ssIG1ldGhvZCkoKQo=