93035 2012-08-02 15:26:35 -0700 writeHelperGetString in V8HTMLDocument uses += to concatenate strings 2012-08-08 18:41:16 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 webkit.review.bot abarth abarth jaepark oldest_to_newest 685901 0 webkit.review.bot 2012-08-02 15:26:35 -0700 writeHelperGetString in V8HTMLDocument uses += to concatenate strings Requested by abarth on #webkit. 685905 1 abarth 2012-08-02 15:29:47 -0700 This should use StringBuilder instead. Feel free to steal this bug from me. 690959 2 157340 jaepark 2012-08-08 17:04:32 -0700 Created attachment 157340 Patch 690962 3 157340 abarth 2012-08-08 17:05:33 -0700 Comment on attachment 157340 Patch Yay! Thanks! 691038 4 157340 webkit.review.bot 2012-08-08 18:10:16 -0700 Comment on attachment 157340 Patch Clearing flags on attachment: 157340 Committed r125132: <http://trac.webkit.org/changeset/125132> 691039 5 webkit.review.bot 2012-08-08 18:10:20 -0700 All reviewed patches have been landed. Closing bug. 691067 6 jaepark 2012-08-08 18:41:16 -0700 (In reply to comment #3) > (From update of attachment 157340 [details]) > Yay! Thanks! Thank you for your review. 157340 2012-08-08 17:04:32 -0700 2012-08-08 18:10:16 -0700 Patch bug-93035-20120809090439.patch text/plain 1998 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQxZjY5YTM1YzkwODM1 ZWFmYWUyZjU4ZmE1ZjI0MzhkNWE3YjMwYS4uMzhjNWJiMDBmMDdkYWI0OTVlYzRlNTc4ODMyYThk OGQ4MjdkN2YxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTA4ICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgd3JpdGVIZWxw ZXJHZXRTdHJpbmcgaW4gVjhIVE1MRG9jdW1lbnQgdXNlcyArPSB0byBjb25jYXRlbmF0ZSBzdHJp bmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzAz NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBh IFN0cmluZ0J1aWxkZXIgaW5zdGVhZCBvZiBTdHJpbmcgY29uY2F0ZW5hdGlvbiBiZWNhdXNlIFN0 cmluZ0J1aWxkZXIgaXMgZ2VuZXJhbGx5IGZhc3Rlci4KKworICAgICAgICBObyBuZXcgZnVuY3Rp b25hbGl0eSwgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9t L1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndyaXRlSGVscGVy R2V0U3RyaW5nKToKKwogMjAxMi0wOC0wOCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIG1pc3NpbmcgT1ZFUlJJREUgYW5kIHZp cnR1YWwgYW5ub3RhdGlvbnMgaW4gY29tcG9zaXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKaW5kZXgg YzIxNTBhMGZiMmZjNTYxY2IyOGI3YWYzYjdlZGVjOWY1ODExYTdhMC4uMGQ0MjFmOTZkODJjM2Ez NWMxZjFkY2QyOTU1NTY3YmEyN2RjYzI4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCkBAIC00Niw2 ICs0Niw3IEBACiAjaW5jbHVkZSAiVjhOb2RlLmgiCiAjaW5jbHVkZSAiVjhQcm94eS5oIgogI2lu Y2x1ZGUgIlY4UmVjdXJzaW9uU2NvcGUuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWls ZGVyLmg+CiAjaW5jbHVkZSA8d3RmL093bkFycmF5UHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0 ci5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KQEAgLTEwOSwxMCArMTEwLDEwIEBA IHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxEb2N1bWVudDo6R2V0TmFtZWRQcm9wZXJ0eShI VE1MRG9jdW1lbnQqIGh0bWxEb2N1bWVuCiAvLyAgIGRvY3VtZW50LndyaXRlKCkgLS0+IGRvY3Vt ZW50LndyaXRlKCIiKQogc3RhdGljIFN0cmluZyB3cml0ZUhlbHBlckdldFN0cmluZyhjb25zdCB2 ODo6QXJndW1lbnRzJiBhcmdzKQogewotICAgIFN0cmluZyBzdHIgPSAiIjsKKyAgICBTdHJpbmdC dWlsZGVyIGJ1aWxkZXI7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBhcmdzLkxlbmd0aCgpOyAr K2kpCi0gICAgICAgIHN0ciArPSB0b1dlYkNvcmVTdHJpbmcoYXJnc1tpXSk7Ci0gICAgcmV0dXJu IHN0cjsKKyAgICAgICAgYnVpbGRlci5hcHBlbmQodG9XZWJDb3JlU3RyaW5nKGFyZ3NbaV0pKTsK KyAgICByZXR1cm4gYnVpbGRlci50b1N0cmluZygpOwogfQogCiB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gVjhIVE1MRG9jdW1lbnQ6OndyaXRlQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJn cykK