93030 2012-08-02 14:32:15 -0700 [EFL] Build failures with harfbuzz outside standard locations 2012-08-22 08:45:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco d-r glima gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 685830 0 rakuco 2012-08-02 14:32:15 -0700 glima has been having some trouble building WebKit-EFL without building the dependencies with jhbuild. One of the problems is: In file included from /home/glima/devel/webkit/Source/WebCore/platform/graphics/freetype/FontPlatformData.h:33:0, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/FontPlatformData.h:35, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/SimpleFontData.h:30, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/FontFallbackList.h:25, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/Font.h:29, from /home/glima/devel/webkit/Source/WebCore/platform/PopupMenuStyle.h:30, from /home/glima/devel/webkit/Source/WebCore/platform/PopupMenuClient.h:26, from /home/glima/devel/webkit/Source/WebCore/page/ChromeClient.h:33, from /home/glima/devel/webkit/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp:34: /home/glima/devel/webkit/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:34:16: fatal error: hb.h: No such file or directory compilation terminated. I think there are problems when building Source/WebKit as well. This can be solved by including ${HARFBUZZ_INCLUDE_DIRS} in the include path. 696717 1 rakuco 2012-08-15 21:33:28 -0700 I've finished building here and couldn't reproduce the issue (I was able to do so on another system). The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. Are you building the port with build-webkit or using CMake on your own? In case it's the latter, I suspect evas may have been built without harfbuzz support and the flag is thus absent from your evas.pc. In case it's the former, I'd like to see the output of `./Tools/efl/run-with-jhbuild pkg-config --cflags-only-I evas'. 696718 2 rakuco 2012-08-15 21:34:11 -0700 (In reply to comment #1) > The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. (Relying on this is wrong, by the way, but I'd like to pinpoint where the problem is before trying to fix it). 696719 3 rakuco 2012-08-15 21:37:53 -0700 (In reply to comment #1) > I've finished building here and couldn't reproduce the issue (I was able to do so on another system). ... Thinking of it again, I was able to reproduce this when I was testing my FindEFL.cmake rewrite, which gets rid of those implicit dependencies I mentioned in the previous comments, so it makes sense to have experienced the same build problem. 697164 4 glima 2012-08-16 08:22:01 -0700 The problem occurs with a build without build-webkit usage, but pristine cmake. Evas without harfbuzz linkage too. I've just found out that a harfbuzzy Evas will let the build go, but apparently this should not be a requirement. My 2 cents. 701530 5 159850 rakuco 2012-08-21 20:15:44 -0700 Created attachment 159850 Patch 701842 6 d-r 2012-08-22 06:29:59 -0700 Makes sense to me, thanks for catching this. 701945 7 159850 rwlbuis 2012-08-22 08:32:46 -0700 Comment on attachment 159850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159850&action=review LGTM. > Source/WebCore/PlatformEfl.cmake:158 > + ${HARFBUZZ_INCLUDE_DIRS} Is the indenting correct here? 701951 8 rakuco 2012-08-22 08:36:44 -0700 Yep, we're just not using quotes. 701967 9 159850 rakuco 2012-08-22 08:45:46 -0700 Comment on attachment 159850 Patch Clearing flags on attachment: 159850 Committed r126305: <http://trac.webkit.org/changeset/126305> 701968 10 rakuco 2012-08-22 08:45:53 -0700 All reviewed patches have been landed. Closing bug. 159850 2012-08-21 20:15:44 -0700 2012-08-22 08:45:46 -0700 Patch bug-93030-20120822001541.patch text/plain 1783 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI1YzBlMDNlYzgwMzY4 MjY1ZTk1NDcyNjY4ZGUyYTVlOGQ2Zjc2YS4uMzZmOGEyOTYzYzRjZTJmYWUyYzIzZDZhNGE3ZGU2 YmNlN2FhMGZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTIxICBSYXBo YWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBC dWlsZCBmYWlsdXJlcyB3aXRoIGhhcmZidXp6IG91dHNpZGUgc3RhbmRhcmQgbG9jYXRpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzAzMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCAke0hBUkZC VVpaX0lOQ0xVREVfRElSU30gdG8gdGhlIGxpc3Qgb2YgaW5jbHVkZWQgcGF0aHM6IHNvIGZhcgor ICAgICAgICBpdCB3YXMgYmVpbmcgaW1wbGljaXRseSBwdWxsZWQgZnJvbSBldmFzJ3MgcGtnLWNv bmZpZyBmaWxlLCBhbmQKKyAgICAgICAgdXNlZCB0byB3b3JrIHdoZW4gV2ViS2l0LUVGTCdzIGRl cGVuZGVuY2llcyB3ZXJlIGJ1aWx0IHdpdGgKKyAgICAgICAgamhidWlsZCAtLSBpbiB0aGlzIGNh c2UsIGhhcmZidXp6IGlzIGJ1aWx0IGJlZm9yZSBldmFzLCB3aGljaCBpcworICAgICAgICB0aGVu IGJ1aWx0IHdpdGggaGFyZmJ1enogc3VwcG9ydCBhbmQgYWRkcyB0aGUgcmVxdWlyZWQgcGF0aHMg dG8KKyAgICAgICAgaXRzIC5wYyBmaWxlLgorCisgICAgICAgIFdlIG5lZWQgdG8gaW5jbHVkZSB0 aGluZ3MgZGlyZWN0bHkgdG8gYWNjb3VudCBmb3IgdGhlIGNhc2Ugb2YKKyAgICAgICAgcGVvcGxl IG5vdCB1c2luZyBqaGJ1aWxkIGFuZCB0aHVzIG5vdCBuZWNlc3NhcmlseSBoYXZpbmcgaGFyZmJ1 enoKKyAgICAgICAgYXMgYW4gZXZhcyBkZXBlbmRlbmN5LgorCisgICAgICAgICogUGxhdGZvcm1F ZmwuY21ha2U6CisKIDIwMTItMDgtMjEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW3JlZ3Jlc3Npb25dIFNldHRpbmdzIHBh bmVsIGZhaWxzIHRvIG9wZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVm bC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDhkZTdiYjQ5 YWQ0ODE3ZTFhNDNhNGU0MGMxYWE3NzNlOWM2ZWNlNmYuLjI1YzM1ZDU3Y2YyNDM2MzY0ODQ2NjMy YmQ5MDFkZjhiMDRkZWYyYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xNTUsNiAr MTU1LDcgQEAgSUYgKFdURl9VU0VfQ0FJUk8pCiAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZv cm0vZ3JhcGhpY3MvZnJlZXR5cGUiCiAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3Jh cGhpY3MvaGFyZmJ1enovIgogICAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNz L2hhcmZidXp6L25nIgorICAgICAgJHtIQVJGQlVaWl9JTkNMVURFX0RJUlN9CiAgICAgKQogICAg IExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvV09G RkZpbGVGb3JtYXQuY3BwCg==