93024 2012-08-02 13:47:48 -0700 [chromium] Remove dependency on Scrollbar.h from ScrollbarLayerChromium 2012-08-02 15:47:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92930 1 enne enne enne jamesr webkit.review.bot oldest_to_newest 685767 0 enne 2012-08-02 13:47:48 -0700 [chromium] Remove dependency on Scrollbar.h from ScrollbarLayerChromium 685769 1 156157 enne 2012-08-02 13:49:22 -0700 Created attachment 156157 Patch 685779 2 156157 jamesr 2012-08-02 13:56:34 -0700 Comment on attachment 156157 Patch Nice! 685922 3 156157 webkit.review.bot 2012-08-02 15:47:55 -0700 Comment on attachment 156157 Patch Clearing flags on attachment: 156157 Committed r124516: <http://trac.webkit.org/changeset/124516> 685923 4 webkit.review.bot 2012-08-02 15:47:58 -0700 All reviewed patches have been landed. Closing bug. 156157 2012-08-02 13:49:22 -0700 2012-08-02 15:47:55 -0700 Patch bug-93024-20120802134903.patch text/plain 5189 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2EyNGRlZTk2ZWUwMTE0 OTYxYjU4YTUyNWQ2ZDk2ZmQ1YTZlNDU1MC4uMDcyNzQ5OTg2MTRiZjZhZTUzYzgwYmU5MTUwOTUw ZTVlZjZlMThkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA4LTAyICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKKyAgICAgICAgW2Nocm9taXVtXSBSZW1v dmUgZGVwZW5kZW5jeSBvbiBTY3JvbGxiYXIuaCBmcm9tIFNjcm9sbGJhckxheWVyQ2hyb21pdW0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDI0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHBh cnQgZW51bSBmcm9tIHRoZSBTY3JvbGxiYXIgdmVyc2lvbiB0byBXZWJTY3JvbGxiYXIncy4KKwor ICAgICAgICBUZXN0ZWQgYnkgY29tcG9zaXRlZCBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TY3JvbGxiYXJMYXllckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhckJhY2tncm91bmRQYWludGVyOjpjcmVhdGUpOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyQmFja2dyb3VuZFBhaW50ZXI6OlNjcm9sbGJhckJhY2tn cm91bmRQYWludGVyKToKKyAgICAgICAgKFNjcm9sbGJhckJhY2tncm91bmRQYWludGVyKToKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhckxheWVyQ2hyb21pdW06OmNyZWF0ZVRleHR1cmVVcGRh dGVySWZOZWVkZWQpOgorCisyMDEyLTA4LTAyICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2ds ZS5jb20+CisKICAgICAgICAgW2Nocm9taXVtXSBNYWtlIENDU2Nyb2xsYmFyTGF5ZXJJbXBsIGhh bmRsZSBsb3N0IGNvbnRleHRzIHByb3Blcmx5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MzAyMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TY3JvbGxiYXJMYXllckNocm9taXVtLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Njcm9sbGJhckxheWVyQ2hy b21pdW0uY3BwCmluZGV4IDk0NDIzMTAyNzg0Y2E2OTk1MmIwYmY2M2VlMjVlODBkZDE5MjczYmIu LjVmNzNlYmUyNmU1MzhiNTg3YWRiZWY3NDg1OGUxNTgyYWQ4NjdmNTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Njcm9sbGJhckxheWVyQ2hy b21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1Njcm9sbGJhckxheWVyQ2hyb21pdW0uY3BwCkBAIC0zMCw3ICszMCw2IEBACiAKICNpbmNsdWRl ICJCaXRtYXBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmgiCiAjaW5jbHVkZSAiTGF5ZXJQYWlu dGVyQ2hyb21pdW0uaCIKLSNpbmNsdWRlICJTY3JvbGxiYXIuaCIKICNpbmNsdWRlICJjYy9DQ0xh eWVyVHJlZUhvc3QuaCIKICNpbmNsdWRlICJjYy9DQ1Njcm9sbGJhckxheWVySW1wbC5oIgogI2lu Y2x1ZGUgImNjL0NDVGV4dHVyZVVwZGF0ZXIuaCIKQEAgLTg2LDcgKzg1LDcgQEAgdm9pZCBTY3Jv bGxiYXJMYXllckNocm9taXVtOjpwdXNoUHJvcGVydGllc1RvKENDTGF5ZXJJbXBsKiBsYXllcikK IGNsYXNzIFNjcm9sbGJhckJhY2tncm91bmRQYWludGVyIDogcHVibGljIExheWVyUGFpbnRlckNo cm9taXVtIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShTY3JvbGxiYXJCYWNrZ3JvdW5kUGFp bnRlcik7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NPd25QdHI8U2Nyb2xsYmFyQmFja2dyb3Vu ZFBhaW50ZXI+IGNyZWF0ZShXZWJLaXQ6OldlYlNjcm9sbGJhciogc2Nyb2xsYmFyLCBXZWJLaXQ6 OldlYlNjcm9sbGJhclRoZW1lUGFpbnRlciBwYWludGVyLCBXZWJLaXQ6OldlYlNjcm9sbGJhclRo ZW1lR2VvbWV0cnkgZ2VvbWV0cnksIFNjcm9sbGJhclBhcnQgdHJhY2tQYXJ0KQorICAgIHN0YXRp YyBQYXNzT3duUHRyPFNjcm9sbGJhckJhY2tncm91bmRQYWludGVyPiBjcmVhdGUoV2ViS2l0OjpX ZWJTY3JvbGxiYXIqIHNjcm9sbGJhciwgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZVBhaW50ZXIg cGFpbnRlciwgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZUdlb21ldHJ5IGdlb21ldHJ5LCBXZWJL aXQ6OldlYlNjcm9sbGJhcjo6U2Nyb2xsYmFyUGFydCB0cmFja1BhcnQpCiAgICAgewogICAgICAg ICByZXR1cm4gYWRvcHRQdHIobmV3IFNjcm9sbGJhckJhY2tncm91bmRQYWludGVyKHNjcm9sbGJh ciwgcGFpbnRlciwgZ2VvbWV0cnksIHRyYWNrUGFydCkpOwogICAgIH0KQEAgLTExNiw3ICsxMTUs NyBAQCBwdWJsaWM6CiAKICAgICAgICAgYm9vbCB0aHVtYlByZXNlbnQgPSBtX2dlb21ldHJ5Lmhh c1RodW1iKG1fc2Nyb2xsYmFyKTsKICAgICAgICAgaWYgKHRodW1iUHJlc2VudCkgewotICAgICAg ICAgICAgaWYgKG1fdHJhY2tQYXJ0ID09IEZvcndhcmRUcmFja1BhcnQpCisgICAgICAgICAgICBp ZiAobV90cmFja1BhcnQgPT0gV2ViS2l0OjpXZWJTY3JvbGxiYXI6OkZvcndhcmRUcmFja1BhcnQp CiAgICAgICAgICAgICAgICAgbV9wYWludGVyLnBhaW50Rm9yd2FyZFRyYWNrUGFydChjYW52YXMs IG1fc2Nyb2xsYmFyLCB0cmFja1BhaW50UmVjdCk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAg ICAgICAgICAgbV9wYWludGVyLnBhaW50QmFja1RyYWNrUGFydChjYW52YXMsIG1fc2Nyb2xsYmFy LCB0cmFja1BhaW50UmVjdCk7CkBAIC0xMjUsNyArMTI0LDcgQEAgcHVibGljOgogICAgICAgICBt X3BhaW50ZXIucGFpbnRUaWNrbWFya3MoY2FudmFzLCBtX3Njcm9sbGJhciwgdHJhY2tQYWludFJl Y3QpOwogICAgIH0KIHByaXZhdGU6Ci0gICAgU2Nyb2xsYmFyQmFja2dyb3VuZFBhaW50ZXIoV2Vi S2l0OjpXZWJTY3JvbGxiYXIqIHNjcm9sbGJhciwgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZVBh aW50ZXIgcGFpbnRlciwgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZUdlb21ldHJ5IGdlb21ldHJ5 LCBTY3JvbGxiYXJQYXJ0IHRyYWNrUGFydCkKKyAgICBTY3JvbGxiYXJCYWNrZ3JvdW5kUGFpbnRl cihXZWJLaXQ6OldlYlNjcm9sbGJhciogc2Nyb2xsYmFyLCBXZWJLaXQ6OldlYlNjcm9sbGJhclRo ZW1lUGFpbnRlciBwYWludGVyLCBXZWJLaXQ6OldlYlNjcm9sbGJhclRoZW1lR2VvbWV0cnkgZ2Vv bWV0cnksIFdlYktpdDo6V2ViU2Nyb2xsYmFyOjpTY3JvbGxiYXJQYXJ0IHRyYWNrUGFydCkKICAg ICAgICAgOiBtX3Njcm9sbGJhcihzY3JvbGxiYXIpCiAgICAgICAgICwgbV9wYWludGVyKHBhaW50 ZXIpCiAgICAgICAgICwgbV9nZW9tZXRyeShnZW9tZXRyeSkKQEAgLTEzNiw3ICsxMzUsNyBAQCBw cml2YXRlOgogICAgIFdlYktpdDo6V2ViU2Nyb2xsYmFyKiBtX3Njcm9sbGJhcjsKICAgICBXZWJL aXQ6OldlYlNjcm9sbGJhclRoZW1lUGFpbnRlciBtX3BhaW50ZXI7CiAgICAgV2ViS2l0OjpXZWJT Y3JvbGxiYXJUaGVtZUdlb21ldHJ5IG1fZ2VvbWV0cnk7Ci0gICAgU2Nyb2xsYmFyUGFydCBtX3Ry YWNrUGFydDsKKyAgICBXZWJLaXQ6OldlYlNjcm9sbGJhcjo6U2Nyb2xsYmFyUGFydCBtX3RyYWNr UGFydDsKIH07CiAKIGNsYXNzIFNjcm9sbGJhclRodW1iUGFpbnRlciA6IHB1YmxpYyBMYXllclBh aW50ZXJDaHJvbWl1bSB7CkBAIC0xODgsMTQgKzE4NywxNCBAQCB2b2lkIFNjcm9sbGJhckxheWVy Q2hyb21pdW06OmNyZWF0ZVRleHR1cmVVcGRhdGVySWZOZWVkZWQoKQogICAgIG1fdGV4dHVyZUZv cm1hdCA9IGxheWVyVHJlZUhvc3QoKS0+bGF5ZXJSZW5kZXJlckNhcGFiaWxpdGllcygpLmJlc3RU ZXh0dXJlRm9ybWF0OwogCiAgICAgaWYgKCFtX2JhY2tUcmFja1VwZGF0ZXIpCi0gICAgICAgIG1f YmFja1RyYWNrVXBkYXRlciA9IEJpdG1hcENhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXI6OmNyZWF0 ZShTY3JvbGxiYXJCYWNrZ3JvdW5kUGFpbnRlcjo6Y3JlYXRlKG1fc2Nyb2xsYmFyLmdldCgpLCBt X3BhaW50ZXIsIG1fZ2VvbWV0cnksIEJhY2tUcmFja1BhcnQpKTsKKyAgICAgICAgbV9iYWNrVHJh Y2tVcGRhdGVyID0gQml0bWFwQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6Y3JlYXRlKFNjcm9s bGJhckJhY2tncm91bmRQYWludGVyOjpjcmVhdGUobV9zY3JvbGxiYXIuZ2V0KCksIG1fcGFpbnRl ciwgbV9nZW9tZXRyeSwgV2ViS2l0OjpXZWJTY3JvbGxiYXI6OkJhY2tUcmFja1BhcnQpKTsKICAg ICBpZiAoIW1fYmFja1RyYWNrKQogICAgICAgICBtX2JhY2tUcmFjayA9IG1fYmFja1RyYWNrVXBk YXRlci0+Y3JlYXRlVGV4dHVyZShsYXllclRyZWVIb3N0KCktPmNvbnRlbnRzVGV4dHVyZU1hbmFn ZXIoKSk7CiAKICAgICAvLyBPbmx5IGNyZWF0ZSB0d28tcGFydCB0cmFjayBpZiB3ZSB0aGluayB0 aGUgdHdvIHBhcnRzIGNvdWxkIGJlIGRpZmZlcmVudCBpbiBhcHBlYXJhbmNlLgogICAgIGlmICht X3Njcm9sbGJhci0+aXNDdXN0b21TY3JvbGxiYXIoKSkgewogICAgICAgICBpZiAoIW1fZm9yZVRy YWNrVXBkYXRlcikKLSAgICAgICAgICAgIG1fZm9yZVRyYWNrVXBkYXRlciA9IEJpdG1hcENhbnZh c0xheWVyVGV4dHVyZVVwZGF0ZXI6OmNyZWF0ZShTY3JvbGxiYXJCYWNrZ3JvdW5kUGFpbnRlcjo6 Y3JlYXRlKG1fc2Nyb2xsYmFyLmdldCgpLCBtX3BhaW50ZXIsIG1fZ2VvbWV0cnksIEZvcndhcmRU cmFja1BhcnQpKTsKKyAgICAgICAgICAgIG1fZm9yZVRyYWNrVXBkYXRlciA9IEJpdG1hcENhbnZh c0xheWVyVGV4dHVyZVVwZGF0ZXI6OmNyZWF0ZShTY3JvbGxiYXJCYWNrZ3JvdW5kUGFpbnRlcjo6 Y3JlYXRlKG1fc2Nyb2xsYmFyLmdldCgpLCBtX3BhaW50ZXIsIG1fZ2VvbWV0cnksIFdlYktpdDo6 V2ViU2Nyb2xsYmFyOjpGb3J3YXJkVHJhY2tQYXJ0KSk7CiAgICAgICAgIGlmICghbV9mb3JlVHJh Y2spCiAgICAgICAgICAgICBtX2ZvcmVUcmFjayA9IG1fZm9yZVRyYWNrVXBkYXRlci0+Y3JlYXRl VGV4dHVyZShsYXllclRyZWVIb3N0KCktPmNvbnRlbnRzVGV4dHVyZU1hbmFnZXIoKSk7CiAgICAg fQo=