93012 2012-08-02 11:44:11 -0700 [BlackBerry] Rounding error of destination rect of checkerboard 2012-08-02 12:54:12 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 leoyang webkit-unassigned mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 685626 0 leoyang 2012-08-02 11:44:11 -0700 1302 void BackingStorePrivate::blitContents(const Platform::IntRect& dstRect, 1303 const Platform::IntRect& srcRect, 1304 bool force) 1305 { ... 1407 // Blit checkered to those parts that are not covered by the backingStoreRect. 1408 IntRectList checkeredRects = checkeredRegion.rects(); 1409 for (size_t i = 0; i < checkeredRects.size(); ++i) { 1410 Platform::IntRect dstRect = transformation.mapRect(Platform::IntRect( 1411 Platform::IntPoint(checkeredRects.at(i).x() - origin.x(), checkeredRects.at(i).y() - origin.y()), 1412 checkeredRects.at(i).size())); 1413 #if DEBUG_CHECKERBOARD 1414 blitCheckered = true; 1415 #endif 1416 fillWindow(BlackBerry::Platform::Graphics::CheckerboardPattern, 1417 dstRect, checkeredRects.at(i).location(), transformation.a()); 1418 } 1419 } ... } The dstRect in line 1401 might get rounding error +1/-1 pixel due to transformation. We need to intersect it with the original dstRect passed into this function. Patch is coming soon. 685650 1 156134 leoyang 2012-08-02 12:07:28 -0700 Created attachment 156134 Patch 685660 2 156134 rwlbuis 2012-08-02 12:19:39 -0700 Comment on attachment 156134 Patch LGTM. 685693 3 156134 webkit.review.bot 2012-08-02 12:54:08 -0700 Comment on attachment 156134 Patch Clearing flags on attachment: 156134 Committed r124487: <http://trac.webkit.org/changeset/124487> 685694 4 webkit.review.bot 2012-08-02 12:54:12 -0700 All reviewed patches have been landed. Closing bug. 156134 2012-08-02 12:07:28 -0700 2012-08-02 12:54:08 -0700 Patch 0001-BlackBerry-Rounding-error-of-destination-rect-of-che.patch text/plain 2920 leoyang RnJvbSAyY2ZmYWMxN2U5MzEyYzQzNmQ4M2I0ZDU0MmY3MGNjNWI3MWU2YmVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBUaHUs IDIgQXVnIDIwMTIgMTU6MDU6NTMgLTA0MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g Um91bmRpbmcgZXJyb3Igb2YgZGVzdGluYXRpb24gcmVjdCBvZgogY2hlY2tlcmJvYXJkIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzAxMgoKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgpSZXZpZXdlZCBpbnRlcm5hbGx5IGJ5IEpha29iIFBldHNvdml0cy4KCklu dGVyc2VjdCB3aXRoIHRoZSBkZXN0aW5hdGlvbiByZWN0YW5nbGUgdG8gZWxpbWluYXRlIHRoZSBy b3VuZGluZyBlcnJvci4KCiogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CihCbGFja0JlcnJ5OjpXZWJL aXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmJsaXRDb250ZW50cyk6Ci0tLQogU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwIHwgICAgNyArKysrKy0tCiBTb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3Bw IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCmluZGV4IGJj NTQ3YjAuLjg3ODY2NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv QmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tp bmdTdG9yZS5jcHAKQEAgLTE0MDcsMTQgKzE0MDcsMTcgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2 YXRlOjpibGl0Q29udGVudHMoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGRzdFJlY3QsCiAgICAg ICAgICAgICAvLyBCbGl0IGNoZWNrZXJlZCB0byB0aG9zZSBwYXJ0cyB0aGF0IGFyZSBub3QgY292 ZXJlZCBieSB0aGUgYmFja2luZ1N0b3JlUmVjdC4KICAgICAgICAgICAgIEludFJlY3RMaXN0IGNo ZWNrZXJlZFJlY3RzID0gY2hlY2tlcmVkUmVnaW9uLnJlY3RzKCk7CiAgICAgICAgICAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IGNoZWNrZXJlZFJlY3RzLnNpemUoKTsgKytpKSB7Ci0gICAgICAg ICAgICAgICAgUGxhdGZvcm06OkludFJlY3QgZHN0UmVjdCA9IHRyYW5zZm9ybWF0aW9uLm1hcFJl Y3QoUGxhdGZvcm06OkludFJlY3QoCisgICAgICAgICAgICAgICAgUGxhdGZvcm06OkludFJlY3Qg Y2xpcHBlZERzdFJlY3QgPSB0cmFuc2Zvcm1hdGlvbi5tYXBSZWN0KFBsYXRmb3JtOjpJbnRSZWN0 KAogICAgICAgICAgICAgICAgICAgICBQbGF0Zm9ybTo6SW50UG9pbnQoY2hlY2tlcmVkUmVjdHMu YXQoaSkueCgpIC0gb3JpZ2luLngoKSwgY2hlY2tlcmVkUmVjdHMuYXQoaSkueSgpIC0gb3JpZ2lu LnkoKSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGVja2VyZWRS ZWN0cy5hdChpKS5zaXplKCkpKTsKKyAgICAgICAgICAgICAgICAvLyBUbyBlbGltaW5hdGUgMSBw aXhlbCBpbmZsYXRpb24gZHVlIHRvIHRyYW5zZm9ybWF0aW9uIHJvdW5kaW5nLgorICAgICAgICAg ICAgICAgIGNsaXBwZWREc3RSZWN0LmludGVyc2VjdChkc3RSZWN0KTsKICNpZiBERUJVR19DSEVD S0VSQk9BUkQKICAgICAgICAgICAgICAgICBibGl0Q2hlY2tlcmVkID0gdHJ1ZTsKICNlbmRpZgor CiAgICAgICAgICAgICAgICAgZmlsbFdpbmRvdyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhp Y3M6OkNoZWNrZXJib2FyZFBhdHRlcm4sCi0gICAgICAgICAgICAgICAgICAgIGRzdFJlY3QsIGNo ZWNrZXJlZFJlY3RzLmF0KGkpLmxvY2F0aW9uKCksIHRyYW5zZm9ybWF0aW9uLmEoKSk7CisgICAg ICAgICAgICAgICAgICAgIGNsaXBwZWREc3RSZWN0LCBjaGVja2VyZWRSZWN0cy5hdChpKS5sb2Nh dGlvbigpLCB0cmFuc2Zvcm1hdGlvbi5hKCkpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGQyZGFiYjcuLjMxYjg0MDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTAyICBM ZW8gWWFuZyAgPGxlb3lhbmdAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUm91bmRp bmcgZXJyb3Igb2YgZGVzdGluYXRpb24gcmVjdCBvZiBjaGVja2VyYm9hcmQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBi eSBKYWtvYiBQZXRzb3ZpdHMuCisKKyAgICAgICAgSW50ZXJzZWN0IHdpdGggdGhlIGRlc3RpbmF0 aW9uIHJlY3RhbmdsZSB0byBlbGltaW5hdGUgdGhlIHJvdW5kaW5nIGVycm9yLgorCisgICAgICAg ICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJh Y2tpbmdTdG9yZVByaXZhdGU6OmJsaXRDb250ZW50cyk6CisKIDIwMTItMDgtMDEgIEFudG9uaW8g R29tZXMgIDxhZ29tZXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gSW1wbGVtZW50 IEluUmVnaW9uU2Nyb2xsZXIgY2xhc3MgYXMgYSBpbi1yZWdpb24gc2Nyb2xsIGNvbnRyb2xsZXIK LS0gCjEuNy41LjQKCg==