92992 2012-08-02 07:46:13 -0700 Limited the number of queried cached build infos in URLs used by Garden-o-matic. 2012-08-03 12:00:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kadam webkit-unassigned abarth dglazkov galpeter kadam kkristof ojan webkit.review.bot oldest_to_newest 685379 0 kadam 2012-08-02 07:46:13 -0700 Limited the number of queried cached builds. I tried to add a reasonable limit. I need it, because I would like to add the QTSED bots to garden-o-matic. These bots store about 100 cached builds. When the Garden-o-matic gets the cached build information then it hangs up, because the URL is too long. Do you prefer setting this limit number in config.js globally or should it be set per platform? I'm going to upload the draft patch. 685382 1 156082 kadam 2012-08-02 07:47:32 -0700 Created attachment 156082 draft patch 685420 2 abarth 2012-08-02 08:24:51 -0700 > Do you prefer setting this limit number in config.js globally or should it be set per platform? I'd start with a global constant in config.js. We can change it to be per-platform if folks want to customize it for different platforms. (Also, your patch will need a ChangeLog, which can be generated by prepare-ChangeLogs.) 686654 3 156355 kadam 2012-08-03 06:47:14 -0700 Created attachment 156355 proposed patch Thanks for your comment. I fixed my patch. 686864 4 156355 abarth 2012-08-03 09:52:24 -0700 Comment on attachment 156355 proposed patch Ok. 687013 5 156355 webkit.review.bot 2012-08-03 12:00:29 -0700 Comment on attachment 156355 proposed patch Clearing flags on attachment: 156355 Committed r124635: <http://trac.webkit.org/changeset/124635> 687014 6 webkit.review.bot 2012-08-03 12:00:34 -0700 All reviewed patches have been landed. Closing bug. 156082 2012-08-02 07:47:32 -0700 2012-08-03 06:47:14 -0700 draft patch 201200802gardenomatic.patch text/plain 1074 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2J1aWxkZXJzLmpzIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMuanMKaW5kZXggZDQ1Y2UyMi4uNGFmNTRjZSAxMDA2 NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMuanMKKysrIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMuanMKQEAgLTEyNyw3ICsxMjcsOCBAQCBidWlsZGVy cy5jYWNoZWRCdWlsZEluZm9zID0gZnVuY3Rpb24ocGxhdGZvcm0sIGJ1aWxkZXJOYW1lLCBjYWxs YmFjaykKICAgICBuZXQuZ2V0KGJ1aWxkZXJJbmZvVVJMLCBmdW5jdGlvbihidWlsZGVySW5mbykg ewogICAgICAgICB2YXIgc2VsZWN0VVJMID0gdXJsRm9yQnVpbGRlckluZm8ocGxhdGZvcm0sIGJ1 aWxkZXJOYW1lKSArICdidWlsZHMnOwogICAgICAgICAvLyAvLyBGSVhNRTogbGltaXQgdG8gc29t ZSByZWFzb25hYmxlIG51bWJlcj8KLSAgICAgICAgdmFyIHNlbGVjdFBhcmFtcyA9IHsgc2VsZWN0 IDogYnVpbGRlckluZm8uY2FjaGVkQnVpbGRzIH07CisgICAgICAgIHZhciBzdGFydCA9IE1hdGgu bWF4KDAsIGJ1aWxkZXJJbmZvLmNhY2hlZEJ1aWxkcy5sZW5ndGgtMjApOworICAgICAgICB2YXIg c2VsZWN0UGFyYW1zID0geyBzZWxlY3QgOiBidWlsZGVySW5mby5jYWNoZWRCdWlsZHMuc2xpY2Uo c3RhcnQpIH07CiAgICAgICAgIHZhciB0cmFkaXRpb25hbEVuY29kaW5nID0gdHJ1ZTsKICAgICAg ICAgc2VsZWN0VVJMICs9ICc/JyArICQucGFyYW0oc2VsZWN0UGFyYW1zLCB0cmFkaXRpb25hbEVu Y29kaW5nKTsKICAgICAgICAgbmV0LmdldChzZWxlY3RVUkwsIGNhbGxiYWNrKTsK 156355 2012-08-03 06:47:14 -0700 2012-08-03 12:00:29 -0700 proposed patch 20120803limitbuildnumber.patch text/plain 2572 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Mzk2 NTZhLi4xMTc3OTRlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMDMgIMOBZMOhbSBLYWxsYWkgIDxrYWRh bUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgTGltaXRlZCB0aGUgbnVtYmVyIG9mIHF1ZXJp ZWQgY2FjaGVkIGJ1aWxkIGluZm9zIGluIFVSTHMgdXNlZCBieSBHYXJkZW4tby1tYXRpYy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyOTkyLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgYWRkZWQgYSBs aW1pdCB0byB0aGUgY2FjaGVkIGJ1aWxkcyB0aGF0IGFyZSBpbmNsdWRlZCBpbiB0aGUgVVJMIHRv IGF2b2lkIHRvbyBsb25nIFVSTHMgaW4gR2FyZGVuLW8tbWF0aWMuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFp bHVyZXMvc2NyaXB0cy9idWlsZGVycy5qczoKKyAgICAgICAgKC4pOgorICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9zY3JpcHRzL2NvbmZpZy5qczoKKwogMjAxMi0wOC0wMyAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXgg Zm9yIEdUSyBhZnRlciByMTI0NTgxLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Njcmlw dHMvYnVpbGRlcnMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVycy5qcwppbmRl eCBkNDVjZTIyLi4zY2I4MDRhIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9i dWlsZGVycy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVycy5qcwpAQCAt MTI2LDggKzEyNiw4IEBAIGJ1aWxkZXJzLmNhY2hlZEJ1aWxkSW5mb3MgPSBmdW5jdGlvbihwbGF0 Zm9ybSwgYnVpbGRlck5hbWUsIGNhbGxiYWNrKQogICAgIHZhciBidWlsZGVySW5mb1VSTCA9IHVy bEZvckJ1aWxkZXJJbmZvKHBsYXRmb3JtLCBidWlsZGVyTmFtZSk7CiAgICAgbmV0LmdldChidWls ZGVySW5mb1VSTCwgZnVuY3Rpb24oYnVpbGRlckluZm8pIHsKICAgICAgICAgdmFyIHNlbGVjdFVS TCA9IHVybEZvckJ1aWxkZXJJbmZvKHBsYXRmb3JtLCBidWlsZGVyTmFtZSkgKyAnYnVpbGRzJzsK LSAgICAgICAgLy8gLy8gRklYTUU6IGxpbWl0IHRvIHNvbWUgcmVhc29uYWJsZSBudW1iZXI/Ci0g ICAgICAgIHZhciBzZWxlY3RQYXJhbXMgPSB7IHNlbGVjdCA6IGJ1aWxkZXJJbmZvLmNhY2hlZEJ1 aWxkcyB9OworICAgICAgICB2YXIgc3RhcnQgPSBNYXRoLm1heCgwLCBidWlsZGVySW5mby5jYWNo ZWRCdWlsZHMubGVuZ3RoIC0gY29uZmlnLmtCdWlsZE51bWJlckxpbWl0KTsKKyAgICAgICAgdmFy IHNlbGVjdFBhcmFtcyA9IHsgc2VsZWN0IDogYnVpbGRlckluZm8uY2FjaGVkQnVpbGRzLnNsaWNl KHN0YXJ0KSB9OwogICAgICAgICB2YXIgdHJhZGl0aW9uYWxFbmNvZGluZyA9IHRydWU7CiAgICAg ICAgIHNlbGVjdFVSTCArPSAnPycgKyAkLnBhcmFtKHNlbGVjdFBhcmFtcywgdHJhZGl0aW9uYWxF bmNvZGluZyk7CiAgICAgICAgIG5ldC5nZXQoc2VsZWN0VVJMLCBjYWxsYmFjayk7CmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9jb25maWcuanMgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c2NyaXB0cy9jb25maWcuanMKaW5kZXggNmM0MDVlZC4uNmM5Y2ViZiAxMDA2NDQKLS0tIGEvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL3NjcmlwdHMvY29uZmlnLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3Jp cHRzL2NvbmZpZy5qcwpAQCAtMjcsNiArMjcsOCBAQCB2YXIgY29uZmlnID0gY29uZmlnIHx8IHt9 OwogCiAoZnVuY3Rpb24oKSB7CiAKK2NvbmZpZy5rQnVpbGROdW1iZXJMaW1pdCA9IDIwOworCiBj b25maWcua1BsYXRmb3JtcyA9IHsKICAgICAnYXBwbGUnIDogewogICAgICAgICBsYWJlbCA6ICdB cHBsZScsCg==