<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92984</bug_id>
          
          <creation_ts>2012-08-02 06:50:06 -0700</creation_ts>
          <short_desc>[cmake] Cleanup FindHarfBuzz.cmake</short_desc>
          <delta_ts>2012-08-03 03:02:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dominik Röttsches (drott)">d-r</reporter>
          <assigned_to name="Dominik Röttsches (drott)">d-r</assigned_to>
          <cc>dbates</cc>
    
    <cc>dpranke</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>rakuco</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>tmpsantos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>685319</commentid>
    <comment_count>0</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-02 06:50:06 -0700</bug_when>
    <thetext>A bit of cleanup did accidentally not make it into my landed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>685345</commentid>
    <comment_count>1</comment_count>
      <attachid>156076</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-02 07:13:36 -0700</bug_when>
    <thetext>Created attachment 156076
FindHarfbuzz.cmake cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>685432</commentid>
    <comment_count>2</comment_count>
      <attachid>156076</attachid>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-08-02 08:37:40 -0700</bug_when>
    <thetext>Comment on attachment 156076
FindHarfbuzz.cmake cleanup.

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>685608</commentid>
    <comment_count>3</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-02 11:23:34 -0700</bug_when>
    <thetext>Looks good, thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>686469</commentid>
    <comment_count>4</comment_count>
      <attachid>156076</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2012-08-03 02:22:46 -0700</bug_when>
    <thetext>Comment on attachment 156076
FindHarfbuzz.cmake cleanup.

rubberstamping.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>686497</commentid>
    <comment_count>5</comment_count>
      <attachid>156076</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-03 03:02:52 -0700</bug_when>
    <thetext>Comment on attachment 156076
FindHarfbuzz.cmake cleanup.

Clearing flags on attachment: 156076

Committed r124587: &lt;http://trac.webkit.org/changeset/124587&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>686498</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-03 03:02:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>156076</attachid>
            <date>2012-08-02 07:13:36 -0700</date>
            <delta_ts>2012-08-03 03:02:52 -0700</delta_ts>
            <desc>FindHarfbuzz.cmake cleanup.</desc>
            <filename>bug-92984-20120802171540.patch</filename>
            <type>text/plain</type>
            <size>1529</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEhhcmZCdXp6LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRIYXJmQnV6ei5jbWFrZQppbmRleCA4
YTk5MDE5YjVjYzQ2OGY2OTdmODNmMGU0NTgyNTlmYTUwMTIwZTNlLi5hMzQ4ODc5MmFkMDVkY2Y1
MjE0ZTY1NjgwOWQzZTMyYzY3OGRlMTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEhh
cmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKQEAgLTI0
LDEyICsyNCwxNCBAQAogIyBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJ
UyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRQogIyBQT1NTSUJJTElUWSBPRiBTVUNI
IERBTUFHRS4KICMKKyMgVHJ5IHRvIGZpbmQgSGFyZmJ1enogaW5jbHVkZSBhbmQgbGlicmFyeSBk
aXJlY3Rvcmllcy4KICMKKyMgQWZ0ZXIgc3VjY2Vzc2Z1bCBkaXNjb3ZlcnksIHRoaXMgd2lsbCBz
ZXQgZm9yIGluY2x1c2lvbiB3aGVyZSBuZWVkZWQ6CisjIEhBUkZCVVpaX0lOQ0xVREVfRElSUyAt
IGNvbnRhaW5nIHRoZSBIYXJmQnV6eiBoZWFkZXJzCisjIEhBUkZCVVpaX0xJQlJBUklFUyAtIGNv
bnRhaW5nIHRoZSBIYXJmQnV6eiBsaWJyYXJ5CiAKIElOQ0xVREUoRmluZFBrZ0NvbmZpZykKIAot
UEtHX0NIRUNLX01PRFVMRVMgKGhhcmZidXp6IFJFUVVJUkVEIGhhcmZidXp6Pj0wLjkuMCkKLQog
UEtHX0NIRUNLX01PRFVMRVMoUENfSEFSRkJVWlogaGFyZmJ1eno+PTAuOS4wKQogCiBGSU5EX1BB
VEgoSEFSRkJVWlpfSU5DTFVERV9ESVJTIE5BTUVTIGhiLmgKZGlmZiAtLWdpdCBhL0NoYW5nZUxv
ZyBiL0NoYW5nZUxvZwppbmRleCAyZTg0MjM2ZmI4ZTBkY2E4YmYxMTQwOWRiODBlYzdjY2JhNmFl
NjBhLi44NDIyN2NmNWY1MTExNjBmYTRiOTdiYzI1MmE3ZmMyOWJmNWUzYjg0IDEwMDY0NAotLS0g
YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDgtMDIg
IERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGludGVsLmNvbT4KKworICAg
ICAgICBbY21ha2VdIENsZWFudXAgRmluZEhhcmZCdXp6LmNtYWtlCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk4NAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFudXAgd2hpY2ggZGlkbid0IG1ha2Ug
aXQgaW50byBteSBwcmV2aW91cyBwdGNoLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRI
YXJmQnV6ei5jbWFrZTogUmVtb3ZlIGR1cGxpY2F0ZSBsaW5lLCBhZGQgYSBiaXQgb2YgZG9jdW1l
bnRhdGlvbi4KKwogMjAxMi0wOC0wMSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAK
ICAgICAgICAgQWRkIG5ldyBDU1MgcHJvcGVydHkgIi13ZWJraXQtd2lkZ2V0LXJlZ2lvbiIgdG8g
ZXhwb3NlIGRhc2hib2FyZCByZWdpb24gc3VwcG9ydCBmb3Igb3RoZXIgcG9ydAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>