92981 2012-08-02 05:31:09 -0700 Web Inspector: remove extraObjectSize parameter from MemoryClassInfo constructor 2012-08-02 05:52:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 87262 0 yurys yurys alph apavlov bweinstein cmarcelo joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 685248 0 yurys 2012-08-02 05:31:09 -0700 The extra size is added by some object referenced from the one being instrumented. We should report such referenced object along with its address instead of just reporting its size in a special parameter. 685251 1 156048 yurys 2012-08-02 05:35:01 -0700 Created attachment 156048 Patch 685267 2 156048 loislo 2012-08-02 05:48:28 -0700 Comment on attachment 156048 Patch lgtm 685271 3 yurys 2012-08-02 05:52:50 -0700 Committed r124444: <http://trac.webkit.org/changeset/124444> 156048 2012-08-02 05:35:01 -0700 2012-08-02 05:50:56 -0700 Patch bug-92981-20120802163441.patch text/plain 5750 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NmYjFlMmY5OWQzYWJi MDAyYWUyZDk0ZGRmZmJlYWQ0NjYyY2JlNy4uMWEwNmMwNWEzZWMwYTFiMmJiMmUzYzcxODgyZmQ2 MDkyZjA5ZGI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEyLTA4LTAyICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlbW92ZSBleHRyYU9iamVjdFNpemUgcGFyYW1ldGVyIGZyb20gTWVtb3J5Q2xhc3NJbmZv IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05Mjk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlZmFjdG9yZWQgTWVtb3J5SW5zdHJ1bWVudGF0aW9uIHRvIGdldCByaWQgb2YgZXh0cmFT aXplIHBhcmFtZXRlciBmcm9tCisgICAgICAgIE1lbW9yeU9iamVjdEluZm8gY29uc3RydWN0b3Ig YW5kIE1lbW9yeU9iamVjdEluZm86OnJlcG9ydE9iamVjdEluZm8uIFRoZQorICAgICAgICBleHRy YSBzaXplIHNob3VsZCBhbHdheXMgYmUgcmVwb3J0ZWQgYXMgYW4gb2JqZWN0IHRoYXQgb2NjdXBp ZXMgdGhlc2UgZXh0cmEKKyAgICAgICAgYnl0ZXMuCisKKyAgICAgICAgKiBkb20vRWxlbWVudEF0 dHJpYnV0ZURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudEF0dHJpYnV0ZURhdGE6 OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGRvbS9F bGVtZW50QXR0cmlidXRlRGF0YS5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChFbGVt ZW50QXR0cmlidXRlRGF0YSk6CisgICAgICAgICogZG9tL01lbW9yeUluc3RydW1lbnRhdGlvbi5o OgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5T2JqZWN0SW5mbzo6cmVwb3J0T2JqZWN0SW5mbyk6 CisgICAgICAgIChXZWJDb3JlOjpNZW1vcnlDbGFzc0luZm86Ok1lbW9yeUNsYXNzSW5mbyk6CisK KzIwMTItMDgtMDIgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKICAg ICAgICAgV2ViIEluc3BlY3RvcjogcmVuYW1lIHJlcG9ydE1lbW9yeVVzYWdlIHRvIHJlcG9ydERl c2NlbmRhbnRNZW1vcnlVc2FnZSBpbiBTdHlsZVJ1bGVCYXNlIGRlc2NlbmRhbnRzCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NgogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudEF0dHJpYnV0ZURhdGEuY3BwIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnRBdHRyaWJ1dGVEYXRhLmNwcAppbmRleCA2ZmI1M2Q1ZDMwYjIz OTk0ZjY4OWIzZDliYzEwYjJmZTcwOWM3NTNjLi5jNTg0OTY1NTliZmM5ZjNhNjRjNWExZDI4MWJh OGJmYzA0ZGNiYjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudEF0dHJp YnV0ZURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50QXR0cmlidXRlRGF0 YS5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgIkF0dHIuaCIKICNpbmNsdWRlICJD U1NTdHlsZVNoZWV0LmgiCisjaW5jbHVkZSAiTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgiCiAjaW5j bHVkZSAiU3R5bGVkRWxlbWVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0yODMsNiAr Mjg0LDE5IEBAIHZvaWQgRWxlbWVudEF0dHJpYnV0ZURhdGE6OmRldGFjaEF0dHJPYmplY3RzRnJv bUVsZW1lbnQoRWxlbWVudCogZWxlbWVudCkgY29uc3QKICAgICBBU1NFUlQoIWVsZW1lbnQtPmhh c0F0dHJMaXN0KCkpOwogfQogCit2b2lkIEVsZW1lbnRBdHRyaWJ1dGVEYXRhOjpyZXBvcnRNZW1v cnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAoreworICAg IE1lbW9yeUNsYXNzSW5mbzxFbGVtZW50QXR0cmlidXRlRGF0YT4gaW5mbyhtZW1vcnlPYmplY3RJ bmZvLCB0aGlzLCBNZW1vcnlJbnN0cnVtZW50YXRpb246OkRPTSk7CisgICAgaW5mby5hZGRJbnN0 cnVtZW50ZWRNZW1iZXIobV9pbmxpbmVTdHlsZURlY2wpOworICAgIGluZm8uYWRkSW5zdHJ1bWVu dGVkTWVtYmVyKG1fYXR0cmlidXRlU3R5bGUpOworICAgIGluZm8uYWRkTWVtYmVyKG1fY2xhc3NO YW1lcyk7CisgICAgaW5mby5hZGRTdHJpbmcobV9pZEZvclN0eWxlUmVzb2x1dGlvbik7CisgICAg aWYgKG1faXNNdXRhYmxlKQorICAgICAgICBpbmZvLmFkZFZlY3RvclB0cihtX211dGFibGVBdHRy aWJ1dGVWZWN0b3IpOworICAgIGVsc2UKKyAgICAgICAgaW5mby5hZGRSYXdCdWZmZXIobV9hdHRy aWJ1dGVzLCBtX2FycmF5U2l6ZSAqIHNpemVvZihBdHRyaWJ1dGUpKTsKK30KKwogc2l6ZV90IEVs ZW1lbnRBdHRyaWJ1dGVEYXRhOjpnZXRBdHRyaWJ1dGVJdGVtSW5kZXhTbG93Q2FzZShjb25zdCBB dG9taWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSkgY29uc3QK IHsKICAgICAvLyBDb250aW51ZSB0byBjaGVja2luZyBjYXNlLWluc2Vuc2l0aXZlbHkgYW5kL29y IGZ1bGwgbmFtZXNwYWNlZCBuYW1lcyBpZiBuZWNlc3Nhcnk6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudEF0dHJpYnV0ZURhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50QXR0cmlidXRlRGF0YS5oCmluZGV4IDFjMmIyZmVhMzM5YzZhOTRhOTk2MjIwZjMyYWNk ZTI2MjBhMTk2ZWIuLjBlMTEzMWE5Y2NjMTFmOGU4ODcwNDFjYmViZTE5ZjQ3ZGY0MjQ0YTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50QXR0cmlidXRlRGF0YS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50QXR0cmlidXRlRGF0YS5oCkBAIC0yNyw3ICsyNyw2 IEBACiAjZGVmaW5lIEVsZW1lbnRBdHRyaWJ1dGVEYXRhX2gKIAogI2luY2x1ZGUgIkF0dHJpYnV0 ZS5oIgotI2luY2x1ZGUgIk1lbW9yeUluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIlNwYWNl U3BsaXRTdHJpbmcuaCIKICNpbmNsdWRlICJTdHlsZVByb3BlcnR5U2V0LmgiCiAjaW5jbHVkZSA8 d3RmL05vdEZvdW5kLmg+CkBAIC0zNiw2ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog Y2xhc3MgQXR0cjsKIGNsYXNzIEVsZW1lbnQ7CitjbGFzcyBNZW1vcnlPYmplY3RJbmZvOwogCiBl bnVtIEVJblVwZGF0ZVN0eWxlQXR0cmlidXRlIHsgTm90SW5VcGRhdGVTdHlsZUF0dHJpYnV0ZSwg SW5VcGRhdGVTdHlsZUF0dHJpYnV0ZSB9OwogCkBAIC05NCwxNiArOTQsNyBAQCBwdWJsaWM6CiAg ICAgUGFzc1JlZlB0cjxBdHRyPiBlbnN1cmVBdHRyKEVsZW1lbnQqLCBjb25zdCBRdWFsaWZpZWRO YW1lJikgY29uc3Q7CiAgICAgdm9pZCBkZXRhY2hBdHRyT2JqZWN0c0Zyb21FbGVtZW50KEVsZW1l bnQqKSBjb25zdDsKIAotICAgIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5m byogbWVtb3J5T2JqZWN0SW5mbykgY29uc3QKLSAgICB7Ci0gICAgICAgIE1lbW9yeUNsYXNzSW5m bzxFbGVtZW50QXR0cmlidXRlRGF0YT4gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBNZW1v cnlJbnN0cnVtZW50YXRpb246OkRPTSwgbV9hcnJheVNpemUgKiBzaXplb2YoQXR0cmlidXRlKSk7 Ci0gICAgICAgIGluZm8uYWRkSW5zdHJ1bWVudGVkTWVtYmVyKG1faW5saW5lU3R5bGVEZWNsLmdl dCgpKTsKLSAgICAgICAgaW5mby5hZGRJbnN0cnVtZW50ZWRNZW1iZXIobV9hdHRyaWJ1dGVTdHls ZS5nZXQoKSk7Ci0gICAgICAgIGluZm8uYWRkTWVtYmVyKG1fY2xhc3NOYW1lcyk7Ci0gICAgICAg IGluZm8uYWRkU3RyaW5nKG1faWRGb3JTdHlsZVJlc29sdXRpb24pOwotICAgICAgICBpZiAobV9p c011dGFibGUpCi0gICAgICAgICAgICBpbmZvLmFkZFZlY3RvcigqbV9tdXRhYmxlQXR0cmlidXRl VmVjdG9yKTsKLSAgICB9CisgICAgdm9pZCByZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJ bmZvKikgY29uc3Q7CiAKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIEVsZW1lbnQ7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmggYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgKaW5kZXggMGNkNzhkNTFiYzY0 MzNkOTVlNDA1NTJjNjQ5NmQ5M2JiOGY1YWRjMi4uNWJjNTA3ZDgxZmU1YzE3YTc0MzA2MzIwOWVl OGY5MzlkY2U0ZWVjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL01lbW9yeUluc3Ry dW1lbnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9NZW1vcnlJbnN0cnVtZW50YXRp b24uaApAQCAtMTQ1LDEyICsxNDUsMTIgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICB0ZW1wbGF0 ZSA8dHlwZW5hbWUgVD4gZnJpZW5kIGNsYXNzIE1lbW9yeUNsYXNzSW5mbzsKIAotICAgIHRlbXBs YXRlIDx0eXBlbmFtZSBUPiB2b2lkIHJlcG9ydE9iamVjdEluZm8oY29uc3QgVCosIE1lbW9yeUlu c3RydW1lbnRhdGlvbjo6T2JqZWN0VHlwZSBvYmplY3RUeXBlLCBzaXplX3QgZXh0cmFPYmplY3RT aXplKQorICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBUPiB2b2lkIHJlcG9ydE9iamVjdEluZm8oY29u c3QgVCosIE1lbW9yeUluc3RydW1lbnRhdGlvbjo6T2JqZWN0VHlwZSBvYmplY3RUeXBlKQogICAg IHsKICAgICAgICAgaWYgKG1fb2JqZWN0VHlwZSAhPSBNZW1vcnlJbnN0cnVtZW50YXRpb246Ok90 aGVyKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBtX29iamVjdFR5cGUgPSBvYmplY3RU eXBlOwotICAgICAgICBtX29iamVjdFNpemUgPSBzaXplb2YoVCkgKyBleHRyYU9iamVjdFNpemU7 CisgICAgICAgIG1fb2JqZWN0U2l6ZSA9IHNpemVvZihUKTsKICAgICB9CiAKICAgICBNZW1vcnlJ bnN0cnVtZW50YXRpb24qIG1fbWVtb3J5SW5zdHJ1bWVudGF0aW9uOwpAQCAtMTYxLDExICsxNjEs MTEgQEAgcHJpdmF0ZToKIHRlbXBsYXRlIDx0eXBlbmFtZSBUPgogY2xhc3MgTWVtb3J5Q2xhc3NJ bmZvIHsKIHB1YmxpYzoKLSAgICBNZW1vcnlDbGFzc0luZm8oTWVtb3J5T2JqZWN0SW5mbyogbWVt b3J5T2JqZWN0SW5mbywgY29uc3QgVCogcHRyLCBNZW1vcnlJbnN0cnVtZW50YXRpb246Ok9iamVj dFR5cGUgb2JqZWN0VHlwZSwgc2l6ZV90IGV4dHJhT2JqZWN0U2l6ZSA9IDApCisgICAgTWVtb3J5 Q2xhc3NJbmZvKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8sIGNvbnN0IFQqIHB0 ciwgTWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpPYmplY3RUeXBlIG9iamVjdFR5cGUpCiAgICAgICAg IDogbV9tZW1vcnlPYmplY3RJbmZvKG1lbW9yeU9iamVjdEluZm8pCiAgICAgICAgICwgbV9tZW1v cnlJbnN0cnVtZW50YXRpb24obWVtb3J5T2JqZWN0SW5mby0+bWVtb3J5SW5zdHJ1bWVudGF0aW9u KCkpCiAgICAgewotICAgICAgICBtX21lbW9yeU9iamVjdEluZm8tPnJlcG9ydE9iamVjdEluZm8o cHRyLCBvYmplY3RUeXBlLCBleHRyYU9iamVjdFNpemUpOworICAgICAgICBtX21lbW9yeU9iamVj dEluZm8tPnJlcG9ydE9iamVjdEluZm8ocHRyLCBvYmplY3RUeXBlKTsKICAgICAgICAgbV9vYmpl Y3RUeXBlID0gbWVtb3J5T2JqZWN0SW5mby0+b2JqZWN0VHlwZSgpOwogICAgIH0KIAo=