92978 2012-08-02 05:08:16 -0700 [Qt] MSVC specific buildfix for DRT. 2012-08-02 06:13:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zarvai webkit-unassigned hausmann kbalazs ossy webkit.review.bot oldest_to_newest 685233 0 zarvai 2012-08-02 05:08:16 -0700 Include for DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build. It's need to be added to DumpRenderTree.pro file. 685234 1 156042 zarvai 2012-08-02 05:09:18 -0700 Created attachment 156042 drt-fix-msvc 685237 2 156042 ossy 2012-08-02 05:15:59 -0700 Comment on attachment 156042 drt-fix-msvc View in context: https://bugs.webkit.org/attachment.cgi?id=156042&action=review > Tools/ChangeLog:4 > + Need the bug URL (OOPS!). ^^^^^^ 685239 3 156044 zarvai 2012-08-02 05:22:11 -0700 Created attachment 156044 drt-fix-msvc Adding missing bug url to patch. Sorry. 685252 4 kbalazs 2012-08-02 05:35:39 -0700 It's strange that on Linux the directory where the pro file exists added by default but on Windows it doesn't. Isn't it a qmake bug? 685284 5 156044 webkit.review.bot 2012-08-02 06:13:48 -0700 Comment on attachment 156044 drt-fix-msvc Clearing flags on attachment: 156044 Committed r124447: <http://trac.webkit.org/changeset/124447> 685285 6 webkit.review.bot 2012-08-02 06:13:52 -0700 All reviewed patches have been landed. Closing bug. 156042 2012-08-02 05:09:18 -0700 2012-08-02 05:22:11 -0700 drt-fix-msvc drt-fix.patch text/plain 1062 zarvai ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZDUw NWUwLi4xOGFkNDQzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDgtMDIgIFpvbHRhbiBBcnZhaSAgPHphcnZh aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBNU1ZDIHNwZWNpZmljIGJ1aWxkZml4 IGZvciBEUlQuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdW1wUmVuZGVyVHJlZS9xdCBz dWJkaXJlY3RvcnkgaXMgbWlzc2luZyBmcm9tIGdlbmVyYXRlZCBtYWtlZmlsZSB1bmRlciBNU1ZD IGJ1aWxkLCBuZWVkIHRvIGJlIGFkZGVkIHRvIHRoZSBwcm8gZmlsZS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLnBybzoKKwogMjAxMi0wOC0wMSAgTWFydGlu IFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWRkIHRoZSBqaGJ1 aWxkIHNvdXJjZSBkaXJlY3RvcnkgdG8gdGhlIF9fYnVpbHRpbl9fIG9iamVjdApkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUucHJvIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUucHJvCmluZGV4IGY0N2ZiNDMuLjcwMzRlNTcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLnBybwor KysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8KQEAgLTEzLDYg KzEzLDcgQEAgV0VCS0lUICs9IHd0ZiB3ZWJjb3JlCiAhdjg6IFdFQktJVCArPSBqYXZhc2NyaXB0 Y29yZQogCiBJTkNMVURFUEFUSCArPSBcCisgICAgJCRQV0QvIFwKICAgICAkJFBXRC8uLiBcCiAg ICAgJCR7Uk9PVF9XRUJLSVRfRElSfS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0IFwK ICAgICAkJHtST09UX1dFQktJVF9ESVJ9L1NvdXJjZS9XVEYK 156044 2012-08-02 05:22:11 -0700 2012-08-02 06:13:48 -0700 drt-fix-msvc drt-fix.patch text/plain 1082 zarvai ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZDUw NWUwLi4xOGFkNDQzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDgtMDIgIFpvbHRhbiBBcnZhaSAgPHphcnZh aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBNU1ZDIHNwZWNpZmljIGJ1aWxkZml4 IGZvciBEUlQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05Mjk3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IER1bXBSZW5kZXJUcmVlL3F0IHN1YmRpcmVjdG9yeSBpcyBtaXNzaW5nIGZyb20gZ2VuZXJhdGVk IG1ha2VmaWxlIHVuZGVyIE1TVkMgYnVpbGQsIG5lZWQgdG8gYmUgYWRkZWQgdG8gdGhlIHBybyBm aWxlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUucHJvOgor CiAyMDEyLTA4LTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAog ICAgICAgICBBZGQgdGhlIGpoYnVpbGQgc291cmNlIGRpcmVjdG9yeSB0byB0aGUgX19idWlsdGlu X18gb2JqZWN0CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZS5wcm8gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8KaW5k ZXggZjQ3ZmI0My4uNzAzNGU1NyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv RHVtcFJlbmRlclRyZWUucHJvCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5k ZXJUcmVlLnBybwpAQCAtMTMsNiArMTMsNyBAQCBXRUJLSVQgKz0gd3RmIHdlYmNvcmUKICF2ODog V0VCS0lUICs9IGphdmFzY3JpcHRjb3JlCiAKIElOQ0xVREVQQVRIICs9IFwKKyAgICAkJFBXRC8g XAogICAgICQkUFdELy4uIFwKICAgICAkJHtST09UX1dFQktJVF9ESVJ9L1NvdXJjZS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQgXAogICAgICQke1JPT1RfV0VCS0lUX0RJUn0vU291cmNlL1dURgo=