92971 2012-08-02 03:55:49 -0700 Speech JavaScript API: Fire speech start event at the same time as sound start event 2012-08-02 10:14:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hans hans abarth dglazkov fishd jamesr satish tkent+wkapi webkit.review.bot oldest_to_newest 685199 0 hans 2012-08-02 03:55:49 -0700 Speech JavaScript API: Fire speech start event at the same time as sound start event 685201 1 156033 hans 2012-08-02 03:59:28 -0700 Created attachment 156033 Patch 685202 2 webkit.review.bot 2012-08-02 04:00:23 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 685203 3 hans 2012-08-02 04:00:48 -0700 The relevant spec text is here: http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-events This patch was moved from Chromium: https://chromiumcodereview.appspot.com/10825133/ 685406 4 156033 abarth 2012-08-02 08:11:26 -0700 Comment on attachment 156033 Patch Ok. 685511 5 hans 2012-08-02 09:52:45 -0700 darin/jamesr: are you OK with this as well? Seeing as you commented on the original patch on the Chromium side. 685524 6 fishd 2012-08-02 09:58:54 -0700 Yes, LGTM 685535 7 156033 webkit.review.bot 2012-08-02 10:14:19 -0700 Comment on attachment 156033 Patch Clearing flags on attachment: 156033 Committed r124474: <http://trac.webkit.org/changeset/124474> 685536 8 webkit.review.bot 2012-08-02 10:14:24 -0700 All reviewed patches have been landed. Closing bug. 156033 2012-08-02 03:59:28 -0700 2012-08-02 10:14:19 -0700 Patch bug-92971-20120802115908.patch text/plain 6968 hans U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNmODUwNTRiOWI0YzViMmIyMDNiZTQxMTUwMjNhYTM3ZTdmZjJkYTYuLjlkZGRmNzA0M2JmNWRl NGEzYjNlZTFiZjVhNTM3MDUxMjVlYmFhZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDgtMDIgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVt Lm9yZz4KKworICAgICAgICBTcGVlY2ggSmF2YVNjcmlwdCBBUEk6IEZpcmUgc3BlZWNoIHN0YXJ0 IGV2ZW50IGF0IHRoZSBzYW1lIHRpbWUgYXMgc291bmQgc3RhcnQgZXZlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyOTcxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0ncyBzcGVlY2ggcmVj b2duaXplciBkb2Vzbid0IGRpZmZlcmVudGlhdGUgYmV0d2VlbiAic291bmQKKyAgICAgICAgc3Rh cnRlZCIgYW5kICJzcGVlY2ggc3RhcnRlZCIuIEp1c3QgZmlyZSB0aG9zZSBldmVudHMgYXQgdGhl IHNhbWUKKyAgICAgICAgdGltZSwgYW5kIGRvbid0IHByb3ZpZGUgZnVuY3Rpb25zIGZvciB0aGVt IGluCisgICAgICAgIFdlYlNwZWVjaFJlY29nbml6ZXJDbGllbnQuCisKKyAgICAgICAgKiBwdWJs aWMvV2ViU3BlZWNoUmVjb2duaXplckNsaWVudC5oOgorICAgICAgICAqIHNyYy9TcGVlY2hSZWNv Z25pdGlvbkNsaWVudFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6U3BlZWNoUmVjb2duaXRp b25DbGllbnRQcm94eTo6ZGlkU3RhcnRTb3VuZCk6CisgICAgICAgIChXZWJLaXQ6OlNwZWVjaFJl Y29nbml0aW9uQ2xpZW50UHJveHk6OmRpZEVuZFNvdW5kKToKKyAgICAgICAgKiBzcmMvU3BlZWNo UmVjb2duaXRpb25DbGllbnRQcm94eS5oOgorICAgICAgICAoU3BlZWNoUmVjb2duaXRpb25DbGll bnRQcm94eSk6CisKIDIwMTItMDgtMDEgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRlc3QgbmF0aXZlIG1lbW9yeSBpbnN0 cnVtZW50YXRpb24gY29kZSB3aXRoIGhlbHAgb2YgdW5pdHRlc3RzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hSZWNvZ25pemVyQ2xpZW50LmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hSZWNvZ25pemVyQ2xpZW50LmgK aW5kZXggNjA4YmZiNDgxNWU5OGQwZjVjNjdlZTc3NDc0ZDJhMzAxZmNiZTg4Ni4uM2ZlMTI0NGE3 ZWVkMGVhM2VhMDFkNjI4OTBmMTY1Y2Y2YjE4YWIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoUmVjb2duaXplckNsaWVudC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWVjaFJlY29nbml6ZXJDbGllbnQuaApAQCAt NTksMTMgKzU5LDYgQEAgcHVibGljOgogICAgIC8vIFRoaXMgaXMgZXhwZWN0ZWQgdG8gYmUgY2Fs bGVkIGFmdGVyIGRpZFN0YXJ0QXVkaW8uCiAgICAgdmlydHVhbCB2b2lkIGRpZFN0YXJ0U291bmQo Y29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5kbGUmKSA9IDA7CiAKLSAgICAvLyBUbyBiZSBj YWxsZWQgd2hlbiBzcGVlY2ggaGFzIGJlZW4gZGV0ZWN0ZWQuCi0gICAgLy8gVGhpcyBpcyBleHBl Y3RlZCB0byBiZSBjYWxsZWQgYWZ0ZXIgZGlkU3RhcnRTb3VuZC4KLSAgICB2aXJ0dWFsIHZvaWQg ZGlkU3RhcnRTcGVlY2goY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5kbGUmKSA9IDA7Ci0K LSAgICAvLyBUbyBiZSBjYWxsZWQgd2hlbiBzcGVlY2ggaXMgbm8gbG9uZ2VyIGRldGVjdGVkLgot ICAgIHZpcnR1YWwgdm9pZCBkaWRFbmRTcGVlY2goY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25I YW5kbGUmKSA9IDA7Ci0KICAgICAvLyBUbyBiZSBjYWxsZWQgd2hlbiBzb3VuZCBpcyBubyBsb25n ZXIgZGV0ZWN0ZWQuCiAgICAgLy8gVGhpcyBpcyBleHBlY3RlZCB0byBiZSBjYWxsZWQgYWZ0ZXIg ZGlkRW5kU3BlZWNoLgogICAgIHZpcnR1YWwgdm9pZCBkaWRFbmRTb3VuZChjb25zdCBXZWJTcGVl Y2hSZWNvZ25pdGlvbkhhbmRsZSYpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1NwZWVjaFJlY29nbml0aW9uQ2xpZW50UHJveHkuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU3BlZWNoUmVjb2duaXRpb25DbGllbnRQcm94eS5jcHAKaW5kZXggMDg4 OGUzMDMzMjUxN2M1NmRjNjVmYWJkNmM4NDdkNmMzNjk3ZWY4Yi4uYWE5YjE4OWE3Yzc5MDQ5ZWJh YTY5ZTRkNjc5MjkzYmUzOTEzMjJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvU3BlZWNoUmVjb2duaXRpb25DbGllbnRQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU3BlZWNoUmVjb2duaXRpb25DbGllbnRQcm94eS5jcHAKQEAgLTg1LDIz ICs4NSwxMyBAQCB2b2lkIFNwZWVjaFJlY29nbml0aW9uQ2xpZW50UHJveHk6OmRpZFN0YXJ0U291 bmQoY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5kbAogewogICAgIFJlZlB0cjxTcGVlY2hS ZWNvZ25pdGlvbj4gcmVjb2duaXRpb24gPSBQYXNzUmVmUHRyPFNwZWVjaFJlY29nbml0aW9uPiho YW5kbGUpOwogICAgIHJlY29nbml0aW9uLT5kaWRTdGFydFNvdW5kKCk7Ci19Ci0KLXZvaWQgU3Bl ZWNoUmVjb2duaXRpb25DbGllbnRQcm94eTo6ZGlkU3RhcnRTcGVlY2goY29uc3QgV2ViU3BlZWNo UmVjb2duaXRpb25IYW5kbGUmIGhhbmRsZSkKLXsKLSAgICBSZWZQdHI8U3BlZWNoUmVjb2duaXRp b24+IHJlY29nbml0aW9uID0gUGFzc1JlZlB0cjxTcGVlY2hSZWNvZ25pdGlvbj4oaGFuZGxlKTsK ICAgICByZWNvZ25pdGlvbi0+ZGlkU3RhcnRTcGVlY2goKTsKIH0KIAotdm9pZCBTcGVlY2hSZWNv Z25pdGlvbkNsaWVudFByb3h5OjpkaWRFbmRTcGVlY2goY29uc3QgV2ViU3BlZWNoUmVjb2duaXRp b25IYW5kbGUmIGhhbmRsZSkKLXsKLSAgICBSZWZQdHI8U3BlZWNoUmVjb2duaXRpb24+IHJlY29n bml0aW9uID0gUGFzc1JlZlB0cjxTcGVlY2hSZWNvZ25pdGlvbj4oaGFuZGxlKTsKLSAgICByZWNv Z25pdGlvbi0+ZGlkRW5kU3BlZWNoKCk7Ci19Ci0KIHZvaWQgU3BlZWNoUmVjb2duaXRpb25DbGll bnRQcm94eTo6ZGlkRW5kU291bmQoY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5kbGUmIGhh bmRsZSkKIHsKICAgICBSZWZQdHI8U3BlZWNoUmVjb2duaXRpb24+IHJlY29nbml0aW9uID0gUGFz c1JlZlB0cjxTcGVlY2hSZWNvZ25pdGlvbj4oaGFuZGxlKTsKKyAgICByZWNvZ25pdGlvbi0+ZGlk RW5kU3BlZWNoKCk7CiAgICAgcmVjb2duaXRpb24tPmRpZEVuZFNvdW5kKCk7CiB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NwZWVjaFJlY29nbml0aW9uQ2xpZW50 UHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NwZWVjaFJlY29nbml0aW9uQ2xp ZW50UHJveHkuaAppbmRleCA4MDYzZTcxZWRiNmUxMzllYjZmNjc1NzdiOTE1MDNlY2ZmNmI4MDFk Li43NTBjYmFlNWNiMDk4NGI1ZWU5NWM0MzM4MTI0MDBlNGYwYjYwYzYzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9TcGVlY2hSZWNvZ25pdGlvbkNsaWVudFByb3h5LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU3BlZWNoUmVjb2duaXRpb25DbGllbnRQ cm94eS5oCkBAIC01Myw4ICs1Myw2IEBAIHB1YmxpYzoKICAgICAvLyBXZWJTcGVlY2hSZWNvZ25p emVyQ2xpZW50OgogICAgIHZpcnR1YWwgdm9pZCBkaWRTdGFydEF1ZGlvKGNvbnN0IFdlYlNwZWVj aFJlY29nbml0aW9uSGFuZGxlJikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGRpZFN0YXJ0 U291bmQoY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5kbGUmKSBPVkVSUklERTsKLSAgICB2 aXJ0dWFsIHZvaWQgZGlkU3RhcnRTcGVlY2goY29uc3QgV2ViU3BlZWNoUmVjb2duaXRpb25IYW5k bGUmKSBPVkVSUklERTsKLSAgICB2aXJ0dWFsIHZvaWQgZGlkRW5kU3BlZWNoKGNvbnN0IFdlYlNw ZWVjaFJlY29nbml0aW9uSGFuZGxlJikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGRpZEVu ZFNvdW5kKGNvbnN0IFdlYlNwZWVjaFJlY29nbml0aW9uSGFuZGxlJikgT1ZFUlJJREU7CiAgICAg dmlydHVhbCB2b2lkIGRpZEVuZEF1ZGlvKGNvbnN0IFdlYlNwZWVjaFJlY29nbml0aW9uSGFuZGxl JikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVSZXN1bHQoY29uc3QgV2Vi U3BlZWNoUmVjb2duaXRpb25IYW5kbGUmLCBjb25zdCBXZWJTcGVlY2hSZWNvZ25pdGlvblJlc3Vs dCYsIHVuc2lnbmVkIGxvbmcgcmVzdWx0SW5kZXgsIGNvbnN0IFdlYlZlY3RvcjxXZWJTcGVlY2hS ZWNvZ25pdGlvblJlc3VsdD4mIHJlc3VsdEhpc3RvcnkpIE9WRVJSSURFOwpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDlhNGVhOTEyZWYxODQ4Mjky OGNhYTRiMzUyMmM3ZTQ5ZDk2NWMzNzEuLmYxZWI0NjY0NDQ0YzU0Yzg4N2UyMjM0NTczNjU5YjNk ZTFlNzZlNjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOC0wMiAgSGFucyBXZW5uYm9yZyAgPGhhbnNAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFNwZWVjaCBKYXZhU2NyaXB0IEFQSTogRmlyZSBzcGVlY2gg c3RhcnQgZXZlbnQgYXQgdGhlIHNhbWUgdGltZSBhcyBzb3VuZCBzdGFydCBldmVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI5NzEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIE1vY2tX ZWJTcGVlY2hSZWNvZ25pemVyIHRvIG5vdCBmaXJlICJzcGVlY2ggc3RhcnRlZCIgZXZlbnRzCisg ICAgICAgIHNlcGFyYXRlbHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9N b2NrV2ViU3BlZWNoUmVjb2duaXplci5jcHA6CisgICAgICAgIChNb2NrV2ViU3BlZWNoUmVjb2du aXplcjo6c3RhcnQpOgorCiAyMDEyLTA4LTAxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyMzg5Myk6IFJlZnRlc3QgbWlzbWF0Y2hl cyBhcmUgcnVuIHRocm91Z2ggSW1hZ2VEaWZmIHdpdGggMC4xIHRvbGVyYW5jZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYlNwZWVjaFJlY29nbml6ZXIu Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYlNwZWVjaFJlY29nbml6 ZXIuY3BwCmluZGV4IDhmMmVmNWQzNTllYjFiMTU1Yzg4MWUxNmY5OWRmOTJlZDgzYjcwZGYuLjUw MmFkZGVhOTI1NjJkNGM3MmEwMmRmZmNlOGU0ZjFhMTNhZTE3NTIgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJTcGVlY2hSZWNvZ25pemVyLmNwcAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViU3BlZWNoUmVjb2duaXplci5j cHAKQEAgLTExOCw3ICsxMTgsNiBAQCB2b2lkIE1vY2tXZWJTcGVlY2hSZWNvZ25pemVyOjpzdGFy dChjb25zdCBXZWJTcGVlY2hSZWNvZ25pdGlvbkhhbmRsZSYgaGFuZGxlLCBjbwogICAgIG1fdGFz a1F1ZXVlLmFwcGVuZChhZG9wdFB0cihuZXcgQ2xpZW50Q2FsbFRhc2sodGhpcywgJldlYlNwZWVj aFJlY29nbml6ZXJDbGllbnQ6OmRpZFN0YXJ0KSkpOwogICAgIG1fdGFza1F1ZXVlLmFwcGVuZChh ZG9wdFB0cihuZXcgQ2xpZW50Q2FsbFRhc2sodGhpcywgJldlYlNwZWVjaFJlY29nbml6ZXJDbGll bnQ6OmRpZFN0YXJ0QXVkaW8pKSk7CiAgICAgbV90YXNrUXVldWUuYXBwZW5kKGFkb3B0UHRyKG5l dyBDbGllbnRDYWxsVGFzayh0aGlzLCAmV2ViU3BlZWNoUmVjb2duaXplckNsaWVudDo6ZGlkU3Rh cnRTb3VuZCkpKTsKLSAgICBtX3Rhc2tRdWV1ZS5hcHBlbmQoYWRvcHRQdHIobmV3IENsaWVudENh bGxUYXNrKHRoaXMsICZXZWJTcGVlY2hSZWNvZ25pemVyQ2xpZW50OjpkaWRTdGFydFNwZWVjaCkp KTsKIAogICAgIGlmICghbV9tb2NrVHJhbnNjcmlwdHMuaXNFbXB0eSgpKSB7CiAgICAgICAgIEFT U0VSVChtX21vY2tUcmFuc2NyaXB0cy5zaXplKCkgPT0gbV9tb2NrQ29uZmlkZW5jZXMuc2l6ZSgp KTsKQEAgLTEzMSw3ICsxMzAsNiBAQCB2b2lkIE1vY2tXZWJTcGVlY2hSZWNvZ25pemVyOjpzdGFy dChjb25zdCBXZWJTcGVlY2hSZWNvZ25pdGlvbkhhbmRsZSYgaGFuZGxlLCBjbwogICAgIH0gZWxz ZQogICAgICAgICBtX3Rhc2tRdWV1ZS5hcHBlbmQoYWRvcHRQdHIobmV3IE5vTWF0Y2hUYXNrKHRo aXMpKSk7CiAKLSAgICBtX3Rhc2tRdWV1ZS5hcHBlbmQoYWRvcHRQdHIobmV3IENsaWVudENhbGxU YXNrKHRoaXMsICZXZWJTcGVlY2hSZWNvZ25pemVyQ2xpZW50OjpkaWRFbmRTcGVlY2gpKSk7CiAg ICAgbV90YXNrUXVldWUuYXBwZW5kKGFkb3B0UHRyKG5ldyBDbGllbnRDYWxsVGFzayh0aGlzLCAm V2ViU3BlZWNoUmVjb2duaXplckNsaWVudDo6ZGlkRW5kU291bmQpKSk7CiAgICAgbV90YXNrUXVl dWUuYXBwZW5kKGFkb3B0UHRyKG5ldyBDbGllbnRDYWxsVGFzayh0aGlzLCAmV2ViU3BlZWNoUmVj b2duaXplckNsaWVudDo6ZGlkRW5kQXVkaW8pKSk7CiAgICAgbV90YXNrUXVldWUuYXBwZW5kKGFk b3B0UHRyKG5ldyBDbGllbnRDYWxsVGFzayh0aGlzLCAmV2ViU3BlZWNoUmVjb2duaXplckNsaWVu dDo6ZGlkRW5kKSkpOwo=