92964 2012-08-02 02:36:16 -0700 [EFL] Change return value of battey level 2012-08-02 06:53:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.w3.org/TR/battery-status/#idl-def-BatteryManager P2 Normal --- 92839 0 kihong.kwon webkit-unassigned gyuyoung.kim hausmann lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 685146 0 kihong.kwon 2012-08-02 02:36:16 -0700 Battery level is defined like below, in the Battery Status API spec. ------------------------------------------------------------ level of type double, readonly Represents the current battery level scaled from 0 to 1.0. No exceptions. ------------------------------------------------------------ But EFL battery returns 0 ~ 100 level. Therefore we need to fix this to 0 ~ 1.0. 685180 1 156027 kihong.kwon 2012-08-02 03:34:41 -0700 Created attachment 156027 Patch 685189 2 156027 ryuan.choi 2012-08-02 03:50:00 -0700 Comment on attachment 156027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156027&action=review > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:165 > levelChanged = true; > level = property->val.d; > > - WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level); > + WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level / 100); If then, should we compare with clientBatteryStatus->level() * 100 and property->val.d ? IMO, you'd better to assign property->val.d / 100 to `level` to reduce confusion. 685192 3 kihong.kwon 2012-08-02 03:52:44 -0700 (In reply to comment #2) > (From update of attachment 156027 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156027&action=review > > > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:165 > > levelChanged = true; > > level = property->val.d; > > > > - WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level); > > + WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level / 100); > > If then, should we compare with clientBatteryStatus->level() * 100 and property->val.d ? > > IMO, you'd better to assign property->val.d / 100 to `level` to reduce confusion. You are right. It was my mistake. 685197 4 156032 kihong.kwon 2012-08-02 03:54:48 -0700 Created attachment 156032 Patch 685205 5 156032 ryuan.choi 2012-08-02 04:09:19 -0700 Comment on attachment 156032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156032&action=review > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:163 > - if (!clientBatteryStatus || clientBatteryStatus->level() != property->val.d) > + if (!clientBatteryStatus || clientBatteryStatus->level() != property->val.d / 100) > levelChanged = true; > - level = property->val.d; > + level = property->val.d / 100; I am not sure why you use level, local variable. IMO, you can remove level variable or assign it before 161 line with declaration. 685211 6 156037 kihong.kwon 2012-08-02 04:13:53 -0700 Created attachment 156037 Patch 685259 7 156051 kihong.kwon 2012-08-02 05:39:44 -0700 Created attachment 156051 Patch 685263 8 156051 ryuan.choi 2012-08-02 05:44:49 -0700 Comment on attachment 156051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156051&action=review > Source/WebCore/ChangeLog:11 > + No new tests, no behavior changed. I think that this comment is wrong. This patch changes behavior but we can not make automated tests for this because we can not emulate E_Ukit. > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:155 > + double level = property->val.d / 100; I think that property of "Percentage" is not assigned yet. 685268 9 156053 kihong.kwon 2012-08-02 05:49:59 -0700 Created attachment 156053 Patch 685316 10 156053 webkit.review.bot 2012-08-02 06:46:00 -0700 Comment on attachment 156053 Patch Clearing flags on attachment: 156053 Committed r124450: <http://trac.webkit.org/changeset/124450> 685317 11 webkit.review.bot 2012-08-02 06:46:05 -0700 All reviewed patches have been landed. Closing bug. 156027 2012-08-02 03:34:41 -0700 2012-08-02 03:54:41 -0700 Patch bug-92964-20120802193422.patch text/plain 1776 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1MzY0OGZiM2Y2NzMw ZjBhMWM2NDNiMzgyZGViZGM3MjllNDFjMi4uMzM3MjQzZjAxYWY0MDQ4M2RjMmYwZDI4NGRiZTMz MzdmYWE0NTA4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIENoYW5n ZSByZXR1cm4gdmFsdWUgb2YgYmF0dGV5IGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSByZXR1cm4gdmFsdWUgb2YgbmF2aWdhdG9yLndl YmtpdEJhdHRlcnkubGV2ZWwgZnJvbSAwfjEwMCB0byAwfjEuMC4KKyAgICAgICAgQmF0dGVyeSBs ZXZlbCBoYXZlIHRvIHJldHVybnMgMH4xLjAgYnkgQmF0dGVyeSBTdGF0dXMgQVBJIHNwZWMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VkLgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC YXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQpOgorCiAyMDEyLTA4LTAyICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENTU1JlZ2lvbnM6IENy YXNoIHdoZW4gcmVhdHRhY2hpbmcgYSByZWdpb24gdG8gYSBuYW1lZCBmbG93LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAppbmRleCBj NWQwMzBhM2QxZDYyMWQ1ZGZhNWNlNWFkOTVlOTVmODUwYjEyN2FkLi45OWVkZmZhOWU5NWZhM2Ex ZjRlMjRhZTk5ZDY0MGJiMzNmZDMzZmY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcApAQCAtMTYyLDcgKzE2Miw3IEBAIHZvaWQg QmF0dGVyeVByb3ZpZGVyRWZsOjpzZXRCYXR0ZXJ5Q2xpZW50KHZvaWQqIGRhdGEsIHZvaWQqIHJl cGx5RGF0YSwgREJ1c0Vycm9yCiAgICAgICAgIGxldmVsQ2hhbmdlZCA9IHRydWU7CiAgICAgbGV2 ZWwgPSBwcm9wZXJ0eS0+dmFsLmQ7CiAKLSAgICBXVEY6OlJlZlB0cjxCYXR0ZXJ5U3RhdHVzPiBi YXR0ZXJ5U3RhdHVzID0gQmF0dGVyeVN0YXR1czo6Y3JlYXRlKGNoYXJnaW5nLCBjaGFyZ2luZ1Rp bWUsIGRpc2NoYXJnaW5nVGltZSwgbGV2ZWwpOworICAgIFdURjo6UmVmUHRyPEJhdHRlcnlTdGF0 dXM+IGJhdHRlcnlTdGF0dXMgPSBCYXR0ZXJ5U3RhdHVzOjpjcmVhdGUoY2hhcmdpbmcsIGNoYXJn aW5nVGltZSwgZGlzY2hhcmdpbmdUaW1lLCBsZXZlbCAvIDEwMCk7CiAgICAgaWYgKGNoYXJnaW5n Q2hhbmdlZCkKICAgICAgICAgY2xpZW50LT5zZXRCYXR0ZXJ5U3RhdHVzKGV2ZW50TmFtZXMoKS5j aGFyZ2luZ2NoYW5nZUV2ZW50LCBiYXR0ZXJ5U3RhdHVzKTsKICAgICBpZiAoY2hhcmdpbmdUaW1l Q2hhbmdlZCkK 156032 2012-08-02 03:54:48 -0700 2012-08-02 04:13:46 -0700 Patch bug-92964-20120802195428.patch text/plain 1889 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1MzY0OGZiM2Y2NzMw ZjBhMWM2NDNiMzgyZGViZGM3MjllNDFjMi4uMzM3MjQzZjAxYWY0MDQ4M2RjMmYwZDI4NGRiZTMz MzdmYWE0NTA4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIENoYW5n ZSByZXR1cm4gdmFsdWUgb2YgYmF0dGV5IGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSByZXR1cm4gdmFsdWUgb2YgbmF2aWdhdG9yLndl YmtpdEJhdHRlcnkubGV2ZWwgZnJvbSAwfjEwMCB0byAwfjEuMC4KKyAgICAgICAgQmF0dGVyeSBs ZXZlbCBoYXZlIHRvIHJldHVybnMgMH4xLjAgYnkgQmF0dGVyeSBTdGF0dXMgQVBJIHNwZWMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VkLgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC YXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQpOgorCiAyMDEyLTA4LTAyICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENTU1JlZ2lvbnM6IENy YXNoIHdoZW4gcmVhdHRhY2hpbmcgYSByZWdpb24gdG8gYSBuYW1lZCBmbG93LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAppbmRleCBj NWQwMzBhM2QxZDYyMWQ1ZGZhNWNlNWFkOTVlOTVmODUwYjEyN2FkLi4yYWYyNTBhYjNhOWUxNTk4 ZDY4YjcyMzA4NWM0ZjJmOGUxNGQ3ZWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcApAQCAtMTU4LDkgKzE1OCw5IEBAIHZvaWQg QmF0dGVyeVByb3ZpZGVyRWZsOjpzZXRCYXR0ZXJ5Q2xpZW50KHZvaWQqIGRhdGEsIHZvaWQqIHJl cGx5RGF0YSwgREJ1c0Vycm9yCiAgICAgcHJvcGVydHkgPSBzdGF0aWNfY2FzdDxFX1VraXRfUHJv cGVydHkqPihlaW5hX2hhc2hfZmluZChldWtpdFByb3BlcnR5TmFtZXMtPnByb3BlcnRpZXMsICJQ ZXJjZW50YWdlIikpOwogICAgIGlmICghcHJvcGVydHkpCiAgICAgICAgIHJldHVybjsKLSAgICBp ZiAoIWNsaWVudEJhdHRlcnlTdGF0dXMgfHwgY2xpZW50QmF0dGVyeVN0YXR1cy0+bGV2ZWwoKSAh PSBwcm9wZXJ0eS0+dmFsLmQpCisgICAgaWYgKCFjbGllbnRCYXR0ZXJ5U3RhdHVzIHx8IGNsaWVu dEJhdHRlcnlTdGF0dXMtPmxldmVsKCkgIT0gcHJvcGVydHktPnZhbC5kIC8gMTAwKQogICAgICAg ICBsZXZlbENoYW5nZWQgPSB0cnVlOwotICAgIGxldmVsID0gcHJvcGVydHktPnZhbC5kOworICAg IGxldmVsID0gcHJvcGVydHktPnZhbC5kIC8gMTAwOwogCiAgICAgV1RGOjpSZWZQdHI8QmF0dGVy eVN0YXR1cz4gYmF0dGVyeVN0YXR1cyA9IEJhdHRlcnlTdGF0dXM6OmNyZWF0ZShjaGFyZ2luZywg Y2hhcmdpbmdUaW1lLCBkaXNjaGFyZ2luZ1RpbWUsIGxldmVsKTsKICAgICBpZiAoY2hhcmdpbmdD aGFuZ2VkKQo= 156037 2012-08-02 04:13:53 -0700 2012-08-02 05:39:38 -0700 Patch bug-92964-20120802201333.patch text/plain 2214 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1MzY0OGZiM2Y2NzMw ZjBhMWM2NDNiMzgyZGViZGM3MjllNDFjMi4uMzM3MjQzZjAxYWY0MDQ4M2RjMmYwZDI4NGRiZTMz MzdmYWE0NTA4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIENoYW5n ZSByZXR1cm4gdmFsdWUgb2YgYmF0dGV5IGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSByZXR1cm4gdmFsdWUgb2YgbmF2aWdhdG9yLndl YmtpdEJhdHRlcnkubGV2ZWwgZnJvbSAwfjEwMCB0byAwfjEuMC4KKyAgICAgICAgQmF0dGVyeSBs ZXZlbCBoYXZlIHRvIHJldHVybnMgMH4xLjAgYnkgQmF0dGVyeSBTdGF0dXMgQVBJIHNwZWMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VkLgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC YXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQpOgorCiAyMDEyLTA4LTAyICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENTU1JlZ2lvbnM6IENy YXNoIHdoZW4gcmVhdHRhY2hpbmcgYSByZWdpb24gdG8gYSBuYW1lZCBmbG93LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAppbmRleCBj NWQwMzBhM2QxZDYyMWQ1ZGZhNWNlNWFkOTVlOTVmODUwYjEyN2FkLi40ZmZkZTIxYzdiMDE2ZWNl MTU1NzA2MjI2MDdmNWYxYTMwZTBkNGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcApAQCAtMTUyLDE3ICsxNTIsMTQgQEAgdm9p ZCBCYXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQodm9pZCogZGF0YSwgdm9pZCog cmVwbHlEYXRhLCBEQnVzRXJyb3IKICAgICAgICAgZGlzY2hhcmdpbmdUaW1lID0gcHJvcGVydHkt PnZhbC54OwogICAgIH0KIAotICAgIGRvdWJsZSBsZXZlbCA9IDA7CiAgICAgYm9vbCBsZXZlbENo YW5nZWQgPSBmYWxzZTsKLQogICAgIHByb3BlcnR5ID0gc3RhdGljX2Nhc3Q8RV9Va2l0X1Byb3Bl cnR5Kj4oZWluYV9oYXNoX2ZpbmQoZXVraXRQcm9wZXJ0eU5hbWVzLT5wcm9wZXJ0aWVzLCAiUGVy Y2VudGFnZSIpKTsKICAgICBpZiAoIXByb3BlcnR5KQogICAgICAgICByZXR1cm47Ci0gICAgaWYg KCFjbGllbnRCYXR0ZXJ5U3RhdHVzIHx8IGNsaWVudEJhdHRlcnlTdGF0dXMtPmxldmVsKCkgIT0g cHJvcGVydHktPnZhbC5kKQorICAgIGlmICghY2xpZW50QmF0dGVyeVN0YXR1cyB8fCBjbGllbnRC YXR0ZXJ5U3RhdHVzLT5sZXZlbCgpICE9IHByb3BlcnR5LT52YWwuZCAvIDEwMCkKICAgICAgICAg bGV2ZWxDaGFuZ2VkID0gdHJ1ZTsKLSAgICBsZXZlbCA9IHByb3BlcnR5LT52YWwuZDsKIAotICAg IFdURjo6UmVmUHRyPEJhdHRlcnlTdGF0dXM+IGJhdHRlcnlTdGF0dXMgPSBCYXR0ZXJ5U3RhdHVz OjpjcmVhdGUoY2hhcmdpbmcsIGNoYXJnaW5nVGltZSwgZGlzY2hhcmdpbmdUaW1lLCBsZXZlbCk7 CisgICAgV1RGOjpSZWZQdHI8QmF0dGVyeVN0YXR1cz4gYmF0dGVyeVN0YXR1cyA9IEJhdHRlcnlT dGF0dXM6OmNyZWF0ZShjaGFyZ2luZywgY2hhcmdpbmdUaW1lLCBkaXNjaGFyZ2luZ1RpbWUsIHBy b3BlcnR5LT52YWwuZCAvIDEwMCk7CiAgICAgaWYgKGNoYXJnaW5nQ2hhbmdlZCkKICAgICAgICAg Y2xpZW50LT5zZXRCYXR0ZXJ5U3RhdHVzKGV2ZW50TmFtZXMoKS5jaGFyZ2luZ2NoYW5nZUV2ZW50 LCBiYXR0ZXJ5U3RhdHVzKTsKICAgICBpZiAoY2hhcmdpbmdUaW1lQ2hhbmdlZCkK 156051 2012-08-02 05:39:44 -0700 2012-08-02 05:49:52 -0700 Patch bug-92964-20120802213925.patch text/plain 1992 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1MzY0OGZiM2Y2NzMw ZjBhMWM2NDNiMzgyZGViZGM3MjllNDFjMi4uMzM3MjQzZjAxYWY0MDQ4M2RjMmYwZDI4NGRiZTMz MzdmYWE0NTA4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIENoYW5n ZSByZXR1cm4gdmFsdWUgb2YgYmF0dGV5IGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSByZXR1cm4gdmFsdWUgb2YgbmF2aWdhdG9yLndl YmtpdEJhdHRlcnkubGV2ZWwgZnJvbSAwfjEwMCB0byAwfjEuMC4KKyAgICAgICAgQmF0dGVyeSBs ZXZlbCBoYXZlIHRvIHJldHVybnMgMH4xLjAgYnkgQmF0dGVyeSBTdGF0dXMgQVBJIHNwZWMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VkLgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC YXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQpOgorCiAyMDEyLTA4LTAyICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENTU1JlZ2lvbnM6IENy YXNoIHdoZW4gcmVhdHRhY2hpbmcgYSByZWdpb24gdG8gYSBuYW1lZCBmbG93LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAppbmRleCBj NWQwMzBhM2QxZDYyMWQ1ZGZhNWNlNWFkOTVlOTVmODUwYjEyN2FkLi5lZWUzYjZjZjRmZDcwNDVm NmMzMGM2N2IwYWRkYmJiMGYxZmIxMDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcApAQCAtMTUyLDE1ICsxNTIsMTQgQEAgdm9p ZCBCYXR0ZXJ5UHJvdmlkZXJFZmw6OnNldEJhdHRlcnlDbGllbnQodm9pZCogZGF0YSwgdm9pZCog cmVwbHlEYXRhLCBEQnVzRXJyb3IKICAgICAgICAgZGlzY2hhcmdpbmdUaW1lID0gcHJvcGVydHkt PnZhbC54OwogICAgIH0KIAotICAgIGRvdWJsZSBsZXZlbCA9IDA7CisgICAgZG91YmxlIGxldmVs ID0gcHJvcGVydHktPnZhbC5kIC8gMTAwOwogICAgIGJvb2wgbGV2ZWxDaGFuZ2VkID0gZmFsc2U7 CiAKICAgICBwcm9wZXJ0eSA9IHN0YXRpY19jYXN0PEVfVWtpdF9Qcm9wZXJ0eSo+KGVpbmFfaGFz aF9maW5kKGV1a2l0UHJvcGVydHlOYW1lcy0+cHJvcGVydGllcywgIlBlcmNlbnRhZ2UiKSk7CiAg ICAgaWYgKCFwcm9wZXJ0eSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmICghY2xpZW50QmF0dGVy eVN0YXR1cyB8fCBjbGllbnRCYXR0ZXJ5U3RhdHVzLT5sZXZlbCgpICE9IHByb3BlcnR5LT52YWwu ZCkKKyAgICBpZiAoIWNsaWVudEJhdHRlcnlTdGF0dXMgfHwgY2xpZW50QmF0dGVyeVN0YXR1cy0+ bGV2ZWwoKSAhPSBsZXZlbCkKICAgICAgICAgbGV2ZWxDaGFuZ2VkID0gdHJ1ZTsKLSAgICBsZXZl bCA9IHByb3BlcnR5LT52YWwuZDsKIAogICAgIFdURjo6UmVmUHRyPEJhdHRlcnlTdGF0dXM+IGJh dHRlcnlTdGF0dXMgPSBCYXR0ZXJ5U3RhdHVzOjpjcmVhdGUoY2hhcmdpbmcsIGNoYXJnaW5nVGlt ZSwgZGlzY2hhcmdpbmdUaW1lLCBsZXZlbCk7CiAgICAgaWYgKGNoYXJnaW5nQ2hhbmdlZCkK 156053 2012-08-02 05:49:59 -0700 2012-08-02 06:46:00 -0700 Patch bug-92964-20120802214939.patch text/plain 1946 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1MzY0OGZiM2Y2NzMw ZjBhMWM2NDNiMzgyZGViZGM3MjllNDFjMi4uZTJmYWU2MTllZjFhN2I3NWYyYzQwNDMyN2Y4MDRh ZDliYTQzMDJkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTAyICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIENoYW5n ZSByZXR1cm4gdmFsdWUgb2YgYmF0dGV5IGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSByZXR1cm4gdmFsdWUgb2YgbmF2aWdhdG9yLndl YmtpdEJhdHRlcnkubGV2ZWwgZnJvbSAwfjEwMCB0byAwfjEuMC4KKyAgICAgICAgQmF0dGVyeSBs ZXZlbCBoYXZlIHRvIHJldHVybnMgMH4xLjAgYnkgQmF0dGVyeSBTdGF0dXMgQVBJIHNwZWMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVyRWZsLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkJhdHRlcnlQcm92aWRlckVmbDo6c2V0QmF0dGVyeUNsaWVudCk6CisKIDIwMTIt MDgtMDIgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgQ1NT UmVnaW9uczogQ3Jhc2ggd2hlbiByZWF0dGFjaGluZyBhIHJlZ2lvbiB0byBhIG5hbWVkIGZsb3cu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQmF0dGVyeVByb3ZpZGVy RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwu Y3BwCmluZGV4IGM1ZDAzMGEzZDFkNjIxZDVkZmE1Y2U1YWQ5NWU5NWY4NTBiMTI3YWQuLmVlZTNi NmNmNGZkNzA0NWY2YzMwYzY3YjBhZGRiYmIwZjFmYjEwNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwCkBAIC0xNTIsMTUgKzE1 MiwxNCBAQCB2b2lkIEJhdHRlcnlQcm92aWRlckVmbDo6c2V0QmF0dGVyeUNsaWVudCh2b2lkKiBk YXRhLCB2b2lkKiByZXBseURhdGEsIERCdXNFcnJvcgogICAgICAgICBkaXNjaGFyZ2luZ1RpbWUg PSBwcm9wZXJ0eS0+dmFsLng7CiAgICAgfQogCi0gICAgZG91YmxlIGxldmVsID0gMDsKKyAgICBk b3VibGUgbGV2ZWwgPSBwcm9wZXJ0eS0+dmFsLmQgLyAxMDA7CiAgICAgYm9vbCBsZXZlbENoYW5n ZWQgPSBmYWxzZTsKIAogICAgIHByb3BlcnR5ID0gc3RhdGljX2Nhc3Q8RV9Va2l0X1Byb3BlcnR5 Kj4oZWluYV9oYXNoX2ZpbmQoZXVraXRQcm9wZXJ0eU5hbWVzLT5wcm9wZXJ0aWVzLCAiUGVyY2Vu dGFnZSIpKTsKICAgICBpZiAoIXByb3BlcnR5KQogICAgICAgICByZXR1cm47Ci0gICAgaWYgKCFj bGllbnRCYXR0ZXJ5U3RhdHVzIHx8IGNsaWVudEJhdHRlcnlTdGF0dXMtPmxldmVsKCkgIT0gcHJv cGVydHktPnZhbC5kKQorICAgIGlmICghY2xpZW50QmF0dGVyeVN0YXR1cyB8fCBjbGllbnRCYXR0 ZXJ5U3RhdHVzLT5sZXZlbCgpICE9IGxldmVsKQogICAgICAgICBsZXZlbENoYW5nZWQgPSB0cnVl OwotICAgIGxldmVsID0gcHJvcGVydHktPnZhbC5kOwogCiAgICAgV1RGOjpSZWZQdHI8QmF0dGVy eVN0YXR1cz4gYmF0dGVyeVN0YXR1cyA9IEJhdHRlcnlTdGF0dXM6OmNyZWF0ZShjaGFyZ2luZywg Y2hhcmdpbmdUaW1lLCBkaXNjaGFyZ2luZ1RpbWUsIGxldmVsKTsKICAgICBpZiAoY2hhcmdpbmdD aGFuZ2VkKQo=