9296 2006-06-03 13:08:19 -0700 Performance improvement for svn-create-patch 2006-06-03 13:36:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer oldest_to_newest 44563 0 ddkilzer 2006-06-03 13:08:19 -0700 Once $indexPath is set (on the very first line returned), the three regular expressions inside the "if ($indexPath)" block of the diff() subroutine are applied to every single line of the resulting patch. This is unnecessary. 44564 1 8682 ddkilzer 2006-06-03 13:16:09 -0700 Created attachment 8682 Patch v1 Patch v1 undefines the $indexPath variable so that the three regex replacement statements do not get run after the paths in each patch header are processed. Note that I didn't actually do any benchmarking; this seemed like an obvious performance win. 44567 2 timothy 2006-06-03 13:36:02 -0700 ddkilzer landed this in r14713. 8682 2006-06-03 13:16:09 -0700 2006-06-03 13:30:44 -0700 Patch v1 bug-9296-v1.diff text/plain 1212 ddkilzer SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHJldmlzaW9uIDE0NzA5KQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBA IC0xMjcsNyArMTI3LDcgQEAKICAgICAgICAgICAgICMgRml4IHBhdGhzIG9uIGRpZmYsIC0tLSwg YW5kICsrKyBsaW5lcyB0byBtYXRjaCBwcmVjZWRpbmcgSW5kZXg6IGxpbmUuCiAgICAgICAgICAg ICBzL1xTKyQvJGluZGV4UGF0aC8gaWYgL15kaWZmLzsKICAgICAgICAgICAgIHMvXi0tLSBcUysv LS0tICRpbmRleFBhdGgvOwotICAgICAgICAgICAgcy9eXCtcK1wrIFxTKy8rKysgJGluZGV4UGF0 aC87CisgICAgICAgICAgICBzL15cK1wrXCsgXFMrLysrKyAkaW5kZXhQYXRoLyAmJiB1bmRlZiAk aW5kZXhQYXRoOwogICAgICAgICB9CiAgICAgICAgIHByaW50OwogICAgIH0KSW5kZXg6IFdlYktp dFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0NzExKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTQgQEAKIDIwMDYtMDYtMDMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk2CisgICAg ICAgIFBlcmZvcm1hbmNlIGltcHJvdmVtZW50IGZvciBzdm4tY3JlYXRlLXBhdGNoCisKKyAgICAg ICAgKiBTY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2g6IFVuZGVmICRpbmRleFBhdGggYWZ0ZXIgYWxs IHBhdGhzIGhhdmUgYmVlbiBmaXhlZCBmb3IgYSBnaXZlbiBwYXRjaC4KKworMjAwNi0wNi0wMyAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAa2lsemVyLm5ldD4KKwogICAgICAgICBSZXZpZXdlZCBi eSBkYXJpbi4KIAogICAgICAgICBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19i dWcuY2dpP2lkPTkyOTAK