92943 2012-08-01 22:20:01 -0700 [EFL] Crash while loading plugin after r121467 2012-08-02 18:55:11 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez lucas.de.marchi webkit.review.bot oldest_to_newest 684977 0 ryuan.choi 2012-08-01 22:20:01 -0700 r121467 introduced eina_module instead of dlopen. but some codes using dlsym are remaind. So EWebLauncher is crashed while loading plugin when enabled netscape plugin api. 684985 1 155976 ryuan.choi 2012-08-01 22:39:22 -0700 Created attachment 155976 Patch 685746 2 155976 laszlo.gombos 2012-08-02 13:38:37 -0700 Comment on attachment 155976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review > Source/WebCore/ChangeLog:8 > + r121468 replaced POSIX dlopen to helpers in eina_module, but some codes Nit - should this be 121467 instead of 121468. 685763 3 155976 cdumez 2012-08-02 13:45:15 -0700 Comment on attachment 155976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review LGTM but: >> Source/WebCore/ChangeLog:8 >> + r121468 replaced POSIX dlopen to helpers in eina_module, but some codes > > Nit - should this be 121467 instead of 121468. Yes, Laszlo is right, definitely http://trac.webkit.org/changeset/121467 685984 4 156203 ryuan.choi 2012-08-02 16:46:29 -0700 Created attachment 156203 Patch 685986 5 ryuan.choi 2012-08-02 16:47:47 -0700 (In reply to comment #2) > (From update of attachment 155976 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review > > > Source/WebCore/ChangeLog:8 > > + r121468 replaced POSIX dlopen to helpers in eina_module, but some codes > > Nit - should this be 121467 instead of 121468. Oops, my mistake, fixed. 686047 6 156203 laszlo.gombos 2012-08-02 17:49:09 -0700 Comment on attachment 156203 Patch r=me. Thanks. 686111 7 156203 webkit.review.bot 2012-08-02 18:55:06 -0700 Comment on attachment 156203 Patch Clearing flags on attachment: 156203 Committed r124548: <http://trac.webkit.org/changeset/124548> 686112 8 webkit.review.bot 2012-08-02 18:55:11 -0700 All reviewed patches have been landed. Closing bug. 155976 2012-08-01 22:39:22 -0700 2012-08-02 16:46:22 -0700 Patch bug-92943-20120802143903.patch text/plain 2109 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFlYjUwY2M0ZmIxNzc3 NGU5NzcyNTMyODdmNjBkM2Q4ZjE0NTFiNS4uZDkyZWMxMmRhN2QwMjQwM2FmYWMyZDdlM2U4ZTI2 ZGM5MzI4YmFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTAxICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBDcmFzaCB3 aGlsZSBsb2FkaW5nIHBsdWdpbiBhZnRlciByMTIxNDY3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIHIxMjE0NjggcmVwbGFjZWQgUE9TSVggZGxvcGVuIHRv IGhlbHBlcnMgaW4gZWluYV9tb2R1bGUsIGJ1dCBzb21lIGNvZGVzCisgICAgICAgIGFyZSBub3Qg Y2hhbmdlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIGhhcyBub3QgY2hhbmdl ZC4KKworICAgICAgICAqIHBsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKToKKyAgICAgICAgQ2hhbmdlcyBk bHN5bSB0byBlaW5hX21vZHVsZV9zeW1ib2xfZ2V0IHRvIGZvbGxvdyBjaGFuZ2VzIG9mIHIxMjE0 NjguCisKIDIwMTItMDgtMDEgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFRoZSBlbGVtZW50cyBpbiBTaGFkb3cgRE9NIG9mIGlucHV0IHNob3VsZCBu b3QgYmUgbW9kaWZpYWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZs L1BsdWdpblBhY2thZ2VFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9lZmwvUGx1Z2lu UGFja2FnZUVmbC5jcHAKaW5kZXggMzViMWU3ZDMxNmMwYzM1OWZjYmU1NGEzMjlkNjQxZWUzMDk4 MzExYi4uZDZmZDlkMWFiZTY1MWRlNzMwMmZkOWE3N2MyZGQ1NTQyYjI0ZjQyOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9lZmwvUGx1Z2luUGFja2FnZUVmbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9lZmwvUGx1Z2luUGFja2FnZUVmbC5jcHAKQEAgLTUzLDEz ICs1MywxMyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNoSW5mbygpCiAgICAgTlBQX0dldFZh bHVlUHJvY1B0ciBnZXRWYWx1ZSA9IDA7CiAgICAgTlBfR2V0TUlNRURlc2NyaXB0aW9uRnVuY1B0 ciBnZXRNSU1FRGVzY3JpcHRpb24gPSAwOwogCi0gICAgZ2V0VmFsdWUgPSByZWludGVycHJldF9j YXN0PE5QUF9HZXRWYWx1ZVByb2NQdHI+KGRsc3ltKG1fbW9kdWxlLCAiTlBfR2V0VmFsdWUiKSk7 CisgICAgZ2V0VmFsdWUgPSByZWludGVycHJldF9jYXN0PE5QUF9HZXRWYWx1ZVByb2NQdHI+KGVp bmFfbW9kdWxlX3N5bWJvbF9nZXQobV9tb2R1bGUsICJOUF9HZXRWYWx1ZSIpKTsKICAgICBpZiAo KGVycm1zZyA9IGRsZXJyb3IoKSkpIHsKICAgICAgICAgRUlOQV9MT0dfRVJSKCJDb3VsZCBub3Qg Z2V0IHN5bWJvbCBOUF9HZXRWYWx1ZTogJXMiLCBlcnJtc2cpOwogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgfQogCi0gICAgZ2V0TUlNRURlc2NyaXB0aW9uID0gcmVpbnRlcnByZXRfY2FzdDxO UF9HZXRNSU1FRGVzY3JpcHRpb25GdW5jUHRyPihkbHN5bShtX21vZHVsZSwgIk5QX0dldE1JTUVE ZXNjcmlwdGlvbiIpKTsKKyAgICBnZXRNSU1FRGVzY3JpcHRpb24gPSByZWludGVycHJldF9jYXN0 PE5QX0dldE1JTUVEZXNjcmlwdGlvbkZ1bmNQdHI+KGVpbmFfbW9kdWxlX3N5bWJvbF9nZXQobV9t b2R1bGUsICJOUF9HZXRNSU1FRGVzY3JpcHRpb24iKSk7CiAgICAgaWYgKChlcnJtc2cgPSBkbGVy cm9yKCkpKSB7CiAgICAgICAgIEVJTkFfTE9HX0VSUigiQ291bGQgbm90IGdldCBzeW1ib2wgTlBf R2V0TUlNRURlc2NyaXB0aW9uOiAlcyIsIGVycm1zZyk7CiAgICAgICAgIHJldHVybiBmYWxzZTsK 156203 2012-08-02 16:46:29 -0700 2012-08-02 18:55:06 -0700 Patch bug-92943-20120803084609.patch text/plain 2092 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y3MTVlNTQ0ZTVhMDIx Mzk3NTYzMjRmYTE3Y2RiMTY4YTM1MDAyOS4uZmI5NzRhODNlNDQxNThmYjM3YWEwYmExNTMwZmE1 NmYyYzUzMzNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTAyICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBDcmFzaCB3 aGlsZSBsb2FkaW5nIHBsdWdpbiBhZnRlciByMTIxNDY3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIHIxMjE0NjcgcmVwbGFjZWQgUE9TSVggZGxvcGVuIHRv IGhlbHBlcnMgaW4gZWluYV9tb2R1bGUsIGJ1dCBzb21lIGNvZGVzCisgICAgICAgIGFyZSBub3Qg Y2hhbmdlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIGhhcyBub3QgY2hhbmdl ZC4KKworICAgICAgICAqIHBsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKToKKyAgICAgICAgQ2hhbmdlcyBk bHN5bSB0byBlaW5hX21vZHVsZV9zeW1ib2xfZ2V0IHRvIGZvbGxvdyBjaGFuZ2VzIG9mIHIxMjE0 NjcuCisKIDIwMTItMDgtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgc2NyaXB0cyBpbiBmb3JtYWN0aW9uIHNob3VsZCBiZSBzdHJpcHBlZCB1cG9uIHBhc3Rl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2VmbC9QbHVnaW5QYWNrYWdlRWZs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwCmlu ZGV4IDM1YjFlN2QzMTZjMGMzNTlmY2JlNTRhMzI5ZDY0MWVlMzA5ODMxMWIuLmQ2ZmQ5ZDFhYmU2 NTFkZTczMDJmZDlhNzdjMmRkNTU0MmIyNGY0MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwCkBAIC01MywxMyArNTMsMTMgQEAgYm9vbCBQ bHVnaW5QYWNrYWdlOjpmZXRjaEluZm8oKQogICAgIE5QUF9HZXRWYWx1ZVByb2NQdHIgZ2V0VmFs dWUgPSAwOwogICAgIE5QX0dldE1JTUVEZXNjcmlwdGlvbkZ1bmNQdHIgZ2V0TUlNRURlc2NyaXB0 aW9uID0gMDsKIAotICAgIGdldFZhbHVlID0gcmVpbnRlcnByZXRfY2FzdDxOUFBfR2V0VmFsdWVQ cm9jUHRyPihkbHN5bShtX21vZHVsZSwgIk5QX0dldFZhbHVlIikpOworICAgIGdldFZhbHVlID0g cmVpbnRlcnByZXRfY2FzdDxOUFBfR2V0VmFsdWVQcm9jUHRyPihlaW5hX21vZHVsZV9zeW1ib2xf Z2V0KG1fbW9kdWxlLCAiTlBfR2V0VmFsdWUiKSk7CiAgICAgaWYgKChlcnJtc2cgPSBkbGVycm9y KCkpKSB7CiAgICAgICAgIEVJTkFfTE9HX0VSUigiQ291bGQgbm90IGdldCBzeW1ib2wgTlBfR2V0 VmFsdWU6ICVzIiwgZXJybXNnKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAg IGdldE1JTUVEZXNjcmlwdGlvbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8TlBfR2V0TUlNRURlc2NyaXB0 aW9uRnVuY1B0cj4oZGxzeW0obV9tb2R1bGUsICJOUF9HZXRNSU1FRGVzY3JpcHRpb24iKSk7Cisg ICAgZ2V0TUlNRURlc2NyaXB0aW9uID0gcmVpbnRlcnByZXRfY2FzdDxOUF9HZXRNSU1FRGVzY3Jp cHRpb25GdW5jUHRyPihlaW5hX21vZHVsZV9zeW1ib2xfZ2V0KG1fbW9kdWxlLCAiTlBfR2V0TUlN RURlc2NyaXB0aW9uIikpOwogICAgIGlmICgoZXJybXNnID0gZGxlcnJvcigpKSkgewogICAgICAg ICBFSU5BX0xPR19FUlIoIkNvdWxkIG5vdCBnZXQgc3ltYm9sIE5QX0dldE1JTUVEZXNjcmlwdGlv bjogJXMiLCBlcnJtc2cpOwogICAgICAgICByZXR1cm4gZmFsc2U7Cg==