92920 2012-08-01 16:12:55 -0700 Fix for drawing invalid layers in WebViewBenchmarkSupportImpl 2012-08-01 19:11:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dmurph dmurph alokp crogers enne jamesr nduca scheib webkit.review.bot oldest_to_newest 684728 0 dmurph 2012-08-01 16:12:55 -0700 Fix for drawing invalid layers in WebViewBenchmarkSupportImpl 684732 1 155916 dmurph 2012-08-01 16:14:45 -0700 Created attachment 155916 Patch 684741 2 jamesr 2012-08-01 16:25:20 -0700 What's the bug that this fixes? 684743 3 155916 enne 2012-08-01 16:26:43 -0700 Comment on attachment 155916 Patch Are there any tests for this feature? 684744 4 dmurph 2012-08-01 16:26:55 -0700 There was an assertion being thrown when we tried to paint non-content layer, at RenderLayerBacking.cpp:1219. This only shows up on websites with backing layers like the poster circle. 684753 5 dmurph 2012-08-01 16:32:07 -0700 No, there are none. Testing this specifically seems a bit infeasible. This provides the drawing for canvas serialization, so when that's working we can do bitmap based tests. 684757 6 alokp 2012-08-01 16:38:35 -0700 I think it will be nice to have a simple webkit test for WebViewBenchmarkSupport::paint() since it uses a path different from the actual paint path. Testing it downstream will be hard to maintain. 684758 7 nduca 2012-08-01 16:41:02 -0700 I think no test is needed for this. This is not because I think testing is unnecessary. But rather, that testing for this specific bug is busy work. There is a broader question of how to test the support code. And whether its testable. I propose we land this fix, and then Alokp, Daniel and I deal with the testability discussion offline. It may be that we're going to change this more heavily. 684759 8 enne 2012-08-01 16:43:49 -0700 (In reply to comment #7) > This is not because I think testing is unnecessary. But rather, that testing for this specific bug is busy work. There is a broader question of how to test the support code. And whether its testable. I think that was really my question. I hadn't ever seen WebViewBenchmarkSupport before and was curious if there was any testing strategy here. > I propose we land this fix, and then Alokp, Daniel and I deal with the testability discussion offline. It may be that we're going to change this more heavily. Sure. 684761 9 155916 enne 2012-08-01 16:44:04 -0700 Comment on attachment 155916 Patch R=me. 684795 10 155916 webkit.review.bot 2012-08-01 17:20:25 -0700 Comment on attachment 155916 Patch Clearing flags on attachment: 155916 Committed r124391: <http://trac.webkit.org/changeset/124391> 684796 11 webkit.review.bot 2012-08-01 17:20:29 -0700 All reviewed patches have been landed. Closing bug. 155916 2012-08-01 16:14:45 -0700 2012-08-01 17:20:25 -0700 Patch bug-92920-20120801161427.patch text/plain 1612 dmurph U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDlhMDdjNGQ5MTI0NDZmYjBlN2MwY2U2YjZkMTY2ZjUxYWMxNWUzZjUuLjJkODFhNWFhYjZhNTEz MjU4OTc3NmY0NzM4YjdhYTk2NTdhMWI3MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMDEgIERhbmllbCBNdXJwaHkgIDxkbXVycGhAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEZpeCBmb3IgZHJhd2luZyBpbnZhbGlkIGxheWVycyBpbiBXZWJW aWV3QmVuY2htYXJrU3VwcG9ydEltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyOTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIEdyYXBoaWNzTGF5ZXJzIHdpdGhvdXQgY29udGVudCBuZWVkZWQg dG8gYmUgc2tpcHBlZC4KKworICAgICAgICAqIHNyYy9XZWJWaWV3QmVuY2htYXJrU3VwcG9ydElt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3QmVuY2htYXJrU3VwcG9ydEltcGw6OmFj Y2VsZXJhdGVkUGFpbnRVbmNsaXBwZWQpOgorCiAyMDEyLTA4LTAxICBTaGVyaWZmIEJvdCAgPHdl YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTI0MzM0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0JlbmNobWFya1N1cHBvcnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdCZW5jaG1hcmtTdXBwb3J0SW1wbC5jcHAKaW5kZXggOTc2NGFmMTM4MjY4ZjcwMTU5 ODZjM2RmZGYyNmU4MDhiMzQzN2MxNS4uYTBmN2E0YjBiNmQxYTIxYWY4MTc5NjJlN2QxMjc0ZmU3 YWI5ZjgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0Jl bmNobWFya1N1cHBvcnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3QmVuY2htYXJrU3VwcG9ydEltcGwuY3BwCkBAIC01OSw3ICs1OSw4IEBAIHZvaWQgV2Vi Vmlld0JlbmNobWFya1N1cHBvcnRJbXBsOjphY2NlbGVyYXRlZFBhaW50VW5jbGlwcGVkKFBhaW50 Q2xpZW50KiBwYWludENsCiAgICAgRmxvYXRTaXplIGxheWVyU2l6ZSA9IGxheWVyLnNpemUoKTsK ICAgICBJbnRSZWN0IGNsaXAoMCwgMCwgbGF5ZXJTaXplLndpZHRoKCksIGxheWVyU2l6ZS5oZWln aHQoKSk7CiAKLSAgICBwYWludExheWVyKHBhaW50Q2xpZW50LCBsYXllciwgY2xpcCk7CisgICAg aWYgKGxheWVyLmRyYXdzQ29udGVudCgpKQorICAgICAgICBwYWludExheWVyKHBhaW50Q2xpZW50 LCBsYXllciwgY2xpcCk7CiAKICAgICBjb25zdCBWZWN0b3I8R3JhcGhpY3NMYXllcio+JiBjaGls ZHJlbiA9IGxheWVyLmNoaWxkcmVuKCk7CiAgICAgVmVjdG9yPEdyYXBoaWNzTGF5ZXIqPjo6Y29u c3RfaXRlcmF0b3IgaXQ7Cg==