92902 2012-08-01 12:53:41 -0700 [Qt][WK2] Race condition between first layout and viewport attributes initialization 2012-08-01 15:21:20 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jesus jesus abecsi cmarcelo menard webkit.review.bot zoltan oldest_to_newest 684491 0 jesus 2012-08-01 12:53:41 -0700 During our WebView initialization a default FrameView is created, triggering a layout. This is triggering QtViewportHandler::pageContentsSizeChanged earlier than the first QtViewportHandler::viewportAttributesChanged, which was responsible for initializing m_rawAttributes from QtViewportHandler. This hasn't been noticed before because we set useFixedLayout in QQuickWebViewFlickablePrivate::initialize before the layout is finished, which triggers the correct layout anyway. However, while debugging https://bugs.webkit.org/show_bug.cgi?id=92753, debug messages delayed the initialization of the webview and the first layout finished before expected, leading us to "ASSERT(scale < 0)" in QQuickWebPage::setContentsScale. (The random negative scale was returned by WebCore::computeMinimumScaleFactorForContentContained, called in QtViewportHandler::pageContentsSizeChanged). This overly descriptive bug report is for the sake of remembering, since it took me a while to understand the race condition... Patch is coming. 684528 1 155874 jesus 2012-08-01 13:38:32 -0700 Created attachment 155874 Patch 684644 2 155874 webkit.review.bot 2012-08-01 15:21:16 -0700 Comment on attachment 155874 Patch Clearing flags on attachment: 155874 Committed r124374: <http://trac.webkit.org/changeset/124374> 684645 3 webkit.review.bot 2012-08-01 15:21:20 -0700 All reviewed patches have been landed. Closing bug. 155874 2012-08-01 13:38:32 -0700 2012-08-01 15:21:16 -0700 Patch bug-92902-20120801173720.patch text/plain 2133 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDg1MGE1NTA3ZGI1MTgw YTU2NDRmNjk2OTYwYzhmMzcyODYyYjhhZi4uZjJhY2FmZmU0MmI1ZTQ5NmJjMDE2NjA2NmQ4YzBm MDZlMTIyNzhkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTAxICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gUmFjZSBjb25kaXRpb24gYmV0d2VlbiBmaXJzdCBsYXlvdXQgYW5kIHZp ZXdwb3J0IGF0dHJpYnV0ZXMgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyOTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGl6aW5nIG1fcmF3QXR0cmlidXRlcyBmcm9t IFF0Vmlld3BvcnRIYW5kbGVyIHRvIGF2b2lkIGNhbGN1bGF0aW9uIG9mIHJhbmRvbQorICAgICAg ICBzY2FsZSBmYWN0b3JzIG9uIHRoZSBmaXJzdCBsYXlvdXQgaXMgdHJpZ2dlcmVkLgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6UXRWaWV3cG9ydEhhbmRsZXI6OlF0Vmlld3BvcnRIYW5kbGVyKToKKwogMjAxMi0wOC0wMSAg WmVubyBBbGJpc3NlciAgPHplbm9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdUkVHUkVTU0lP TihyMTIzNzg2KTogSXQgbWFkZSAzIGZhc3QvYW5pbWF0aW9uIHRlc3RzIGZhaWwuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEhhbmRsZXIuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRIYW5kbGVyLmNwcAppbmRleCAz ZjE1NmU5NWY3ZTg0MWI4ZDMxMjE2Y2ZjNWM0NzQ3YTUzMDE5MWVmLi5mYWZmMzMxYmU2YmUxMWI3 MTIxYjJlYjM2NTdlY2YyZjg5NzBkYjE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRWaWV3cG9ydEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9RdFZpZXdwb3J0SGFuZGxlci5jcHAKQEAgLTE3MSw2ICsxNzEsMTQgQEAgUXRWaWV3 cG9ydEhhbmRsZXI6OlF0Vmlld3BvcnRIYW5kbGVyKFdlYktpdDo6V2ViUGFnZVByb3h5KiBwcm94 eSwgUVF1aWNrV2ViVmlldyoKICAgICBtX3NjYWxlQW5pbWF0aW9uLT5zZXREdXJhdGlvbihrU2Nh bGVBbmltYXRpb25EdXJhdGlvbk1pbGxpcyk7CiAgICAgbV9zY2FsZUFuaW1hdGlvbi0+c2V0RWFz aW5nQ3VydmUoUUVhc2luZ0N1cnZlOjpPdXRDdWJpYyk7CiAKKyAgICAvLyBJbml0aWFsaXppbmcg Vmlld3BvcnQgUmF3IEF0dHJpYnV0ZXMgdG8gYXZvaWQgcmFuZG9tIG5lZ2F0aXZlIHNjYWxlIGZh Y3RvcnMKKyAgICAvLyBpZiB0aGVyZSBpcyBhIHJhY2UgY29uZGl0aW9uIGJldHdlZW4gdGhlIGZp cnN0IGxheW91dCBhbmQgc2V0dGluZyB0aGUgdmlld3BvcnQgYXR0cmlidXRlcyBmb3IgdGhlIGZp cnN0IHRpbWUuCisgICAgbV9yYXdBdHRyaWJ1dGVzLmRldmljZVBpeGVsUmF0aW8gPSBtX2Rldmlj ZVBpeGVsUmF0aW87CisgICAgbV9yYXdBdHRyaWJ1dGVzLmluaXRpYWxTY2FsZSA9IDE7CisgICAg bV9yYXdBdHRyaWJ1dGVzLm1pbmltdW1TY2FsZSA9IG1fbWluaW11bVNjYWxlOworICAgIG1fcmF3 QXR0cmlidXRlcy5tYXhpbXVtU2NhbGUgPSBtX21heGltdW1TY2FsZTsKKyAgICBtX3Jhd0F0dHJp YnV0ZXMudXNlclNjYWxhYmxlID0gbV9hbGxvd3NVc2VyU2NhbGluZzsKKwogICAgIGNvbm5lY3Qo bV92aWV3cG9ydEl0ZW0sIFNJR05BTChtb3ZlbWVudFN0YXJ0ZWQoKSksIFNMT1QoZmxpY2tNb3Zl U3RhcnRlZCgpKSwgUXQ6OkRpcmVjdENvbm5lY3Rpb24pOwogICAgIGNvbm5lY3QobV92aWV3cG9y dEl0ZW0sIFNJR05BTChtb3ZlbWVudEVuZGVkKCkpLCBTTE9UKGZsaWNrTW92ZUVuZGVkKCkpLCBR dDo6RGlyZWN0Q29ubmVjdGlvbik7CiAK