92895 2012-08-01 12:03:13 -0700 [Qt][WK2] There's no way to test the gesture tap on WTR 2012-08-03 10:21:38 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66173 91012 1 hugo.lima hugo.lima abecsi cmarcelo jesus kenneth luciano.wolf menard tonikitoo webkit.review.bot zoltan oldest_to_newest 684429 0 hugo.lima 2012-08-01 12:03:13 -0700 There's no way to test the gesture tap on WTR because the code on QtWebPageEventHandler::doneWithTouchEvent relies on a instance of QtViewportHandler and such instance doesn't exist because WTR runs on "desktop mode". 685913 1 156184 hugo.lima 2012-08-02 15:36:01 -0700 Created attachment 156184 Patch 686787 2 abecsi 2012-08-03 08:47:12 -0700 As far as I remember componentComplete is only triggered in QML, so in C++ unless WTR creates a WebView component dinamically this codepath won't be triggered so the viewport handler will still be null there, but I might be wrong. 686902 3 156184 webkit.review.bot 2012-08-03 10:21:34 -0700 Comment on attachment 156184 Patch Clearing flags on attachment: 156184 Committed r124625: <http://trac.webkit.org/changeset/124625> 686903 4 webkit.review.bot 2012-08-03 10:21:38 -0700 All reviewed patches have been landed. Closing bug. 156184 2012-08-02 15:36:01 -0700 2012-08-03 10:21:33 -0700 Patch bug-92895-20120802193532.patch text/plain 5413 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjBhNWJjYWNjZGNhMmQw M2E3NjBlMjA1MGViMDZhZjYwYWI1Mjk1ZC4uNDFmMTQ2ZGU0MTQwMjdjYmUwNjU0MWU5NjhmZjI4 MmJmNDIyOGM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTAyICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF1b V0syXSBUaGVyZSdzIG5vIHdheSB0byB0ZXN0IHRoZSBnZXN0dXJlIHRhcCBvbiBXVFIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODk1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIGluc3RhbmNl IG9mIFF0Vmlld3BvcnRIYW5kbGVyIHRvIFFRdWlja1dlYlZpZXdQcml2YXRlLCBzbyBpdCdzCisg ICAgICAgIG5vdyBhdmFpbGFibGUgb24gbW9iaWxlIGFuZCBkZXNrdG9wIG1vZGVzLCBhcyBhIHNp ZGUgZWZmZWN0IGdlc3R1cmUgdGFwCisgICAgICAgIGV2ZW50cyBjYW4gbm93IGJlIGNyZWF0ZWQg YW5kIHNlbnQgdG8gV2ViQ29yZS4KKworICAgICAgICBUaGlzIGlzIG5lZWRlZCB0byB0ZXN0IHRh cCBnZXN0dXJlcyBhbmQgdG8gZ2V0IHRhcCBnZXN0dXJlcyB3b3JraW5nCisgICAgICAgIHdoZW4g eW91IGhhdmUgYSBXZWJWaWV3IChpbiBkZXNrdG9wIG1vZGUpIG9uIG5vdGVib29rcyBlcXVpcHBl ZCB3aXRoCisgICAgICAgIHRvdWNoIHNjcmVlbnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6Om9u Q29tcG9uZW50Q29tcGxldGUpOgorICAgICAgICAoUVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZh dGU6Om9uQ29tcG9uZW50Q29tcGxldGUpOiBJbXBsZW1lbnRhdGlvbgorICAgICAgICBtb3ZlZCB0 byBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6b25Db21wb25lbnRDb21wbGV0ZS4KKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJW aWV3UHJpdmF0ZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZSk6CisK IDIwMTItMDgtMDIgIExhdXJvIE5ldG8gIDxsYXVyby5uZXRvQG9wZW5ib3NzYS5vcmc+CiAKICAg ICAgICAgW1F0XSBGaXggYXhpcyBsb2NraW5nIHdoZW4gcGFubmluZyBvbiBOOQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggN2I1 NTI3OTk1OGU5YTQ3NTM3YjRjYWY2N2JmYWRhZWMwNGQ5OTZiNy4uODJhNzAwOWUyZmQ3ZGM2MzI0 ZmNjMWYzYzhiZDAyYWM3YTBiNzdlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0zMjEsNiArMzIxLDEzIEBAIHZvaWQgUVF1 aWNrV2ViVmlld1ByaXZhdGU6OmluaXRpYWxpemUoV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdL UGFnZUdyb3VwUmVmIHBhCiAgICAgd2ViUGFnZVByb3h5LT5pbml0aWFsaXplV2ViUGFnZSgpOwog fQogCit2b2lkIFFRdWlja1dlYlZpZXdQcml2YXRlOjpvbkNvbXBvbmVudENvbXBsZXRlKCkKK3sK KyAgICBRX1EoUVF1aWNrV2ViVmlldyk7CisgICAgbV92aWV3cG9ydEhhbmRsZXIucmVzZXQobmV3 IFF0Vmlld3BvcnRIYW5kbGVyKHdlYlBhZ2VQcm94eS5nZXQoKSwgcSwgcGFnZVZpZXcuZGF0YSgp KSk7CisgICAgcGFnZVZpZXctPmV2ZW50SGFuZGxlcigpLT5zZXRWaWV3cG9ydEhhbmRsZXIobV92 aWV3cG9ydEhhbmRsZXIuZGF0YSgpKTsKK30KKwogdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6 c2V0VHJhbnNwYXJlbnRCYWNrZ3JvdW5kKGJvb2wgZW5hYmxlKQogewogICAgIHdlYlBhZ2VQcm94 eS0+c2V0RHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQoZW5hYmxlKTsKQEAgLTg1MiwxMCArODU5 LDcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZTo6aW5pdGlhbGl6ZShXS0Nv bnRleHRSZWYgY29udGV4dFJlZiwgV0tQYWdlR3IKIAogdm9pZCBRUXVpY2tXZWJWaWV3RmxpY2th YmxlUHJpdmF0ZTo6b25Db21wb25lbnRDb21wbGV0ZSgpCiB7Ci0gICAgUV9RKFFRdWlja1dlYlZp ZXcpOwotCi0gICAgbV92aWV3cG9ydEhhbmRsZXIucmVzZXQobmV3IFF0Vmlld3BvcnRIYW5kbGVy KHdlYlBhZ2VQcm94eS5nZXQoKSwgcSwgcGFnZVZpZXcuZGF0YSgpKSk7Ci0gICAgcGFnZVZpZXct PmV2ZW50SGFuZGxlcigpLT5zZXRWaWV3cG9ydEhhbmRsZXIobV92aWV3cG9ydEhhbmRsZXIuZGF0 YSgpKTsKKyAgICBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6b25Db21wb25lbnRDb21wbGV0ZSgpOwog CiAgICAgLy8gVHJpZ2dlciBzZXR0aW5nIG9mIGNvcnJlY3QgdmlzaWJpbGl0eSBmbGFncyBhZnRl ciBldmVyeXRoaW5nIHdhcyBhbGxvY2F0ZWQgYW5kIGluaXRpYWxpemVkLgogICAgIF9xX29uVmlz aWJsZUNoYW5nZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlld19wX3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlld19wX3AuaAppbmRleCBmYzY2NGExMTNhYjY0MDhjZTg4MDY4ZDkwODYyMWE0 YWUyMmIyNzIxLi43OGFkZmIzODU5NDY5NTJhYTdkYzgzZWFmYTA3ZWE1YTNjMzcwZTNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9w LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3Bf cC5oCkBAIC02OSw3ICs2OSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBpbml0aWFs aXplKFdLQ29udGV4dFJlZiBjb250ZXh0UmVmID0gMCwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3Vw UmVmID0gMCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgb25Db21wb25lbnRDb21wbGV0ZSgpIHsgfQor ICAgIHZpcnR1YWwgdm9pZCBvbkNvbXBvbmVudENvbXBsZXRlKCk7CiAKICAgICB2aXJ0dWFsIHZv aWQgZW5hYmxlTW91c2VFdmVudHMoKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlzYWJsZU1vdXNl RXZlbnRzKCkgeyB9CkBAIC0xNzUsNiArMTc1LDcgQEAgcHJvdGVjdGVkOgogICAgIFFTY29wZWRQ b2ludGVyPFFRdWlja1dlYlBhZ2U+IHBhZ2VWaWV3OwogICAgIFFRdWlja1dlYlZpZXcqIHFfcHRy OwogCisgICAgUVNjb3BlZFBvaW50ZXI8V2ViS2l0OjpRdFZpZXdwb3J0SGFuZGxlcj4gbV92aWV3 cG9ydEhhbmRsZXI7CiAgICAgRmxpY2thYmxlQXhpc0xvY2tlciBheGlzTG9ja2VyOwogCiAgICAg UVFtbENvbXBvbmVudCogYWxlcnREaWFsb2c7CkBAIC0yMzAsOSArMjMxLDYgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgdm9pZCBwYWdlRGlkUmVxdWVzdFNjcm9sbChjb25zdCBRUG9pbnQmIHBvcyk7 CiAgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZUNvbnRlbnRzU2l6ZShjb25zdCBRU2l6ZSYgbmV3 U2l6ZSk7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZU1vdXNlRXZlbnQoUU1vdXNlRXZlbnQqKTsK LQotcHJpdmF0ZToKLSAgICBRU2NvcGVkUG9pbnRlcjxXZWJLaXQ6OlF0Vmlld3BvcnRIYW5kbGVy PiBtX3ZpZXdwb3J0SGFuZGxlcjsKIH07CiAKICNlbmRpZiAvLyBxcXVpY2t3ZWJ2aWV3X3BfcF9o CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGM3 NzE3MTQ5YTY0YWZkOTljNTVmNzMyYjBhODdmYzkxYTliYzE3ZS4uY2RiMjJlOTQzNGMzNzY4MGNk Mjc1MTBlY2UxYmFmYWY5NTFmYmJiNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTAyICBIdWdvIFBhcmVu dGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF1bV0syXSBU aGVyZSdzIG5vIHdheSB0byB0ZXN0IHRoZSBnZXN0dXJlIHRhcCBvbiBXVFIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODk1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV1RSIGRvZXNuJ3QgY3JlYXRlIHRo ZSBRUXVpY2tJdGVtIGZyb20gQysrLCBub3QgZnJvbSBRTUwsIHNvIGEgY2FsbAorICAgICAgICB0 byBjb21wb25lbnRDb21wbGV0ZSgpIHdhcyBhZGRlZCB0byBtaW1pYyB0aGUgUU1MIGJlaGF2aW91 ci4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3Bw OgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyk6CisKIDIw MTItMDgtMDIgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBT cGVlY2ggSmF2YVNjcmlwdCBBUEk6IEZpcmUgc3BlZWNoIHN0YXJ0IGV2ZW50IGF0IHRoZSBzYW1l IHRpbWUgYXMgc291bmQgc3RhcnQgZXZlbnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9x dC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAKaW5kZXggYjI2ZTIwNTE1MWJkODc2MDA0NmZmZTlkZDY4 YzZlODRiNzNjYzIyMC4uOGE3NTJhODMxZDc3OTA5OTY4NjYyOWMxMTcwZjk2YTlmNWEzOWQ1OSAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5j cHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAK QEAgLTc3LDYgKzc3LDcgQEAgUGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcoV0tDb250 ZXh0UmVmIGNvbnRleHRSZWYsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm8KICAgICBRUXVpY2tXZWJW aWV3RXhwZXJpbWVudGFsIGV4cGVyaW1lbnRhbChtX3ZpZXcpOwogICAgIGV4cGVyaW1lbnRhbC5z ZXRSZW5kZXJUb09mZnNjcmVlbkJ1ZmZlcih0cnVlKTsKICAgICBtX3ZpZXctPnNldEFsbG93QW55 SFRUUFNDZXJ0aWZpY2F0ZUZvckxvY2FsSG9zdCh0cnVlKTsKKyAgICBtX3ZpZXctPmNvbXBvbmVu dENvbXBsZXRlKCk7CiB9CiAKIFBsYXRmb3JtV2ViVmlldzo6flBsYXRmb3JtV2ViVmlldygpCg==