92892 2012-08-01 11:50:47 -0700 C++ code should get ClassInfo from the Structure 2012-08-01 12:25:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo ggaren oldest_to_newest 684407 0 mhahnenberg 2012-08-01 11:50:47 -0700 In our march to remove ClassInfo from our JSCell object headers, we can switch C++ code over to grabbing the ClassInfo from the Structure since it is finally safe to do so now that Structure access is safe during finalization/destruction. The remaining JIT code changes can be done in a separate patch. 684434 1 155854 mhahnenberg 2012-08-01 12:03:46 -0700 Created attachment 155854 Patch 684443 2 155854 ggaren 2012-08-01 12:07:33 -0700 Comment on attachment 155854 Patch r=me 684460 3 mhahnenberg 2012-08-01 12:25:14 -0700 Committed r124355: <http://trac.webkit.org/changeset/124355> 155854 2012-08-01 12:03:46 -0700 2012-08-01 12:07:33 -0700 Patch bug-92892-20120801120330.patch text/plain 3931 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI0MzUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDEyLTA4LTAxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQysrIGNvZGUgc2hvdWxkIGdldCBDbGFzc0luZm8gZnJvbSB0aGUgU3RydWN0dXJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjg5Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIG91ciBt YXJjaCB0byByZW1vdmUgQ2xhc3NJbmZvIGZyb20gb3VyIEpTQ2VsbCBvYmplY3QgaGVhZGVycywg d2UgY2FuIHN3aXRjaCAKKyAgICAgICAgQysrIGNvZGUgb3ZlciB0byBncmFiYmluZyB0aGUgQ2xh c3NJbmZvIGZyb20gdGhlIFN0cnVjdHVyZSBzaW5jZSBpdCBpcyBmaW5hbGx5IAorICAgICAgICBz YWZlIHRvIGRvIHNvIG5vdyB0aGF0IFN0cnVjdHVyZSBhY2Nlc3MgaXMgc2FmZSBkdXJpbmcgZmlu YWxpemF0aW9uL2Rlc3RydWN0aW9uLiAKKyAgICAgICAgVGhlIHJlbWFpbmluZyBKSVQgY29kZSBj aGFuZ2VzIGNhbiBiZSBkb25lIGluIGEgc2VwYXJhdGUgcGF0Y2guCisKKyAgICAgICAgKiBoZWFw L01hcmtlZEJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6OmNhbGxEZXN0cnVj dG9yKTogV2UgZG9uJ3Qgd2FudCB0byBjbGVhciB0aGUgU3RydWN0dXJlIGFueSBtb3JlIAorICAg ICAgICBzaW5jZSB0aGUgU3RydWN0dXJlIHNob3VsZCBzdGlsbCBiZSB2YWxpZCBhdCB0aGlzIHBv aW50LgorICAgICAgICAqIGhlYXAvV2Vha1NldElubGluZXMuaDoKKyAgICAgICAgKEpTQzo6V2Vh a0Jsb2NrOjpmaW5hbGl6ZSk6IERpdHRvLgorICAgICAgICAqIHJ1bnRpbWUvSlNDZWxsLmg6Cisg ICAgICAgIChKU0MpOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmg6CisgICAgICAgIChK U0M6OkpTQ2VsbDo6Y2xhc3NJbmZvKTogTW92ZSBKU0NlbGwncyBjbGFzc0luZm8oKSB0byBTdHJ1 Y3R1cmUuaCBzbyBpdCBjYW4gYmUgCisgICAgICAgIGlubGluZS4gVXNlIGEgZGlmZmVyZW50IG1l dGhvZCBvZiBnZXR0aW5nIHRoZSBKU0NlbGwncyBTdHJ1Y3R1cmUgYmFzZWQgb24gCisgICAgICAg IHdoZXRoZXIgd2UncmUgaW4gR0NfVkFMSURBVElPTiBtb2RlIG9yIG5vdCwgc2luY2UgYWx3YXlz IHVzaW5nIGdldCgpIHdpbGwgY2F1c2UgCisgICAgICAgIGluZmluaXRlIHJlY3Vyc2lvbiBpbiBH Q19WQUxJREFUSU9OIG1vZGUuCisgICAgICAgIChKU0MpOgorCiAyMDEyLTA3LTMxICBNYXJrIEhh aG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFya2VkQmxvY2s6 OnN3ZWVwKCkgc2hvdWxkIHN3ZWVwIGFub3RoZXIgYmxvY2sgaWYgaXQgY2FuJ3Qgc3dlZXAgYSBT dHJ1Y3R1cmUgYmxvY2sKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJs b2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRC bG9jay5jcHAJKHJldmlzaW9uIDEyNDM0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hcmtlZEJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsMTAgKzYxLDYgQEAgaW5saW5l IHZvaWQgTWFya2VkQmxvY2s6OmNhbGxEZXN0cnVjdG9yKAogICAgIG1faGVhcC0+bV9kZXN0cm95 ZWRUeXBlQ291bnRzLmNvdW50VlB0cih2cHRyKTsKICNlbmRpZgogCi0jaWYgIUFTU0VSVF9ESVNB QkxFRCB8fCBFTkFCTEUoR0NfVkFMSURBVElPTikKLSAgICBjZWxsLT5jbGVhclN0cnVjdHVyZSgp OwotI2VuZGlmCi0KICAgICBjZWxsLT5tZXRob2RUYWJsZSgpLT5kZXN0cm95KGNlbGwpOwogICAg IGNlbGwtPnphcCgpOwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha1Nl dElubGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFr U2V0SW5saW5lcy5oCShyZXZpc2lvbiAxMjQzNDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9XZWFrU2V0SW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw5ICs0OSw2IEBAIGlu bGluZSB2b2lkIFdlYWtCbG9jazo6ZmluYWxpemUoV2Vha0ltcGwKICAgICBXZWFrSGFuZGxlT3du ZXIqIHdlYWtIYW5kbGVPd25lciA9IHdlYWtJbXBsLT53ZWFrSGFuZGxlT3duZXIoKTsKICAgICBp ZiAoIXdlYWtIYW5kbGVPd25lcikKICAgICAgICAgcmV0dXJuOwotI2lmICFBU1NFUlRfRElTQUJM RUQgfHwgRU5BQkxFKEdDX1ZBTElEQVRJT04pCi0gICAgd2Vha0ltcGwtPmpzVmFsdWUoKS5hc0Nl bGwoKS0+Y2xlYXJTdHJ1Y3R1cmUoKTsKLSNlbmRpZgogICAgIHdlYWtIYW5kbGVPd25lci0+Zmlu YWxpemUoSGFuZGxlPFVua25vd24+Ojp3cmFwU2xvdCgmY29uc3RfY2FzdDxKU1ZhbHVlJj4od2Vh a0ltcGwtPmpzVmFsdWUoKSkpLCB3ZWFrSW1wbC0+Y29udGV4dCgpKTsKIH0KIApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgJKHJldmlzaW9uIDEyNDM0MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0x OTIsMTEgKzE5Miw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gbV9zdHJ1Y3R1 cmUuZ2V0KCk7CiAgICAgfQogCi0gICAgaW5saW5lIGNvbnN0IENsYXNzSW5mbyogSlNDZWxsOjpj bGFzc0luZm8oKSBjb25zdAotICAgIHsKLSAgICAgICAgcmV0dXJuIG1fY2xhc3NJbmZvOwotICAg IH0KLQogICAgIGlubGluZSB2b2lkIEpTQ2VsbDo6dmlzaXRDaGlsZHJlbihKU0NlbGwqIGNlbGws IFNsb3RWaXNpdG9yJiB2aXNpdG9yKQogICAgIHsKICAgICAgICAgTUFSS19MT0dfUEFSRU5UKHZp c2l0b3IsIGNlbGwpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlLmgJKHJldmlzaW9uIDEyNDM0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cnVjdHVyZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MDIsNiArNjAyLDE1IEBAIG5hbWVzcGFj ZSBKU0MgewogICAgICAgICBBU1NFUlQobV9zdHJ1Y3R1cmUgfHwgIWdsb2JhbERhdGEuc3RydWN0 dXJlU3RydWN0dXJlKTsKICAgICB9CiAKKyAgICBpbmxpbmUgY29uc3QgQ2xhc3NJbmZvKiBKU0Nl bGw6OmNsYXNzSW5mbygpIGNvbnN0CisgICAgeworI2lmIEVOQUJMRShHQ19WQUxJREFUSU9OKQor ICAgICAgICByZXR1cm4gbV9zdHJ1Y3R1cmUudW52YWxpZGF0ZWRHZXQoKS0+Y2xhc3NJbmZvKCk7 CisjZWxzZQorICAgICAgICByZXR1cm4gbV9zdHJ1Y3R1cmUtPmNsYXNzSW5mbygpOworI2VuZGlm CisgICAgfQorCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlmIC8vIFN0cnVjdHVyZV9oCg==