92888 2012-08-01 10:59:13 -0700 Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot 2012-08-01 13:19:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned apavlov oldest_to_newest 684322 0 koivisto 2012-08-01 10:59:13 -0700 [WebView(WebPrivate) _close] ends up calling [WebView dealloc] which is wrong (gdb) bt #0 0x0000000101ecfe9a in -[WebViewPrivate dealloc] (self=0x7fcb088e8410, _cmd=0x7fff929bcb6b) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebView/WebViewData.mm:114 #1 0x0000000101eb08f7 in -[WebView dealloc] (self=0x7fcb05bc5a70, _cmd=0x7fff929bcb6b) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebView/WebView.mm:3389 #2 0x0000000101e2ec9a in -[WebInspectorWindowController dealloc] (self=0x7fcb0885cd30, _cmd=0x7fff929bcb6b) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:302 #3 0x00007fff92239301 in -[NSWindowController release] () #4 0x00007fff8fbc3f9a in CFRelease () #5 0x0000000101e30df1 in WTF::RetainPtr<WebInspectorWindowController>::~RetainPtr (this=0x7fcb033b2df0) at RetainPtr.h:76 #6 0x0000000101e306e5 in WTF::RetainPtr<WebInspectorWindowController>::~RetainPtr (this=0x7fcb033b2df0) at RetainPtr.h:76 #7 0x0000000101e30eb8 in WebInspectorFrontendClient::~WebInspectorFrontendClient (this=0x7fcb033b2d90) at WebInspectorClient.h:89 #8 0x0000000101e30995 in WebInspectorFrontendClient::~WebInspectorFrontendClient (this=0x7fcb033b2d90) at WebInspectorClient.h:89 #9 0x0000000101e309b8 in WebInspectorFrontendClient::~WebInspectorFrontendClient (this=0x7fcb033b2d90) at WebInspectorClient.h:89 #10 0x0000000102d696ae in WTF::deleteOwnedPtr<WebCore::InspectorFrontendClient> (ptr=0x7fcb033b2d90) at OwnPtrCommon.h:56 #11 0x0000000102d6c7e8 in WTF::OwnPtr<WebCore::InspectorFrontendClient>::~OwnPtr (this=0x7fcb05b9ad48) at OwnPtr.h:55 #12 0x0000000102d68ee5 in WTF::OwnPtr<WebCore::InspectorFrontendClient>::~OwnPtr (this=0x7fcb05b9ad48) at OwnPtr.h:55 #13 0x0000000102d665b1 in WebCore::InspectorController::~InspectorController (this=0x7fcb05b9acf0) at /Users/antti/webkit/OpenSource/Source/WebCore/inspector/InspectorController.cpp:178 #14 0x0000000102d664a5 in WebCore::InspectorController::~InspectorController (this=0x7fcb05b9acf0) at /Users/antti/webkit/OpenSource/Source/WebCore/inspector/InspectorController.cpp:173 #15 0x00000001034d28fa in WTF::deleteOwnedPtr<WebCore::InspectorController> (ptr=0x7fcb05b9acf0) at OwnPtrCommon.h:56 #16 0x00000001034d28c8 in WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr (this=0x7fcb0415f258) at OwnPtr.h:55 #17 0x00000001034cd395 in WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr (this=0x7fcb0415f258) at OwnPtr.h:55 #18 0x00000001034c89d8 in WebCore::Page::~Page (this=0x7fcb0415f200) at /Users/antti/webkit/OpenSource/Source/WebCore/page/Page.cpp:214 #19 0x00000001034c8715 in WebCore::Page::~Page (this=0x7fcb0415f200) at /Users/antti/webkit/OpenSource/Source/WebCore/page/Page.cpp:187 #20 0x0000000101ea3dfc in -[WebView(WebPrivate) _close] (self=0x7fcb05bc5a70, _cmd=0x7fff92a3fd13) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebView/WebView.mm:1122 #21 0x0000000101eb0a2b in -[WebView close] (self=0x7fcb05bc5a70, _cmd=0x7fff929c6d8f) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebView/WebView.mm:3408 #22 0x0000000101e2fd7c in -[WebInspectorWindowController destroyInspectorView:] (self=0x7fcb0885cd30, _cmd=0x7fff91c950c0, notifyInspectorController=false) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:514 #23 0x0000000101e2e610 in WebInspectorFrontendClient::disconnectFromBackend (this=0x7fcb033b2d90) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:213 #24 0x0000000101e2dda6 in WebInspectorClient::closeInspectorFrontend (this=0x7fcb02463d90) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:112 #25 0x0000000102d66cf1 in WebCore::InspectorController::close (this=0x7fcb0245d120) at /Users/antti/webkit/OpenSource/Source/WebCore/inspector/InspectorController.cpp:280 #26 0x0000000101e2d23b in -[WebInspector close:] (self=0x7fcb0245c870, _cmd=0x7fff929efe49, sender=0x0) at /Users/antti/webkit/OpenSource/Source/WebKit/mac/WebInspector/WebInspector.mm:169 #27 0x0000000100dad305 in LayoutTestController::closeWebInspector (this=0x7fcb055c0d60) at /Users/antti/webkit/OpenSource/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:891 #28 0x0000000100d7cbcd in runTest (testPathOrURL=@0x7fff5ee9b270) at /Users/antti/webkit/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1393 #29 0x0000000100d7b0ea in runTestingServerLoop () at /Users/antti/webkit/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:829 #30 0x0000000100d7a97a in dumpRenderTree (argc=2, argv=0x7fff5ee9bc68) at /Users/antti/webkit/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:875 #31 0x0000000100d7cfe9 in main (argc=2, argv=0x7fff5ee9bc68) at /Users/antti/webkit/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:913 684438 1 155855 koivisto 2012-08-01 12:05:29 -0700 Created attachment 155855 patch 684500 2 155867 koivisto 2012-08-01 13:08:38 -0700 Created attachment 155867 better patch 684509 3 koivisto 2012-08-01 13:19:09 -0700 http://trac.webkit.org/changeset/124360 155855 2012-08-01 12:05:29 -0700 2012-08-01 13:08:38 -0700 patch inspector-webview.patch text/plain 1383 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDM1MikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTAx ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24g ZmFpbHVyZSBpbiBpbnNwZWN0b3IvcHJvZmlsZXIvaGVhcC1zbmFwc2hvdC1jb250YWlubWVudC1z aG93LWFsbC5odG1sIG9uIExpb24gYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Mjg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFByb3RlY3QgdGhlIFdlYlZpZXcgc28gaXQgZG9lc24ndCBnZXQgZGVz dHJveWVkIGR1cmluZyBbV2ViVmlldyBjbG9zZV0gd2hpY2ggaXMgbm90IHNhZmUuCisKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW06CisgICAgICAgICgtW1dl Ykluc3BlY3RvcldpbmRvd0NvbnRyb2xsZXIgZGVzdHJveUluc3BlY3RvclZpZXc6XSk6CisKIDIw MTItMDctMjkgIFJpayBDYWJhbmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KIAogICAgICAgICBB ZGQgRU5BQkxFX0NTU19DT01QT1NJVElORyBmbGFnCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9X ZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCShyZXZpc2lv biAxMjQzMDUpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0 b3JDbGllbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTUxMSw2ICs1MTEsOCBAQCAtICh2b2lkKWRl c3Ryb3lJbnNwZWN0b3JWaWV3Oihib29sKW5vdGlmCiAgICAgICAgICAgICBpbnNwZWN0ZWRQYWdl LT5pbnNwZWN0b3JDb250cm9sbGVyKCktPmRpc2Nvbm5lY3RGcm9udGVuZCgpOwogICAgIH0KIAor ICAgIC8vIFtXZWJWaWV3IGNsb3NlXSBtYXkgZW5kIHVwIGRlYWxsb2NhdGluZyB0aGUgdmlldyBh cyB0aGUgaW5zcGVjdG9yIHBhZ2UgaW5kaXJlY3RseSBob2xkcyB0aGUgbGFzdCByZWZlcmVuY2Uu CisgICAgUmV0YWluUHRyPFdlYlZpZXc+IHByb3RlY3QoX3dlYlZpZXcpOwogICAgIFtfd2ViVmll dyBjbG9zZV07CiB9CiAK 155867 2012-08-01 13:08:38 -0700 2012-08-01 13:19:27 -0700 better patch inspector-webview-2.patch text/plain 1283 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDM1MikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTAx ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24g ZmFpbHVyZSBpbiBpbnNwZWN0b3IvcHJvZmlsZXIvaGVhcC1zbmFwc2hvdC1jb250YWlubWVudC1z aG93LWFsbC5odG1sIG9uIExpb24gYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Mjg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xp bmcuCisKKyAgICAgICAgUHJvdGVjdCB0aGUgV2ViVmlldyBzbyBpdCBkb2Vzbid0IGdldCBkZXN0 cm95ZWQgZHVyaW5nIFtXZWJWaWV3IGNsb3NlXSB3aGljaCBpcyBub3Qgc2FmZS4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbToKKyAgICAgICAgKC1bV2Vi SW5zcGVjdG9yV2luZG93Q29udHJvbGxlciBkZXN0cm95SW5zcGVjdG9yVmlldzpdKToKKwogMjAx Mi0wNy0yOSAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgogCiAgICAgICAgIEFk ZCBFTkFCTEVfQ1NTX0NPTVBPU0lUSU5HIGZsYWcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dl YkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0JKHJldmlzaW9u IDEyNDMwNSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5tbQkod29ya2luZyBjb3B5KQpAQCAtNTExLDYgKzUxMSw3IEBAIC0gKHZvaWQpZGVz dHJveUluc3BlY3RvclZpZXc6KGJvb2wpbm90aWYKICAgICAgICAgICAgIGluc3BlY3RlZFBhZ2Ut Pmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ZGlzY29ubmVjdEZyb250ZW5kKCk7CiAgICAgfQogCisg ICAgUmV0YWluUHRyPFdlYkluc3BlY3RvcldpbmRvd0NvbnRyb2xsZXI+IHByb3RlY3Qoc2VsZik7 CiAgICAgW193ZWJWaWV3IGNsb3NlXTsKIH0KIAo=