92880 2012-08-01 10:14:28 -0700 Remove code duplication in determining if display is inline or replaced 2012-08-01 13:47:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth eric jchaffraix webkit.review.bot oldest_to_newest 684269 0 ojan 2012-08-01 10:14:28 -0700 Remove code duplication in determining if display is inline or replaced 684270 1 155827 ojan 2012-08-01 10:15:49 -0700 Created attachment 155827 Patch 684365 2 155827 jchaffraix 2012-08-01 11:28:25 -0700 Comment on attachment 155827 Patch r=me 684538 3 155827 webkit.review.bot 2012-08-01 13:47:26 -0700 Comment on attachment 155827 Patch Clearing flags on attachment: 155827 Committed r124364: <http://trac.webkit.org/changeset/124364> 684539 4 webkit.review.bot 2012-08-01 13:47:30 -0700 All reviewed patches have been landed. Closing bug. 155827 2012-08-01 10:15:49 -0700 2012-08-01 13:47:26 -0700 Patch bug-92880-20120801101531.patch text/plain 2943 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWMxNzQ1Mzk2YjUzYjFm YjU3YThiMzA1YWU5NzcwNDU2MjA0ZmVmYi4uZjZhNjgwY2MzMWMyMDE1MzVlMjcyMDA3MjBhMWJm MGE4MTZlZjI2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTAxICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGNvZGUgZHVwbGlj YXRpb24gaW4gZGV0ZXJtaW5pbmcgaWYgZGlzcGxheSBpcyBpbmxpbmUgb3IgcmVwbGFjZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVkdXBsaWNhdGUg bGlzdHMgb2YgZGlzcGxheSB0eXBlcyBieSB1c2luZyBwcml2YXRlIGhlbHBlcnMuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKwogMjAxMi0wOC0wMSAgVnNldm9sb2QgVmxhc292 ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDcmFzaGVz IGluIE5ldHdvcmtSZXNvdXJjZXNEYXRhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5 bGUvUmVuZGVyU3R5bGUuaAppbmRleCA1N2IxOTVmMWEzMGRlOTFlMTZjMDg3OGM1MjVjODdlMzg4 NzY4NTlkLi43MWVjZjAyOGYxMTNmYjA5ZDUzNDQ5OTIwNjBhN2E5YmM1ZmMwNWMyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApAQCAtMTQ4MywyMiAr MTQ4Myw5IEBAIHB1YmxpYzoKIAogICAgIFN0eWxlRGlmZmVyZW5jZSBkaWZmKGNvbnN0IFJlbmRl clN0eWxlKiwgdW5zaWduZWQmIGNoYW5nZWRDb250ZXh0U2Vuc2l0aXZlUHJvcGVydGllcykgY29u c3Q7CiAKLSAgICBib29sIGlzRGlzcGxheVJlcGxhY2VkVHlwZSgpIGNvbnN0Ci0gICAgewotICAg ICAgICByZXR1cm4gZGlzcGxheSgpID09IElOTElORV9CTE9DSyB8fCBkaXNwbGF5KCkgPT0gSU5M SU5FX0JPWCB8fCBkaXNwbGF5KCkgPT0gSU5MSU5FX1RBQkxFIHx8IGRpc3BsYXkoKSA9PSBJTkxJ TkVfR1JJRDsKLSAgICB9Ci0KLSAgICBib29sIGlzRGlzcGxheUlubGluZVR5cGUoKSBjb25zdAot ICAgIHsKLSAgICAgICAgcmV0dXJuIGRpc3BsYXkoKSA9PSBJTkxJTkUgfHwgaXNEaXNwbGF5UmVw bGFjZWRUeXBlKCk7Ci0gICAgfQotCi0gICAgYm9vbCBpc09yaWdpbmFsRGlzcGxheUlubGluZVR5 cGUoKSBjb25zdAotICAgIHsKLSAgICAgICAgcmV0dXJuIG9yaWdpbmFsRGlzcGxheSgpID09IElO TElORSB8fCBvcmlnaW5hbERpc3BsYXkoKSA9PSBJTkxJTkVfQkxPQ0sKLSAgICAgICAgICAgIHx8 IG9yaWdpbmFsRGlzcGxheSgpID09IElOTElORV9CT1ggfHwgb3JpZ2luYWxEaXNwbGF5KCkgPT0g SU5MSU5FX1RBQkxFIHx8IG9yaWdpbmFsRGlzcGxheSgpID09IElOTElORV9HUklEOwotICAgIH0K LQorICAgIGJvb2wgaXNEaXNwbGF5UmVwbGFjZWRUeXBlKCkgY29uc3QgeyByZXR1cm4gaXNEaXNw bGF5UmVwbGFjZWRUeXBlKGRpc3BsYXkoKSk7IH0KKyAgICBib29sIGlzRGlzcGxheUlubGluZVR5 cGUoKSBjb25zdCB7IHJldHVybiBpc0Rpc3BsYXlJbmxpbmVUeXBlKGRpc3BsYXkoKSk7IH0KKyAg ICBib29sIGlzT3JpZ2luYWxEaXNwbGF5SW5saW5lVHlwZSgpIGNvbnN0IHsgcmV0dXJuIGlzRGlz cGxheUlubGluZVR5cGUob3JpZ2luYWxEaXNwbGF5KCkpOyB9CiAgICAgYm9vbCBpc0Rpc3BsYXlS ZWdpb25UeXBlKCkgY29uc3QKICAgICB7CiAgICAgICAgIHJldHVybiBkaXNwbGF5KCkgPT0gQkxP Q0sgfHwgZGlzcGxheSgpID09IElOTElORV9CTE9DSwpAQCAtMTc0OCw2ICsxNzM1LDE2IEBAIHBy aXZhdGU6CiAgICAgICAgIHJldHVybiBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gZ2V0U2hh ZG93VmVydGljYWxFeHRlbnQoc2hhZG93LCBsb2dpY2FsVG9wLCBsb2dpY2FsQm90dG9tKSA6IGdl dFNoYWRvd0hvcml6b250YWxFeHRlbnQoc2hhZG93LCBsb2dpY2FsVG9wLCBsb2dpY2FsQm90dG9t KTsKICAgICB9CiAKKyAgICBib29sIGlzRGlzcGxheVJlcGxhY2VkVHlwZShFRGlzcGxheSBkaXNw bGF5KSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGRpc3BsYXkgPT0gSU5MSU5FX0JMT0NL IHx8IGRpc3BsYXkgPT0gSU5MSU5FX0JPWCB8fCBkaXNwbGF5ID09IElOTElORV9UQUJMRSB8fCBk aXNwbGF5ID09IElOTElORV9HUklEOworICAgIH0KKworICAgIGJvb2wgaXNEaXNwbGF5SW5saW5l VHlwZShFRGlzcGxheSBkaXNwbGF5KSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGRpc3Bs YXkgPT0gSU5MSU5FIHx8IGlzRGlzcGxheVJlcGxhY2VkVHlwZShkaXNwbGF5KTsKKyAgICB9CisK ICAgICAvLyBDb2xvciBhY2Nlc3NvcnMgYXJlIGFsbCBwcml2YXRlIHRvIG1ha2Ugc3VyZSBjYWxs ZXJzIHVzZSB2aXNpdGVkRGVwZW5kZW50Q29sb3IgaW5zdGVhZCB0byBhY2Nlc3MgdGhlbS4KICAg ICBDb2xvciBpbnZhbGlkQ29sb3IoKSBjb25zdCB7IHN0YXRpYyBDb2xvciBpbnZhbGlkOyByZXR1 cm4gaW52YWxpZDsgfQogICAgIENvbG9yIGJvcmRlckxlZnRDb2xvcigpIGNvbnN0IHsgcmV0dXJu IHN1cnJvdW5kLT5ib3JkZXIubGVmdCgpLmNvbG9yKCk7IH0K