92876 2012-08-01 09:41:01 -0700 keyring.get_password may raise an exception. 2012-08-01 10:48:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier dpranke webkit.review.bot oldest_to_newest 684249 0 a.renevier 2012-08-01 09:41:01 -0700 Hi, when using gnome keyring, the method get_password may raise an IOError exception. One workaround is to wrap self._keyring.get_password in a try catch. May be we can also wrap set_password in a try/catch also 684253 1 155824 a.renevier 2012-08-01 09:46:27 -0700 Created attachment 155824 patch proposal In this patch, I catch all exception, (not IOError only), just to be safe 684307 2 155824 webkit.review.bot 2012-08-01 10:48:24 -0700 Comment on attachment 155824 patch proposal Clearing flags on attachment: 155824 Committed r124343: <http://trac.webkit.org/changeset/124343> 684308 3 webkit.review.bot 2012-08-01 10:48:27 -0700 All reviewed patches have been landed. Closing bug. 155824 2012-08-01 09:46:27 -0700 2012-08-01 10:48:24 -0700 patch proposal bug-92876-20120801094609.patch text/plain 2163 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzc4MzE4YmM5NjY5ZGY0ZmQyYTZmNDg0MTY1NTQxY2M2 NmVmYzBiZC4uOTFlMmFmNDdhMWFjY2ZjYzMyNmRiMzk3NjlhMzc3ZGU4YTA4MTM4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA4LTAxICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAga2V5cmluZy5nZXRfcGFzc3dvcmQgbWF5IHJhaXNlIGFuIGV4Y2Vw dGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTky ODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAga2V5 cmluZy5nZXRfcGFzc3dvcmQgc29tZXRpbWVzIHJhaXNlcyBhbiBleGNlcHRpb24uIFdlIHdyYXAg dGhpcyBjYWxsLAorICAgICAgICBhbmQgYWxzbyBzZXRfcGFzc3dvcmQgdG8gYXZvaWQgYnJlYWtp bmcgd2Via2l0LXBhdGNoIGluIHRoYXQgY2FzZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9jcmVkZW50aWFscy5weToKKyAgICAgICAgKENyZWRlbnRpYWxzLl9vZmZl cl90b19zdG9yZV9jcmVkZW50aWFsc19pbl9rZXlyaW5nKToKKyAgICAgICAgKENyZWRlbnRpYWxz LnJlYWRfY3JlZGVudGlhbHMpOgorCiAyMDEyLTA3LTMxICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5yd3Q6IHJlbmFtZSB3b3JrZXIucHkgdG8gbGF5b3V0 X3Rlc3RfcnVubmVyLnB5CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9uZXQvY3JlZGVudGlhbHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv Y3JlZGVudGlhbHMucHkKaW5kZXggMTFiN2FjNzVkODZmZjZkMjM3OGVmMzBmMDNjMjhkOGYzZGU5 MGVjNi4uMjFhZWFlYWZlNjJkZTVlMGU3NGMxNzg5Y2NkYzJjNGUxN2MwZGUwNCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2NyZWRlbnRpYWxzLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9jcmVkZW50aWFscy5weQpAQCAtMTMx LDcgKzEzMSwxMCBAQCBjbGFzcyBDcmVkZW50aWFscyhvYmplY3QpOgogICAgICAgICAgICAgcmV0 dXJuCiAgICAgICAgIGlmIG5vdCBVc2VyKCkuY29uZmlybSgiU3RvcmUgcGFzc3dvcmQgaW4gc3lz dGVtIGtleXJpbmc/IiwgVXNlci5ERUZBVUxUX05PKToKICAgICAgICAgICAgIHJldHVybgotICAg ICAgICBzZWxmLl9rZXlyaW5nLnNldF9wYXNzd29yZChzZWxmLmhvc3QsIHVzZXJuYW1lLCBwYXNz d29yZCkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgc2VsZi5fa2V5cmluZy5zZXRfcGFzc3dv cmQoc2VsZi5ob3N0LCB1c2VybmFtZSwgcGFzc3dvcmQpCisgICAgICAgIGV4Y2VwdDoKKyAgICAg ICAgICAgIHBhc3MKIAogICAgIGRlZiByZWFkX2NyZWRlbnRpYWxzKHNlbGYsIHVzZXI9VXNlcik6 CiAgICAgICAgIHVzZXJuYW1lLCBwYXNzd29yZCA9IHNlbGYuX2NyZWRlbnRpYWxzX2Zyb21fZW52 aXJvbm1lbnQoKQpAQCAtMTQ2LDcgKzE0OSwxMCBAQCBjbGFzcyBDcmVkZW50aWFscyhvYmplY3Qp OgogICAgICAgICAgICAgdXNlcm5hbWUgPSB1c2VyLnByb21wdCgiJXMgbG9naW46ICIgJSBzZWxm Lmhvc3QpCiAKICAgICAgICAgaWYgdXNlcm5hbWUgYW5kIG5vdCBwYXNzd29yZCBhbmQgc2VsZi5f a2V5cmluZzoKLSAgICAgICAgICAgIHBhc3N3b3JkID0gc2VsZi5fa2V5cmluZy5nZXRfcGFzc3dv cmQoc2VsZi5ob3N0LCB1c2VybmFtZSkKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAg ICBwYXNzd29yZCA9IHNlbGYuX2tleXJpbmcuZ2V0X3Bhc3N3b3JkKHNlbGYuaG9zdCwgdXNlcm5h bWUpCisgICAgICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICAgICAgcGFzcwogCiAgICAgICAg IGlmIG5vdCBwYXNzd29yZDoKICAgICAgICAgICAgIHBhc3N3b3JkID0gdXNlci5wcm9tcHRfcGFz c3dvcmQoIiVzIHBhc3N3b3JkIGZvciAlczogIiAlIChzZWxmLmhvc3QsIHVzZXJuYW1lKSkK