92851 2012-08-01 01:08:17 -0700 Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API 2012-08-01 05:24:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 76257 1 paroga paroga morrita webkit.review.bot oldest_to_newest 683964 0 paroga 2012-08-01 01:08:17 -0700 Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API 683968 1 155744 paroga 2012-08-01 01:12:28 -0700 Created attachment 155744 Patch 684014 2 155744 morrita 2012-08-01 02:22:47 -0700 Comment on attachment 155744 Patch Looks good. By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate patch in some timing? I'm sorry that my suggestion there was wrong... 684017 3 paroga 2012-08-01 02:26:26 -0700 (In reply to comment #2) > (From update of attachment 155744 [details]) > Looks good. > > By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate > patch in some timing? I'm sorry that my suggestion there was wrong... I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-) 684027 4 morrita 2012-08-01 02:36:36 -0700 > I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-) Sounds good :-) 684102 5 155744 webkit.review.bot 2012-08-01 05:24:10 -0700 Comment on attachment 155744 Patch Clearing flags on attachment: 155744 Committed r124328: <http://trac.webkit.org/changeset/124328> 684103 6 webkit.review.bot 2012-08-01 05:24:13 -0700 All reviewed patches have been landed. Closing bug. 155744 2012-08-01 01:12:28 -0700 2012-08-01 05:24:10 -0700 Patch bug-92851.patch text/plain 1226 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggODQyZDcwMS4uYWNmNWViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOC0wMSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBFeHBvcnQg U3RyaW5nSW1wbDo6c2l6ZUluQnl0ZXMoKSB3aXRoIFdURl9FWFBPUlRfU1RSSU5HX0FQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI4NTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMTI0MDY5IG1pc3Nl ZCB0byBjaGFuZ2Ugb25lIGV4cG9ydCBtYWNybywgd2hpY2ggaXMgbmVlZGVkCisgICAgICAgIHRv IG1ha2UgdGhlIHdpbmRvd3MgcG9ydCB3aXRoIFVTRShFWFBPUlRfTUFDUk9TKS4KKworICAgICAg ICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAgICAgKFN0cmluZ0ltcGwpOgorCiAyMDEy LTA3LTMxICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29t PgogCiAgICAgICAgIEFkZCBhIG1lY2hhbmlzbSB0byBkdW1wIHRoZSBzdGFjayB0cmFjZSBpbiBj YXNlIG9mIGEgY3Jhc2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1w bC5oIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggOGUyMzI3Zi4uMzk0 YzQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKQEAgLTM4NSw3ICszODUsNyBAQCBwdWJs aWM6CiAgICAgICAgIHJldHVybiBtX2xlbmd0aDsKICAgICB9CiAKLSAgICBXVEZfRVhQT1JUX1BS SVZBVEUgc2l6ZV90IHNpemVJbkJ5dGVzKCkgY29uc3Q7CisgICAgV1RGX0VYUE9SVF9TVFJJTkdf QVBJIHNpemVfdCBzaXplSW5CeXRlcygpIGNvbnN0OwogCiAgICAgYm9vbCBoYXMxNkJpdFNoYWRv dygpIGNvbnN0IHsgcmV0dXJuIG1faGFzaEFuZEZsYWdzICYgc19oYXNoRmxhZ0hhczE2Qml0U2hh ZG93OyB9CiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHZvaWQgdXBjb252ZXJ0Q2hhcmFjdGVy cyh1bnNpZ25lZCwgdW5zaWduZWQpIGNvbnN0Owo=