92848 2012-08-01 00:59:18 -0700 Attempt to fix flakiness of color-suggestion-picker-appearance.html 2012-08-01 05:03:30 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 683952 0 keishi 2012-08-01 00:59:18 -0700 We observed console.log bleeding into the next test. 683969 1 155745 keishi 2012-08-01 01:12:30 -0700 Created attachment 155745 Patch 683972 2 155745 tkent 2012-08-01 01:20:18 -0700 Comment on attachment 155745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review > Source/WebCore/ChangeLog:10 > + (ColorPicker.prototype._layout): We put the width and height into > + variables so we don't call window.onresize twice. Why window.onresize is called twice with the current code? 683977 3 keishi 2012-08-01 01:34:35 -0700 (In reply to comment #2) > (From update of attachment 155745 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review > > > Source/WebCore/ChangeLog:10 > > + (ColorPicker.prototype._layout): We put the width and height into > > + variables so we don't call window.onresize twice. > > Why window.onresize is called twice with the current code? My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately. 683981 4 155745 tkent 2012-08-01 01:43:18 -0700 Comment on attachment 155745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review >>> Source/WebCore/ChangeLog:10 >>> + variables so we don't call window.onresize twice. >> >> Why window.onresize is called twice with the current code? > > My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately. I don't think so. Layout doesn't change the window size basically. Did you reproduce the problem locally, and confirmed the fix by this change? 684052 5 keishi 2012-08-01 03:31:22 -0700 (In reply to comment #4) > > My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately. > > I don't think so. Layout doesn't change the window size basically. > Did you reproduce the problem locally, and confirmed the fix by this change? Here is the stack trace. It seems to be true. WebCore::EventHandler::sendResizeEvent() WebCore::FrameView::performPostLayoutTasks() WebCore::FrameView::layout(bool) WebCore::RenderWidget::updateWidgetPosition() WebCore::RenderView::updateWidgetPositions() WebCore::FrameView::performPostLayoutTasks() WebCore::FrameView::layout(bool) WebCore::Document::updateLayout() WebCore::Document::updateLayout() WebCore::Document::updateLayoutIgnorePendingStylesheets() WebCore::Element::offsetHeight() ... 684073 6 tkent 2012-08-01 04:35:25 -0700 So, did you reproduce the problem locally, and confirmed the fix? 684074 7 keishi 2012-08-01 04:36:18 -0700 (In reply to comment #6) > So, did you reproduce the problem locally, and confirmed the fix? Yes, I did. 684076 8 155745 tkent 2012-08-01 04:40:32 -0700 Comment on attachment 155745 Patch ok 684086 9 155745 webkit.review.bot 2012-08-01 05:03:27 -0700 Comment on attachment 155745 Patch Clearing flags on attachment: 155745 Committed r124326: <http://trac.webkit.org/changeset/124326> 684087 10 webkit.review.bot 2012-08-01 05:03:30 -0700 All reviewed patches have been landed. Closing bug. 155745 2012-08-01 01:12:30 -0700 2012-08-01 05:03:26 -0700 Patch bug-92848-20120801171212.patch text/plain 3546 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQxODVkM2E3M2Q0NTg4 NmJiMzNkMDRkYzM3YWRkM2NiZmM3NDJlNi4uOGFmYTkyNjkzMjkxNWIwODFlMmYyYzUwN2I2OTFi MGM1MzczODc3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTAxICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEF0dGVtcHQgdG8gZml4 IGZsYWtpbmVzcyBvZiBjb2xvci1zdWdnZXN0aW9uLXBpY2tlci1hcHBlYXJhbmNlLmh0bWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODQ4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBSZXNvdXJjZXMv Y29sb3JTdWdnZXN0aW9uUGlja2VyLmpzOgorICAgICAgICAoQ29sb3JQaWNrZXIucHJvdG90eXBl Ll9sYXlvdXQpOiBXZSBwdXQgdGhlIHdpZHRoIGFuZCBoZWlnaHQgaW50bworICAgICAgICB2YXJp YWJsZXMgc28gd2UgZG9uJ3QgY2FsbCB3aW5kb3cub25yZXNpemUgdHdpY2UuCisKIDIwMTItMDct MzEgIFZpbmNlbnQgU2NoZWliICA8c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJr aXRSZXF1ZXN0UG9pbnRlckxvY2sgYW5kIHdlYmtpdEV4aXRQb2ludGVyTG9jayBsaW1pdGVkIHRv IHRoZSBzYW1lIGRvY3VtZW50IG9mIGFuIGFjdGl2ZSBQb2ludGVyIGxvY2suCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvY29sb3JTdWdnZXN0aW9uUGlja2VyLmpzIGIvU291 cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NvbG9yU3VnZ2VzdGlvblBpY2tlci5qcwppbmRleCBiZTIw NDg0NTEyNmY2NDJjYWFkYWYzNTRmNjljZjZmMjQxNzY2NWM4Li4yMDQ1MzAxYzkyYzcyMTg3NTM4 OWM0ZmIxNmY4ZmFhZjA5ZWQzZjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJj ZXMvY29sb3JTdWdnZXN0aW9uUGlja2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNl cy9jb2xvclN1Z2dlc3Rpb25QaWNrZXIuanMKQEAgLTE3MSwxMSArMTcxLDEzIEBAIENvbG9yUGlj a2VyLnByb3RvdHlwZS5fbGF5b3V0ID0gZnVuY3Rpb24oKSB7CiAgICAgdmFyIG90aGVyQnV0dG9u ID0gY3JlYXRlRWxlbWVudCgiYnV0dG9uIiwgIm90aGVyLWNvbG9yIiwgdGhpcy5fY29uZmlnLm90 aGVyQ29sb3JMYWJlbCk7CiAgICAgb3RoZXJCdXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2si LCBjaG9vc2VPdGhlckNvbG9yLCBmYWxzZSk7CiAgICAgdGhpcy5fZWxlbWVudC5hcHBlbmRDaGls ZChvdGhlckJ1dHRvbik7CisgICAgdmFyIGVsZW1lbnRXaWR0aCA9IHRoaXMuX2VsZW1lbnQub2Zm c2V0V2lkdGg7CisgICAgdmFyIGVsZW1lbnRIZWlnaHQgPSB0aGlzLl9lbGVtZW50Lm9mZnNldEhl aWdodDsKICAgICBpZiAod2luZG93LmZyYW1lRWxlbWVudCkgewotICAgICAgICB3aW5kb3cuZnJh bWVFbGVtZW50LnN0eWxlLndpZHRoID0gdGhpcy5fZWxlbWVudC5vZmZzZXRXaWR0aCArICJweCI7 Ci0gICAgICAgIHdpbmRvdy5mcmFtZUVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0gdGhpcy5fZWxlbWVu dC5vZmZzZXRIZWlnaHQgKyAicHgiOworICAgICAgICB3aW5kb3cuZnJhbWVFbGVtZW50LnN0eWxl LndpZHRoID0gZWxlbWVudFdpZHRoICsgInB4IjsKKyAgICAgICAgd2luZG93LmZyYW1lRWxlbWVu dC5zdHlsZS5oZWlnaHQgPSBlbGVtZW50SGVpZ2h0ICsgInB4IjsKICAgICB9IGVsc2UgewotICAg ICAgICB3aW5kb3cucmVzaXplVG8odGhpcy5fZWxlbWVudC5vZmZzZXRXaWR0aCwgdGhpcy5fZWxl bWVudC5vZmZzZXRIZWlnaHQpOworICAgICAgICB3aW5kb3cucmVzaXplVG8oZWxlbWVudFdpZHRo LCBlbGVtZW50SGVpZ2h0KTsKICAgICB9CiB9OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTNmNGYxYmY4MzkyNmUxNTQ1 ODViYzk1NGRkMmNjZjg5YTNjNTJhYi4uYTZlNWRlZTk5NjhkNzRmMjYyNmEwZmMxNDlmMWE1OTk2 ZDUzMTM2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTAxICBLZWlzaGkgSGF0dG9y aSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEF0dGVtcHQgdG8gZml4IGZsYWtpbmVz cyBvZiBjb2xvci1zdWdnZXN0aW9uLXBpY2tlci1hcHBlYXJhbmNlLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugb2JzZXJ2ZWQgY29uc29sZS5s b2cgYmxlZWRpbmcgaW50byB0aGUgbmV4dCB0ZXN0LgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vZmFzdC9mb3Jtcy9jb2xvci9jb2xvci1zdWdnZXN0aW9uLXBpY2tlci1hcHBlYXJhbmNl Lmh0bWw6CisKIDIwMTItMDctMzEgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBMYXlvdXQgVGVzdCBtZWRpYS92aWRlby1jdXJyZW50VGltZS1zZXQuaHRt bCBpcyBzdGlsbCBmbGFreQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vZmFzdC9mb3Jtcy9jb2xvci9jb2xvci1zdWdnZXN0aW9uLXBpY2tlci1hcHBlYXJhbmNlLmh0 bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2Zvcm1zL2NvbG9yL2NvbG9y LXN1Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2UuaHRtbAppbmRleCAyZGI3OWZhZmU1OTlkY2U3 N2FiZGIwN2M0N2EyZmU4ZmNhZDA5ZmYzLi43MjJhOGI3ODA0N2ZjZTI3Njg1NmE2ZTQ1MDExZDk0 NWE3ZmRjMjg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0 L2Zvcm1zL2NvbG9yL2NvbG9yLXN1Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2UuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2Zvcm1zL2NvbG9yL2NvbG9yLXN1 Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2UuaHRtbApAQCAtMzQsNyArMzQsNyBAQCBpZiAod2lu ZG93LmV2ZW50U2VuZGVyKQogdmFyIHBpY2tlcldpbmRvdyA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdtb2NrLXBhZ2UtcG9wdXAnKS5jb250ZW50V2luZG93OwogcGlja2VyV2luZG93Lm9ucmVz aXplID0gZnVuY3Rpb24oKSB7CiAgICAgY29uc29sZS5sb2cocGlja2VyV2luZG93LnBhZ2VQb3B1 cENvbnRyb2xsZXIpOwotICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIHNldFRpbWVv dXQoZnVuY3Rpb24oKSB7dGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7fSwgMCk7CiB9CiA8L3Njcmlw dD4KIDwvYm9keT4K