92845 2012-07-31 23:43:47 -0700 Regression(r124135): nrwt: --verbose logging does not work right on windows 2012-08-01 11:59:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 92673 1 tmpsantos tmpsantos abarth dpranke ojan webkit.review.bot zan oldest_to_newest 683917 0 tmpsantos 2012-07-31 23:43:47 -0700 [0/1552] webkit2.messages_unittest.ParsingTest.test_receiver [945/1552] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_verbose erred: Traceback (most recent call last): File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 934, in test_verbose _, _, err, _ = logging_run(['--verbose', '--fully-parallel', '--child-processes', '2', 'passes/text.html', 'passes/image.html'], tests_included=True) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 110, in logging_run res, buildbot_output, regular_output = run_and_capture(port_obj, options, parsed_args, shared_port) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 124, in run_and_capture regular_output=regular_output) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run unexpected_result_count = manager.run(args) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 725, in run interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_names, result_summary, int(self._options.child_processes)) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 638, in _run_tests pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run self.wait() File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 130, in wait self._loop(block=True) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 182, in _loop method(message.src, *message.args) File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 161, in _handle_worker_exception raise WorkerException(str(exception_value)) WorkerException: [Errno 2] No such file or directory: '/tmp/layout-test-results/tests_run1.txt' Ran 1552 tests in 6.899s FAILED (failures=0, errors=1) 684041 1 155768 tmpsantos 2012-08-01 03:11:27 -0700 Created attachment 155768 Patch 684043 2 tmpsantos 2012-08-01 03:13:35 -0700 (In reply to comment #1) > Created an attachment (id=155768) [details] > Patch I wrote some details about why this test is failing on the changelog. If you cannot reproduce the failure is probably because you have the directory /tmp/layout-test-results/ created at your system. 684209 3 155768 dpranke 2012-08-01 08:56:06 -0700 Comment on attachment 155768 Patch Nope, this tests the opposite of what it needs to test (which is that --verbose propagates to the subprocess). I should add a comment to that effect. We'll have to fix the results_dir problem differently. 684210 4 dpranke 2012-08-01 08:57:35 -0700 One workaround is to create the results_directory using fs.maybe_make_directory() right before we create the file. This isn't a good solution because the test shouldn't be modifying the filesystem, but it would work. Another solution is to just disable the test for now (e.g., change the name to disabled_test_verbose). 684218 5 tmpsantos 2012-08-01 09:04:22 -0700 (In reply to comment #4) > One workaround is to create the results_directory using fs.maybe_make_directory() right before we create the file. > > This isn't a good solution because the test shouldn't be modifying the filesystem, but it would work. > > Another solution is to just disable the test for now (e.g., change the name to disabled_test_verbose). In this case I agree, it wasn't really clear to me what was being tested. Judging by the original patch I thought it was just validating --verbose (that was previously not working on Windows). Going to update the patch. Thanks for reviewing. 684234 6 155820 tmpsantos 2012-08-01 09:32:05 -0700 Created attachment 155820 Patch Creating the folder might work for *nix but since it relies on the default_results_directory() provided by the MockPort, it wont scale to Windows. This patch disables the test until we find a better solution. 684310 7 155820 webkit.review.bot 2012-08-01 10:50:12 -0700 Comment on attachment 155820 Patch Clearing flags on attachment: 155820 Committed r124344: <http://trac.webkit.org/changeset/124344> 684311 8 webkit.review.bot 2012-08-01 10:50:17 -0700 All reviewed patches have been landed. Closing bug. 684424 9 dpranke 2012-08-01 11:59:40 -0700 re-enabling the test in bug 92894. 155768 2012-08-01 03:11:27 -0700 2012-08-01 09:31:53 -0700 Patch bug-92845-20120801131109.patch text/plain 2402 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGU2ZTAxMGUzMTdjOGZmMjFiZTgyZWM4NGE5ZTAyNGMy ZjY2NTM4ZS4uZWQ5M2FkMzdlYzJhZTJlNDdhNmVjMDNmZDU3NzE3YzkyOTM2NWVkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA4LTAxICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjEyNDEzNSk6IG5yd3Q6IC0tdmVyYm9z ZSBsb2dnaW5nIGRvZXMgbm90IHdvcmsgcmlnaHQgb24gd2luZG93cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI4NDUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2luZyBtb3JlIHRoYW4gb25lIHdvcmtl ciB3aWxsIGNoZWNrIGlmIHRoZSBob3N0IGlzIHBpY2thYmxlIGFuZAorICAgICAgICBzaW5jZSBp dCBpcyBub3QsIGl0IHdpbGwgY3JlYXRlIGEgV29ya2VyIHRocmVhZCB3aXRoIG5vIGhvc3QuIFRo ZQorICAgICAgICBXb3JrZXIgdGhlbiBpbnN0YW50aWF0ZXMgaXQncyBvd24gSG9zdCgpIGluc3Rl YWQgb2YgdXNpbmcgdGhlCisgICAgICAgIE1vY2tIb3N0IGFuZCB3aWxsIHRyeSB0byB1c2UgdGhl IHJlYWwgZmlsZXN5c3RlbS4gVGhlIGVhc3kgZml4IGlzIGp1c3QKKyAgICAgICAgdXNlIGEgc2lu Z2xlIHdvcmtlciBhdCB0aGlzIHRlc3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weToKKyAgICAgICAg KE1haW5UZXN0LnRlc3RfdmVyYm9zZSk6CisKIDIwMTItMDctMzEgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgbnJ3dDogbW92ZSBhY3R1YWwgdGVzdC1ydW5u aW5nIGNvZGUgaW50byBsYXlvdXRfdGVzdF9ydW5uZXIucHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKaW5kZXggNmQ0OTE0ZWFmYWFjYTQzN2ZlYWY4MTZiZGJm YjI2YzcwYmRlZTU3NC4uZWM4MDJkMTI3ZWJiYzY5YjlhMzlkOWNjOWIxMGZiMDg2YTBiNmM2NiAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKQEAgLTkyOSwx MSArOTI5LDkgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UsIFN0cmVhbVRlc3Rp bmdNaXhpbik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGxvZ3MsICcnKQogCiAgICAgZGVm IHRlc3RfdmVyYm9zZShzZWxmKToKLSAgICAgICAgIyBOb3RlIHRoYXQgdGhlIHRlc3RzIGZhaWwg YmVjYXVzZSB3ZSBjYW4ndCBwYXNzIGEgbW9jayBob3N0IHRvIHRoZSB3b3JrZXIgcHJvY2Vzc2Vz ICphbmQqCi0gICAgICAgICMgdXNlIG91dHB1dGNhcHR1cmUgdG8gY2FwdHVyZSB0aGUgb3V0cHV0 IChkb2luZyB0aGUgbGF0dGVyIHJlc3VsdHMgaW4gYSBub25waWNrbGFibGUgaG9zdCkuCi0gICAg ICAgIF8sIF8sIGVyciwgXyA9IGxvZ2dpbmdfcnVuKFsnLS12ZXJib3NlJywgJy0tZnVsbHktcGFy YWxsZWwnLCAnLS1jaGlsZC1wcm9jZXNzZXMnLCAnMicsICdwYXNzZXMvdGV4dC5odG1sJywgJ3Bh c3Nlcy9pbWFnZS5odG1sJ10sIHRlc3RzX2luY2x1ZGVkPVRydWUpCi0gICAgICAgIHNlbGYuYXNz ZXJ0VHJ1ZSgndGV4dC5odG1sIGZhaWxlZCcgaW4gZXJyLmdldHZhbHVlKCkpCi0gICAgICAgIHNl bGYuYXNzZXJ0VHJ1ZSgnaW1hZ2UuaHRtbCBmYWlsZWQnIGluIGVyci5nZXR2YWx1ZSgpKQorICAg ICAgICBfLCBvdXQsIGVyciwgXyA9IGxvZ2dpbmdfcnVuKFsnLS12ZXJib3NlJywgJ3Bhc3Nlcy90 ZXh0Lmh0bWwnLCAncGFzc2VzL2ltYWdlLmh0bWwnXSwgdGVzdHNfaW5jbHVkZWQ9VHJ1ZSkKKyAg ICAgICAgc2VsZi5hc3NlcnRUcnVlKCcyLzIgdGVzdHMgcGFzc2VkJyBpbiBvdXQuZ2V0dmFsdWUo KSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdBbGwgMiB0ZXN0cyByYW4gYXMgZXhwZWN0ZWQu JyBpbiBlcnIuZ2V0dmFsdWUoKSkKIAogCiBjbGFzcyBFbmRUb0VuZFRlc3QodW5pdHRlc3QuVGVz dENhc2UpOgo= 155820 2012-08-01 09:32:05 -0700 2012-08-01 10:50:12 -0700 Patch bug-92845-20120801193414.patch text/plain 1954 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWRlZjc4YTM1NjJjYjkxOTU5MWMzNzdjMWNhYzUzNTdj YmQ5YzI0My4uYjZiYWVmMjVkZGUwN2I3NzFiNTkwMGFkMjRhZmQ5ZGMwNWJiZDI4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA4LTAxICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjEyNDEzNSk6IG5yd3Q6IC0tdmVyYm9z ZSBsb2dnaW5nIGRvZXMgbm90IHdvcmsgcmlnaHQgb24gd2luZG93cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI4NDUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlZCB0aGUgZmFpbGluZyB0ZXN0 LiBUaGUgV29ya2VycyBzcGF3bmVkIGJ5IHRoaXMgdGVzdCBhcmUgdXNpbmcgSG9zdCgpCisgICAg ICAgIGluc3RlYWQgb2YgTW9ja0hvc3QoKSBhbmQgdHJ5aW5nIHRvIGFjY2VzcyB0aGUgcmVhbCBm aWxlc3lzdGVtIGluc3RlYWQgb2YgdGhlCisgICAgICAgIE1vY2tGaWxlc3l0ZW0uCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVn cmF0aW9udGVzdC5weToKKyAgICAgICAgKE1haW5UZXN0LmRpc2FibGVkX3Rlc3RfdmVyYm9zZSk6 CisKIDIwMTItMDgtMDEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjQzMjUuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2lu dGVncmF0aW9udGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CmluZGV4IDZkNDkxNGVhZmFhY2E0Mzdm ZWFmODE2YmRiZmIyNmM3MGJkZWU1NzQuLjNiMjJkODI4ODlhZWU3ZmYzMmY0ZGZlZGI2N2ZjZmI4 ZmU2Y2JhMTUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5 CkBAIC05MjgsNyArOTI4LDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UsIFN0 cmVhbVRlc3RpbmdNaXhpbik6CiAgICAgICAgICMgVGhpcyBpcyBlbXB0eSBiZWNhdXNlIHdlIGRv bid0IGV2ZW4gZ2V0IGEgY2hhbmNlIHRvIGNvbmZpZ3VyZSB0aGUgbG9nZ2VyIGJlZm9yZSBmYWls aW5nLgogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhsb2dzLCAnJykKIAotICAgIGRlZiB0ZXN0 X3ZlcmJvc2Uoc2VsZik6CisgICAgZGVmIGRpc2FibGVkX3Rlc3RfdmVyYm9zZShzZWxmKToKICAg ICAgICAgIyBOb3RlIHRoYXQgdGhlIHRlc3RzIGZhaWwgYmVjYXVzZSB3ZSBjYW4ndCBwYXNzIGEg bW9jayBob3N0IHRvIHRoZSB3b3JrZXIgcHJvY2Vzc2VzICphbmQqCiAgICAgICAgICMgdXNlIG91 dHB1dGNhcHR1cmUgdG8gY2FwdHVyZSB0aGUgb3V0cHV0IChkb2luZyB0aGUgbGF0dGVyIHJlc3Vs dHMgaW4gYSBub25waWNrbGFibGUgaG9zdCkuCiAgICAgICAgIF8sIF8sIGVyciwgXyA9IGxvZ2dp bmdfcnVuKFsnLS12ZXJib3NlJywgJy0tZnVsbHktcGFyYWxsZWwnLCAnLS1jaGlsZC1wcm9jZXNz ZXMnLCAnMicsICdwYXNzZXMvdGV4dC5odG1sJywgJ3Bhc3Nlcy9pbWFnZS5odG1sJ10sIHRlc3Rz X2luY2x1ZGVkPVRydWUpCg==