92807 2012-07-31 16:19:14 -0700 Remove unused method HTMLElementStack::bottom() 2012-07-31 17:52:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul haraken webkit.review.bot oldest_to_newest 683600 0 skyul 2012-07-31 16:19:14 -0700 HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode() in r80231. 683605 1 155667 skyul 2012-07-31 16:21:01 -0700 Created attachment 155667 Patch 683623 2 skyul 2012-07-31 16:33:40 -0700 BTW, r80231 (Bug 48719) seems to be the major source of complexity and irregularity in the HTML parser because HTMLElementStack needs to handle not only Element but also ContainerNode after r80231. I understand this is a necessary evil for performance reasons, but I hope we could lessen the complexity. 683634 3 155667 haraken 2012-07-31 16:46:03 -0700 Comment on attachment 155667 Patch Looks OK 683700 4 155667 webkit.review.bot 2012-07-31 17:52:07 -0700 Comment on attachment 155667 Patch Clearing flags on attachment: 155667 Committed r124277: <http://trac.webkit.org/changeset/124277> 683701 5 webkit.review.bot 2012-07-31 17:52:10 -0700 All reviewed patches have been landed. Closing bug. 155667 2012-07-31 16:21:01 -0700 2012-07-31 17:52:07 -0700 Patch bug-92807-20120801082032.patch text/plain 2119 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDUwNmJhNjM4OGJkNzg0 NWE3NTE4ZDk3YWRjNmUxZTcxOGVhYWI4YS4uNTIzYWIzMjcwYzc5YzE4NWI2N2IyZTk3NGE1Zjhl MTY0ZDdhYjQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA3LTMxICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBtZXRob2QgSFRNTEVsZW1lbnRTdGFjazo6Ym90dG9tKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTEVsZW1lbnRTdGFjazo6Ym90dG9tKCkgd2Fz IHJlcGxhY2VkIHdpdGggSFRNTEVsZW1lbnRTdGFjazo6cm9vdE5vZGUoKQorICAgICAgICBpbiBy ODAyMzEuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2UsIHNvIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suY3BwOgorICAgICAgICAq IGh0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suaDoKKyAgICAgICAgKEhUTUxFbGVtZW50U3Rh Y2spOgorCisyMDEyLTA3LTMxICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+ CisKICAgICAgICAgUmVhZCB0YWcgbmFtZXMgYW5kIGF0dHJpYnV0ZXMgZnJvbSB0aGUgc2F2ZWQg dG9rZW5zIGluIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZyhBdG9taWNIVE1MVG9rZW4q KQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI3MTUK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFj ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmNwcApp bmRleCA0N2U0OWY0MDY1ODZhNzkxYTc2NjcwNzgyNmI3OTY1NzMzOGRiMzc3Li4yMmVkNjA3NDM1 M2Q4ZWJjMTI4YzYwODY1YTQ3YWI0MjE1ZmNmN2UzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmNwcApAQCAtMzkzLDExICszOTMsNiBAQCBIVE1M U3RhY2tJdGVtKiBIVE1MRWxlbWVudFN0YWNrOjpvbmVCZWxvd1RvcCgpIGNvbnN0CiAgICAgcmV0 dXJuIDA7CiB9CiAKLUVsZW1lbnQqIEhUTUxFbGVtZW50U3RhY2s6OmJvdHRvbSgpIGNvbnN0Ci17 Ci0gICAgcmV0dXJuIGh0bWxFbGVtZW50KCk7Ci19Ci0KIHZvaWQgSFRNTEVsZW1lbnRTdGFjazo6 cmVtb3ZlSFRNTEhlYWRFbGVtZW50KEVsZW1lbnQqIGVsZW1lbnQpCiB7CiAgICAgQVNTRVJUKG1f aGVhZEVsZW1lbnQgPT0gZWxlbWVudCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MRWxlbWVudFN0YWNrLmgKaW5kZXggYzQ4YzMwMTRhNzIxM2NhZGEyM2ZmN2YzNzNiMTdiOWRh ZTFlOWQ5OC4uNjIwYzVhMTk0M2VjN2MwYmVhYjU3NDgyNDQ2NmNjNDFmMTc2NGYwNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFjay5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suaApAQCAtMTAwLDcg KzEwMCw2IEBAIHB1YmxpYzoKIAogICAgIEhUTUxTdGFja0l0ZW0qIG9uZUJlbG93VG9wKCkgY29u c3Q7CiAgICAgRWxlbWVudFJlY29yZCogdG9wUmVjb3JkKCkgY29uc3Q7Ci0gICAgRWxlbWVudCog Ym90dG9tKCkgY29uc3Q7CiAgICAgRWxlbWVudFJlY29yZCogZmluZChFbGVtZW50KikgY29uc3Q7 CiAgICAgRWxlbWVudFJlY29yZCogdG9wbW9zdChjb25zdCBBdG9taWNTdHJpbmcmIHRhZ05hbWUp IGNvbnN0OwogCg==