92786 2012-07-31 13:00:53 -0700 [chromium] Hit test points are being clipped by layers that should not clip. 2012-07-31 16:38:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs jamesr webkit.review.bot oldest_to_newest 683408 0 shawnsingh 2012-07-31 13:00:53 -0700 Patch coming soon. When checking if ancestors clip the hit-testing point, we are accidentally checking all layers, instead of only layers that actually clip something. 683412 1 155614 shawnsingh 2012-07-31 13:08:57 -0700 Created attachment 155614 Patch 683489 2 155614 jamesr 2012-07-31 14:37:39 -0700 Comment on attachment 155614 Patch R=me 683629 3 155614 webkit.review.bot 2012-07-31 16:38:56 -0700 Comment on attachment 155614 Patch Clearing flags on attachment: 155614 Committed r124270: <http://trac.webkit.org/changeset/124270> 683630 4 webkit.review.bot 2012-07-31 16:38:59 -0700 All reviewed patches have been landed. Closing bug. 155614 2012-07-31 13:08:57 -0700 2012-07-31 16:38:56 -0700 Patch bug-92786-20120731130840.patch text/plain 6964 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU2MmI3NWZlYjk5ZDM3 Y2Q5ZTcwNGQ2ZTQ5MGE0MmY5MWJiY2JkNi4uZDY5MjdiOWNlNDRjZDQwNGNlZGE0YTFlZDA0ODhh OGM3YzZlZmY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTMxICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g SGl0IHRlc3QgcG9pbnRzIGFyZSBiZWluZyBjbGlwcGVkIGJ5IGxheWVycyB0aGF0IHNob3VsZCBu b3QgY2xpcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI3ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBP biBpbXBsLXNpZGUgaGl0IHRlc3RpbmcgZm9yIGNocm9taXVtIGNvbXBvc2l0b3IsIHdlIGFyZQor ICAgICAgICBhY2NpZGVudGFsbHkgY2hlY2tpbmcgYWxsIGFuY2VzdG9yIGxheWVycyBmb3IgY2xp cHBpbmcsIGluc3RlYWQgb2YKKyAgICAgICAgb25seSBsYXllcnMgdGhhdCBhY3R1YWxseSBjbGlw IHNvbWV0aGluZy4gVGhpcyBwYXRjaCBmaXhlcyBpdC4KKworICAgICAgICBBZGRlZCBuZXcgdW5p dCB0ZXN0IHRoYXQgcmVwcm9kdWNlcyB0aGUgc2NlbmFyaW86CisgICAgICAgICAgQ0NMYXllclRy ZWVIb3N0Q29tbW9uVGVzdC52ZXJpZnlIaXRUZXN0aW5nRm9yTm9uQ2xpcHBpbmdJbnRlcm1lZGlh dGVMYXllcgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0Q29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBvaW50SXNDbGlwcGVkQnlT dXJmYWNlT3JDbGlwUmVjdCk6CisKIDIwMTItMDctMzEgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0u Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTdXBwb3J0IE5lZ290aWF0ZSBhdXRoCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDVkMDc4MTdmMGMxZDJiZDliM2E1MGE4MTczODg3NzZm ZmI5MmEzNTMuLjkyOGE5N2I1Y2JlYzRmNDk1NzZjODIzMDA1OWYxYzYyZjAwYjAwNTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDctMzEgIFNoYXdu IFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBI aXQgdGVzdCBwb2ludHMgYXJlIGJlaW5nIGNsaXBwZWQgYnkgbGF5ZXJzIHRoYXQgc2hvdWxkIG5v dCBjbGlwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 Mjc4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog dGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHA6IGFkZHMgYSB0ZXN0IHdoZXJlIHRo ZQorICAgICAgICAgIGhpdC10ZXN0YWJsZSBsYXllciBkb2VzIG5vdCBvdmVybGFwIGl0cyBwYXJl bnQuIFRoZSBwYXJlbnQgZG9lcworICAgICAgICAgIG5vdCBjbGlwLCBzbyB0aGUgbGF5ZXIgc2hv dWxkIHN0aWxsIGJlIGhpdHRhYmxlLgorCiAyMDEyLTA3LTMxICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTI0MTc5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAKaW5k ZXggMTgzNmY2MzE1MjhlMjgyNmMwNjNjZmFmMjQ5YzU1MmJkZTI3ZGZjMi4uMDA5NDZmNDBmNTYy MmVmNTMxYmExZTI0ODQ2ODJiNGE2ZTgyMGZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVy VHJlZUhvc3RDb21tb24uY3BwCkBAIC05MTgsNyArOTE4LDcgQEAgc3RhdGljIGJvb2wgcG9pbnRJ c0NsaXBwZWRCeVN1cmZhY2VPckNsaXBSZWN0KGNvbnN0IEludFBvaW50JiB2aWV3cG9ydFBvaW50 LCBDQ0wKICAgICAgICAgLy8gTm90ZSB0aGF0IGRyYXdhYmxlQ29udGVudFJlY3RzIGFyZSBhY3R1 YWxseSBpbiB0YXJnZXRTdXJmYWNlIHNwYWNlLCBzbyB0aGUgdHJhbnNmb3JtIHdlCiAgICAgICAg IC8vIGhhdmUgdG8gcHJvdmlkZSBpcyB0aGUgdGFyZ2V0IHN1cmZhY2UncyBzY3JlZW5TcGFjZVRy YW5zZm9ybS4KICAgICAgICAgQ0NMYXllckltcGwqIHJlbmRlclRhcmdldCA9IGN1cnJlbnRMYXll ci0+cmVuZGVyVGFyZ2V0KCk7Ci0gICAgICAgIGlmICghcG9pbnRIaXRzUmVjdCh2aWV3cG9ydFBv aW50LCByZW5kZXJUYXJnZXQtPnJlbmRlclN1cmZhY2UoKS0+c2NyZWVuU3BhY2VUcmFuc2Zvcm0o KSwgY3VycmVudExheWVyLT5kcmF3YWJsZUNvbnRlbnRSZWN0KCkpKQorICAgICAgICBpZiAobGF5 ZXJDbGlwc1N1YnRyZWUoY3VycmVudExheWVyKSAmJiAhcG9pbnRIaXRzUmVjdCh2aWV3cG9ydFBv aW50LCByZW5kZXJUYXJnZXQtPnJlbmRlclN1cmZhY2UoKS0+c2NyZWVuU3BhY2VUcmFuc2Zvcm0o KSwgY3VycmVudExheWVyLT5kcmF3YWJsZUNvbnRlbnRSZWN0KCkpKQogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CiAKICAgICAgICAgY3VycmVudExheWVyID0gY3VycmVudExheWVyLT5wYXJlbnQo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVI b3N0Q29tbW9uVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJU cmVlSG9zdENvbW1vblRlc3QuY3BwCmluZGV4IDllMjQ5ZjJkNzZlYTJkMTYyMTc5N2MzZjUwMDU2 Y2Y2ODlhZTE4N2MuLjNlZDJkNjBlMmM1OTc1NTM2YmZjNGI0NmQ1NDkxM2I2YmE2NTFjZjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29t bW9uVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJl ZUhvc3RDb21tb25UZXN0LmNwcApAQCAtMzAzOSw2ICszMDM5LDcwIEBAIFRFU1QoQ0NMYXllclRy ZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5SGl0VGVzdGluZ0Zvck11bHRpQ2xpcHBlZFJvdGF0ZWRM YXllcikKICAgICBFWFBFQ1RfRVEoMjQ2OCwgcmVzdWx0TGF5ZXItPmlkKCkpOwogfQogCitURVNU KENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JOb25DbGlwcGlu Z0ludGVybWVkaWF0ZUxheWVyKQoreworICAgIC8vIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBoaXQg dGVzdGluZyBjb2RlIGRvZXMgbm90IGFjY2lkZW50YWxseSBjbGlwIHRvIGxheWVyCisgICAgLy8g Ym91bmRzIGZvciBhIGxheWVyIHRoYXQgYWN0dWFsbHkgZG9lcyBub3QgY2xpcC4KKyAgICBEZWJ1 Z1Njb3BlZFNldEltcGxUaHJlYWQgdGhpc1Njb3BlSXNPbkltcGxUaHJlYWQ7CisKKyAgICBXZWJU cmFuc2Zvcm1hdGlvbk1hdHJpeCBpZGVudGl0eU1hdHJpeDsKKyAgICBGbG9hdFBvaW50IGFuY2hv cigwLCAwKTsKKworICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJbXBsOjpj cmVhdGUoMSk7CisgICAgc2V0TGF5ZXJQcm9wZXJ0aWVzRm9yVGVzdGluZyhyb290LmdldCgpLCBp ZGVudGl0eU1hdHJpeCwgaWRlbnRpdHlNYXRyaXgsIGFuY2hvciwgRmxvYXRQb2ludCgwLCAwKSwg SW50U2l6ZSgxMDAsIDEwMCksIGZhbHNlKTsKKworICAgIHsKKyAgICAgICAgT3duUHRyPENDTGF5 ZXJJbXBsPiBpbnRlcm1lZGlhdGVMYXllciA9IENDTGF5ZXJJbXBsOjpjcmVhdGUoMTIzKTsKKyAg ICAgICAgRmxvYXRQb2ludCBwb3NpdGlvbigxMCwgMTApOyAvLyB0aGlzIGxheWVyIGlzIHBvc2l0 aW9uZWQsIGFuZCBoaXQgdGVzdGluZyBzaG91bGQgY29ycmVjdGx5IGtub3cgd2hlcmUgdGhlIGxh eWVyIGlzIGxvY2F0ZWQuCisgICAgICAgIEludFNpemUgYm91bmRzKDUwLCA1MCk7CisgICAgICAg IHNldExheWVyUHJvcGVydGllc0ZvclRlc3RpbmcoaW50ZXJtZWRpYXRlTGF5ZXIuZ2V0KCksIGlk ZW50aXR5TWF0cml4LCBpZGVudGl0eU1hdHJpeCwgYW5jaG9yLCBwb3NpdGlvbiwgYm91bmRzLCBm YWxzZSk7CisgICAgICAgIC8vIFNhbml0eSBjaGVjayB0aGUgaW50ZXJtZWRpYXRlIGxheWVyIHNo b3VsZCBub3QgY2xpcC4KKyAgICAgICAgQVNTRVJUX0ZBTFNFKGludGVybWVkaWF0ZUxheWVyLT5t YXNrc1RvQm91bmRzKCkpOworICAgICAgICBBU1NFUlRfRkFMU0UoaW50ZXJtZWRpYXRlTGF5ZXIt Pm1hc2tMYXllcigpKTsKKworICAgICAgICAvLyBUaGUgY2hpbGQgb2YgdGhlIGludGVybWVkaWF0 ZUxheWVyIGlzIHRyYW5zbGF0ZWQgc28gdGhhdCBpdCBkb2VzIG5vdCBvdmVybGFwIGludGVybWVk aWF0ZUxheWVyIGF0IGFsbC4KKyAgICAgICAgLy8gSWYgY2hpbGQgaXMgaW5jb3JyZWN0bHkgY2xp cHBlZCwgd2Ugd291bGQgbm90IGJlIGFibGUgdG8gaGl0IGl0IHN1Y2Nlc3NmdWxseS4KKyAgICAg ICAgT3duUHRyPENDTGF5ZXJJbXBsPiBjaGlsZCA9IENDTGF5ZXJJbXBsOjpjcmVhdGUoNDU2KTsK KyAgICAgICAgcG9zaXRpb24gPSBGbG9hdFBvaW50KDYwLCA2MCk7IC8vIDcwLCA3MCBpbiBzY3Jl ZW4gc3BhY2UKKyAgICAgICAgYm91bmRzID0gSW50U2l6ZSgyMCwgMjApOworICAgICAgICBzZXRM YXllclByb3BlcnRpZXNGb3JUZXN0aW5nKGNoaWxkLmdldCgpLCBpZGVudGl0eU1hdHJpeCwgaWRl bnRpdHlNYXRyaXgsIGFuY2hvciwgcG9zaXRpb24sIGJvdW5kcywgZmFsc2UpOworICAgICAgICBj aGlsZC0+c2V0RHJhd3NDb250ZW50KHRydWUpOworICAgICAgICBpbnRlcm1lZGlhdGVMYXllci0+ YWRkQ2hpbGQoY2hpbGQucmVsZWFzZSgpKTsKKyAgICAgICAgcm9vdC0+YWRkQ2hpbGQoaW50ZXJt ZWRpYXRlTGF5ZXIucmVsZWFzZSgpKTsKKyAgICB9CisKKyAgICBWZWN0b3I8Q0NMYXllckltcGwq PiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0OworICAgIGludCBkdW1teU1heFRleHR1cmVTaXplID0g NTEyOworICAgIENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6Y2FsY3VsYXRlRHJhd1RyYW5zZm9ybXMo cm9vdC5nZXQoKSwgcm9vdC0+Ym91bmRzKCksIDEsIDAsIGR1bW15TWF4VGV4dHVyZVNpemUsIHJl bmRlclN1cmZhY2VMYXllckxpc3QpOworICAgIENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6Y2FsY3Vs YXRlVmlzaWJsZUFuZFNjaXNzb3JSZWN0cyhyZW5kZXJTdXJmYWNlTGF5ZXJMaXN0LCBGbG9hdFJl Y3QoKSk7IC8vIGVtcHR5IHNjaXNzb3JSZWN0IHdpbGwgaGVscCBlbnN1cmUgd2UncmUgaGl0IHRl c3RpbmcgdGhlIGNvcnJlY3QgcmVjdC4KKworICAgIC8vIFNhbml0eSBjaGVjayB0aGUgc2NlbmFy aW8gd2UganVzdCBjcmVhdGVkLgorICAgIEFTU0VSVF9FUSgxdSwgcmVuZGVyU3VyZmFjZUxheWVy TGlzdC5zaXplKCkpOworICAgIEFTU0VSVF9FUSgxdSwgcm9vdC0+cmVuZGVyU3VyZmFjZSgpLT5s YXllckxpc3QoKS5zaXplKCkpOworICAgIEFTU0VSVF9FUSg0NTYsIHJvb3QtPnJlbmRlclN1cmZh Y2UoKS0+bGF5ZXJMaXN0KClbMF0tPmlkKCkpOworCisgICAgLy8gSGl0IHRlc3RpbmcgZm9yIGEg cG9pbnQgb3V0c2lkZSB0aGUgbGF5ZXIgc2hvdWxkIHJldHVybiBhIG51bGwgcG9pbnRlci4KKyAg ICBJbnRQb2ludCB0ZXN0UG9pbnQoNjksIDY5KTsKKyAgICBDQ0xheWVySW1wbCogcmVzdWx0TGF5 ZXIgPSBDQ0xheWVyVHJlZUhvc3RDb21tb246OmZpbmRMYXllclRoYXRJc0hpdEJ5UG9pbnQodGVz dFBvaW50LCByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KTsKKyAgICBFWFBFQ1RfRkFMU0UocmVzdWx0 TGF5ZXIpOworCisgICAgdGVzdFBvaW50ID0gSW50UG9pbnQoOTEsIDkxKTsKKyAgICByZXN1bHRM YXllciA9IENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6ZmluZExheWVyVGhhdElzSGl0QnlQb2ludCh0 ZXN0UG9pbnQsIHJlbmRlclN1cmZhY2VMYXllckxpc3QpOworICAgIEVYUEVDVF9GQUxTRShyZXN1 bHRMYXllcik7CisKKyAgICAvLyBIaXQgdGVzdGluZyBmb3IgYSBwb2ludCBpbnNpZGUgc2hvdWxk IHJldHVybiB0aGUgY2hpbGQgbGF5ZXIuCisgICAgdGVzdFBvaW50ID0gSW50UG9pbnQoNzEsIDcx KTsKKyAgICByZXN1bHRMYXllciA9IENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6ZmluZExheWVyVGhh dElzSGl0QnlQb2ludCh0ZXN0UG9pbnQsIHJlbmRlclN1cmZhY2VMYXllckxpc3QpOworICAgIEFT U0VSVF9UUlVFKHJlc3VsdExheWVyKTsKKyAgICBFWFBFQ1RfRVEoNDU2LCByZXN1bHRMYXllci0+ aWQoKSk7CisKKyAgICB0ZXN0UG9pbnQgPSBJbnRQb2ludCg4OSwgODkpOworICAgIHJlc3VsdExh eWVyID0gQ0NMYXllclRyZWVIb3N0Q29tbW9uOjpmaW5kTGF5ZXJUaGF0SXNIaXRCeVBvaW50KHRl c3RQb2ludCwgcmVuZGVyU3VyZmFjZUxheWVyTGlzdCk7CisgICAgQVNTRVJUX1RSVUUocmVzdWx0 TGF5ZXIpOworICAgIEVYUEVDVF9FUSg0NTYsIHJlc3VsdExheWVyLT5pZCgpKTsKK30KKworCiBU RVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JNdWx0aXBs ZUxheWVycykKIHsKICAgICBEZWJ1Z1Njb3BlZFNldEltcGxUaHJlYWQgdGhpc1Njb3BlSXNPbklt cGxUaHJlYWQ7Cg==