92779 2012-07-31 11:45:14 -0700 Gesture click test should validate click count in UIEvent.detail 2019-02-06 09:19:15 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rbyers rbyers abarth rjkroege webkit.review.bot oldest_to_newest 683321 0 rbyers 2012-07-31 11:45:14 -0700 As part of adding gesture support for sending the dblclick event (Bug 92412), I noticed the fast/events/touch/gesture/gesture-click.html test wasn't explicitly testing the 'detail' field of the event to verify it's '1' for the generate mousedown/mouseup/click events and '0' for mousemove. See http://www.w3.org/TR/DOM-Level-3-Events/#current-click-count 683405 1 155609 rbyers 2012-07-31 12:58:27 -0700 Created attachment 155609 Patch 684388 2 rjkroege 2012-08-01 11:42:00 -0700 Nice. This looks good to me. abarth@: Could you review? 684503 3 155609 webkit.review.bot 2012-08-01 13:10:36 -0700 Comment on attachment 155609 Patch Clearing flags on attachment: 155609 Committed r124359: <http://trac.webkit.org/changeset/124359> 684504 4 webkit.review.bot 2012-08-01 13:10:40 -0700 All reviewed patches have been landed. Closing bug. 1503343 5 lforschler 2019-02-06 09:19:15 -0800 Mass move bugs into the DOM component. 155609 2012-07-31 12:58:27 -0700 2012-08-01 13:10:35 -0700 Patch bug-92779-20120731155810.patch text/plain 6297 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2QyNzA2ODYzMmU0MGUy MDlmYTAzNTAwZjNhYmMxMjg5ODZmNmM1Ny4uYzQwYTJmODdmYjc5YmUzNWQzYzU2N2U2MzY5NjMw ZmU0ZjQxOTU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTMxICBSaWNr IEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCByZXF1ZXN0IGEg Y2xpY2tDb3VudCBvZiAxIG9uIG1vdXNlTW92ZSBldmVudCBnZW5lcmF0ZWQgYnkgdGFwIGdlc3R1 cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mjc3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1vdXNl bW92ZSBldmVudHMgZG9uJ3QgaGF2ZSBhIGNsaWNrIGNvdW50LCBzbyB3ZSBzaG91bGRuJ3QgYmUg cGFzc2luZyAxCisgICAgICAgIGhlcmUuICBOb3RlIHRoaXMgbWFrZXMgbm8gcmVhbCBkaWZmZXJl bmNlIGluIHByYWN0aWNlIHNpbmNlIHRoZSB2YWx1ZSBpcworICAgICAgICBpZ25vcmVkIC0gZml4 ZWQgc3RyaWN0bHkgZm9yIHBlZGFudGljcy4KKyAgICAgICAgCisgICAgICAgIFRlc3Q6IGZhc3Qv ZXZlbnRzL3RvdWNoL2dlc3R1cmUvZ2VzdHVyZS1jbGljaworCisgICAgICAgICogcGFnZS9FdmVu dEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0 dXJlVGFwKToKKwogMjAxMi0wNy0zMSAgSGFucyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFNwZWVjaCBKYXZhU2NyaXB0IEFQSTogVGhyb3cgZXhjZXB0aW9uIGZvciBz dGFydCgpIHdoZW4gYWxyZWFkeSBzdGFydGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAKaW5kZXggMDYxZDgzMzBmNTY3ZjliYjQwNzI2MWU5ZmJhNDlmMjE2MmMyNGNiOC4uZjU0NmIx YTllYWU0NTdkZjVlZDE5MDM0YzFhMGM3MWFmZmEwYzMyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcApAQCAtMjQ4MCw3ICsyNDgwLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6Omhh bmRsZUdlc3R1cmVUYXAoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkK ICNlbmRpZgogCiAgICAgYm9vbCBkZWZhdWx0UHJldmVudGVkID0gZmFsc2U7Ci0gICAgUGxhdGZv cm1Nb3VzZUV2ZW50IGZha2VNb3VzZU1vdmUoYWRqdXN0ZWRQb2ludCwgZ2VzdHVyZUV2ZW50Lmds b2JhbFBvc2l0aW9uKCksIE5vQnV0dG9uLCBQbGF0Zm9ybUV2ZW50OjpNb3VzZU1vdmVkLCAvKiBj bGlja0NvdW50ICovIDEsIGdlc3R1cmVFdmVudC5zaGlmdEtleSgpLCBnZXN0dXJlRXZlbnQuY3Ry bEtleSgpLCBnZXN0dXJlRXZlbnQuYWx0S2V5KCksIGdlc3R1cmVFdmVudC5tZXRhS2V5KCksIGdl c3R1cmVFdmVudC50aW1lc3RhbXAoKSk7CisgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IGZha2VNb3Vz ZU1vdmUoYWRqdXN0ZWRQb2ludCwgZ2VzdHVyZUV2ZW50Lmdsb2JhbFBvc2l0aW9uKCksIE5vQnV0 dG9uLCBQbGF0Zm9ybUV2ZW50OjpNb3VzZU1vdmVkLCAvKiBjbGlja0NvdW50ICovIDAsIGdlc3R1 cmVFdmVudC5zaGlmdEtleSgpLCBnZXN0dXJlRXZlbnQuY3RybEtleSgpLCBnZXN0dXJlRXZlbnQu YWx0S2V5KCksIGdlc3R1cmVFdmVudC5tZXRhS2V5KCksIGdlc3R1cmVFdmVudC50aW1lc3RhbXAo KSk7CiAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IGZha2VNb3VzZURvd24oYWRqdXN0ZWRQb2ludCwg Z2VzdHVyZUV2ZW50Lmdsb2JhbFBvc2l0aW9uKCksIExlZnRCdXR0b24sIFBsYXRmb3JtRXZlbnQ6 Ok1vdXNlUHJlc3NlZCwgLyogY2xpY2tDb3VudCAqLyAxLCBnZXN0dXJlRXZlbnQuc2hpZnRLZXko KSwgZ2VzdHVyZUV2ZW50LmN0cmxLZXkoKSwgZ2VzdHVyZUV2ZW50LmFsdEtleSgpLCBnZXN0dXJl RXZlbnQubWV0YUtleSgpLCBnZXN0dXJlRXZlbnQudGltZXN0YW1wKCkpOwogICAgIFBsYXRmb3Jt TW91c2VFdmVudCBmYWtlTW91c2VVcChhZGp1c3RlZFBvaW50LCBnZXN0dXJlRXZlbnQuZ2xvYmFs UG9zaXRpb24oKSwgTGVmdEJ1dHRvbiwgUGxhdGZvcm1FdmVudDo6TW91c2VSZWxlYXNlZCwgLyog Y2xpY2tDb3VudCAqLyAxLCBnZXN0dXJlRXZlbnQuc2hpZnRLZXkoKSwgZ2VzdHVyZUV2ZW50LmN0 cmxLZXkoKSwgZ2VzdHVyZUV2ZW50LmFsdEtleSgpLCBnZXN0dXJlRXZlbnQubWV0YUtleSgpLCBn ZXN0dXJlRXZlbnQudGltZXN0YW1wKCkpOwogICAgIG1vdXNlTW92ZWQoZmFrZU1vdXNlTW92ZSk7 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggOTgwYWE1MmIxY2M4ZTQ2YWU5Y2UyMDNjZjk1Y2M1Njc0YzMzNjk2Ny4uOTJlNTEw ZjQ2ZmYxMTA2YTFlNTA2NGY0ZDE5ODBmODFkNDM1NzcxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA3LTMxICBSaWNrIEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KKworICAgICAg ICBNYWtlIEdlc3R1cmUgY2xpY2sgdGVzdCB2YWxpZGF0ZSBjbGljayBjb3VudCBpbiBVSUV2ZW50 LmRldGFpbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI3NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bHNvIHZhbGlkYXRlcyB0aGF0IG5vIGRibGNsaWNrIGV2ZW50IGlzIGZpcmVkIGZvciB0aGlzIHNp bmdsZSBjbGljay4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9nZXN0dXJlL2dlc3R1cmUt Y2xpY2suaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3Vj aC9nZXN0dXJlL2dlc3R1cmUtY2xpY2stZXhwZWN0ZWQudHh0OgorCiAyMDEyLTA3LTMxICBUaGlh Z28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdIEdhcmRlbmluZyBvZiBmYWlsaW5nIHRlc3RzIGFuZCBuZXcgcGFzc2VzCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9nZXN0dXJlL2dlc3R1cmUtY2xpY2su aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2dlc3R1cmUvZ2VzdHVyZS1jbGlj ay5odG1sCmluZGV4IGYyMjE1N2RiYzVlNzI5NjRjM2JhMjBhY2UwYzcxZTBmNWU3NTNjZjAuLjNh OGE5MDk3NmFlOTZiMmUyOTdlNWIxMDYyZjEyNTVmNTViODA0ZGUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2dlc3R1cmUvZ2VzdHVyZS1jbGljay5odG1sCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2dlc3R1cmUvZ2VzdHVyZS1jbGljay5odG1s CkBAIC0xMCwxNiArMTAsMjEgQEAKIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgogCiA8c2NyaXB0 PgotdmFyIGV4cGVjdGVkTW91c2VFdmVudHMgPSA0OwogdmFyIG1vdXNlRXZlbnRzUmVjZWl2ZWQg PSAwOwotdmFyIGV2ZW50VHlwZXMgPSBbICdtb3VzZW1vdmUnLCAnbW91c2Vkb3duJywgJ21vdXNl dXAnLCAnY2xpY2snIF07Cit2YXIgZXhwZWN0ZWRFdmVudHMgPSBbCisgIHsgdHlwZTogJ21vdXNl bW92ZScsIGRldGFpbDogMCB9LAorICB7IHR5cGU6ICdtb3VzZWRvd24nLCBkZXRhaWw6IDEgfSwK KyAgeyB0eXBlOiAnbW91c2V1cCcsIGRldGFpbDogMSB9LAorICB7IHR5cGU6ICdjbGljaycsIGRl dGFpbDogMSB9LAorICBdOwogCiBmdW5jdGlvbiBnZXN0dXJlRXZlbnRDYWxsYmFjayhldmVudCkK IHsKICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICAgIHNob3VsZEJlRXF1YWxU b1N0cmluZygnZXZlbnQudHlwZScsIGV2ZW50VHlwZXNbbW91c2VFdmVudHNSZWNlaXZlZF0pOwor ICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2V2ZW50LnR5cGUnLCBleHBlY3RlZEV2ZW50 c1ttb3VzZUV2ZW50c1JlY2VpdmVkXS50eXBlKTsKICAgICAgICAgc2hvdWxkQmUoJ2V2ZW50LmNs aWVudFgnLCAnMTAnKTsKICAgICAgICAgc2hvdWxkQmUoJ2V2ZW50LmNsaWVudFknLCAnMTInKTsK KyAgICAgICAgc2hvdWxkRXZhbHVhdGVUbygnZXZlbnQuZGV0YWlsJywgZXhwZWN0ZWRFdmVudHNb bW91c2VFdmVudHNSZWNlaXZlZF0uZGV0YWlsKTsKICAgICAgICAgbW91c2VFdmVudHNSZWNlaXZl ZCsrOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGRlYnVnKGV2ZW50LnR5cGUpOwpAQCAtMzYsNyAr NDEsNyBAQCBmdW5jdGlvbiBxdWl0S2V5VG9FbmRUZXN0KGV2ZW50KSB7CiAKIGZ1bmN0aW9uIGVu ZFRlc3QoKQogewotICAgIGlmIChtb3VzZUV2ZW50c1JlY2VpdmVkIDwgZXhwZWN0ZWRNb3VzZUV2 ZW50cykgeworICAgIGlmIChtb3VzZUV2ZW50c1JlY2VpdmVkIDwgZXhwZWN0ZWRFdmVudHMubGVu Z3RoKSB7CiAgICAgICAgIGRlYnVnKCdHZXN0dXJlIG1hbmFnZXIgbm90IGltcGxlbWVudGVkIG9u IHRoaXMgcGxhdGZvcm0uJyk7CiAgICAgfQogICAgIC8vIEJhaWwuCkBAIC00OCw2ICs1Myw3IEBA IGZ1bmN0aW9uIHJ1blRlc3QoKSB7CiAgICAgdmFyIGRpdiA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdnZXN0dXJlJyk7CiAgICAgZGl2LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIsIGdl c3R1cmVFdmVudENhbGxiYWNrLCBmYWxzZSk7CiAgICAgZGl2LmFkZEV2ZW50TGlzdGVuZXIoImNs aWNrIiwgZ2VzdHVyZUV2ZW50Q2FsbGJhY2ssIGZhbHNlKTsKKyAgICBkaXYuYWRkRXZlbnRMaXN0 ZW5lcigiZGJsY2xpY2siLCBnZXN0dXJlRXZlbnRDYWxsYmFjaywgZmFsc2UpOwogICAgIGRpdi5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZXVwIiwgZ2VzdHVyZUV2ZW50Q2FsbGJhY2ssIGZhbHNlKTsK ICAgICBkaXYuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgZ2VzdHVyZUV2ZW50Q2FsbGJh Y2ssIGZhbHNlKTsKICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgcXVp dEtleVRvRW5kVGVzdCwgZmFsc2UpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vZmFzdC9ldmVudHMvdG91Y2gvZ2VzdHVyZS9nZXN0dXJlLWNsaWNrLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL3RvdWNoL2dl c3R1cmUvZ2VzdHVyZS1jbGljay1leHBlY3RlZC50eHQKaW5kZXggNjIyMWRkODYwYmFkY2E2NWUy YmMwMjI0MDI0NDg0NDJiNjFiYTIxMi4uMTQ0Nzg1YjZhYTM1ZDVjMTE0ZWZiZDNmNDEyNzY1YzRk NGQxMDM5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9l dmVudHMvdG91Y2gvZ2VzdHVyZS9nZXN0dXJlLWNsaWNrLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3VjaC9nZXN0dXJlL2dlc3R1 cmUtY2xpY2stZXhwZWN0ZWQudHh0CkBAIC02LDE1ICs2LDE5IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFCiBQQVNTIGV2ZW50LnR5cGUgaXMgIm1vdXNlbW92ZSIKIFBBU1MgZXZlbnQuY2xpZW50 WCBpcyAxMAogUEFTUyBldmVudC5jbGllbnRZIGlzIDEyCitQQVNTIGV2ZW50LmRldGFpbCBpcyAw CiBQQVNTIGV2ZW50LnR5cGUgaXMgIm1vdXNlZG93biIKIFBBU1MgZXZlbnQuY2xpZW50WCBpcyAx MAogUEFTUyBldmVudC5jbGllbnRZIGlzIDEyCitQQVNTIGV2ZW50LmRldGFpbCBpcyAxCiBQQVNT IGV2ZW50LnR5cGUgaXMgIm1vdXNldXAiCiBQQVNTIGV2ZW50LmNsaWVudFggaXMgMTAKIFBBU1Mg ZXZlbnQuY2xpZW50WSBpcyAxMgorUEFTUyBldmVudC5kZXRhaWwgaXMgMQogUEFTUyBldmVudC50 eXBlIGlzICJjbGljayIKIFBBU1MgZXZlbnQuY2xpZW50WCBpcyAxMAogUEFTUyBldmVudC5jbGll bnRZIGlzIDEyCitQQVNTIGV2ZW50LmRldGFpbCBpcyAxCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK