92764 2012-07-31 08:59:18 -0700 [Chromium] Don't use ninja for building Chromium for Android 2012-07-31 10:27:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84843 1 peter peter abarth webkit.review.bot oldest_to_newest 683144 0 peter 2012-07-31 08:59:18 -0700 [Chromium] Don't use ninja for building Chromium for Android 683145 1 155554 peter 2012-07-31 09:00:48 -0700 Created attachment 155554 Patch 683152 2 peter 2012-07-31 09:03:16 -0700 I reverted (and Yaron re-landed) http://crrev.com/148739 on the Chromium side, which enabled creating Ninja project files. This unintentionally switched Android to using the Ninja build, which then broke. We should eventually make the switch, but do so in a controlled and tested manner. 683245 3 155554 webkit.review.bot 2012-07-31 10:27:06 -0700 Comment on attachment 155554 Patch Clearing flags on attachment: 155554 Committed r124219: <http://trac.webkit.org/changeset/124219> 683246 4 webkit.review.bot 2012-07-31 10:27:10 -0700 All reviewed patches have been landed. Closing bug. 155554 2012-07-31 09:00:48 -0700 2012-07-31 10:27:06 -0700 Patch bug-92764-20120731170030.patch text/plain 1616 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGVhZWQ3NTk5ODczMjE1MzI0MGZiYTkwZWE0ZTFlNmE4 OTI0MTBlMy4uYmZlYTMxZmVkOWIzMzFmZTg2NzBmN2ZkZGM4ZjNjOGMxOTI1NDg0MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA3LTMxICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIERvbid0IHVzZSBuaW5qYSBmb3IgYnVpbGRpbmcgQ2hyb21pdW0g Zm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyNzY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiBOaW5qYSBwcm9qZWN0cyBmaWxlcyBhcmUgZ2VuZXJhdGVkICh3aGljaCB3aWxsIGJl IGRvbmUgZm9yIEFuZHJvaWQpLAorICAgICAgICBtYWtlIHN1cmUgdGhhdCB0aGUgQW5kcm9pZCBi dWlsZGVyIGRvZXNuJ3QgdW5pbnRlbnRpb25hbGx5IHN3aXRjaCB0bworICAgICAgICB1c2luZyBO aW5qYS4gV2Ugc2hvdWxkIG1ha2UgdGhhdCBzd2l0Y2ggYXQgYSBwcmVkZXRlcm1pbmVkIHRpbWUu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChidWlsZENocm9t aXVtKToKKwogMjAxMi0wNy0zMSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbY2hyb21pdW1dIG1vdmUgRXZlbnRTZW5kZXIgaW50byBUZXN0UnVubmVy LmEKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQppbmRleCBmODc5M2RmZjM0NDI2NjMwMThjODEzMTgzMmQyYzIxMGYz YjBhYTczLi40MTIxYzY4ZTIwOTA2YzMxMjBiMDM2NGQ0NTkyNDllZjU3ZDY4NGViIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC0yNTg5LDcgKzI1ODksNyBAQCBzdWIgYnVpbGRDaHJvbWl1bSgkQCkKICAg ICB9IGVsc2lmIChpc0N5Z3dpbigpIHx8IGlzV2luZG93cygpKSB7CiAgICAgICAgICMgV2luZG93 cyBidWlsZCAtIGJ1aWxkcyB0aGUgcm9vdCB2aXN1YWwgc3R1ZGlvIHNvbHV0aW9uLgogICAgICAg ICAkcmVzdWx0ID0gYnVpbGRDaHJvbWl1bVZpc3VhbFN0dWRpb1Byb2plY3QoIlNvdXJjZS9XZWJL aXQvY2hyb21pdW0vQWxsLnNsbiIsICRjbGVhbik7Ci0gICAgfSBlbHNpZiAoaXNDaHJvbWl1bU5p bmphKCkpIHsKKyAgICB9IGVsc2lmIChpc0Nocm9taXVtTmluamEoKSAmJiAhaXNDaHJvbWl1bUFu ZHJvaWQoKSkgewogICAgICAgICAkcmVzdWx0ID0gYnVpbGRDaHJvbWl1bU5pbmphKCJhbGwiLCAk Y2xlYW4sIEBvcHRpb25zKTsKICAgICB9IGVsc2lmIChpc0xpbnV4KCkgfHwgaXNDaHJvbWl1bUFu ZHJvaWQoKSB8fCBpc0Nocm9taXVtTWFjTWFrZSgpKSB7CiAgICAgICAgICMgTGludXggYnVpbGQg LSBidWlsZCB1c2luZyBtYWtlLgo=