92757 2012-07-31 08:07:11 -0700 Remove clone() method from FilterOperation (dead code) 2012-07-31 09:10:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco haraken webkit.review.bot oldest_to_newest 683080 0 senorblanco 2012-07-31 08:07:11 -0700 Remove clone() method from FilterOperation (dead code) 683081 1 155541 senorblanco 2012-07-31 08:08:46 -0700 Created attachment 155541 Patch 683092 2 155541 haraken 2012-07-31 08:21:24 -0700 Comment on attachment 155541 Patch Looks OK 683167 3 155541 webkit.review.bot 2012-07-31 09:10:54 -0700 Comment on attachment 155541 Patch Clearing flags on attachment: 155541 Committed r124213: <http://trac.webkit.org/changeset/124213> 683168 4 webkit.review.bot 2012-07-31 09:10:58 -0700 All reviewed patches have been landed. Closing bug. 155541 2012-07-31 08:08:46 -0700 2012-07-31 09:10:54 -0700 Patch bug-92757-20120731110829.patch text/plain 5329 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDIwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTMxICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB0aGUg Y2xvbmUoKSBtZXRob2QgZnJvbSBGaWx0ZXJPcGVyYXRpb24gKGFuZCBzdWJjbGFzc2VzKS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNzU3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgdGhlIG1v dmUgdG8gV2ViRmlsdGVyT3BlcmF0aW9uIGluIENocm9taXVtLCB0aGlzIGlzIG5vdyBkZWFkCisg ICAgICAgIGNvZGUuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cyBpbiBjc3Mz L2ZpbHRlcnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZp bHRlck9wZXJhdGlvbi5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmls dGVyT3BlcmF0aW9uLmg6CisKIDIwMTItMDctMzEgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdl YmtpdC5vcmc+CiAKICAgICAgICAgU2xpZGVyIHRpY2tzIGFyZSBkcmF3biBhdCB3cm9uZyBwb3Np dGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3Vz dG9tRmlsdGVyT3BlcmF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJPcGVyYXRpb24uaAkocmV2aXNpb24gMTI0 MjAwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21G aWx0ZXJPcGVyYXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNjUsMTMgKzY1LDYgQEAgcHVibGlj OgogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEN1c3RvbUZpbHRlck9wZXJhdGlvbihwcm9n cmFtLCBzb3J0ZWRQYXJhbWV0ZXJzLCBtZXNoUm93cywgbWVzaENvbHVtbnMsIG1lc2hCb3hUeXBl LCBtZXNoVHlwZSkpOwogICAgIH0KICAgICAKLSAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8RmlsdGVy T3BlcmF0aW9uPiBjbG9uZSgpIGNvbnN0Ci0gICAgewotICAgICAgICAvLyBTb21lIG1lbWJlciB2 YXJzIChlLmcuLCBtX3Byb2dyYW0pIGFyZSBub3QgdGhyZWFkLXNhZmUsIHNvCi0gICAgICAgIC8v IHdlIGNhbid0IGJlIGNsb25lZC4KLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQotICAgIAogICAg IEN1c3RvbUZpbHRlclByb2dyYW0qIHByb2dyYW0oKSBjb25zdCB7IHJldHVybiBtX3Byb2dyYW0u Z2V0KCk7IH0KICAgICAKICAgICBjb25zdCBDdXN0b21GaWx0ZXJQYXJhbWV0ZXJMaXN0JiBwYXJh bWV0ZXJzKCkgeyByZXR1cm4gbV9wYXJhbWV0ZXJzOyB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9u LmgJKHJldmlzaW9uIDEyNDIwMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTgyLDggKzgyLDYg QEAgcHVibGljOgogICAgIC8vIFRydWUgaWYgdGhlIHRoZSB2YWx1ZSBvZiBvbmUgcGl4ZWwgY2Fu IGFmZmVjdCB0aGUgdmFsdWUgb2YgYW5vdGhlciBwaXhlbCB1bmRlciB0aGlzIG9wZXJhdGlvbiwg c3VjaCBhcyBibHVyLgogICAgIHZpcnR1YWwgYm9vbCBtb3Zlc1BpeGVscygpIGNvbnN0IHsgcmV0 dXJuIGZhbHNlOyB9CiAKLSAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8RmlsdGVyT3BlcmF0aW9uPiBj bG9uZSgpIGNvbnN0ID0gMDsKLQogcHJvdGVjdGVkOgogICAgIEZpbHRlck9wZXJhdGlvbihPcGVy YXRpb25UeXBlIHR5cGUpCiAgICAgICAgIDogbV90eXBlKHR5cGUpCkBAIC0xMDAsMTEgKzk4LDYg QEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IERlZmF1bHRGaWx0ZXJPcGVy YXRpb24odHlwZSkpOwogICAgIH0KIAotICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxGaWx0ZXJPcGVy YXRpb24+IGNsb25lKCkgY29uc3QKLSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcg RGVmYXVsdEZpbHRlck9wZXJhdGlvbihtX3R5cGUpKTsKLSAgICB9Ci0KIHByaXZhdGU6CiAKICAg ICB2aXJ0dWFsIGJvb2wgb3BlcmF0b3I9PShjb25zdCBGaWx0ZXJPcGVyYXRpb24mIG8pIGNvbnN0 CkBAIC0xMjcsMTEgKzEyMCw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5l dyBQYXNzdGhyb3VnaEZpbHRlck9wZXJhdGlvbigpKTsKICAgICB9CiAKLSAgICB2aXJ0dWFsIFBh c3NSZWZQdHI8RmlsdGVyT3BlcmF0aW9uPiBjbG9uZSgpIGNvbnN0Ci0gICAgewotICAgICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFBhc3N0aHJvdWdoRmlsdGVyT3BlcmF0aW9uKCkpOwotICAgIH0K LQogcHJpdmF0ZToKIAogICAgIHZpcnR1YWwgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEZpbHRlck9w ZXJhdGlvbiYgbykgY29uc3QKQEAgLTE1MiwxMiArMTQwLDYgQEAgcHVibGljOgogICAgICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFJlZmVyZW5jZUZpbHRlck9wZXJhdGlvbih1cmwsIGZyYWdtZW50 LCB0eXBlKSk7CiAgICAgfQogCi0gICAgdmlydHVhbCBQYXNzUmVmUHRyPEZpbHRlck9wZXJhdGlv bj4gY2xvbmUoKSBjb25zdAotICAgIHsKLSAgICAgICAgLy8gVW5pbXBsZW1lbnRlZAotICAgICAg ICByZXR1cm4gMDsKLSAgICB9Ci0KICAgICB2aXJ0dWFsIGJvb2wgYWZmZWN0c09wYWNpdHkoKSBj b25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIG1vdmVzUGl4ZWxzKCkgY29u c3QgeyByZXR1cm4gdHJ1ZTsgfQogCkBAIC0xOTksMTEgKzE4MSw2IEBAIHB1YmxpYzoKICAgICAg ICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBCYXNpY0NvbG9yTWF0cml4RmlsdGVyT3BlcmF0aW9uKGFt b3VudCwgdHlwZSkpOwogICAgIH0KIAotICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxGaWx0ZXJPcGVy YXRpb24+IGNsb25lKCkgY29uc3QKLSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcg QmFzaWNDb2xvck1hdHJpeEZpbHRlck9wZXJhdGlvbihtX2Ftb3VudCwgbV90eXBlKSk7Ci0gICAg fQotCiAgICAgZG91YmxlIGFtb3VudCgpIGNvbnN0IHsgcmV0dXJuIG1fYW1vdW50OyB9CiAKICAg ICB2aXJ0dWFsIFBhc3NSZWZQdHI8RmlsdGVyT3BlcmF0aW9uPiBibGVuZChjb25zdCBGaWx0ZXJP cGVyYXRpb24qIGZyb20sIGRvdWJsZSBwcm9ncmVzcywgYm9vbCBibGVuZFRvUGFzc3Rocm91Z2gg PSBmYWxzZSk7CkBAIC0yMzYsMTEgKzIxMyw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBCYXNpY0NvbXBvbmVudFRyYW5zZmVyRmlsdGVyT3BlcmF0aW9uKGFtb3VudCwg dHlwZSkpOwogICAgIH0KIAotICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxGaWx0ZXJPcGVyYXRpb24+ IGNsb25lKCkgY29uc3QKLSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgQmFzaWND b21wb25lbnRUcmFuc2ZlckZpbHRlck9wZXJhdGlvbihtX2Ftb3VudCwgbV90eXBlKSk7Ci0gICAg fQotCiAgICAgZG91YmxlIGFtb3VudCgpIGNvbnN0IHsgcmV0dXJuIG1fYW1vdW50OyB9CiAKICAg ICB2aXJ0dWFsIGJvb2wgYWZmZWN0c09wYWNpdHkoKSBjb25zdCB7IHJldHVybiBtX3R5cGUgPT0g T1BBQ0lUWTsgfQpAQCAtMjc0LDExICsyNDYsNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBh ZG9wdFJlZihuZXcgR2FtbWFGaWx0ZXJPcGVyYXRpb24oYW1wbGl0dWRlLCBleHBvbmVudCwgb2Zm c2V0LCB0eXBlKSk7CiAgICAgfQogCi0gICAgdmlydHVhbCBQYXNzUmVmUHRyPEZpbHRlck9wZXJh dGlvbj4gY2xvbmUoKSBjb25zdAotICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBH YW1tYUZpbHRlck9wZXJhdGlvbihtX2FtcGxpdHVkZSwgbV9leHBvbmVudCwgbV9vZmZzZXQsIG1f dHlwZSkpOwotICAgIH0KLQogICAgIGRvdWJsZSBhbXBsaXR1ZGUoKSBjb25zdCB7IHJldHVybiBt X2FtcGxpdHVkZTsgfQogICAgIGRvdWJsZSBleHBvbmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fZXhw b25lbnQ7IH0KICAgICBkb3VibGUgb2Zmc2V0KCkgY29uc3QgeyByZXR1cm4gbV9vZmZzZXQ7IH0K QEAgLTMxNCwxMSArMjgxLDYgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IEJsdXJGaWx0ZXJPcGVyYXRpb24oc3RkRGV2aWF0aW9uLCB0eXBlKSk7CiAgICAgfQogCi0gICAg dmlydHVhbCBQYXNzUmVmUHRyPEZpbHRlck9wZXJhdGlvbj4gY2xvbmUoKSBjb25zdAotICAgIHsK LSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBCbHVyRmlsdGVyT3BlcmF0aW9uKG1fc3RkRGV2 aWF0aW9uLCBtX3R5cGUpKTsKLSAgICB9Ci0KICAgICBMZW5ndGggc3RkRGV2aWF0aW9uKCkgY29u c3QgeyByZXR1cm4gbV9zdGREZXZpYXRpb247IH0KIAogICAgIHZpcnR1YWwgYm9vbCBhZmZlY3Rz T3BhY2l0eSgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KQEAgLTM1MSwxMSArMzEzLDYgQEAgcHVi bGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRp b24obG9jYXRpb24sIHN0ZERldmlhdGlvbiwgY29sb3IsIHR5cGUpKTsKICAgICB9CiAKLSAgICB2 aXJ0dWFsIFBhc3NSZWZQdHI8RmlsdGVyT3BlcmF0aW9uPiBjbG9uZSgpIGNvbnN0Ci0gICAgewot ICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24obV9s b2NhdGlvbiwgbV9zdGREZXZpYXRpb24sIG1fY29sb3IsIG1fdHlwZSkpOwotICAgIH0KLQogICAg IGludCB4KCkgY29uc3QgeyByZXR1cm4gbV9sb2NhdGlvbi54KCk7IH0KICAgICBpbnQgeSgpIGNv bnN0IHsgcmV0dXJuIG1fbG9jYXRpb24ueSgpOyB9CiAgICAgSW50UG9pbnQgbG9jYXRpb24oKSBj b25zdCB7IHJldHVybiBtX2xvY2F0aW9uOyB9Cg==