92736 2012-07-31 03:40:05 -0700 REGRESSION(124116): Number of skipped tests isn't printed anymore 2012-07-31 12:05:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 92527 1 ossy dpranke abarth cmarcelo dpranke kadam kkristof ojan ossy rniwa tony webkit.review.bot oldest_to_newest 682893 0 ossy 2012-07-31 03:40:05 -0700 New form: ---------- 02:48:47.588 1369 Found 30509 tests; running 26142. 02:48:47.592 1369 Expect: 26101 passes (26101 now, 0 wontfix) 02:48:47.592 1369 Expect: 38 failures ( 38 now, 0 wontfix) 02:48:47.592 1369 Expect: 3 flaky ( 3 now, 0 wontfix) Old form: ---------- 16:39:31.706 2661 Found 30506 tests. 16:39:31.710 2661 Expect: 26099 passes (26099 now, 0 wontfix) 16:39:31.710 2661 Expect: 38 failures ( 38 now, 0 wontfix) 16:39:31.710 2661 Expect: 3 flaky ( 3 now, 0 wontfix) 16:39:31.710 2661 Expect: 4366 skipped ( 4366 now, 0 wontfix) Unfortunately the number of skipped tests isn't printed anymore, but it is still very important for us. Could you guys put it back? It is a simple multiplication. :) Thanks is advance. 683146 1 dpranke 2012-07-31 09:01:01 -0700 Hi Ossy, I apologize for the inconvenience; I didn't realize this number was important to anyone. This changed because the way we were doing things previously introduced a fair amount of unpleasantness in the code. You can still compute the number of skipped tests from the first line ("Found 30509; running 26142"), since you can subtract the one from the other. Is that good enough? Or would it be helpful to print the subtracted number ("Found 30509; running 26142, skipping 4366" or something)? Or do you really need the original format back? (If this is the case, it's not a big deal and I'll figure out how to make it work). Can you tell me what you're using this number for? Do you have some script parsing it for something, or is this just being read by humans? 683163 2 ossy 2012-07-31 09:08:47 -0700 Not a big problem, we don't use script to parse it, so we don't need the original format. You know there are so many skipped tests on Qt port and we are working hard to try to decrease this number, so we check the actual number of skipped tests day by day, tests by tests. That's why it is important for us. "Found 30509; running 26142, skipping 4366" is absolutely good for us. ;) 683291 3 155590 dpranke 2012-07-31 11:27:27 -0700 Created attachment 155590 Patch 683357 4 155590 webkit.review.bot 2012-07-31 12:05:43 -0700 Comment on attachment 155590 Patch Clearing flags on attachment: 155590 Committed r124234: <http://trac.webkit.org/changeset/124234> 683358 5 webkit.review.bot 2012-07-31 12:05:48 -0700 All reviewed patches have been landed. Closing bug. 155590 2012-07-31 11:27:27 -0700 2012-07-31 12:05:43 -0700 Patch bug-92736-20120731112711.patch text/plain 1927 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTY5YWI4N2IwN2I1NDU0OWEzOTViZDkxMjIzODkzMDIy OWQzODUxOS4uN2U1ZDVmNzMxYjY3YWZkOWVlOWJkYmEzNTMyZTJiMmFkNjE4MzY2OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA3LTMxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIFJFR1JFU1NJT04oMTI0MTE2KTogTnVtYmVyIG9mIHNraXBwZWQgdGVzdHMgaXNuJ3Qg cHJpbnRlZCBhbnltb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MjczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB0aGUgc2tpcHBlZCBudW1iZXIgYmFjayBpbjsgaXQgd2FzIHVzZWZ1bCAuLi4g YWxzbyBjbGVhbiB1cAorICAgICAgICB0aGUgZm9ybWF0dGluZyBhIGxpdHRsZSBiaXQuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weToK KyAgICAgICAgKFByaW50ZXIucHJpbnRfZm91bmQpOgorCisyMDEyLTA3LTMxICBEaXJrIFByYW5r ZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIG5yd3Q6IG1vdmUgaGFuZGxpbmcg dGhlIGluaXRpYWwgbGlzdCBvZiB0ZXN0cyB0byBza2lwIHRvIGZpbmRlcgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI3MDEKIApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQppbmRl eCA2Mzc3MzdlY2RkNzE0NzBlNDA5MmZlMzhkZGZlMjc4NjkyZDA1ZDc4Li44YmM4OWIyNWZhZDky OTc4MDg0ZWQ3ZTE5MmRhOTg0ZWY3NzY0YmUzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQpAQCAtMjIzLDcgKzIyMyw4 IEBAIGNsYXNzIFByaW50ZXIob2JqZWN0KToKICAgICBkZWYgcHJpbnRfZm91bmQoc2VsZiwgbnVt X2FsbF90ZXN0X2ZpbGVzLCBudW1fdG9fcnVuLCByZXBlYXRfZWFjaCwgaXRlcmF0aW9ucyk6CiAg ICAgICAgIGZvdW5kX3N0ciA9ICdGb3VuZCAlczsgcnVubmluZyAlZCcgJSAoZ3JhbW1hci5wbHVy YWxpemUoJ3Rlc3QnLCBudW1fYWxsX3Rlc3RfZmlsZXMpLCBudW1fdG9fcnVuKQogICAgICAgICBp ZiByZXBlYXRfZWFjaCAqIGl0ZXJhdGlvbnMgPiAxOgotICAgICAgICAgICAgZm91bmRfc3RyICs9 ICcsICVkIHRpbWVzIGVhY2ggKC0tcmVwZWF0LWVhY2g9JWQsIC0taXRlcmF0aW9ucz0lZCknICUg KHJlcGVhdF9lYWNoICogaXRlcmF0aW9ucywgcmVwZWF0X2VhY2gsIGl0ZXJhdGlvbnMpCisgICAg ICAgICAgICBmb3VuZF9zdHIgKz0gJyAoJWQgdGltZXMgZWFjaDogLS1yZXBlYXQtZWFjaD0lZCAt LWl0ZXJhdGlvbnM9JWQpJyAlIChyZXBlYXRfZWFjaCAqIGl0ZXJhdGlvbnMsIHJlcGVhdF9lYWNo LCBpdGVyYXRpb25zKQorICAgICAgICBmb3VuZF9zdHIgKz0gJywgc2tpcHBpbmcgJWQnICUgKG51 bV9hbGxfdGVzdF9maWxlcyAtIG51bV90b19ydW4pCiAgICAgICAgIHNlbGYuX3ByaW50X2V4cGVj dGVkKGZvdW5kX3N0ciArICcuJykKIAogICAgIGRlZiBwcmludF9leHBlY3RlZChzZWxmLCByZXN1 bHRfc3VtbWFyeSwgdGVzdHNfd2l0aF9yZXN1bHRfdHlwZV9jYWxsYmFjayk6Cg==