<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92728</bug_id>
          
          <creation_ts>2012-07-31 01:59:14 -0700</creation_ts>
          <short_desc>DFG OSR exit profiling has unusual oversights</short_desc>
          <delta_ts>2012-07-31 11:48:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>92696</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>barraclough</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>oliver</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>682836</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-07-31 01:59:14 -0700</bug_when>
    <thetext>- StructureTransitionWatchpoint doesn&apos;t record when it exits.

- OSR exit counting uses the wrong codeOrigin for forward speculations that appear at the very end of an inlined block.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682840</commentid>
    <comment_count>1</comment_count>
      <attachid>155468</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-07-31 02:03:26 -0700</bug_when>
    <thetext>Created attachment 155468
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>683094</commentid>
    <comment_count>2</comment_count>
      <attachid>155468</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2012-07-31 08:23:41 -0700</bug_when>
    <thetext>Comment on attachment 155468
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>683324</commentid>
    <comment_count>3</comment_count>
      <attachid>155468</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-31 11:48:37 -0700</bug_when>
    <thetext>Comment on attachment 155468
the patch

Clearing flags on attachment: 155468

Committed r124230: &lt;http://trac.webkit.org/changeset/124230&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>683325</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-31 11:48:41 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>155468</attachid>
            <date>2012-07-31 02:03:26 -0700</date>
            <delta_ts>2012-07-31 11:48:37 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>fixosrexit_patch_1.diff</filename>
            <type>text/plain</type>
            <size>3962</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI0MTgzKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA
CisyMDEyLTA3LTMxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
REZHIE9TUiBleGl0IHByb2ZpbGluZyBoYXMgdW51c3VhbCBvdmVyc2lnaHRzCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjcyOAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR09TUkV4aXQuY3Bw
OgorICAgICAgICAoSlNDOjpERkc6Ok9TUkV4aXQ6OmNvbnNpZGVyQWRkaW5nQXNGcmVxdWVudEV4
aXRTaXRlU2xvdyk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAgICAg
IChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OnNwZWN1bGF0aW9uV2F0Y2hwb2ludCk6CisgICAg
ICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6
OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVK
SVQ2NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgor
CiAyMDEyLTA3LTMwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4K
IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTI0MTIzLgpJbmRleDogU291cmNl
L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCShyZXZpc2lvbiAxMjM5OTApCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC02NCw3ICs2NCw3IEBAIGJvb2wgT1NSRXhpdDo6Y29uc2lkZXJBZGRpbmdBc0ZyZXF1ZW50RXgK
ICAgICB9IGVsc2UKICAgICAgICAgZXhpdFNpdGUgPSBGcmVxdWVudEV4aXRTaXRlKG1fY29kZU9y
aWdpbkZvckV4aXRQcm9maWxlLmJ5dGVjb2RlSW5kZXgsIG1fa2luZCk7CiAgICAgCi0gICAgcmV0
dXJuIGJhc2VsaW5lQ29kZUJsb2NrRm9yT3JpZ2luQW5kQmFzZWxpbmVDb2RlQmxvY2sobV9jb2Rl
T3JpZ2luLCBwcm9maWxlZENvZGVCbG9jayktPmFkZEZyZXF1ZW50RXhpdFNpdGUoZXhpdFNpdGUp
OworICAgIHJldHVybiBiYXNlbGluZUNvZGVCbG9ja0Zvck9yaWdpbkFuZEJhc2VsaW5lQ29kZUJs
b2NrKG1fY29kZU9yaWdpbkZvckV4aXRQcm9maWxlLCBwcm9maWxlZENvZGVCbG9jayktPmFkZEZy
ZXF1ZW50RXhpdFNpdGUoZXhpdFNpdGUpOwogfQogCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZH
CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp
dmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDEyMzk5MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1MDUs
NyArMzUwNSw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAg
ICAgICAgCiAgICAgY2FzZSBTdHJ1Y3R1cmVUcmFuc2l0aW9uV2F0Y2hwb2ludDogewogICAgICAg
ICBtX2ppdC5hZGRXZWFrUmVmZXJlbmNlKG5vZGUuc3RydWN0dXJlKCkpOwotICAgICAgICBub2Rl
LnN0cnVjdHVyZSgpLT5hZGRUcmFuc2l0aW9uV2F0Y2hwb2ludChzcGVjdWxhdGlvbldhdGNocG9p
bnQoKSk7CisgICAgICAgIG5vZGUuc3RydWN0dXJlKCktPmFkZFRyYW5zaXRpb25XYXRjaHBvaW50
KHNwZWN1bGF0aW9uV2F0Y2hwb2ludChCYWRDYWNoZSkpOwogICAgICAgICAKICNpZiAhQVNTRVJU
X0RJU0FCTEVECiAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIG9wMSh0aGlzLCBub2RlLmNo
aWxkMSgpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK
SVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj
dWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24gMTIzOTkwKQorKysgU291cmNlL0phdmFTY3JpcHRD
b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUyMCw3
ICszNTIwLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAg
ICAgICAKICAgICBjYXNlIFN0cnVjdHVyZVRyYW5zaXRpb25XYXRjaHBvaW50OiB7CiAgICAgICAg
IG1faml0LmFkZFdlYWtSZWZlcmVuY2Uobm9kZS5zdHJ1Y3R1cmUoKSk7Ci0gICAgICAgIG5vZGUu
c3RydWN0dXJlKCktPmFkZFRyYW5zaXRpb25XYXRjaHBvaW50KHNwZWN1bGF0aW9uV2F0Y2hwb2lu
dCgpKTsKKyAgICAgICAgbm9kZS5zdHJ1Y3R1cmUoKS0+YWRkVHJhbnNpdGlvbldhdGNocG9pbnQo
c3BlY3VsYXRpb25XYXRjaHBvaW50KEJhZENhY2hlKSk7CiAKICNpZiAhQVNTRVJUX0RJU0FCTEVE
CiAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIG9wMSh0aGlzLCBub2RlLmNoaWxkMSgpKTsK
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJ
KHJldmlzaW9uIDEyMzk5MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3Vs
YXRpdmVKSVQuaAkod29ya2luZyBjb3B5KQpAQCAtMjIyNCw5ICsyMjI0LDkgQEAgcHVibGljOgog
ICAgIC8vIFRoZSBkZWZhdWx0IGZvciBzcGVjdWxhdGlvbiB3YXRjaHBvaW50cyBpcyB0aGF0IHRo
ZXkncmUgdW5jb3VudGVkLCBiZWNhdXNlIHRoZQogICAgIC8vIGFjdCBvZiBmaXJpbmcgYSB3YXRj
aHBvaW50IGludmFsaWRhdGVzIGl0LiBTbywgZnV0dXJlIHJlY29tcGlsYXRpb25zIHdpbGwgbm90
CiAgICAgLy8gYXR0ZW1wdCB0byBzZXQgdGhpcyB3YXRjaHBvaW50IGFnYWluLgotICAgIEp1bXBS
ZXBsYWNlbWVudFdhdGNocG9pbnQqIHNwZWN1bGF0aW9uV2F0Y2hwb2ludCgpCisgICAgSnVtcFJl
cGxhY2VtZW50V2F0Y2hwb2ludCogc3BlY3VsYXRpb25XYXRjaHBvaW50KEV4aXRLaW5kIGtpbmQg
PSBVbmNvdW50YWJsZVdhdGNocG9pbnQpCiAgICAgewotICAgICAgICByZXR1cm4gc3BlY3VsYXRp
b25XYXRjaHBvaW50KFVuY291bnRhYmxlV2F0Y2hwb2ludCwgSlNWYWx1ZVNvdXJjZSgpLCBOb05v
ZGUpOworICAgICAgICByZXR1cm4gc3BlY3VsYXRpb25XYXRjaHBvaW50KGtpbmQsIEpTVmFsdWVT
b3VyY2UoKSwgTm9Ob2RlKTsKICAgICB9CiAgICAgdm9pZCBmb3J3YXJkU3BlY3VsYXRpb25DaGVj
ayhFeGl0S2luZCBraW5kLCBKU1ZhbHVlU291cmNlIGpzVmFsdWVTb3VyY2UsIE5vZGVJbmRleCBu
b2RlSW5kZXgsIE1hY3JvQXNzZW1ibGVyOjpKdW1wIGp1bXBUb0ZhaWwsIGNvbnN0IFZhbHVlUmVj
b3ZlcnkmIHZhbHVlUmVjb3ZlcnkpCiAgICAgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>