<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92697</bug_id>
          
          <creation_ts>2012-07-30 17:44:33 -0700</creation_ts>
          <short_desc>RenderObject needs a fast-path for removeAllChildren</short_desc>
          <delta_ts>2012-10-18 11:48:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>98281</dependson>
    
    <dependson>98336</dependson>
    
    <dependson>99741</dependson>
          <blocked>92258</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jamesr</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>kling</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>682570</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-07-30 17:44:33 -0700</bug_when>
    <thetext>RenderObject needs a fast-path for removeAllChildren

Looking at the sample of the benchmark attached to bug 92258.  We see nearly 10% of total time (on a 300x300 grid sample), spent under ContainerNode::removeChildren() tearing down the associated rendering tree.

Each renderer goes through and tell its ancestor chain that it&apos;s dying, and marks the view as needing repaint for its rect. We spend a bunch of time computing those repaint rects, and walking up/down the ancestor chain.

Just like how we have a &quot;fast path&quot; for removing subtrees in the DOM, we need some smarter logic for removing subtrees in the rendering tree.  At least in the non-positioned, flow cases, we should be able to have a single repaint rect instead of all this nonsense.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>