92695 2012-07-30 17:27:22 -0700 Fix potential compile error on LocalFileSystem::deleteFileSystem 2012-07-31 12:20:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tzik tzik abarth webkit.review.bot oldest_to_newest 682562 0 tzik 2012-07-30 17:27:22 -0700 The callback type in LocalFileSystem::deleteFileSystem arguments should AsyncFileSystemCallbacks, instead of ErrorCallback. # Sorry, I contaminated with it a few weeks ago. 682564 1 155407 tzik 2012-07-30 17:29:27 -0700 Created attachment 155407 Patch 683173 2 155407 abarth 2012-07-31 09:12:44 -0700 Comment on attachment 155407 Patch Ok. Can you explain the change a bit more in the ChangeLog? For example, which builds are broken and why the chromium build works. 683242 3 155581 tzik 2012-07-31 10:22:28 -0700 Created attachment 155581 Patch 683244 4 tzik 2012-07-31 10:25:09 -0700 (In reply to comment #2) > (From update of attachment 155407 [details]) > Ok. Can you explain the change a bit more in the ChangeLog? For example, which builds are broken and why the chromium build works. Sure, I updated the ChangeLog. 683334 5 155581 abarth 2012-07-31 11:52:23 -0700 Comment on attachment 155581 Patch Thanks. 683375 6 155581 webkit.review.bot 2012-07-31 12:20:47 -0700 Comment on attachment 155581 Patch Clearing flags on attachment: 155581 Committed r124238: <http://trac.webkit.org/changeset/124238> 683376 7 webkit.review.bot 2012-07-31 12:20:50 -0700 All reviewed patches have been landed. Closing bug. 155407 2012-07-30 17:29:27 -0700 2012-07-31 10:22:23 -0700 Patch bug-92695-20120731092911.patch text/plain 1962 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWI1ZWE0M2I2YmQxNTE1 ZTYyNjgyNDgwZTI1ZTdiNGFmODNkZjhjMi4uMzY2NDk4YjViMjY1Y2UwMTFlMzM3MzYyZGJjMjhh OGRmYmY1ZGRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTMwICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIGJ1 aWxkIGVycm9yIG9uIExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9uLUNocm9tZSBXZWJLaXQg YnVpbGQgd2l0aCBGSUxFX1NZU1RFTSBzaG91bGQgYmUgZmluaXNoZWQgc3VjY2Vzc2Z1bGx5Lgor CisgICAgICAgICogTW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMb2NhbEZpbGVTeXN0ZW06OmRlbGV0ZUZpbGVTeXN0ZW0pOgorCiAyMDEy LTA3LTMwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+ CiAKICAgICAgICAgQXZvaWQgQXNzZXJ0aW9uIEZhaWx1cmUgaW4gSGFyZkJ1enpSdW46OmNoYXJh Y3RlckluZGV4Rm9yWFBvc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv ZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCmluZGV4IDk2OGY0NGIwYjE1NzI3MjEzYWJk ODgyYWJiODczMzI5NTFkZDAzNzYuLjE5ZTJmMTU5ZjA4YWFhNzgxMTI2YjFmNjg4NDQzOTE3MmQ5 MjVjZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9Mb2Nh bEZpbGVTeXN0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9M b2NhbEZpbGVTeXN0ZW0uY3BwCkBAIC0xMDEsNyArMTAxLDcgQEAgdm9pZCBMb2NhbEZpbGVTeXN0 ZW06OnJlcXVlc3RGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEZp bGVTeXMKICAgICBjb250ZXh0LT5wb3N0VGFzayhjcmVhdGVDYWxsYmFja1Rhc2soJm9wZW5GaWxl U3lzdGVtLCBmaWxlU3lzdGVtQmFzZVBhdGgoKSwgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ ZGF0YWJhc2VJZGVudGlmaWVyKCksIHRydWUsIGNhbGxiYWNrcykpOwogfQogCi12b2lkIExvY2Fs RmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250 ZXh0LCBGaWxlU3lzdGVtVHlwZSB0eXBlLCBQYXNzUmVmUHRyPEVycm9yQ2FsbGJhY2s+IGNhbGxi YWNrcykKK3ZvaWQgTG9jYWxGaWxlU3lzdGVtOjpkZWxldGVGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXN0ZW1UeXBlIHR5cGUsIFBhc3NSZWZQdHI8QXN5 bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MpCiB7CiAgICAgLy8gQXN5bmNGaWxlU3lz dGVtOjpkZWxldGVGaWxlU3lzdGVtIGNhbGxzIGNhbGxiYWNrcyBzeW5jaHJvbm91c2x5LCBzbyB0 aGUgbWV0aG9kIG5lZWRzIHRvIGJlIGNhbGxlZCBhc3luY2hyb25vdXNseS4KICAgICBjb250ZXh0 LT5wb3N0VGFzayhjcmVhdGVDYWxsYmFja1Rhc2soJmRlbGV0ZUZpbGVTeXN0ZW0sIGZpbGVzeXN0 ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5kYXRhYmFzZUlkZW50aWZp ZXIoKSwgdHlwZSwgY2FsbGJhY2tzKTsK 155581 2012-07-31 10:22:28 -0700 2012-07-31 12:20:46 -0700 Patch bug-92695-20120801022210.patch text/plain 2271 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk4ZWE4ZWJmMmU4ZDY2 Y2UyMWYxMmY0YTVjNzBhM2NiZDJkMGYyNy4uYTVhNWNiYjUxOTEzYzcwOTM2ZDc2ZTU2ZTZjZWQw ZDI2NTU5NmIzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTMwICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIGJ1 aWxkIGVycm9yIG9uIExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjk1CisKKyAgICAgICAg Tm9uLUNocm9tZSBidWlsZCBvZiBXZWJLaXQgd2l0aCBGSUxFX1NZU1RFTSBmbGFnIHdpbGwgYmUg YnJva2VuIGF0CisgICAgICAgIExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbS4KKyAg ICAgICAgQ2hyb21lIGRvZXMgbm90IHVzZSB0aGlzIHNvdXJjZSBhbmQgbW9zdCBvZiBvdGhlciBw b3J0cyBkb24ndCB0dXJuIG9uCisgICAgICAgIEZJTEVfU1lTVEVNIGZsYWcgZm9yIG5vdy4gU28s IHdlJ3ZlIG5vdCBzZWVuIHRoZSBicmVha2FnZSBleHBsaWNpdGx5IHlldC4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb24tQ2hyb21lIFdlYktpdCBi dWlsZCB3aXRoIEZJTEVfU1lTVEVNIHNob3VsZCBiZSBmaW5pc2hlZCBzdWNjZXNzZnVsbHkuCisK KyAgICAgICAgKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbSk6CisKIDIwMTIt MDctMTcgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2ti ZXJyeV1bRnVsbFNjcmVlbl0gSFRNTDUgPHZpZGVvPiBjb250cm9scyBhcmUgc2NhbGVkIGRpZmZl cmVudGx5IGRlcGVuZGluZyBvbiB0aGUgY3VycmVudCB3ZWJwYWdlIHNjYWxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCmlu ZGV4IDk2OGY0NGIwYjE1NzI3MjEzYWJkODgyYWJiODczMzI5NTFkZDAzNzYuLjE5ZTJmMTU5ZjA4 YWFhNzgxMTI2YjFmNjg4NDQzOTE3MmQ5MjVjZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCkBAIC0xMDEsNyArMTAx LDcgQEAgdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJlcXVlc3RGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXMKICAgICBjb250ZXh0LT5wb3N0VGFzayhjcmVh dGVDYWxsYmFja1Rhc2soJm9wZW5GaWxlU3lzdGVtLCBmaWxlU3lzdGVtQmFzZVBhdGgoKSwgY29u dGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ZGF0YWJhc2VJZGVudGlmaWVyKCksIHRydWUsIGNhbGxi YWNrcykpOwogfQogCi12b2lkIExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbShTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBGaWxlU3lzdGVtVHlwZSB0eXBlLCBQYXNzUmVm UHRyPEVycm9yQ2FsbGJhY2s+IGNhbGxiYWNrcykKK3ZvaWQgTG9jYWxGaWxlU3lzdGVtOjpkZWxl dGVGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXN0ZW1U eXBlIHR5cGUsIFBhc3NSZWZQdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3Mp CiB7CiAgICAgLy8gQXN5bmNGaWxlU3lzdGVtOjpkZWxldGVGaWxlU3lzdGVtIGNhbGxzIGNhbGxi YWNrcyBzeW5jaHJvbm91c2x5LCBzbyB0aGUgbWV0aG9kIG5lZWRzIHRvIGJlIGNhbGxlZCBhc3lu Y2hyb25vdXNseS4KICAgICBjb250ZXh0LT5wb3N0VGFzayhjcmVhdGVDYWxsYmFja1Rhc2soJmRl bGV0ZUZpbGVTeXN0ZW0sIGZpbGVzeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9y aWdpbigpLT5kYXRhYmFzZUlkZW50aWZpZXIoKSwgdHlwZSwgY2FsbGJhY2tzKTsK