92676 2012-07-30 14:02:52 -0700 [WK2] Kill the concept of secondary shared process 2012-07-31 10:50:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca cdumez cgarcia cmarcelo menard rafael.lobo rniwa ryuan.choi sam webkit.review.bot zoltan oldest_to_newest 682361 0 ap 2012-07-30 14:02:52 -0700 A client can build a singleton just as easily on top of WKCreateContext. In fact, both clients that use WKContextGetSharedProcessContext already wrap it in their own singleton! 682363 1 155358 ap 2012-07-30 14:06:07 -0700 Created attachment 155358 proposed patch 682393 2 ap 2012-07-30 14:31:28 -0700 Committed <http://trac.webkit.org/changeset/124092>. 682498 3 rafael.lobo 2012-07-30 16:14:58 -0700 Reopening to attach new patch. 682500 4 155393 rafael.lobo 2012-07-30 16:15:04 -0700 Created attachment 155393 Patch This patch broke qt build. Could you double check if this is the proper fix? 682505 5 155393 ap 2012-07-30 16:25:44 -0700 Comment on attachment 155393 Patch Yes. Apologies for breaking the build - I grepped for API usage, but didn't realize that Qt used WK2 internals directly. 682521 6 rafael.lobo 2012-07-30 16:40:37 -0700 This patch was committed in <http://trac.webkit.org/changeset/124114>, yet that link gives me a "No changeset 124114 in the repository". :-( 682648 7 rniwa 2012-07-30 19:44:05 -0700 Windows build fix landed in http://trac.webkit.org/changeset/124153. 682678 8 ap 2012-07-30 20:18:35 -0700 The Windows fix is not correct - WKContextGetSharedProcessContext should be replaced with WKContextCreate. Sorry, I cannot land an updated one right now. WKContextGetSharedThreadContext may or may not work at all, but it's definitely not the regular mode for running MiniBrowser. 682680 9 rniwa 2012-07-30 20:22:34 -0700 (In reply to comment #8) > The Windows fix is not correct - WKContextGetSharedProcessContext should be replaced with WKContextCreate. Sorry, I cannot land an updated one right now. Okay, fixed in http://trac.webkit.org/changeset/124165. 682686 10 ap 2012-07-30 20:31:19 -0700 I looked at this function more carefully, and while it's correct that WKContextGetSharedProcessContext should be replaced with WKContextCreate, it's not quite that easy. We need to return a singleton object, so the result of WKContextCreate should be put into a static. Creating a new context for every view will likely work at the first glance, but wouldn't be the normal mode either. My apologies for an incomplete advice. 682687 11 rniwa 2012-07-30 20:33:27 -0700 (In reply to comment #10) > I looked at this function more carefully, and while it's correct that WKContextGetSharedProcessContext should be replaced with WKContextCreate, it's not quite that easy. We need to return a singleton object, so the result of WKContextCreate should be put into a static. > > Creating a new context for every view will likely work at the first glance, but wouldn't be the normal mode either. Okay. Would you be able to fix sometime soon or should we roll patches out? 682689 12 ap 2012-07-30 20:35:18 -0700 Since the build is not broken any more, it seems fine to leave as is for a little while. 682711 13 ap 2012-07-30 21:32:57 -0700 Re-opening to re-fix Windows MiniBrowser. 682712 14 155435 ap 2012-07-30 21:33:47 -0700 Created attachment 155435 MiniBrowser fix 682728 15 155435 rafael.lobo 2012-07-30 22:39:50 -0700 Comment on attachment 155435 MiniBrowser fix I think we can apply the same logic for Qt's previous usage of WebContext::sharedProcessContext. I'm wondering if it would be a good idea to modify this API and use something like WebContext::instance() instead like we usually do for singletons. 683255 16 155435 webkit.review.bot 2012-07-31 10:43:01 -0700 Comment on attachment 155435 MiniBrowser fix Clearing flags on attachment: 155435 Committed r124220: <http://trac.webkit.org/changeset/124220> 155358 2012-07-30 14:06:07 -0700 2012-07-30 14:27:21 -0700 proposed patch DeleteSharedProcess.txt text/plain 5173 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDA4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTMwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEtpbGwgdGhlIGNv bmNlcHQgb2Ygc2Vjb25kYXJ5IHNoYXJlZCBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjY3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHA6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOgor ICAgICAgICBEZWxldGVkIHNoYXJlZCBwcm9jZXNzIHJlbGF0ZWQgY29kZS4gV2UgZG9uJ3QgbmVl ZCB0byBidWlsZCB0aGUgc2luZ2xldG9uIGludG8KKyAgICAgICAgdGhlIGNyb3NzLXBsYXRmb3Jt IEMgQVBJLCBwbGF0Zm9ybS1zcGVjaWZpYyBBUEkgd3JhcHBlcnMgYXJlIHBlcmZlY3RseSBjYXBh YmxlCisgICAgICAgIG9mIGRvaW5nIHRoYXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfY29udGV4dC5jcHA6IChjcmVhdGVEZWZhdWx0RXdrQ29udGV4dCk6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHA6IChjcmVhdGVEZWZhdWx0V2Vi Q29udGV4dCk6CisgICAgICAgIFVzZSBXS0NvbnRleHRDcmVhdGUoKSB3aGVuIGNyZWF0aW5nIGRl ZmF1bHQgY29udGV4dC4KKwogMjAxMi0wNy0zMCAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRy YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIGNyaXRpY2FsIHdhcm5pbmc6IGdka193aW5k b3dfZ2V0X2N1cnNvcigpIGNhbGxlZCBvbiBhIE5VTEwgd2luZG93CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCShyZXZpc2lvbiAxMjI5OTcpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxLDE1 ICs5MSw2IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBERUZJTkVfREVCVUdfT05MWV9HTE9CQUwo V1RGOjpSZWZDb3VudGVkTGVha0NvdW50ZXIsIHdlYkNvbnRleHRDb3VudGVyLCAoIldlYkNvbnRl eHQiKSk7CiAKLVdlYkNvbnRleHQqIFdlYkNvbnRleHQ6OnNoYXJlZFByb2Nlc3NDb250ZXh0KCkK LXsKLSAgICBKU0M6OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKLSAgICBXVEY6OmluaXRpYWxpemVN YWluVGhyZWFkKCk7Ci0gICAgUnVuTG9vcDo6aW5pdGlhbGl6ZU1haW5SdW5Mb29wKCk7Ci0gICAg c3RhdGljIFdlYkNvbnRleHQqIGNvbnRleHQgPSBhZG9wdFJlZihuZXcgV2ViQ29udGV4dChQcm9j ZXNzTW9kZWxTaGFyZWRTZWNvbmRhcnlQcm9jZXNzLCBTdHJpbmcoKSkpLmxlYWtSZWYoKTsKLSAg ICByZXR1cm4gY29udGV4dDsKLX0KLQogV2ViQ29udGV4dCogV2ViQ29udGV4dDo6c2hhcmVkVGhy ZWFkQ29udGV4dCgpCiB7CiAgICAgUnVuTG9vcDo6aW5pdGlhbGl6ZU1haW5SdW5Mb29wKCk7Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgJKHJldmlzaW9uIDEyMjk5NykK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgJKHdvcmtpbmcgY29weSkK QEAgLTc2LDcgKzc2LDYgQEAgY2xhc3MgV2ViQ29udGV4dCA6IHB1YmxpYyBBUElPYmplY3QsIHBy aQogcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBUeXBlIEFQSVR5cGUgPSBUeXBlQ29udGV4dDsK IAotICAgIHN0YXRpYyBXZWJDb250ZXh0KiBzaGFyZWRQcm9jZXNzQ29udGV4dCgpOwogICAgIHN0 YXRpYyBXZWJDb250ZXh0KiBzaGFyZWRUaHJlYWRDb250ZXh0KCk7CiAKICAgICBzdGF0aWMgUGFz c1JlZlB0cjxXZWJDb250ZXh0PiBjcmVhdGUoY29uc3QgU3RyaW5nJiBpbmplY3RlZEJ1bmRsZVBh dGgpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5j cHAJKHJldmlzaW9uIDEyMjk5NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSwxMSArNjEsNiBAQCBXS0NvbnRleHRS ZWYgV0tDb250ZXh0Q3JlYXRlV2l0aEluamVjdGVkCiAgICAgcmV0dXJuIHRvQVBJKGNvbnRleHQu cmVsZWFzZSgpLmxlYWtSZWYoKSk7CiB9CiAKLVdLQ29udGV4dFJlZiBXS0NvbnRleHRHZXRTaGFy ZWRQcm9jZXNzQ29udGV4dCgpCi17Ci0gICAgcmV0dXJuIHRvQVBJKFdlYkNvbnRleHQ6OnNoYXJl ZFByb2Nlc3NDb250ZXh0KCkpOwotfQotCiBXS0NvbnRleHRSZWYgV0tDb250ZXh0R2V0U2hhcmVk VGhyZWFkQ29udGV4dCgpCiB7CiAgICAgcmV0dXJuIHRvQVBJKFdlYkNvbnRleHQ6OnNoYXJlZFRo cmVhZENvbnRleHQoKSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tD b250ZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dL Q29udGV4dC5oCShyZXZpc2lvbiAxMjI5OTcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tDb250ZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNyw3ICsxMjcsNiBAQCBXS19F WFBPUlQgV0tUeXBlSUQgV0tDb250ZXh0R2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9SVCBXS0NvbnRl eHRSZWYgV0tDb250ZXh0Q3JlYXRlKCk7CiBXS19FWFBPUlQgV0tDb250ZXh0UmVmIFdLQ29udGV4 dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRsZVBhdGgoV0tTdHJpbmdSZWYgcGF0aCk7Ci1XS19FWFBP UlQgV0tDb250ZXh0UmVmIFdLQ29udGV4dEdldFNoYXJlZFByb2Nlc3NDb250ZXh0KCk7CiAKIFdL X0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldEluamVjdGVkQnVuZGxlQ2xpZW50KFdLQ29udGV4dFJl ZiBjb250ZXh0LCBjb25zdCBXS0NvbnRleHRJbmplY3RlZEJ1bmRsZUNsaWVudCogY2xpZW50KTsK IFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldEhpc3RvcnlDbGllbnQoV0tDb250ZXh0UmVmIGNv bnRleHQsIGNvbnN0IFdLQ29udGV4dEhpc3RvcnlDbGllbnQqIGNsaWVudCk7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHQuY3BwCShyZXZp c2lvbiAxMjI5OTcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29u dGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2LDcgKzY2LDcgQEAgV0tDb250ZXh0UmVmIGV3 a19jb250ZXh0X1dLQ29udGV4dF9nZXQoYwogCiBzdGF0aWMgaW5saW5lIEV3a19Db250ZXh0KiBj cmVhdGVEZWZhdWx0RXdrQ29udGV4dCgpCiB7Ci0gICAgV0tDb250ZXh0UmVmIHdrQ29udGV4dCA9 IFdLQ29udGV4dEdldFNoYXJlZFByb2Nlc3NDb250ZXh0KCk7CisgICAgV0tDb250ZXh0UmVmIHdr Q29udGV4dCA9IFdLQ29udGV4dENyZWF0ZSgpOwogICAgIEV3a19Db250ZXh0KiBld2tDb250ZXh0 ID0gbmV3IEV3a19Db250ZXh0KHdrQ29udGV4dCk7CiAKICNpZiBFTkFCTEUoQkFUVEVSWV9TVEFU VVMpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250 ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJDb250ZXh0LmNwcAkocmV2aXNpb24gMTIyOTk3KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTExOCw3ICsxMTgsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfY2xhc3NfaW5p CiBzdGF0aWMgZ3BvaW50ZXIgY3JlYXRlRGVmYXVsdFdlYkNvbnRleHQoZ3BvaW50ZXIpCiB7CiAg ICAgc3RhdGljIEdSZWZQdHI8V2ViS2l0V2ViQ29udGV4dD4gd2ViQ29udGV4dCA9IGFkb3B0R1Jl ZihXRUJLSVRfV0VCX0NPTlRFWFQoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dFQl9DT05URVhU LCBOVUxMKSkpOwotICAgIHdlYkNvbnRleHQtPnByaXYtPmNvbnRleHQgPSBXS0NvbnRleHRHZXRT aGFyZWRQcm9jZXNzQ29udGV4dCgpOworICAgIHdlYkNvbnRleHQtPnByaXYtPmNvbnRleHQgPSBX S0NvbnRleHRDcmVhdGUoKTsKICAgICB3ZWJDb250ZXh0LT5wcml2LT5yZXF1ZXN0TWFuYWdlciA9 IFdLQ29udGV4dEdldFNvdXBSZXF1ZXN0TWFuYWdlcih3ZWJDb250ZXh0LT5wcml2LT5jb250ZXh0 LmdldCgpKTsKICAgICBXS0NvbnRleHRTZXRDYWNoZU1vZGVsKHdlYkNvbnRleHQtPnByaXYtPmNv bnRleHQuZ2V0KCksIGtXS0NhY2hlTW9kZWxQcmltYXJ5V2ViQnJvd3Nlcik7CiAgICAgYXR0YWNo RG93bmxvYWRDbGllbnRUb0NvbnRleHQod2ViQ29udGV4dC5nZXQoKSk7Cg== 155393 2012-07-30 16:15:04 -0700 2012-07-30 16:25:43 -0700 Patch bug-92676-20120730201638.patch text/plain 1606 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWQ0MjNmM2RjZDc3MzYw OTI4YmRlNjZmOTIzOTk2OTNlOWY2OTZkZS4uMGI2M2FjMmU4NmM5MTIyOWVhZmE0YzE5YzU3MWRh ZTllMDcxNWU1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTMwICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1dLMl0g S2lsbCB0aGUgY29uY2VwdCBvZiBzZWNvbmRhcnkgc2hhcmVkIHByb2Nlc3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjc2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgZml4IGFmdGVyIHIxMjQw OTIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJDb250ZXh0LmNwcDogQnVpbGQgZml4 IGZvciBRdC4gSW4gZXhjaGFuZ2Ugb2YgdGhlCisgICAgICAgIG1ldGhvZCByZW1vdmVkLCBJJ3Zl IHVzZWQgV2ViQ29udGV4dDo6Y3JlYXRlKFN0cmluZygpKS4KKwogMjAxMi0wNy0zMCAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBLaWxsIHRoZSBj b25jZXB0IG9mIHNlY29uZGFyeSBzaGFyZWQgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRXZWJDb250ZXh0LmNwcAppbmRleCA4MjM5YzVkMjE0YjdiOGRkN2I2ZWY3OWJh NTViMDQwNjlmYmU1MmVhLi41MGZhMTdmNjYzZTUwZmMxNjBiOTA2N2ViMmE2YzIyODM5NWRjZDU2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJDb250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJDb250ZXh0LmNwcApAQCAt MTE1LDcgKzExNSw3IEBAIFBhc3NSZWZQdHI8UXRXZWJDb250ZXh0PiBRdFdlYkNvbnRleHQ6OmRl ZmF1bHRDb250ZXh0KCkKICAgICBpZiAoc19kZWZhdWx0Q29udGV4dCkKICAgICAgICAgcmV0dXJu IFBhc3NSZWZQdHI8UXRXZWJDb250ZXh0PihzX2RlZmF1bHRDb250ZXh0KTsKIAotICAgIFJlZlB0 cjxXZWJDb250ZXh0PiBjb250ZXh0ID0gV2ViQ29udGV4dDo6c2hhcmVkUHJvY2Vzc0NvbnRleHQo KTsKKyAgICBSZWZQdHI8V2ViQ29udGV4dD4gY29udGV4dCA9IFdlYkNvbnRleHQ6OmNyZWF0ZShT dHJpbmcoKSk7CiAgICAgUmVmUHRyPFF0V2ViQ29udGV4dD4gZGVmYXVsdENvbnRleHQgPSBRdFdl YkNvbnRleHQ6OmNyZWF0ZShjb250ZXh0LmdldCgpKTsKICAgICBzX2RlZmF1bHRDb250ZXh0ID0g ZGVmYXVsdENvbnRleHQuZ2V0KCk7CiAgICAgLy8gTWFrZSBzdXJlIHRoYXQgdGhpcyBkb2Vzbid0 IGdldCBjYWxsZWQgaW4gV2ViS2l0VGVzdFJ1bm5lciAoZGVmYXVsdENvbnRleHQgaXNuJ3QgdXNl ZCB0aGVyZSkuCg== 155435 2012-07-30 21:33:47 -0700 2012-07-31 10:43:01 -0700 MiniBrowser fix FixWindows.txt text/plain 1332 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNDE3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTA3LTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtXSzJdIEtpbGwgdGhlIGNvbmNlcHQgb2Ygc2Vjb25kYXJ5IHNoYXJlZCBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjY3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWluaUJyb3dzZXIvd2luL0Jyb3dzZXJWaWV3LmNwcDogKEJyb3dzZXJWaWV3OjpjcmVhdGUpOiBV cGRhdGUgV2luZG93cyBidWlsZCBmaXguCisgICAgICAgIERvbid0IGNyZWF0ZSBhIG5ldyBjb250 ZXh0IGZvciBldmVyeSB2aWV3LgorCiAyMDEyLTA3LTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmVydCByMTI0MTUzIGFuZCBsYW5kIHRoZSAicmlnaHQi IGJ1aWxkIGZpeCBwZXIgYXAncyBjb21tZW50IG9uIHRoZSBidWcgOTI2NzYuCkluZGV4OiBUb29s cy9NaW5pQnJvd3Nlci93aW4vQnJvd3NlclZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01p bmlCcm93c2VyL3dpbi9Ccm93c2VyVmlldy5jcHAJKHJldmlzaW9uIDEyNDE3MikKKysrIFRvb2xz L01pbmlCcm93c2VyL3dpbi9Ccm93c2VyVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg3LDgg Kzg3LDEwIEBAIHZvaWQgQnJvd3NlclZpZXc6OmNyZWF0ZShSRUNUIHdlYlZpZXdSZWMKICAgICBX S0NvbnRleHRSZWYgY29udGV4dDsKICAgICBpZiAoaXNTaGlmdEtleURvd24pCiAgICAgICAgIGNv bnRleHQgPSBXS0NvbnRleHRHZXRTaGFyZWRUaHJlYWRDb250ZXh0KCk7Ci0gICAgZWxzZQotICAg ICAgICBjb250ZXh0ID0gV0tDb250ZXh0Q3JlYXRlKCk7CisgICAgZWxzZSB7CisgICAgICAgIHN0 YXRpYyBXS0NvbnRleHRSZWYgc2hhcmVkUmVndWxhckNvbnRleHQgPSBXS0NvbnRleHRDcmVhdGUo KTsKKyAgICAgICAgY29udGV4dCA9IHNoYXJlZFJlZ3VsYXJDb250ZXh0OworICAgIH0KIAogICAg IG1fd2ViVmlldyA9IFdLVmlld0NyZWF0ZSh3ZWJWaWV3UmVjdCwgY29udGV4dCwgMCwgcGFyZW50 V2luZG93LT53aW5kb3coKSk7CiAK