<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92671</bug_id>
          
          <creation_ts>2012-07-30 13:20:03 -0700</creation_ts>
          <short_desc>Add function to calculate the day in year from a date</short_desc>
          <delta_ts>2012-07-30 14:53:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Patrick R. Gansterer">paroga</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>682321</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-07-30 13:20:03 -0700</bug_when>
    <thetext>Add function to calculate the day in year from a date</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682331</commentid>
    <comment_count>1</comment_count>
      <attachid>155349</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-07-30 13:27:34 -0700</bug_when>
    <thetext>Created attachment 155349
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682342</commentid>
    <comment_count>2</comment_count>
      <attachid>155349</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-07-30 13:44:22 -0700</bug_when>
    <thetext>Comment on attachment 155349
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155349&amp;action=review

&gt; Source/WTF/ChangeLog:9
&gt; +        dayInYear() makes existing firstDayOfMonth data
&gt; +        accessible from other files than DateMath too.

Please mention that this change helps fixing the bug 92286.

&gt; Source/WTF/wtf/DateMath.cpp:289
&gt; -static inline int monthToDayInYear(int month, bool isLeapYear)
&gt; +int dayInYear(int year, int month, int day)

Let&apos;s keep this function static local for now since it&apos;s not used elsewhere at the moment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682420</commentid>
    <comment_count>3</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-07-30 14:53:37 -0700</bug_when>
    <thetext>Committed r124095: &lt;http://trac.webkit.org/changeset/124095&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>155349</attachid>
            <date>2012-07-30 13:27:34 -0700</date>
            <delta_ts>2012-07-30 13:44:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92671-20120730222717.patch</filename>
            <type>text/plain</type>
            <size>2524</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3OWM2NjAyMDg0MmI4NjEzMTIxM2Y2
Mzc4YmMzYTczMDBhNmRmNmQuLjE1NzViOTMwZTZlMDQ0YjQxMmFmOWQxMGFhMWNmOTA0OWY3ODZk
NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDctMzEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8
cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGZ1bmN0aW9uIHRvIGNhbGN1bGF0ZSB0
aGUgZGF5IGluIHllYXIgZnJvbSBhIGRhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTkyNjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgZGF5SW5ZZWFyKCkgbWFrZXMgZXhpc3RpbmcgZmlyc3REYXlPZk1v
bnRoIGRhdGEKKyAgICAgICAgYWNjZXNzaWJsZSBmcm9tIG90aGVyIGZpbGVzIHRoYW4gRGF0ZU1h
dGggdG9vLgorCisgICAgICAgICogd3RmL0RhdGVNYXRoLmNwcDoKKyAgICAgICAgKFdURjo6ZGF5
SW5ZZWFyKToKKyAgICAgICAgKFdURjo6ZGF0ZVRvRGF5c0Zyb20xOTcwKToKKyAgICAgICAgKiB3
dGYvRGF0ZU1hdGguaDoKKyAgICAgICAgKFdURik6CisKIDIwMTItMDctMzAgIFBhdHJpY2sgR2Fu
c3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBVbmljb2RlV2lu
Q0Ugd2l0aCBVbmljb2RlV2NoYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0RhdGVNYXRo
LmNwcCBiL1NvdXJjZS9XVEYvd3RmL0RhdGVNYXRoLmNwcAppbmRleCAzYjBiYmQzMDk0MjA0NGY0
Njk2ZjQ4NjE3YTI5NDM5ZGU1NzE0NDg5Li5kYzdhMTdhMTM2YTI3Y2FjYWMxNWFjZjM0YjBhMmU4
ZmYwYWU0NzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAKKysrIGIv
U291cmNlL1dURi93dGYvRGF0ZU1hdGguY3BwCkBAIC0yODYsOSArMjg2LDkgQEAgaW50IGRheUlu
TW9udGhGcm9tRGF5SW5ZZWFyKGludCBkYXlJblllYXIsIGJvb2wgbGVhcFllYXIpCiAgICAgcmV0
dXJuIGQgLSBzdGVwOwogfQogCi1zdGF0aWMgaW5saW5lIGludCBtb250aFRvRGF5SW5ZZWFyKGlu
dCBtb250aCwgYm9vbCBpc0xlYXBZZWFyKQoraW50IGRheUluWWVhcihpbnQgeWVhciwgaW50IG1v
bnRoLCBpbnQgZGF5KQogewotICAgIHJldHVybiBmaXJzdERheU9mTW9udGhbaXNMZWFwWWVhcl1b
bW9udGhdOworICAgIHJldHVybiBmaXJzdERheU9mTW9udGhbaXNMZWFwWWVhcih5ZWFyKV1bbW9u
dGhdICsgZGF5IC0gMTsKIH0KIAogZG91YmxlIGRhdGVUb0RheXNGcm9tMTk3MChpbnQgeWVhciwg
aW50IG1vbnRoLCBpbnQgZGF5KQpAQCAtMzAzLDkgKzMwMyw3IEBAIGRvdWJsZSBkYXRlVG9EYXlz
RnJvbTE5NzAoaW50IHllYXIsIGludCBtb250aCwgaW50IGRheSkKIAogICAgIGRvdWJsZSB5ZWFy
ZGF5ID0gZmxvb3IoZGF5c0Zyb20xOTcwVG9ZZWFyKHllYXIpKTsKICAgICBBU1NFUlQoKHllYXIg
Pj0gMTk3MCAmJiB5ZWFyZGF5ID49IDApIHx8ICh5ZWFyIDwgMTk3MCAmJiB5ZWFyZGF5IDwgMCkp
OwotICAgIGludCBtb250aGRheSA9IG1vbnRoVG9EYXlJblllYXIobW9udGgsIGlzTGVhcFllYXIo
eWVhcikpOwotCi0gICAgcmV0dXJuIHllYXJkYXkgKyBtb250aGRheSArIGRheSAtIDE7CisgICAg
cmV0dXJuIHllYXJkYXkgKyBkYXlJblllYXIoeWVhciwgbW9udGgsIGRheSk7CiB9CiAKIC8vIFRo
ZXJlIGlzIGEgaGFyZCBsaW1pdCBhdCAyMDM4IHRoYXQgd2UgY3VycmVudGx5IGRvIG5vdCBoYXZl
IGEgd29ya2Fyb3VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRGF0ZU1hdGguaCBiL1Nv
dXJjZS9XVEYvd3RmL0RhdGVNYXRoLmgKaW5kZXggNjJhZGQ1ZWVlYTBiYjdlMzhjNTQyOWZkYWIx
ZDViZmI2MWM4ZDRkMy4uNTA4ZmRjM2Q0YzNiMDhjMmIyMTAwOGQ2MTNiOTZkMTlmZGEzMjU1OCAx
MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRGF0ZU1hdGguaAorKysgYi9Tb3VyY2UvV1RGL3d0
Zi9EYXRlTWF0aC5oCkBAIC05NSw2ICs5NSw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSBpbnQgbXNU
b1llYXIoZG91YmxlIG1zKTsKIGRvdWJsZSBtc1RvRGF5cyhkb3VibGUgbXMpOwogaW50IG1zVG9N
aW51dGVzKGRvdWJsZSBtcyk7CiBpbnQgbXNUb0hvdXJzKGRvdWJsZSBtcyk7CitpbnQgZGF5SW5Z
ZWFyKGludCB5ZWFyLCBpbnQgbW9udGgsIGludCBkYXkpOwogV1RGX0VYUE9SVF9QUklWQVRFIGlu
dCBkYXlJblllYXIoZG91YmxlIG1zLCBpbnQgeWVhcik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgaW50
IG1vbnRoRnJvbURheUluWWVhcihpbnQgZGF5SW5ZZWFyLCBib29sIGxlYXBZZWFyKTsKIFdURl9F
WFBPUlRfUFJJVkFURSBpbnQgZGF5SW5Nb250aEZyb21EYXlJblllYXIoaW50IGRheUluWWVhciwg
Ym9vbCBsZWFwWWVhcik7Cg==
</data>
<flag name="review"
          id="164784"
          type_id="1"
          status="+"
          setter="rniwa"
    />
    <flag name="commit-queue"
          id="164785"
          type_id="3"
          status="-"
          setter="rniwa"
    />
          </attachment>
      

    </bug>

</bugzilla>