92664 2012-07-30 11:41:58 -0700 After r123895, new-run-webkit-tests can fail with TypeError when a test crashes 2012-07-30 11:55:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff dpranke oldest_to_newest 682231 0 msaboff 2012-07-30 11:41:58 -0700 After http://trac.webkit.org/changeset/123895, I'm seeing the following Python traceback when a test crashes and the controller tries to gather the crash_logs. TypeError raised: coercing to Unicode: need string or buffer, tuple found 11:27:31.413 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run 11:27:31.414 73403 unexpected_result_count = manager.run(args) 11:27:31.414 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 881, in run 11:27:31.414 73403 self._look_for_new_crash_logs(result_summary, start_time) 11:27:31.414 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 964, in _look_for_new_crash_logs 11:27:31.414 73403 writer.write_crash_log(crash_log) 11:27:31.414 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 167, in write_crash_log 11:27:31.414 73403 self._write_text_file(filename, crash_log) 11:27:31.414 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 136, in _write_text_file 11:27:31.414 73403 self._filesystem.write_text_file(path, contents) 11:27:31.414 73403 File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/common/system/filesystem.py", line 226, in write_text_file 11:27:31.414 73403 f.write(contents) 11:27:31.414 73403 File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 691, in write 11:27:31.415 73403 return self.writer.write(data) 11:27:31.415 73403 File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write 11:27:31.415 73403 data, consumed = self.encode(object, self.errors) Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 124. program finished with exit code 254 It looks like manager.py needs to be updated for r123895. 682235 1 155330 msaboff 2012-07-30 11:44:04 -0700 Created attachment 155330 Patch 682251 2 155333 dpranke 2012-07-30 11:51:49 -0700 Created attachment 155333 Patch 682257 3 155333 dpranke 2012-07-30 11:55:30 -0700 Comment on attachment 155333 Patch Clearing flags on attachment: 155333 Committed r124071: <http://trac.webkit.org/changeset/124071> 682258 4 dpranke 2012-07-30 11:55:32 -0700 All reviewed patches have been landed. Closing bug. 155330 2012-07-30 11:44:04 -0700 2012-07-30 11:51:47 -0700 Patch 92664.patch text/plain 1760 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNDA2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA3LTMwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIEFmdGVyIHIxMjM4OTUsIG5ldy1ydW4td2Via2l0LXRlc3RzIGNhbiBmYWls IHdpdGggVHlwZUVycm9yIHdoZW4gYSB0ZXN0IGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0byBoYW5kbGUgY3Jhc2hfbG9ncyBi ZWluZyByZXR1cm5lZCBhcyBhIHR1cGxlIG9mIChzdGRlcnIsIGNyYXNoX2xvZykuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5 OgorICAgICAgICAoTWFuYWdlci5fbG9va19mb3JfbmV3X2NyYXNoX2xvZ3MpOgorCiAyMDEyLTA3 LTMwICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEFkZGVkIGEgU2tpYUdyYXBoaWNzIGRlZmluaXRpb24gdG8gdGhlIHdhdGNobGlzdCBmaWxlOyBj YydlZCBteXNlbGYKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv bnRyb2xsZXJzL21hbmFnZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQkocmV2aXNpb24gMTI0MDY0KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdl ci5weQkod29ya2luZyBjb3B5KQpAQCAtOTYxLDcgKzk2MSwxMSBAQCBjbGFzcyBNYW5hZ2VyKG9i amVjdCk6CiAgICAgICAgIGlmIGNyYXNoX2xvZ3M6CiAgICAgICAgICAgICBmb3IgdGVzdCwgY3Jh c2hfbG9nIGluIGNyYXNoX2xvZ3MuaXRlcml0ZW1zKCk6CiAgICAgICAgICAgICAgICAgd3JpdGVy ID0gVGVzdFJlc3VsdFdyaXRlcihzZWxmLl9wb3J0Ll9maWxlc3lzdGVtLCBzZWxmLl9wb3J0LCBz ZWxmLl9wb3J0LnJlc3VsdHNfZGlyZWN0b3J5KCksIHRlc3QpCi0gICAgICAgICAgICAgICAgd3Jp dGVyLndyaXRlX2NyYXNoX2xvZyhjcmFzaF9sb2cpCisgICAgICAgICAgICAgICAgaWYgaXNpbnN0 YW5jZShjcmFzaF9sb2csIHR1cGxlKSBhbmQgbGVuKGNyYXNoX2xvZykgPj0gMiBhbmQgaXNpbnN0 YW5jZShjcmFzaF9sb2dbMV0sIGJhc2VzdHJpbmcpOgorICAgICAgICAgICAgICAgICAgICBjcmFz aF9sb2dfc3RyID0gY3Jhc2hfbG9nWzFdCisgICAgICAgICAgICAgICAgZWxzZToKKyAgICAgICAg ICAgICAgICAgICAgY3Jhc2hfbG9nX3N0ciA9ICJDcmFzaCBsb2cgbm90IGZvdW5kLlxuIgorICAg ICAgICAgICAgICAgIHdyaXRlci53cml0ZV9jcmFzaF9sb2coY3Jhc2hfbG9nX3N0cikKIAogICAg IGRlZiBfbWFya19pbnRlcnJ1cHRlZF90ZXN0c19hc19za2lwcGVkKHNlbGYsIHJlc3VsdF9zdW1t YXJ5KToKICAgICAgICAgZm9yIHRlc3RfbmFtZSBpbiBzZWxmLl90ZXN0X2ZpbGVzOgo= 155333 2012-07-30 11:51:49 -0700 2012-07-30 11:55:30 -0700 Patch bug-92664-20120730115133.patch text/plain 1695 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmEyODIzMzkyOTllM2YxZmU5MTJjNGU3NDg4MzFmOWYw OWM3YzU2Ny4uYzBiYjUwYjIxMGNlZDMwNWFiMWRmZGVkMTE1OTJiZGEzMThlNzU2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA3LTMwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIEFmdGVyIHIxMjM4OTUsIG5ldy1ydW4td2Via2l0LXRlc3RzIGNhbiBmYWlsIHdpdGgg VHlwZUVycm9yIHdoZW4gYSB0ZXN0IGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0byBoYW5kbGUgY3Jhc2hfbG9ncyBiZWluZyBy ZXR1cm5lZCBhcyBhIHR1cGxlIG9mIChzdGRlcnIsIGNyYXNoX2xvZykuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weToKKyAgICAgICAgKE1hY1Bv cnQubG9va19mb3JfbmV3X2NyYXNoX2xvZ3MpOgorCiAyMDEyLTA3LTI3ICBEaXJrIFByYW5rZSAg PGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgICJ3ZWJraXQtcGF0Y2ggcmViYXNlbGlu ZSA8dGVzdD4iIGZhaWxzIHdpdGggZXhpdF9jb2RlIDEKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKaW5kZXggNzU2YmQyYWJlMWNmMDhhZWIxMjMy NzNhYjIxNzE5MjRmMDJhMTg4MC4uZDBjYWE1YjIyMzYzNzNjZmY4OTM3OTU3NWNlMGY5NTc1YjYz N2Y4NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9tYWMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9t YWMucHkKQEAgLTIzNSw3ICsyMzUsNyBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAg ICAgIGZvciAodGVzdF9uYW1lLCBwcm9jZXNzX25hbWUsIHBpZCkgaW4gY3Jhc2hlZF9wcm9jZXNz ZXM6CiAgICAgICAgICAgICAjIFBhc3NpbmcgTm9uZSBmb3Igb3V0cHV0LiAgVGhpcyBpcyBhIHNl Y29uZCBwYXNzIGFmdGVyIHRoZSB0ZXN0IGZpbmlzaGVkIHNvCiAgICAgICAgICAgICAjIGlmIHRo ZSBvdXRwdXQgaGFkIGFueSBsb2dnaW5lIHdlIHdvdWxkIGhhdmUgYWxyZWFkeSBjb2xsZWN0ZWQg aXQuCi0gICAgICAgICAgICBjcmFzaF9sb2cgPSBzZWxmLl9nZXRfY3Jhc2hfbG9nKHByb2Nlc3Nf bmFtZSwgcGlkLCBOb25lLCBOb25lLCBzdGFydF90aW1lLCB3YWl0X2Zvcl9sb2c9RmFsc2UpCisg ICAgICAgICAgICBjcmFzaF9sb2cgPSBzZWxmLl9nZXRfY3Jhc2hfbG9nKHByb2Nlc3NfbmFtZSwg cGlkLCBOb25lLCBOb25lLCBzdGFydF90aW1lLCB3YWl0X2Zvcl9sb2c9RmFsc2UpWzFdCiAgICAg ICAgICAgICBpZiBub3QgY3Jhc2hfbG9nOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAg ICAgICAgICBjcmFzaF9sb2dzW3Rlc3RfbmFtZV0gPSBjcmFzaF9sb2cK