92662 2012-07-30 11:09:05 -0700 fast/writing-mode/flipped-blocks-hit-test-line-edges.html broken on non-Mac Chromium 2012-07-30 13:46:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92597 1 tomhudson pkasting mitz pkasting rniwa tomhudson oldest_to_newest 682202 0 tomhudson 2012-07-30 11:09:05 -0700 It isn't clear if the layout test is telling us that: 1. there's a Chromium bug; non-Mac should render like Mac and isn't 2. the test needs to be modified so the results aren't platform dependent 3. the test needs to be modified to expect platform-dependent results 682203 1 tomhudson 2012-07-30 11:09:47 -0700 mitz, rniwa, could you give us some guidance on how you expect Chromium to handle this layout test? 682245 2 rniwa 2012-07-30 11:50:50 -0700 https://bugs.webkit.org/show_bug.cgi?id=92636 --- Comment #3 from mitz@webkit.org 2012-07-30 07:16:06 PST --- The test is failing because of the different selection mode used in some non-OS X ports. 682252 3 mitz 2012-07-30 11:52:48 -0700 I think there may be a way for TestRunner or Internals to change the selection behavior, so that’s one option. Another option would be to consider both possible results as PASS. Yet another option would be to just remove that point from the test. 682256 4 mitz 2012-07-30 11:54:33 -0700 internals.settings.setEditingBehavior('mac') should do the trick. 682278 5 155336 pkasting 2012-07-30 12:20:53 -0700 Created attachment 155336 patch v1 So, something like this then? 682339 6 rniwa 2012-07-30 13:33:57 -0700 Thanks for the fix. 682345 7 pkasting 2012-07-30 13:46:11 -0700 Fixed in r124084. 155336 2012-07-30 12:20:53 -0700 2012-07-30 13:46:27 -0700 patch v1 patch text/plain 1232 pkasting SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDA3MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA3LTMwICBQZXRlciBLYXN0aW5nICA8 cGthc3RpbmdAZ29vZ2xlLmNvbT4KKworICAgICAgICBGb3JjZSBNYWMgZWRpdGluZyBtb2RlIG9u IG5ldyB0ZXN0IHNvIG90aGVyIHBsYXRmb3JtcyB3aWxsIHBhc3MgaXQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjY2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC93cml0aW5nLW1vZGUvZmxp cHBlZC1ibG9ja3MtaGl0LXRlc3QtbGluZS1lZGdlcy5odG1sOgorCiAyMDEyLTA3LTMwICBQZXRl ciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbQ2hyb21pdW1dIFJl YmFzZWxpbmUgdGVzdHMgZm9yIFNraWEgY2hhbmdlcy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv d3JpdGluZy1tb2RlL2ZsaXBwZWQtYmxvY2tzLWhpdC10ZXN0LWxpbmUtZWRnZXMuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9mbGlwcGVkLWJsb2Nrcy1o aXQtdGVzdC1saW5lLWVkZ2VzLmh0bWwJKHJldmlzaW9uIDEyNDA0NykKKysrIExheW91dFRlc3Rz L2Zhc3Qvd3JpdGluZy1tb2RlL2ZsaXBwZWQtYmxvY2tzLWhpdC10ZXN0LWxpbmUtZWRnZXMuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtOCw4ICs4LDEwIEBACiAiPkxvcmVtIGlwc3VtIGRvbG9yIHNp dCBhbWV0PC9kaXY+CiA8cHJlIGlkPSJsb2ciPjwvcHJlPgogPHNjcmlwdD4KLSAgICBpZiAod2lu ZG93LnRlc3RSdW5uZXIpCisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyICYmIHdpbmRvdy5pbnRl cm5hbHMpIHsKICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGludGVy bmFscy5zZXR0aW5ncy5zZXRFZGl0aW5nQmVoYXZpb3IoIm1hYyIpOworICAgIH0gICAgICAgIAog CiAgICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCiAgICAgewo=