92660 2012-07-30 10:52:54 -0700 [chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently 2012-09-06 14:48:21 -0700 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco alokp alokp cc-bugs danakj dglazkov enne eric fred.wang jamesr peter+ews senorblanco vangelis webkit.review.bot oldest_to_newest 682189 0 senorblanco 2012-07-30 10:52:54 -0700 platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/accelerated-drawing/alpha.html are crashing intermittently on all platforms due to an assert. This looks to have been exposed by: http://trac.webkit.org/changeset/123987 which passes through the acceleratePainting flag to settings. Sample Linux crash stack: crash log for DumpRenderTree (pid 6766): STDOUT: <empty> STDERR: [6766:6766:915311230:ERROR:gles2_cmd_decoder.cc(5109)] GL ERROR :GL_INVALID_OPERATION : glFramebufferTexture2D: unknown texture STDERR: base::debug::StackTrace::StackTrace() [0x82d82a8] STDERR: base::(anonymous namespace)::StackDumpSignalHandler() [0x82c17bd] STDERR: 0xb773d400 STDERR: WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect() [0x88caa79] STDERR: WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect() [0x88cae62] STDERR: WebCore::(anonymous namespace)::UnthrottledTextureUploader::uploadTexture() [0x89088d4] STDERR: WebCore::CCTextureUpdater::update() [0x88fe628] STDERR: WebCore::CCSingleThreadProxy::doCommit() [0x88fcf1d] STDERR: WebCore::CCSingleThreadProxy::commitAndComposite() [0x88fcfcc] STDERR: WebCore::CCSingleThreadProxy::compositeAndReadback() [0x88fd48f] STDERR: WebCore::CCLayerTreeHost::compositeAndReadback() [0x88db3d4] STDERR: WebKit::WebLayerTreeView::compositeAndReadback() [0x8104c1b] STDERR: WebKit::WebViewImpl::doPixelReadbackToCanvas() [0x80c61a8] STDERR: WebKit::WebViewImpl::paint() [0x80c65aa] STDERR: WebViewHost::paintRect() [0x8089750] STDERR: WebViewHost::paintInvalidatedRegion() [0x80898b1] STDERR: TestShell::dump() [0x80852d6] STDERR: TestShell::testFinished() [0x80858c9] STDERR: LayoutTestController::WorkQueue::processWorkSoon() [0x8066a65] STDERR: WebViewHost::locationChangeDone() [0x808a0e8] STDERR: WebKit::FrameLoaderClientImpl::dispatchDidFinishLoad() [0x80ef741] STDERR: WebCore::FrameLoader::checkLoadCompleteForThisFrame() [0x8b68dfd] STDERR: WebCore::FrameLoader::checkLoadComplete() [0x8b68fd9] STDERR: WebCore::DocumentLoader::finishedLoading() [0x8b51822] STDERR: WebCore::MainResourceLoader::didFinishLoading() [0x8b79399] STDERR: WebCore::ResourceLoader::didFinishLoading() [0x8b8e166] STDERR: WebCore::ResourceHandleInternal::didFinishLoading() [0x9817dab] STDERR: webkit_glue::WebURLLoaderImpl::Context::OnCompletedRequest() [0x92f872e] STDERR: (anonymous namespace)::RequestProxy::NotifyCompletedRequest() [0x93983f6] STDERR: base::internal::Invoker<>::Run() [0x939860b] STDERR: MessageLoop::RunTask() [0x82b5080] STDERR: MessageLoop::DeferOrRunPendingTask() [0x82b5722] STDERR: MessageLoop::DoWork() [0x82b5a81] STDERR: base::MessagePumpGlib::HandleDispatch() [0x82d2018] STDERR: (anonymous namespace)::WorkSourceDispatch() [0x82d2057] STDERR: 0xb75325e5 STDERR: 0xb75362d8 STDERR: 0xb75364b8 STDERR: base::MessagePumpGlib::RunWithDispatcher() [0x82d24e9] STDERR: base::MessagePumpGlib::Run() [0x82d207e] STDERR: MessageLoop::RunInternal() [0x82b043e] STDERR: base::RunLoop::Run() [0x82c1a69] STDERR: MessageLoop::Run() [0x82af60e] STDERR: webkit_support::RunMessageLoop() [0x81cbff7] STDERR: TestShell::waitTestFinished() [0x8085999] STDERR: TestShell::runFileTest() [0x8083f9f] STDERR: runTest() [0x805d3f3] STDERR: main [0x805d9d3] STDERR: 0xb6a3abd6 STDERR: 0x805c561 705666 1 alokp 2012-08-27 14:19:06 -0700 Accelerated painting used the compositor context to create and upload the tile textures. Now it seems we use two contexts - one that creates the texture and another to upload it. Although the texture is shared by the two contexts, it is not immediately available after creation to the context that uploads it. Flushing the context that creates it fixes the problem. 705723 2 160818 alokp 2012-08-27 15:02:59 -0700 Created attachment 160818 proposed patch 705736 3 160822 alokp 2012-08-27 15:13:42 -0700 Created attachment 160822 proposed patch sync'd with TOT. 705737 4 danakj 2012-08-27 15:13:59 -0700 The Framebuffer texture updater isn't actually used unless enabled by command-line flags anywhere. At a minimum you will need to do something on other code paths such as BitmapCanvasLayerTextureUpdater (the default updater). But presumably you want to flush the sharedContext used for filters, not the context being used for upload, and we should do this once before any uploading takes place? Maybe CCTextureUpdateController? 705739 5 danakj 2012-08-27 15:16:01 -0700 Oh I may be thinking backwards, the texture is created by our resource provider, but we're uploading using ganesh? Too used to the other way around. If so then ignore my last comment. 705748 6 alokp 2012-08-27 15:22:14 -0700 Right. This class is exclusively used by accelerated-painting path. AFAIK BitmapCanvasLayerTextureUpdater is not affected by using two contexts. In fact I am not even aware when we switched to using two contexts. I am not flushing the context that uploads. I am flushing the context that creates the textures. We could add a flush here: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/chromium/cc/CCResourceProvider.cpp#L124 (right after the texture is created), but that would affect other texture-updaters as well - even the ones that do not need it. 705754 7 danakj 2012-08-27 15:27:42 -0700 Yeh this seems legit as presented, sorry for my misunderstanding! 705787 8 160822 webkit.review.bot 2012-08-27 15:38:49 -0700 Comment on attachment 160822 proposed patch Attachment 160822 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13648036 705907 9 160822 peter+ews 2012-08-27 17:18:13 -0700 Comment on attachment 160822 proposed patch Attachment 160822 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13635103 706414 10 160998 alokp 2012-08-28 09:27:08 -0700 Created attachment 160998 proposed patch sync'd again with TOT. 706797 11 alokp 2012-08-28 15:35:01 -0700 james: can you review it? 708106 12 alokp 2012-08-29 17:35:43 -0700 ping! 709830 13 160998 webkit.review.bot 2012-08-31 11:24:03 -0700 Comment on attachment 160998 proposed patch Clearing flags on attachment: 160998 Committed r127294: <http://trac.webkit.org/changeset/127294> 709831 14 webkit.review.bot 2012-08-31 11:24:07 -0700 All reviewed patches have been landed. Closing bug. 713731 15 162592 alokp 2012-09-06 14:46:42 -0700 Created attachment 162592 Adjusting TestExpectations Adjusting test expectations after watching test bots and flakiness dashboard. It seems the earlier patch indeed fixed the problem. 713735 16 alokp 2012-09-06 14:48:01 -0700 Stephen: Could you approve the TestExpectations patch. Thanks. 713736 17 jamesr 2012-09-06 14:48:13 -0700 Don't attach new patches to closed bugs - open a new bug for new patches if you want a review. For this, I'd just commit it. 160818 2012-08-27 15:02:59 -0700 2012-08-27 15:13:42 -0700 proposed patch 92660.patch text/plain 3164 alokp SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjgwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTI3ICBBbG9rIFBy aXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gTGF5 b3V0IHRlc3RzIHN2Zy1maWx0ZXJzLmh0bWwgYW5kIGFscGhhLmh0bWwgYXJlIGNyYXNoaW5nIGlu dGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MjY2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIHVzZSB0d28gR0wgY29udGV4dHMgdG8gY3JlYXRlIGFuZCB1cGxvYWQgdGlsZSB0ZXh0 dXJlcy4KKyAgICAgICAgT25lIGNvbnRleHQgY3JlYXRlcyB0aGUgdGV4dHVyZSwgd2hpbGUgYW5v dGhlciB1cGxvYWRzIGl0LgorICAgICAgICBFdmVuIHRob3VnaCB0aGUgdGV4dHVyZSBpcyBzaGFy ZWQgYnkgdGhlIHR3byBjb250ZXh0cywgaXQgaXMgbm90CisgICAgICAgIGF2YWlsYWJsZSB0byB0 aGUgdXBsb2FkaW5nIGNvbnRleHQgaW1tZWRpYXRlbHkgYWZ0ZXIgY3JlYXRpb24sCisgICAgICAg IHVubGVzcyB0aGUgY3JlYXRpbmcgY29udGV4dCBpcyBmbHVzaGVkLiAKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJU ZXh0dXJlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVBY2NlbGVyYXRlZENh bnZhcyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXI6OnVwZGF0ZVRleHR1cmVSZWN0KToKKwogMjAxMi0wOC0yNyAgUm9iIEJ1 aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIEZpeCBjb21waWxlciB3YXJuaW5ncyBpbiBU ZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9GcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0 ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAJ KHJldmlzaW9uIDEyNjc5OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDcgQEAgc3RhdGljIFBhc3NPd25QdHI8U2tDYW52 YXM+IGNyZWF0ZUFjY2VsZQogICAgIHRleHR1cmVEZXNjLmZGbGFncyA9IGtSZW5kZXJUYXJnZXRf R3JQbGF0Zm9ybVRleHR1cmVGbGFnOwogICAgIHRleHR1cmVEZXNjLmZXaWR0aCA9IGNhbnZhc1Np emUud2lkdGgoKTsKICAgICB0ZXh0dXJlRGVzYy5mSGVpZ2h0ID0gY2FudmFzU2l6ZS5oZWlnaHQo KTsKLSAgICB0ZXh0dXJlRGVzYy5mQ29uZmlnID0ga1NraWE4ODg4X0dyUGl4ZWxDb25maWc7Cisg ICAgdGV4dHVyZURlc2MuZkNvbmZpZyA9IGtTa2lhODg4OF9QTV9HclBpeGVsQ29uZmlnOwogICAg IHRleHR1cmVEZXNjLmZUZXh0dXJlSGFuZGxlID0gdGV4dHVyZUlkOwogICAgIFNrQXV0b1RVbnJl ZjxHclRleHR1cmU+IHRhcmdldChnckNvbnRleHQtPmNyZWF0ZVBsYXRmb3JtVGV4dHVyZSh0ZXh0 dXJlRGVzYykpOwogICAgIFNrQXV0b1RVbnJlZjxTa0RldmljZT4gZGV2aWNlKG5ldyBTa0dwdURl dmljZShnckNvbnRleHQsIHRhcmdldC5nZXQoKSkpOwpAQCAtMTAzLDExICsxMDMsMTYgQEAgTGF5 ZXJUZXh0dXJlVXBkYXRlcjo6U2FtcGxlZFRleGVsRm9ybWF0IAogCiB2b2lkIEZyYW1lQnVmZmVy U2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6dXBkYXRlVGV4dHVyZVJlY3QoV2Vi R3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIEdyQ29udGV4dCogZ3JDb250ZXh0LCBDQ1Jlc291 cmNlUHJvdmlkZXIqIHJlc291cmNlUHJvdmlkZXIsIENDUHJpb3JpdGl6ZWRUZXh0dXJlKiB0ZXh0 dXJlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25zdCBJbnRTaXplJiBkZXN0T2Zmc2V0 KQogeworICAgIHRleHR1cmUtPmFjcXVpcmVCYWNraW5nVGV4dHVyZShyZXNvdXJjZVByb3ZpZGVy KTsKKyAgICAvLyBGbHVzaCB0aGUgY29udGV4dCBpbiB3aGljaCB0aGUgYmFja2luZyB0ZXh0dXJl IGlzIGNyZWF0ZWQgc28gdGhhdCBpdAorICAgIC8vIGlzIGF2YWlsYWJsZSBpbiBvdGhlciBzaGFy ZWQgY29udGV4dHMuIEl0IGlzIGltcG9ydGFudCB0byBkbyBoZXJlCisgICAgLy8gYmVjYXVzZSB0 aGUgYmFja2luZyB0ZXh0dXJlIGlzIGNyZWF0ZWQgaW4gb25lIGNvbnRleHQgd2hpbGUgaXQgaXMK KyAgICAvLyBiZWluZyB3cml0dGVuIHRvIGluIGFub3RoZXIuCisgICAgcmVzb3VyY2VQcm92aWRl ci0+Zmx1c2goKTsKKyAgICBDQ1Njb3BlZExvY2tSZXNvdXJjZUZvcldyaXRlIGxvY2socmVzb3Vy Y2VQcm92aWRlciwgdGV4dHVyZS0+cmVzb3VyY2VJZCgpKTsKKwogICAgIC8vIE1ha2Ugc3VyZSBn YW5lc2ggdXNlcyB0aGUgY29ycmVjdCBHTCBjb250ZXh0LgogICAgIGNvbnRleHQtPm1ha2VDb250 ZXh0Q3VycmVudCgpOwotCi0gICAgdGV4dHVyZS0+YWNxdWlyZUJhY2tpbmdUZXh0dXJlKHJlc291 cmNlUHJvdmlkZXIpOwotICAgIENDUmVzb3VyY2VQcm92aWRlcjo6U2NvcGVkV3JpdGVMb2NrR0wg bG9jayhyZXNvdXJjZVByb3ZpZGVyLCB0ZXh0dXJlLT5yZXNvdXJjZUlkKCkpOwogICAgIC8vIENy ZWF0ZSBhbiBhY2NlbGVyYXRlZCBjYW52YXMgdG8gZHJhdyBvbi4KICAgICBPd25QdHI8U2tDYW52 YXM+IGNhbnZhcyA9IGNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKGdyQ29udGV4dCwgdGV4dHVyZS0+ c2l6ZSgpLCBsb2NrLnRleHR1cmVJZCgpKTsKIAo= 160822 2012-08-27 15:13:42 -0700 2012-08-28 09:27:08 -0700 proposed patch 92660.patch text/plain 2669 alokp SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjgwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTI3ICBBbG9rIFBy aXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gTGF5 b3V0IHRlc3RzIHN2Zy1maWx0ZXJzLmh0bWwgYW5kIGFscGhhLmh0bWwgYXJlIGNyYXNoaW5nIGlu dGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MjY2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIHVzZSB0d28gR0wgY29udGV4dHMgdG8gY3JlYXRlIGFuZCB1cGxvYWQgdGlsZSB0ZXh0 dXJlcy4KKyAgICAgICAgT25lIGNvbnRleHQgY3JlYXRlcyB0aGUgdGV4dHVyZSwgd2hpbGUgYW5v dGhlciB1cGxvYWRzIGl0LgorICAgICAgICBFdmVuIHRob3VnaCB0aGUgdGV4dHVyZSBpcyBzaGFy ZWQgYnkgdGhlIHR3byBjb250ZXh0cywgaXQgaXMgbm90CisgICAgICAgIGF2YWlsYWJsZSB0byB0 aGUgdXBsb2FkaW5nIGNvbnRleHQgaW1tZWRpYXRlbHkgYWZ0ZXIgY3JlYXRpb24sCisgICAgICAg IHVubGVzcyB0aGUgY3JlYXRpbmcgY29udGV4dCBpcyBmbHVzaGVkLiAKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJU ZXh0dXJlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVBY2NlbGVyYXRlZENh bnZhcyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXI6OnVwZGF0ZVRleHR1cmVSZWN0KToKKwogMjAxMi0wOC0yNCAgSmFtZXMg Um9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ2xl YW4gdXAgZGVwZW5kZW5jaWVzIG9mIFdlYlNjcm9sbGJhciBhbmQgV2ViU2Nyb2xsYmFyTGF5ZXIK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZyYW1lQnVm ZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRnJhbWVCdWZmZXJTa1Bp Y3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAkocmV2aXNpb24gMTI2ODA0KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRnJhbWVCdWZmZXJTa1Bp Y3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAz LDExICsxMDMsMTYgQEAgTGF5ZXJUZXh0dXJlVXBkYXRlcjo6U2FtcGxlZFRleGVsRm9ybWF0IAog CiB2b2lkIEZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6dXBk YXRlVGV4dHVyZVJlY3QoV2ViR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIEdyQ29udGV4dCog Z3JDb250ZXh0LCBDQ1Jlc291cmNlUHJvdmlkZXIqIHJlc291cmNlUHJvdmlkZXIsIENDUHJpb3Jp dGl6ZWRUZXh0dXJlKiB0ZXh0dXJlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25zdCBJ bnRTaXplJiBkZXN0T2Zmc2V0KQogeworICAgIHRleHR1cmUtPmFjcXVpcmVCYWNraW5nVGV4dHVy ZShyZXNvdXJjZVByb3ZpZGVyKTsKKyAgICAvLyBGbHVzaCB0aGUgY29udGV4dCBpbiB3aGljaCB0 aGUgYmFja2luZyB0ZXh0dXJlIGlzIGNyZWF0ZWQgc28gdGhhdCBpdAorICAgIC8vIGlzIGF2YWls YWJsZSBpbiBvdGhlciBzaGFyZWQgY29udGV4dHMuIEl0IGlzIGltcG9ydGFudCB0byBkbyBoZXJl CisgICAgLy8gYmVjYXVzZSB0aGUgYmFja2luZyB0ZXh0dXJlIGlzIGNyZWF0ZWQgaW4gb25lIGNv bnRleHQgd2hpbGUgaXQgaXMKKyAgICAvLyBiZWluZyB3cml0dGVuIHRvIGluIGFub3RoZXIuCisg ICAgcmVzb3VyY2VQcm92aWRlci0+Zmx1c2goKTsKKyAgICBDQ1Njb3BlZExvY2tSZXNvdXJjZUZv cldyaXRlIGxvY2socmVzb3VyY2VQcm92aWRlciwgdGV4dHVyZS0+cmVzb3VyY2VJZCgpKTsKKwog ICAgIC8vIE1ha2Ugc3VyZSBnYW5lc2ggdXNlcyB0aGUgY29ycmVjdCBHTCBjb250ZXh0LgogICAg IGNvbnRleHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwotCi0gICAgdGV4dHVyZS0+YWNxdWlyZUJh Y2tpbmdUZXh0dXJlKHJlc291cmNlUHJvdmlkZXIpOwotICAgIENDUmVzb3VyY2VQcm92aWRlcjo6 U2NvcGVkV3JpdGVMb2NrR0wgbG9jayhyZXNvdXJjZVByb3ZpZGVyLCB0ZXh0dXJlLT5yZXNvdXJj ZUlkKCkpOwogICAgIC8vIENyZWF0ZSBhbiBhY2NlbGVyYXRlZCBjYW52YXMgdG8gZHJhdyBvbi4K ICAgICBPd25QdHI8U2tDYW52YXM+IGNhbnZhcyA9IGNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKGdy Q29udGV4dCwgdGV4dHVyZS0+c2l6ZSgpLCBsb2NrLnRleHR1cmVJZCgpKTsKIAo= 160998 2012-08-28 09:27:08 -0700 2012-08-31 11:24:03 -0700 proposed patch 92660.patch text/plain 2623 alokp SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjgwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTI3ICBBbG9rIFBy aXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gTGF5 b3V0IHRlc3RzIHN2Zy1maWx0ZXJzLmh0bWwgYW5kIGFscGhhLmh0bWwgYXJlIGNyYXNoaW5nIGlu dGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MjY2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIHVzZSB0d28gR0wgY29udGV4dHMgdG8gY3JlYXRlIGFuZCB1cGxvYWQgdGlsZSB0ZXh0 dXJlcy4KKyAgICAgICAgT25lIGNvbnRleHQgY3JlYXRlcyB0aGUgdGV4dHVyZSwgd2hpbGUgYW5v dGhlciB1cGxvYWRzIGl0LgorICAgICAgICBFdmVuIHRob3VnaCB0aGUgdGV4dHVyZSBpcyBzaGFy ZWQgYnkgdGhlIHR3byBjb250ZXh0cywgaXQgaXMgbm90CisgICAgICAgIGF2YWlsYWJsZSB0byB0 aGUgdXBsb2FkaW5nIGNvbnRleHQgaW1tZWRpYXRlbHkgYWZ0ZXIgY3JlYXRpb24sCisgICAgICAg IHVubGVzcyB0aGUgY3JlYXRpbmcgY29udGV4dCBpcyBmbHVzaGVkLiAKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJU ZXh0dXJlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVBY2NlbGVyYXRlZENh bnZhcyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXI6OnVwZGF0ZVRleHR1cmVSZWN0KToKKwogMjAxMi0wOC0yNCAgSmFtZXMg Um9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ2xl YW4gdXAgZGVwZW5kZW5jaWVzIG9mIFdlYlNjcm9sbGJhciBhbmQgV2ViU2Nyb2xsYmFyTGF5ZXIK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZyYW1lQnVm ZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRnJhbWVCdWZmZXJTa1Bp Y3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAkocmV2aXNpb24gMTI2ODA0KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRnJhbWVCdWZmZXJTa1Bp Y3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAz LDExICsxMDMsMTYgQEAgTGF5ZXJUZXh0dXJlVXBkYXRlcjo6U2FtcGxlZFRleGVsRm9ybWF0IAog CiB2b2lkIEZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6dXBk YXRlVGV4dHVyZVJlY3QoV2ViR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIEdyQ29udGV4dCog Z3JDb250ZXh0LCBDQ1Jlc291cmNlUHJvdmlkZXIqIHJlc291cmNlUHJvdmlkZXIsIENDUHJpb3Jp dGl6ZWRUZXh0dXJlKiB0ZXh0dXJlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25zdCBJ bnRTaXplJiBkZXN0T2Zmc2V0KQogewotICAgIC8vIE1ha2Ugc3VyZSBnYW5lc2ggdXNlcyB0aGUg Y29ycmVjdCBHTCBjb250ZXh0LgotICAgIGNvbnRleHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwot CiAgICAgdGV4dHVyZS0+YWNxdWlyZUJhY2tpbmdUZXh0dXJlKHJlc291cmNlUHJvdmlkZXIpOwor ICAgIC8vIEZsdXNoIHRoZSBjb250ZXh0IGluIHdoaWNoIHRoZSBiYWNraW5nIHRleHR1cmUgaXMg Y3JlYXRlZCBzbyB0aGF0IGl0CisgICAgLy8gaXMgYXZhaWxhYmxlIGluIG90aGVyIHNoYXJlZCBj b250ZXh0cy4gSXQgaXMgaW1wb3J0YW50IHRvIGRvIGhlcmUKKyAgICAvLyBiZWNhdXNlIHRoZSBi YWNraW5nIHRleHR1cmUgaXMgY3JlYXRlZCBpbiBvbmUgY29udGV4dCB3aGlsZSBpdCBpcworICAg IC8vIGJlaW5nIHdyaXR0ZW4gdG8gaW4gYW5vdGhlci4KKyAgICByZXNvdXJjZVByb3ZpZGVyLT5m bHVzaCgpOwogICAgIENDUmVzb3VyY2VQcm92aWRlcjo6U2NvcGVkV3JpdGVMb2NrR0wgbG9jayhy ZXNvdXJjZVByb3ZpZGVyLCB0ZXh0dXJlLT5yZXNvdXJjZUlkKCkpOworCisgICAgLy8gTWFrZSBz dXJlIGdhbmVzaCB1c2VzIHRoZSBjb3JyZWN0IEdMIGNvbnRleHQuCisgICAgY29udGV4dC0+bWFr ZUNvbnRleHRDdXJyZW50KCk7CiAgICAgLy8gQ3JlYXRlIGFuIGFjY2VsZXJhdGVkIGNhbnZhcyB0 byBkcmF3IG9uLgogICAgIE93blB0cjxTa0NhbnZhcz4gY2FudmFzID0gY3JlYXRlQWNjZWxlcmF0 ZWRDYW52YXMoZ3JDb250ZXh0LCB0ZXh0dXJlLT5zaXplKCksIGxvY2sudGV4dHVyZUlkKCkpOwog Cg== 162592 2012-09-06 14:46:42 -0700 2012-09-06 14:48:21 -0700 Adjusting TestExpectations 92260.patch text/plain 1542 alokp SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNzc4NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA2ICBBbG9rIFByaXlhZGFyc2hp ICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gTGF5b3V0IHRlc3Rz IHN2Zy1maWx0ZXJzLmh0bWwgYW5kIGFscGhhLmh0bWwgYXJlIGNyYXNoaW5nIGludGVybWl0dGVu dGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjY2 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0 ZSBjaHJvbWl1bSBUZXN0RXhwZWN0YXRpb25zIHRvIHJlbW92ZSBmYWlsdXJlcyBmb3IgYWNjZWxl cmF0ZWQtcGFpbnRpbmcuCisgICAgICAgIFRoZXkgd2VyZSBmaXhlZCBpbiByMTI3Mjk0LgorCisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wOS0w NiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl0gQ2xhc3NpZnkgc2V2ZXJhbCB0ZXN0IGNhc2VzIGluIFRlc3RFeHBlY3Rh dGlvbnMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlv bnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucwkocmV2aXNpb24gMTI3NzgzKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjY5MywxMCArMjY5Myw2IEBA IEJVR1dLNzcxMTAgV0lOIERFQlVHIDogYWNjZXNzaWJpbGl0eS9sb2EKIAogQlVHV0s3MzUxNCBX SU4gOiBwbGF0Zm9ybS9jaHJvbWl1bS9jb21wb3NpdGluZy9sb3N0LWNvbXBvc2l0b3ItY29udGV4 dC1wZXJtYW5lbnRseS5odG1sID0gUEFTUyBUSU1FT1VUCiAKLS8vIEZsYWt5L2NyYXNoaW5nCi1C VUdXSzkyNjYwIDogcGxhdGZvcm0vY2hyb21pdW0vY29tcG9zaXRpbmcvYWNjZWxlcmF0ZWQtZHJh d2luZy9zdmctZmlsdGVycy5odG1sID0gQ1JBU0ggUEFTUwotQlVHV0s5MjY2MCA6IHBsYXRmb3Jt L2Nocm9taXVtL2NvbXBvc2l0aW5nL2FjY2VsZXJhdGVkLWRyYXdpbmcvYWxwaGEuaHRtbCA9IENS QVNIIFBBU1MKLQogQlVHV0s3Mzc2NiA6IGNzczMvdW5pY29kZS1iaWRpLWlzb2xhdGUtYWhhcm9u LWZhaWxpbmcuaHRtbCA9IElNQUdFCiAKIEJVR1dLNzg1NDQgTElOVVggQU5EUk9JRCA6IGZhc3Qv dGV4dC9pbnRlcm5hdGlvbmFsL2RhbmRhLXNwYWNlLmh0bWwgPSBQQVNTIElNQUdFIElNQUdFK1RF WFQK