92651 2012-07-30 08:45:14 -0700 [GTK] critical warning: gdk_window_get_cursor() called on a NULL window 2012-07-30 13:58:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 682047 0 csaavedra 2012-07-30 08:45:14 -0700 In WK2, WebKit::PageClientImpl::setCursor(WebCore::Cursor const&) is calling gdk_window_get_cursor() in a NULL GdkWindow. Maybe the underlying widget is not realized yet? This happens when I open a new Epiphany session after having closed one with several tabs open. #0 0x00007ffff3c23c11 in g_logv (log_domain=0x7ffff4357075 "Gdk", log_level=G_LOG_LEVEL_CRITICAL, format=0x7ffff3ca82c0 "%s: assertion `%s' failed", args1=0x7fffffffc4b8) at gmessages.c:758 #1 0x00007ffff3c23d05 in g_log (log_domain=0x7ffff4357075 "Gdk", log_level=G_LOG_LEVEL_CRITICAL, format=0x7ffff3ca82c0 "%s: assertion `%s' failed") at gmessages.c:792 #2 0x00007ffff3c23d46 in g_return_if_fail_warning (log_domain=0x7ffff4357075 "Gdk", pretty_function=0x7ffff4357e40 "gdk_window_get_cursor", expression=0x7ffff435725e "GDK_IS_WINDOW (window)") at gmessages.c:801 #3 0x00007ffff431163e in gdk_window_get_cursor (window=0x0) at gdkwindow.c:6766 #4 0x00007ffff6a7e8ca in WebKit::PageClientImpl::setCursor(WebCore::Cursor const&) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #5 0x00007ffff6b83d70 in void CoreIPC::handleMessage<Messages::WebPageProxy::SetCursor, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)>(CoreIPC::ArgumentDecoder*, WebKit::WebPageP roxy*, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #6 0x00007ffff6b8392b in WebKit::WebPageProxy::didReceiveWebPageProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #7 0x00007ffff6ac1a4a in WebKit::WebConnectionToWebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #8 0x00007ffff6a3f958 in CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #9 0x00007ffff6a3fa82 in CoreIPC::Connection::dispatchOneMessage() () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #10 0x00007ffff71d4224 in WebCore::RunLoop::performWork() () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #11 0x00007ffff7a99849 in WebCore::RunLoop::queueWork(WebCore::RunLoop*) () from /opt/gnome-3.0/lib64/libwebkit2gtk-3.0.so.0 #12 0x00007ffff3c1c818 in g_idle_dispatch (source=0x7fff88001c50, callback=0x7ffff7a99840 <WebCore::RunLoop::queueWork(WebCore::RunLoop*)>, user_data=0x7fffe9cf6c98) at gmain.c:4788 #13 0x00007ffff3c1a1d5 in g_main_dispatch (context=0x511510) at gmain.c:2698 #14 0x00007ffff3c1ad85 in g_main_context_dispatch (context=0x511510) at gmain.c:3202 #15 0x00007ffff3c1af68 in g_main_context_iterate (context=0x511510, block=1, dispatch=1, self=0x53a520) at gmain.c:3273 #16 0x00007ffff3c1b02c in g_main_context_iteration (context=0x511510, may_block=1) at gmain.c:3334 #17 0x00007ffff3e2e7b0 in g_application_run (application=0x630010, argc=1, argv=0x7fffffffd0c8) at gapplication.c:1607 #18 0x000000000042e0e3 in main (argc=1, argv=0x7fffffffd0c8) at ephy-main.c:493 682067 1 155298 csaavedra 2012-07-30 09:13:18 -0700 Created attachment 155298 2012-07-30 Claudio Saavedra <csaavedra@igalia.com> [GTK] critical warning: gdk_window_get_cursor() called on a NULL window https://bugs.webkit.org/show_bug.cgi?id=92651 Reviewed by NOBODY (OOPS!). PageClientImpl::setCursor() might get called before the window is realized, so safeguard against it. * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::setCursor): early return if the window is not realized. 682075 2 webkit.review.bot 2012-07-30 09:20:57 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 682353 3 155298 webkit.review.bot 2012-07-30 13:58:14 -0700 Comment on attachment 155298 2012-07-30 Claudio Saavedra <csaavedra@igalia.com> Clearing flags on attachment: 155298 Committed r124087: <http://trac.webkit.org/changeset/124087> 682354 4 webkit.review.bot 2012-07-30 13:58:18 -0700 All reviewed patches have been landed. Closing bug. 155298 2012-07-30 09:13:18 -0700 2012-07-30 13:58:14 -0700 2012-07-30 Claudio Saavedra <csaavedra@igalia.com> 2012-07-30-Claudio-Saavedra-csaavedraigaliacom.patch text/plain 2322 csaavedra RnJvbSA4NTE3OGM2OTQ5ODIyMjUzNjM4NDI1Yjc1ZDUyODBlZjNhZGU4NGI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGF1ZGlvIFNhYXZlZHJhIDxjc2FhdmVkcmFAaWdhbGlhLmNv bT4KRGF0ZTogTW9uLCAzMCBKdWwgMjAxMiAxODoxMjoxOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTItMDctMzAgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KCiAg ICAgICAgW0dUS10gY3JpdGljYWwgd2FybmluZzogZ2RrX3dpbmRvd19nZXRfY3Vyc29yKCkgY2Fs bGVkIG9uIGEgTlVMTCB3aW5kb3cKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTI2NTEKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgIFBhZ2VDbGllbnRJbXBsOjpzZXRDdXJzb3IoKSBtaWdodCBnZXQgY2FsbGVkIGJlZm9y ZSB0aGUKICAgICAgICB3aW5kb3cgaXMgcmVhbGl6ZWQsIHNvIHNhZmVndWFyZCBhZ2FpbnN0IGl0 LgoKICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKICAgICAg ICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6c2V0Q3Vyc29yKTogZWFybHkgcmV0dXJuIGlmIHRo ZSB3aW5kb3cgaXMKICAgICAgICBub3QgcmVhbGl6ZWQuCi0tLQogU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcCB8ICAzICsr KwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDgxNDU1 NWUuLmFmNGY3NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNy0zMCAgQ2xh dWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGNy aXRpY2FsIHdhcm5pbmc6IGdka193aW5kb3dfZ2V0X2N1cnNvcigpIGNhbGxlZCBvbiBhIE5VTEwg d2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBh Z2VDbGllbnRJbXBsOjpzZXRDdXJzb3IoKSBtaWdodCBnZXQgY2FsbGVkIGJlZm9yZSB0aGUKKyAg ICAgICAgd2luZG93IGlzIHJlYWxpemVkLCBzbyBzYWZlZ3VhcmQgYWdhaW5zdCBpdC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGFnZUNsaWVudEltcGw6OnNldEN1cnNvcik6IGVhcmx5IHJldHVybiBpZiB0aGUgd2lu ZG93IGlzCisgICAgICAgIG5vdCByZWFsaXplZC4KKwogMjAxMi0wNy0yNyAgQ2hyaXN0b3BoZSBE dW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0g QXNzZXJ0aW9uIGhpdCBpbiBld2tfY29va2llX21hbmFnZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggOGVjZDQ4 MC4uNWE2YWRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv UGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtMTQyLDYgKzE0Miw5IEBAIHZvaWQgUGFnZUNsaWVudElt cGw6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYgbmV3VG9vbFRp cCkKIAogdm9pZCBQYWdlQ2xpZW50SW1wbDo6c2V0Q3Vyc29yKGNvbnN0IEN1cnNvciYgY3Vyc29y KQogeworICAgIGlmICghZ3RrX3dpZGdldF9nZXRfcmVhbGl6ZWQobV92aWV3V2lkZ2V0KSkKKyAg ICAgICAgcmV0dXJuOworCiAgICAgLy8gW0dUS10gV2lkZ2V0OjpzZXRDdXJzb3IoKSBnZXRzIGNh bGxlZCBmcmVxdWVudGx5CiAgICAgLy8gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYzODgKICAgICAvLyBTZXR0aW5nIHRoZSBjdXJzb3IgbWF5IGJlIGFuIGV4cGVuc2l2 ZSBvcGVyYXRpb24gaW4gc29tZSBiYWNrZW5kcywKLS0gCjEuNy4xMS4y