92627 2012-07-30 04:12:21 -0700 [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work 2012-07-30 12:21:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED NRWT, Qt, QtTriaged P2 Normal --- 91754 1 ossy kbalazs abarth dpranke galpeter kadam kbalazs kkristof noam ojan ossy webkit.review.bot oldest_to_newest 681847 0 ossy 2012-07-30 04:12:21 -0700 "run-webkit-tests --pixel-tests --pixel-test-directory X" works fine, but "run-webkit-tests --pixel-tests X.html Y.html Z-directory" doesn't run pixel tests. I think the new --pixel-test-directory shouldn't affect the original behaviour of NRWT when we don't use this option. Could you check it, please? 681863 1 kbalazs 2012-07-30 04:37:09 -0700 This is because I made compositing the default directory for pixel testing. Maybe it was not the best idea. My idea was that maybe we want to run pixel test by default but only for the test cases that affects accelerated compositing. I made it to be a default so that developers run the same set of pixel tests as bots (without the need to know some special configuration). One workaround could be to accept globs, so one could say --pixel-test-directory *. However, given that it's still not very clear how we want to go on with pixel testing, I could rather just remove this default behavior, so that --pixel-tests will turn on pixel testing for all tests again. 681872 2 155257 kbalazs 2012-07-30 04:43:26 -0700 Created attachment 155257 Patch 681874 3 ossy 2012-07-30 04:45:20 -0700 (In reply to comment #1) > This is because I made compositing the default directory for pixel testing. Maybe it was not the best idea. My idea was that maybe we want to run pixel test by default but only for the test cases that affects accelerated compositing. I made it to be a default so that developers run the same set of pixel tests as bots (without the need to know some special configuration). > One workaround could be to accept globs, so one could say --pixel-test-directory *. However, given that it's still not very clear how we want to go on with pixel testing, I could rather just remove this default behavior, so that --pixel-tests will turn on pixel testing for all tests again. Ah, I see it now. The idea was good to switch on pixel tests by default for compositing dir. But unfortunately its sideeffect was that we can't run pixel tests for other dirs without passing --pixel-test-directory ... Now I don't have idea which workaround would be better ... Don't hurry, we have time to find the best solution. ;-) I'm examining the status, stability, ... of pixel testing after the big rebaseline. 681878 4 kbalazs 2012-07-30 04:48:34 -0700 > Ah, I see it now. The idea was good to switch on pixel tests by default for > compositing dir. No, I was not enabled pixel testing by default, but restricted --pixel-tests to compositing (by default). 681958 5 155257 ossy 2012-07-30 06:21:43 -0700 Comment on attachment 155257 Patch Clearing flags on attachment: 155257 Committed r124020: <http://trac.webkit.org/changeset/124020> 681959 6 ossy 2012-07-30 06:21:50 -0700 All reviewed patches have been landed. Closing bug. 682279 7 dpranke 2012-07-30 12:21:01 -0700 It seems like there's four different things we might want to do ... 1) don't run any pixel tests 2) run a default set 3) run a custom set 4) run all of them One option would be to introduce a magic directory name (e.g., "default"), and you could then say "--pixel-test-directory default --pixel-test-directory svg" , etc. Another option (that I like less) would be to add another command line flag. Another option would be to not have the default set, but it seems like if this "only run some of them" idea is a good permanent solution we'll really want a default set. 155257 2012-07-30 04:43:26 -0700 2012-07-30 06:21:43 -0700 Patch bug-92627-20120730134256.patch text/plain 1651 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2Q4ZWQ3OTExNzZjMzkwOGMyNDBhM2Q3ZDMwMjk1YTQ4 MzdlYTM1Yy4uN2EwZTUzOWUzZWZhN2Q2NTNhNjAyZjQwMWY4MWEwYTIwMGU5ZDY5NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA3LTMwICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbUXRdW05SV1RdIFJFR1JFU1NJT04oMTIzNzI5KTogRm9yY2luZyBwaXhlbCB0ZXN0 cyB3aXRoIC1wIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTI2MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgdGhlIGRlZmF1bHQgYmVoYXZpb3IgSSBhZGRlZCBpbiByMTIz NzI5IHNvIHRoYXQgd2UgcnVuIGFsbCB0ZXN0cyBhcyBwaXhlbAorICAgICAgICB0ZXN0IHdpdGgg LXAuIEl0IHdhcyBpbnRlbnRpb25hbCBidXQgaXQgc2VlbXMgbGlrZSB3ZSBkb24ndCBoYXZlIGNv bnNlbnN1cyBvbgorICAgICAgICB0aGF0IHdlIHdhbnQgaXQuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5OgorICAgICAgICAoUXRQb3J0Ll9zdXBw b3J0c19zd2l0Y2hpbmdfcGl4ZWxfdGVzdHNfcGVyX3Rlc3QpOgorCiAyMDEyLTA3LTMwICBNaWto YWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdW1dUUl0gRW5mb3JjZSBTSElGVCBtb2RpZmllciB0byB1cHBlciBjYXNlIGtleXMgaW4g ZXZlbnQgc2VuZGVyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvcXQucHkKaW5kZXggMzkyYWIwMjhmZWE0MDdhNDM2NTU2ZWYyOTFmOTE3OTEzYjY2Nzg4MS4u ZTIzOWM3ZTNhYWY2ZjYwMmIwYzM1MWVjMjJkY2ZhNjgwNjRlYTI2OSAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CkBAIC0xODcsMTAgKzE4Nywz IEBAIGNsYXNzIFF0UG9ydChQb3J0KToKICAgICBkZWYgX3N1cHBvcnRzX3N3aXRjaGluZ19waXhl bF90ZXN0c19wZXJfdGVzdChzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKIAotICAgIGRlZiBf c2hvdWxkX3J1bl9hc19waXhlbF90ZXN0KHNlbGYsIHRlc3RfaW5wdXQpOgotICAgICAgICByZXR1 cm4gYW55KHRlc3RfaW5wdXQudGVzdF9uYW1lLnN0YXJ0c3dpdGgoZGlyZWN0b3J5KQotICAgICAg ICAgICAgICAgICAgIGZvciBkaXJlY3RvcnkgaW4gUXRQb3J0Ll9kZWZhdWx0X3BpeGVsX3Rlc3Rf ZGlyZWN0b3JpZXMoKSkKLQotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgX2RlZmF1bHRfcGl4 ZWxfdGVzdF9kaXJlY3RvcmllcygpOgotICAgICAgICByZXR1cm4gWydjb21wb3NpdGluZyddCg==