92598 2012-07-29 15:10:44 -0700 PropertyNameArray::m_shouldCache is only assigned and never used 2012-07-29 16:16:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough fpizlo ggaren mhahnenberg oliver oldest_to_newest 681603 0 fpizlo 2012-07-29 15:10:44 -0700 It should be removed. 681604 1 155184 fpizlo 2012-07-29 15:14:01 -0700 Created attachment 155184 the patch 681613 2 155184 fpizlo 2012-07-29 16:13:29 -0700 Comment on attachment 155184 the patch Will land manually. 681615 3 fpizlo 2012-07-29 16:16:01 -0700 Landed in http://trac.webkit.org/changeset/123989 155184 2012-07-29 15:14:01 -0700 2012-07-29 16:13:29 -0700 the patch killshouldcache_patch_1.diff text/plain 1872 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIzOTg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA3LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UHJvcGVydHlOYW1lQXJyYXk6Om1fc2hvdWxkQ2FjaGUgaXMgb25seSBhc3NpZ25lZCBhbmQgbmV2 ZXIgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI1OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJ1bnRpbWUvUHJvcGVydHlOYW1lQXJyYXkuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlOYW1l QXJyYXk6OlByb3BlcnR5TmFtZUFycmF5KToKKyAgICAgICAgKFByb3BlcnR5TmFtZUFycmF5KToK KwogMjAxMi0wNy0yOSAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgogCiAgICAg ICAgIEFkZCBFTkFCTEVfQ1NTX0NPTVBPU0lUSU5HIGZsYWcKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1Byb3BlcnR5TmFtZUFycmF5LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVydHlOYW1lQXJyYXkuaAkocmV2aXNpb24gMTIz Njk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVydHlOYW1lQXJyYXku aAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiAgQ29weXJpZ2h0IChDKSAy MDA2LCAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQg KEMpIDIwMDYsIDIwMDgsIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJh cnkgR2VuZXJhbCBQdWJsaWMKQEAgLTU1LDE0ICs1NSwxMiBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgUHJvcGVydHlOYW1lQXJyYXkoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhKQogICAgICAg ICAgICAgOiBtX2RhdGEoUHJvcGVydHlOYW1lQXJyYXlEYXRhOjpjcmVhdGUoKSkKICAgICAgICAg ICAgICwgbV9nbG9iYWxEYXRhKGdsb2JhbERhdGEpCi0gICAgICAgICAgICAsIG1fc2hvdWxkQ2Fj aGUodHJ1ZSkKICAgICAgICAgewogICAgICAgICB9CiAKICAgICAgICAgUHJvcGVydHlOYW1lQXJy YXkoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICAgICAgOiBtX2RhdGEoUHJvcGVydHlOYW1lQXJy YXlEYXRhOjpjcmVhdGUoKSkKICAgICAgICAgICAgICwgbV9nbG9iYWxEYXRhKCZleGVjLT5nbG9i YWxEYXRhKCkpCi0gICAgICAgICAgICAsIG1fc2hvdWxkQ2FjaGUodHJ1ZSkKICAgICAgICAgewog ICAgICAgICB9CiAKQEAgLTkxLDcgKzg5LDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIFJl ZlB0cjxQcm9wZXJ0eU5hbWVBcnJheURhdGE+IG1fZGF0YTsKICAgICAgICAgSWRlbnRpZmllclNl dCBtX3NldDsKICAgICAgICAgSlNHbG9iYWxEYXRhKiBtX2dsb2JhbERhdGE7Ci0gICAgICAgIGJv b2wgbV9zaG91bGRDYWNoZTsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MK