92570 2012-07-27 22:04:22 -0700 [Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?) 2012-08-03 14:19:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pkasting pfeldman abarth apavlov bweinstein haraken japhet jochen joepeck kbr keishi loislo msaboff pfeldman pmuellr rik timothy ulan webkit.review.bot yurys oldest_to_newest 681327 0 pkasting 2012-07-27 22:04:22 -0700 At least the following tests all began timing out on the Chromium Windows debug canary bot at the same time: inspector/debugger/dom-breakpoints.html (consistently) inspector/timeline/timeline-network-received-data.html (usually) inspector/timeline/timeline-start-time.html (sometimes) The regression range is WebKit r123556-r123563: http://trac.webkit.org/log/?verbose=on&rev=123563&stop_rev=123556 Or Chromium r148262-148277: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&mode=html&range=148277:148262 See flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fdom-breakpoints.html%2Cinspector%2Ftimeline%2Ftimeline-network-received-data.html%2Cinspector%2Ftimeline%2Ftimeline-start-time.html The Chromium commits look harmless to me. The most obvious culprits seem like http://trac.webkit.org/changeset/123556 and http://trac.webkit.org/changeset/123560 . CCed those patch authors. Sending to pfeldman for initial triage, anyone else who knows the area feel free to take. 682246 1 155331 kbr 2012-07-30 11:50:52 -0700 Created attachment 155331 Patch 682250 2 kbr 2012-07-30 11:51:45 -0700 I can believe that my patch http://trac.webkit.org/changeset/123556 could be the culprit. Here's a patch that should avoid having it affect these Inspector tests; shall we land this and see whether it clears up the timeouts? 685632 3 155331 pfeldman 2012-08-02 11:53:01 -0700 Comment on attachment 155331 Patch Do you have anyone to stamp this change? I can do that in case it is safe and you provide a brief explanation on why it is so. Thanks. 685987 4 kbr 2012-08-02 16:47:51 -0700 It restricts the earlier heuristics which force full GCs to only apply to pages using WebGL, not pages using 2D canvas contexts. This is sufficient for our needs at the moment, and I think will clear up the Inspector timeouts if those pages are using 2D canvas. 686252 5 155331 webkit.review.bot 2012-08-02 23:10:23 -0700 Comment on attachment 155331 Patch Rejecting attachment 155331 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp Hunk #1 FAILED at 87. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13424550 687004 6 156426 kbr 2012-08-03 11:46:18 -0700 Created attachment 156426 Patch for landing 687144 7 156426 webkit.review.bot 2012-08-03 14:19:52 -0700 Comment on attachment 156426 Patch for landing Clearing flags on attachment: 156426 Committed r124653: <http://trac.webkit.org/changeset/124653> 687145 8 webkit.review.bot 2012-08-03 14:19:58 -0700 All reviewed patches have been landed. Closing bug. 155331 2012-07-30 11:50:52 -0700 2012-08-03 11:46:13 -0700 Patch bug-92570-20120730115036.patch text/plain 2592 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QwZDZiZDEyMjlhMmRm N2ZmYTliMWYyMDFiZTllZDVkMmMwNDBhMi4uMWJlMzAyYWUwYzZmZTBjY2ZkOTdhNzQyMjkwYzAw OGFmZWU4NThjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTMwICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYiBJ bnNwZWN0b3I6IFdpbiBEYmcgdGVzdHMgdGltaW5nIG91dCAocjEyMzU1NiBvciByMTIzNTYwPykK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTcwCisK KyAgICAgICAgVHJ5IHJlc3RyaWN0aW5nIHRoZSB1c2Ugb2YgdGhlIEdDIGhpbnQgZm9yIGNhbnZh cyBjb250ZXh0cyB0byBvbmx5CisgICAgICAgIFdlYkdMIGNvbnRleHRzLCB3aGVyZSBpdCBpcyBt b3N0IG5lZWRlZCwgdG8gc2VlIHdoZXRoZXIgdGhpcworICAgICAgICBjbGVhcnMgdXAgdGhlIHRp bWVvdXRzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1l bnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhIVE1MQ2FudmFzRWxlbWVudDo6Z2V0 Q29udGV4dENhbGxiYWNrKToKKwogMjAxMi0wNy0zMCAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBn b29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVHVybiBiYWNrIG9uIFNjcm9sbGJhckxh eWVyQ2hyb21pdW0gZm9yIFdpbmRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOEhUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNwcAppbmRl eCAxMTBhZTliODY5NWIxYjg2ZGI4MzgyNDExOTU0Y2EzNjU4ZmIzZTc5Li5kYTE2NTE3OTUzY2E5 ZDUzNzE2ZjM1OGU4ZTYxNTI5ZWFlMGRmNDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhIVE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20u Y3BwCkBAIC04NywxNiArODcsMTYgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTENhbnZh c0VsZW1lbnQ6OmdldENvbnRleHRDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnQKICAgICBpZiAo IXJlc3VsdCkKICAgICAgICAgcmV0dXJuIHY4OjpOdWxsKGFyZ3MuR2V0SXNvbGF0ZSgpKTsKIAot ICAgIC8vIEJvdGggMkQgYW5kIDNEIGNhbnZhcyBjb250ZXh0cyBjYW4gaG9sZCBvbiB0byBsb3Rz IG9mIEdQVSByZXNvdXJjZXMsIGFuZCB3ZQotICAgIC8vIHdhbnQgdG8gdGFrZSBhbiBvcHBvcnR1 bml0eSB0byBnZXQgcmlkIG9mIHRoZW0gYXMgc29vbiBhcyBwb3NzaWJsZSB3aGVuIHdlCi0gICAg Ly8gbmF2aWdhdGUgYXdheSBmcm9tIHBhZ2VzIHVzaW5nIHRoZW0uCi0gICAgVjhCaW5kaW5nUGVy SXNvbGF0ZURhdGEqIHBlcklzb2xhdGVEYXRhID0gVjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmN1 cnJlbnQoYXJncy5HZXRJc29sYXRlKCkpOwotICAgIHBlcklzb2xhdGVEYXRhLT5zZXRMb3dNZW1v cnlOb3RpZmljYXRpb25IaW50KCk7Ci0KICAgICBpZiAocmVzdWx0LT5pczJkKCkpCiAgICAgICAg IHJldHVybiB0b1Y4KHN0YXRpY19jYXN0PENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCo+KHJlc3Vs dCksIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICNpZiBFTkFCTEUoV0VCR0wpCiAgICAgZWxzZSBpZiAo cmVzdWx0LT5pczNkKCkpIHsKKyAgICAgICAgLy8gM0QgY2FudmFzIGNvbnRleHRzIGNhbiBob2xk IG9uIHRvIGxvdHMgb2YgR1BVIHJlc291cmNlcywgYW5kIHdlIHdhbnQgdG8gdGFrZSBhbgorICAg ICAgICAvLyBvcHBvcnR1bml0eSB0byBnZXQgcmlkIG9mIHRoZW0gYXMgc29vbiBhcyBwb3NzaWJs ZSB3aGVuIHdlIG5hdmlnYXRlIGF3YXkgZnJvbSBwYWdlcyB1c2luZworICAgICAgICAvLyB0aGVt LgorICAgICAgICBWOEJpbmRpbmdQZXJJc29sYXRlRGF0YSogcGVySXNvbGF0ZURhdGEgPSBWOEJp bmRpbmdQZXJJc29sYXRlRGF0YTo6Y3VycmVudChhcmdzLkdldElzb2xhdGUoKSk7CisgICAgICAg IHBlcklzb2xhdGVEYXRhLT5zZXRMb3dNZW1vcnlOb3RpZmljYXRpb25IaW50KCk7CisKICAgICAg ICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHY4UmVzdWx0ID0gdG9WOChzdGF0aWNfY2FzdDxXZWJH TFJlbmRlcmluZ0NvbnRleHQqPihyZXN1bHQpLCBhcmdzLkdldElzb2xhdGUoKSk7CiAgICAgICAg IGlmIChJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246Omhhc0Zyb250ZW5kcygpKSB7CiAgICAgICAg ICAgICBTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUgPSBTY3JpcHRTdGF0ZTo6Zm9yQ29udGV4dCh2 ODo6Q29udGV4dDo6R2V0Q3VycmVudCgpKTsK 156426 2012-08-03 11:46:18 -0700 2012-08-03 14:19:52 -0700 Patch for landing bug-92570-20120803114558.patch text/plain 2630 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgyYWU2MjY2YzQ4ODcx NTBlNDFlNjlhNDE2Nzk5ZGQ2YmFkN2MzYy4uODYwMTM3MGM5ZjM4ZjFlOTVhNDJkNWI2NjZmZWNm MWY0ZTZiNDczOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTAzICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYiBJ bnNwZWN0b3I6IFdpbiBEYmcgdGVzdHMgdGltaW5nIG91dCAocjEyMzU1NiBvciByMTIzNTYwPykK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTcwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KKworICAgICAgICBUcnkgcmVzdHJp Y3RpbmcgdGhlIHVzZSBvZiB0aGUgR0MgaGludCBmb3IgY2FudmFzIGNvbnRleHRzIHRvIG9ubHkK KyAgICAgICAgV2ViR0wgY29udGV4dHMsIHdoZXJlIGl0IGlzIG1vc3QgbmVlZGVkLCB0byBzZWUg d2hldGhlciB0aGlzCisgICAgICAgIGNsZWFycyB1cCB0aGUgdGltZW91dHMuCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOEhUTUxDYW52YXNFbGVtZW50OjpnZXRDb250ZXh0Q2FsbGJhY2spOgor CiAyMDEyLTA4LTAzICBTYWRydWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBBdm9pZCBkaXNwYXRjaGluZyBnZXN0dXJlIGV2ZW50cyBvZiB1bmtub3du IHR5cGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhI VE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhIVE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHAKaW5kZXggZjllOGFhNjRkZTkyNjNh ZDRmYWQyYjVmMGQxYmEyMzc0MjcwOTI4NC4uZmU1NGQ4NTcyZjQwNzI3YjkwMTYxMzMyY2I2MDAx YjdmMDI3YTNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOEhUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNwcApAQCAtODcsMTYgKzg3 LDE2IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxDYW52YXNFbGVtZW50OjpnZXRDb250 ZXh0Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50CiAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAg IHJldHVybiB2ODo6TnVsbChhcmdzLkdldElzb2xhdGUoKSk7CiAKLSAgICAvLyBCb3RoIDJEIGFu ZCAzRCBjYW52YXMgY29udGV4dHMgY2FuIGhvbGQgb24gdG8gbG90cyBvZiBHUFUgcmVzb3VyY2Vz LCBhbmQgd2UKLSAgICAvLyB3YW50IHRvIHRha2UgYW4gb3Bwb3J0dW5pdHkgdG8gZ2V0IHJpZCBv ZiB0aGVtIGFzIHNvb24gYXMgcG9zc2libGUgd2hlbiB3ZQotICAgIC8vIG5hdmlnYXRlIGF3YXkg ZnJvbSBwYWdlcyB1c2luZyB0aGVtLgotICAgIFY4QmluZGluZ1Blcklzb2xhdGVEYXRhKiBwZXJJ c29sYXRlRGF0YSA9IFY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjpjdXJyZW50KGFyZ3MuR2V0SXNv bGF0ZSgpKTsKLSAgICBwZXJJc29sYXRlRGF0YS0+c2V0U2hvdWxkQ29sbGVjdEdhcmJhZ2VTb29u KCk7Ci0KICAgICBpZiAocmVzdWx0LT5pczJkKCkpCiAgICAgICAgIHJldHVybiB0b1Y4KHN0YXRp Y19jYXN0PENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCo+KHJlc3VsdCksIGFyZ3MuR2V0SXNvbGF0 ZSgpKTsKICNpZiBFTkFCTEUoV0VCR0wpCiAgICAgZWxzZSBpZiAocmVzdWx0LT5pczNkKCkpIHsK KyAgICAgICAgLy8gM0QgY2FudmFzIGNvbnRleHRzIGNhbiBob2xkIG9uIHRvIGxvdHMgb2YgR1BV IHJlc291cmNlcywgYW5kIHdlIHdhbnQgdG8gdGFrZSBhbgorICAgICAgICAvLyBvcHBvcnR1bml0 eSB0byBnZXQgcmlkIG9mIHRoZW0gYXMgc29vbiBhcyBwb3NzaWJsZSB3aGVuIHdlIG5hdmlnYXRl IGF3YXkgZnJvbSBwYWdlcyB1c2luZworICAgICAgICAvLyB0aGVtLgorICAgICAgICBWOEJpbmRp bmdQZXJJc29sYXRlRGF0YSogcGVySXNvbGF0ZURhdGEgPSBWOEJpbmRpbmdQZXJJc29sYXRlRGF0 YTo6Y3VycmVudChhcmdzLkdldElzb2xhdGUoKSk7CisgICAgICAgIHBlcklzb2xhdGVEYXRhLT5z ZXRTaG91bGRDb2xsZWN0R2FyYmFnZVNvb24oKTsKKwogICAgICAgICB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gdjhSZXN1bHQgPSB0b1Y4KHN0YXRpY19jYXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4dCo+ KHJlc3VsdCksIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICAgICAgICAgaWYgKEluc3BlY3Rvckluc3Ry dW1lbnRhdGlvbjo6aGFzRnJvbnRlbmRzKCkpIHsKICAgICAgICAgICAgIFNjcmlwdFN0YXRlKiBz Y3JpcHRTdGF0ZSA9IFNjcmlwdFN0YXRlOjpmb3JDb250ZXh0KHY4OjpDb250ZXh0OjpHZXRDdXJy ZW50KCkpOwo=