92566 2012-07-27 18:02:11 -0700 In flipped lines writing modes, hit testing at the beginning of a column may return a result from the previous column 2012-07-28 14:41:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz eric webkit.review.bot oldest_to_newest 681289 0 mitz 2012-07-27 18:02:11 -0700 In flipped lines writing modes, hit testing at the beginning of a column may return a result from the previous column 681292 1 155099 mitz 2012-07-27 18:07:32 -0700 Created attachment 155099 Enhance the fix for bug 92524 to work with flipped lines 681484 2 mitz 2012-07-28 14:41:35 -0700 Fixed in <http://trac.webkit.org/r123973>. 155099 2012-07-27 18:07:32 -0700 2012-07-28 14:32:52 -0700 Enhance the fix for bug 92524 to work with flipped lines bug-92566-20120727180719.patch text/plain 5556 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzk0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTI3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSW4gZmxpcHBlZCBsaW5lcyB3cml0 aW5nIG1vZGVzLCBoaXQgdGVzdGluZyBhdCB0aGUgYmVnaW5uaW5nIG9mIGEgY29sdW1uIG1heSBy ZXR1cm4gYSByZXN1bHQgZnJvbSB0aGUgcHJldmlvdXMgY29sdW1uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjU2NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuaGFuY2VkIHRoZSBmaXggZm9yIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzkyNTI0PiB0byB3b3JrIHdpdGggZmxpcHBlZCBsaW5lcy4KKworICAg ICAgICBFeHRlbmRlZCBmYXN0L211bHRpY29sL2hpdC10ZXN0LWVuZC1vZi1jb2x1bW4td2l0aC1s aW5lLWhlaWdodC5odG1sLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwb3NpdGlvbkZvclBvaW50V2l0aElubGlu ZUNoaWxkcmVuKTogRm9yIGZsaXBwZWQgbGluZXMsIGNoZWNrIGlmIHRoZQorICAgICAgICBoaXQg bGluZSBpcyB0aGUgbGFzdCBvbmUgYmVmb3JlIGEgcGFnZSBicmVhaywgYW5kIGluIHRoYXQgY2Fz ZSwgY2hlY2sgaWYgdGhlIGhpdCBwb2ludCB3YXMKKyAgICAgICAgYWZ0ZXIgdGhlIGJyZWFrLgor CiAyMDEyLTA3LTI3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFJlc2V0IHRoZSBzZXQgb2YgInNlZW4iIHBsdWdpbnMgd2hlbiB0aGUgbWFpbiBmcmFtZSBsb2Fk IGlzIGNvbW1pdHRlZC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcAkocmV2aXNpb24gMTIzOTEyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDkxNiw2ICs0OTE2LDggQEAgVmlzaWJsZVBv c2l0aW9uIFJlbmRlckJsb2NrOjpwb3NpdGlvbkZvcgogICAgIGlmICghZmlyc3RSb290Qm94KCkp CiAgICAgICAgIHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24oMCwgRE9XTlNUUkVBTSk7CiAK KyAgICBib29sIGxpbmVzQXJlRmxpcHBlZCA9IHN0eWxlKCktPmlzRmxpcHBlZExpbmVzV3JpdGlu Z01vZGUoKTsKKwogICAgIC8vIGxvb2sgZm9yIHRoZSBjbG9zZXN0IGxpbmUgYm94IGluIHRoZSBy b290IGJveCB3aGljaCBpcyBhdCB0aGUgcGFzc2VkLWluIHkgY29vcmRpbmF0ZQogICAgIElubGlu ZUJveCogY2xvc2VzdEJveCA9IDA7CiAgICAgUm9vdElubGluZUJveCogZmlyc3RSb290Qm94V2l0 aENoaWxkcmVuID0gMDsKQEAgLTQ5MjYsMTMgKzQ5MjgsMjEgQEAgVmlzaWJsZVBvc2l0aW9uIFJl bmRlckJsb2NrOjpwb3NpdGlvbkZvcgogICAgICAgICBpZiAoIWZpcnN0Um9vdEJveFdpdGhDaGls ZHJlbikKICAgICAgICAgICAgIGZpcnN0Um9vdEJveFdpdGhDaGlsZHJlbiA9IHJvb3Q7CiAKLSAg ICAgICAgaWYgKHJvb3QtPmlzRmlyc3RBZnRlclBhZ2VCcmVhaygpICYmIHBvaW50SW5Mb2dpY2Fs Q29udGVudHMueSgpIDwgcm9vdC0+bGluZVRvcFdpdGhMZWFkaW5nKCkpCisgICAgICAgIGlmICgh bGluZXNBcmVGbGlwcGVkICYmIHJvb3QtPmlzRmlyc3RBZnRlclBhZ2VCcmVhaygpICYmIHBvaW50 SW5Mb2dpY2FsQ29udGVudHMueSgpIDwgcm9vdC0+bGluZVRvcFdpdGhMZWFkaW5nKCkpCiAgICAg ICAgICAgICBicmVhazsKIAogICAgICAgICBsYXN0Um9vdEJveFdpdGhDaGlsZHJlbiA9IHJvb3Q7 CiAKICAgICAgICAgLy8gY2hlY2sgaWYgdGhpcyByb290IGxpbmUgYm94IGlzIGxvY2F0ZWQgYXQg dGhpcyB5IGNvb3JkaW5hdGUKICAgICAgICAgaWYgKHBvaW50SW5Mb2dpY2FsQ29udGVudHMueSgp IDwgcm9vdC0+c2VsZWN0aW9uQm90dG9tKCkpIHsKKyAgICAgICAgICAgIGlmIChsaW5lc0FyZUZs aXBwZWQpIHsKKyAgICAgICAgICAgICAgICBSb290SW5saW5lQm94KiBuZXh0Um9vdEJveFdpdGhD aGlsZHJlbiA9IHJvb3QtPm5leHRSb290Qm94KCk7CisgICAgICAgICAgICAgICAgd2hpbGUgKG5l eHRSb290Qm94V2l0aENoaWxkcmVuICYmICFuZXh0Um9vdEJveFdpdGhDaGlsZHJlbi0+Zmlyc3RM ZWFmQ2hpbGQoKSkKKyAgICAgICAgICAgICAgICAgICAgbmV4dFJvb3RCb3hXaXRoQ2hpbGRyZW4g PSBuZXh0Um9vdEJveFdpdGhDaGlsZHJlbi0+bmV4dFJvb3RCb3goKTsKKworICAgICAgICAgICAg ICAgIGlmIChuZXh0Um9vdEJveFdpdGhDaGlsZHJlbiAmJiBuZXh0Um9vdEJveFdpdGhDaGlsZHJl bi0+aXNGaXJzdEFmdGVyUGFnZUJyZWFrKCkgJiYgcG9pbnRJbkxvZ2ljYWxDb250ZW50cy55KCkg Pj0gbmV4dFJvb3RCb3hXaXRoQ2hpbGRyZW4tPmxpbmVUb3BXaXRoTGVhZGluZygpKQorICAgICAg ICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGNsb3Nl c3RCb3ggPSByb290LT5jbG9zZXN0TGVhZkNoaWxkRm9yTG9naWNhbExlZnRQb3NpdGlvbihwb2lu dEluTG9naWNhbENvbnRlbnRzLngoKSk7CiAgICAgICAgICAgICBpZiAoY2xvc2VzdEJveCkKICAg ICAgICAgICAgICAgICBicmVhazsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzk0MikKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3 LTI3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSW4gZmxpcHBl ZCBsaW5lcyB3cml0aW5nIG1vZGVzLCBoaXQgdGVzdGluZyBhdCB0aGUgYmVnaW5uaW5nIG9mIGEg Y29sdW1uIG1heSByZXR1cm4gYSByZXN1bHQgZnJvbSB0aGUgcHJldmlvdXMgY29sdW1uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjU2NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9tdWx0aWNv bC9oaXQtdGVzdC1lbmQtb2YtY29sdW1uLXdpdGgtbGluZS1oZWlnaHQtZXhwZWN0ZWQudHh0OiBV cGRhdGVkLgorICAgICAgICAqIGZhc3QvbXVsdGljb2wvaGl0LXRlc3QtZW5kLW9mLWNvbHVtbi13 aXRoLWxpbmUtaGVpZ2h0Lmh0bWw6IEV4dGVuZGVkIHdpdGggdGVzdHMgZm9yCisgICAgICAgIGhv cml6b250YWwtYnQuCisKIDIwMTItMDctMjcgIFN1a29sc2FrIFNha3NodXdvbmcgIDxzdWtvbHNh a0Bnb29nbGUuY29tPgogCiAgICAgICAgIGV4ZWNDb21tYW5kIGNvcGllcyB0aGUgYmFja2dyb3Vu Zy1jb2xvciBvZiB0aGUgZW5jbG9zaW5nIGVsZW1lbnQgdG8gdGhlIGVsZW1lbnQgYmVpbmcgZWRp dGVkLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9oaXQtdGVzdC1lbmQtb2YtY29s dW1uLXdpdGgtbGluZS1oZWlnaHQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvbXVsdGljb2wvaGl0LXRlc3QtZW5kLW9mLWNvbHVtbi13aXRoLWxpbmUtaGVpZ2h0 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTIzOTEyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9tdWx0 aWNvbC9oaXQtdGVzdC1lbmQtb2YtY29sdW1uLXdpdGgtbGluZS1oZWlnaHQtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNiBAQAogTG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFt ZXQKIFBBU1MKIFBBU1MKK1BBU1MKK1BBU1MKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tdWx0 aWNvbC9oaXQtdGVzdC1lbmQtb2YtY29sdW1uLXdpdGgtbGluZS1oZWlnaHQuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2hpdC10ZXN0LWVuZC1vZi1jb2x1bW4t d2l0aC1saW5lLWhlaWdodC5odG1sCShyZXZpc2lvbiAxMjM5MTIpCisrKyBMYXlvdXRUZXN0cy9m YXN0L211bHRpY29sL2hpdC10ZXN0LWVuZC1vZi1jb2x1bW4td2l0aC1saW5lLWhlaWdodC5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC0yNyw0ICsyNywxNiBAQAogICAgIC8vIENsaWNraW5nIGFib3Zl IHRoZSBmaXJzdCBsaW5lIGluIHRoZSBzZWNvbmQgY29sdW1uIHNob3VsZCBub3Qgc25hcCB0byB0 aGUgYmVnaW5uaW5nIG9mIHRoZSBsaW5lLgogICAgIGhpdE9mZnNldCA9IGRvY3VtZW50LmNhcmV0 UmFuZ2VGcm9tUG9pbnQodGFyZ2V0Lm9mZnNldExlZnQgKyAyNTAsIHRhcmdldC5vZmZzZXRUb3Ag KyAyKS5zdGFydE9mZnNldDsKICAgICBsb2coaGl0T2Zmc2V0ID09PSAxNCA/ICJQQVNTIiA6ICJG QUlMOiBoaXQgb2Zmc2V0ICIgKyBoaXRPZmZzZXQgKyAiLiIpOworCisgICAgLy8gTm93IHRlc3Qg d2l0aCBhIGZsaXBwZWQgbGluZXMgd3JpdGluZyBtb2RlLgorICAgIHRhcmdldC5zdHlsZS53ZWJr aXRXcml0aW5nTW9kZSA9ICJob3Jpem9udGFsLWJ0IjsKKworICAgIC8vIENsaWNraW5nIGFib3Zl IHRoZSBsYXN0IGxpbmUgaW4gdGhlIGZpcnN0IGNvbHVtbiBzaG91bGQgbm90IHNlbGVjdCBhbnl0 aGluZyBmcm9tIHRoZSBmaXJzdAorICAgIC8vIGxpbmUgb24gdGhlIHNlY29uZCBjb2x1bW4uCisg ICAgaGl0T2Zmc2V0ID0gZG9jdW1lbnQuY2FyZXRSYW5nZUZyb21Qb2ludCh0YXJnZXQub2Zmc2V0 TGVmdCArIDE5MCwgdGFyZ2V0Lm9mZnNldFRvcCArIDMpLnN0YXJ0T2Zmc2V0OworICAgIGxvZyho aXRPZmZzZXQgPT09IDExID8gIlBBU1MiIDogIkZBSUw6IGhpdCBvZmZzZXQgIiArIGhpdE9mZnNl dCArICIuIik7CisKKyAgICAvLyBDbGlja2luZyBiZWxvdyB0aGUgZmlyc3QgbGluZSBpbiB0aGUg c2Vjb25kIGNvbHVtbiBzaG91bGQgbm90IHNuYXAgdG8gdGhlIGJlZ2lubmluZyBvZiB0aGUgbGlu ZS4KKyAgICBoaXRPZmZzZXQgPSBkb2N1bWVudC5jYXJldFJhbmdlRnJvbVBvaW50KHRhcmdldC5v ZmZzZXRMZWZ0ICsgMjUwLCB0YXJnZXQub2Zmc2V0VG9wICsgNzgpLnN0YXJ0T2Zmc2V0OworICAg IGxvZyhoaXRPZmZzZXQgPT09IDE0ID8gIlBBU1MiIDogIkZBSUw6IGhpdCBvZmZzZXQgIiArIGhp dE9mZnNldCArICIuIik7CiA8L3NjcmlwdD4K