92550 2012-07-27 14:49:09 -0700 Split functionality of MarkedAllocator::m_currentBlock 2012-07-27 15:59:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo ggaren oldest_to_newest 681110 0 mhahnenberg 2012-07-27 14:49:09 -0700 MarkedAllocator::m_currentBlock serves two purposes right now; it indicates the block that is currently being used for allocation and the beginning of the list of blocks that need to be swept. We should split these two functionalities into two separate fields. 681121 1 155058 mhahnenberg 2012-07-27 14:57:37 -0700 Created attachment 155058 Patch 681195 2 mhahnenberg 2012-07-27 15:59:34 -0700 Committed r123931: <http://trac.webkit.org/changeset/123931> 155058 2012-07-27 14:57:37 -0700 2012-07-27 15:18:12 -0700 Patch bug-92550-20120727145725.patch text/plain 5066 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIzOTE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDEyLTA3LTI3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU3BsaXQgZnVuY3Rpb25hbGl0eSBvZiBNYXJrZWRBbGxvY2F0b3I6Om1fY3VycmVu dEJsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h cmtlZEFsbG9jYXRvcjo6bV9jdXJyZW50QmxvY2sgc2VydmVzIHR3byBwdXJwb3NlcyByaWdodCBu b3c7IGl0IGluZGljYXRlcyB0aGUgYmxvY2sgdGhhdCBpcyBjdXJyZW50bHkgCisgICAgICAgIGJl aW5nIHVzZWQgZm9yIGFsbG9jYXRpb24gYW5kIHRoZSBiZWdpbm5pbmcgb2YgdGhlIGxpc3Qgb2Yg YmxvY2tzIHRoYXQgbmVlZCB0byBiZSBzd2VwdC4gV2Ugc2hvdWxkIHNwbGl0IAorICAgICAgICB0 aGVzZSB0d28gZnVuY3Rpb25hbGl0aWVzIGludG8gdHdvIHNlcGFyYXRlIGZpZWxkcy4KKworICAg ICAgICAqIGhlYXAvTWFya2VkQWxsb2NhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6TWFya2VkQWxs b2NhdG9yOjp0cnlBbGxvY2F0ZUhlbHBlcik6IFVzZSBtX2Jsb2Nrc1RvU3dlZXAgaW5zdGVhZCBv ZiBtX2N1cnJlbnRCbG9jayBhcyB0aGUgCisgICAgICAgIGluaXRpYWxpemVyL3JlZmVyZW5jZSBv ZiB0aGUgbG9vcC4gT25seSBjaGFuZ2UgbV9jdXJyZW50QmxvY2sgd2hlbiB3ZSBrbm93IHdoYXQg dGhlIHJlc3VsdCB3aWxsIGJlLgorICAgICAgICAoSlNDOjpNYXJrZWRBbGxvY2F0b3I6OmFkZEJs b2NrKTogV2hlbiB3ZSBhZGQgYSBuZXcgYmxvY2sgd2Uga25vdyB0aGF0IGJvdGggbV9ibG9ja3NU b1N3ZWVwIGFuZCAKKyAgICAgICAgbV9jdXJyZW50QmxvY2sgYXJlIG51bGwuIEluIG9yZGVyIHRv IHByZXNlcnZlIHRoZSBpbnZhcmlhbnQgdGhhdCBtX2N1cnJlbnRCbG9jayA8PSBtX2Jsb2Nrc1Rv U3dlZXAsIAorICAgICAgICB3ZSBhc3NpZ24gYm90aCBvZiB0aGVtIHRvIHBvaW50IHRvIHRoZSBu ZXcgYmxvY2suCisgICAgICAgIChKU0M6Ok1hcmtlZEFsbG9jYXRvcjo6cmVtb3ZlQmxvY2spOiBX ZSBuZWVkIGEgc2VwYXJhdGUgY2hlY2sgdG8gc2VlIGlmIHRoZSBibG9jayB3ZSdyZSByZW1vdmlu ZyBpcyAKKyAgICAgICAgbV9ibG9ja3NUb1N3ZWVwIGFuZCBpZiBzbywgYWR2YW5jZSBpdCB0byB0 aGUgbmV4dCBibG9jayBpbiB0aGUgbGlzdC4KKyAgICAgICAgKiBoZWFwL01hcmtlZEFsbG9jYXRv ci5oOgorICAgICAgICAoTWFya2VkQWxsb2NhdG9yKTogSW5pdGlhbGl6ZSBtX2Jsb2Nrc1RvU3dl ZXAuCisgICAgICAgIChKU0M6Ok1hcmtlZEFsbG9jYXRvcjo6TWFya2VkQWxsb2NhdG9yKToKKyAg ICAgICAgKEpTQzo6TWFya2VkQWxsb2NhdG9yOjpyZXNldCk6IFdlIHNldCBtX2Jsb2Nrc1RvU3dl ZXAgdG8gYmUgdGhlIGhlYWQgb2Ygb3VyIGxpc3QuIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkCisg ICAgICAgIGF0IHRoZSBlbmQgb2YgYSBjb2xsZWN0aW9uLCBzbyBhbGwgb2YgdGhlIGJsb2NrcyBp biBvdXIgYWxsb2NhdG9yIG5lZWQgdG8gYmUgc3dlcHQuIFdlIG5lZWQgdG8gc3dlZXAgYSAKKyAg ICAgICAgYmxvY2sgYmVmb3JlIHdlIGNhbiBzdGFydCBhbGxvY2F0aW5nLCBzbyBtX2N1cnJlbnRC bG9jayBpcyBzZXQgdG8gbnVsbC4gV2UgYWxzbyBzZXQgdGhlIGZyZWVMaXN0IHRvIAorICAgICAg ICB0aGUgZW1wdHkgRnJlZUxpc3QgdG8gZW1waGFzaXplIHRoZSBmYWN0IHRoYXQgd2UgY2FuJ3Qg c3RhcnQgYWxsb2NhdGluZyB1bnRpbCB3ZSBkbyBzb21lIHN3ZWVwaW5nLgorCiAyMDEyLTA3LTI3 ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgSW5j cmVhc2UgaW5saW5lIHN0b3JhZ2UgZm9yIEpTRmluYWxPYmplY3RzIGJ5IG9uZQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQWxsb2NhdG9yLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRBbGxvY2F0b3IuY3BwCShyZXZpc2lv biAxMjM5MTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRBbGxvY2F0b3Iu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxNSArMjksMTkgQEAgYm9vbCBNYXJrZWRBbGxvY2F0 b3I6OmlzUGFnZWRPdXQoZG91YmxlIAogaW5saW5lIHZvaWQqIE1hcmtlZEFsbG9jYXRvcjo6dHJ5 QWxsb2NhdGVIZWxwZXIoKQogewogICAgIGlmICghbV9mcmVlTGlzdC5oZWFkKSB7Ci0gICAgICAg IGZvciAoTWFya2VkQmxvY2sqJiBibG9jayA9IG1fY3VycmVudEJsb2NrOyBibG9jazsgYmxvY2sg PSBzdGF0aWNfY2FzdDxNYXJrZWRCbG9jayo+KGJsb2NrLT5uZXh0KCkpKSB7CisgICAgICAgIGZv ciAoTWFya2VkQmxvY2sqJiBibG9jayA9IG1fYmxvY2tzVG9Td2VlcDsgYmxvY2s7IGJsb2NrID0g c3RhdGljX2Nhc3Q8TWFya2VkQmxvY2sqPihibG9jay0+bmV4dCgpKSkgewogICAgICAgICAgICAg bV9mcmVlTGlzdCA9IGJsb2NrLT5zd2VlcChNYXJrZWRCbG9jazo6U3dlZXBUb0ZyZWVMaXN0KTsK LSAgICAgICAgICAgIGlmIChtX2ZyZWVMaXN0LmhlYWQpCisgICAgICAgICAgICBpZiAobV9mcmVl TGlzdC5oZWFkKSB7CisgICAgICAgICAgICAgICAgbV9jdXJyZW50QmxvY2sgPSBibG9jazsKICAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJsb2NrLT5k aWRDb25zdW1lRnJlZUxpc3QoKTsKICAgICAgICAgfQogICAgICAgICAKLSAgICAgICAgaWYgKCFt X2ZyZWVMaXN0LmhlYWQpCisgICAgICAgIGlmICghbV9mcmVlTGlzdC5oZWFkKSB7CisgICAgICAg ICAgICBtX2N1cnJlbnRCbG9jayA9IDA7CiAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAg fQogICAgIH0KICAgICAKICAgICBNYXJrZWRCbG9jazo6RnJlZUNlbGwqIGhlYWQgPSBtX2ZyZWVM aXN0LmhlYWQ7CkBAIC0xMDAsMTAgKzEwNCwxMSBAQCBNYXJrZWRCbG9jayogTWFya2VkQWxsb2Nh dG9yOjphbGxvY2F0ZUJsCiB2b2lkIE1hcmtlZEFsbG9jYXRvcjo6YWRkQmxvY2soTWFya2VkQmxv Y2sqIGJsb2NrKQogewogICAgIEFTU0VSVCghbV9jdXJyZW50QmxvY2spOworICAgIEFTU0VSVCgh bV9ibG9ja3NUb1N3ZWVwKTsKICAgICBBU1NFUlQoIW1fZnJlZUxpc3QuaGVhZCk7CiAgICAgCiAg ICAgbV9ibG9ja0xpc3QuYXBwZW5kKGJsb2NrKTsKLSAgICBtX2N1cnJlbnRCbG9jayA9IGJsb2Nr OworICAgIG1fYmxvY2tzVG9Td2VlcCA9IG1fY3VycmVudEJsb2NrID0gYmxvY2s7CiAgICAgbV9m cmVlTGlzdCA9IGJsb2NrLT5zd2VlcChNYXJrZWRCbG9jazo6U3dlZXBUb0ZyZWVMaXN0KTsKIH0K IApAQCAtMTEzLDYgKzExOCw4IEBAIHZvaWQgTWFya2VkQWxsb2NhdG9yOjpyZW1vdmVCbG9jayhN YXJrZWQKICAgICAgICAgbV9jdXJyZW50QmxvY2sgPSBzdGF0aWNfY2FzdDxNYXJrZWRCbG9jayo+ KG1fY3VycmVudEJsb2NrLT5uZXh0KCkpOwogICAgICAgICBtX2ZyZWVMaXN0ID0gTWFya2VkQmxv Y2s6OkZyZWVMaXN0KCk7CiAgICAgfQorICAgIGlmIChtX2Jsb2Nrc1RvU3dlZXAgPT0gYmxvY2sp CisgICAgICAgIG1fYmxvY2tzVG9Td2VlcCA9IHN0YXRpY19jYXN0PE1hcmtlZEJsb2NrKj4obV9i bG9ja3NUb1N3ZWVwLT5uZXh0KCkpOwogICAgIG1fYmxvY2tMaXN0LnJlbW92ZShibG9jayk7CiB9 CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEFsbG9jYXRvci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEFsbG9jYXRvci5o CShyZXZpc2lvbiAxMjM5MTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRB bGxvY2F0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsNyBAQCBwcml2YXRlOgogICAg IAogICAgIE1hcmtlZEJsb2NrOjpGcmVlTGlzdCBtX2ZyZWVMaXN0OwogICAgIE1hcmtlZEJsb2Nr KiBtX2N1cnJlbnRCbG9jazsKKyAgICBNYXJrZWRCbG9jayogbV9ibG9ja3NUb1N3ZWVwOwogICAg IERvdWJseUxpbmtlZExpc3Q8SGVhcEJsb2NrPiBtX2Jsb2NrTGlzdDsKICAgICBzaXplX3QgbV9j ZWxsU2l6ZTsKICAgICBib29sIG1fY2VsbHNOZWVkRGVzdHJ1Y3Rpb247CkBAIC01Niw2ICs1Nyw3 IEBAIHByaXZhdGU6CiAKIGlubGluZSBNYXJrZWRBbGxvY2F0b3I6Ok1hcmtlZEFsbG9jYXRvcigp CiAgICAgOiBtX2N1cnJlbnRCbG9jaygwKQorICAgICwgbV9ibG9ja3NUb1N3ZWVwKDApCiAgICAg LCBtX2NlbGxTaXplKDApCiAgICAgLCBtX2NlbGxzTmVlZERlc3RydWN0aW9uKHRydWUpCiAgICAg LCBtX29ubHlDb250YWluc1N0cnVjdHVyZXMoZmFsc2UpCkBAIC04Niw3ICs4OCw5IEBAIGlubGlu ZSB2b2lkKiBNYXJrZWRBbGxvY2F0b3I6OmFsbG9jYXRlKCkKIAogaW5saW5lIHZvaWQgTWFya2Vk QWxsb2NhdG9yOjpyZXNldCgpCiB7Ci0gICAgbV9jdXJyZW50QmxvY2sgPSBzdGF0aWNfY2FzdDxN YXJrZWRCbG9jayo+KG1fYmxvY2tMaXN0LmhlYWQoKSk7CisgICAgbV9jdXJyZW50QmxvY2sgPSAw OworICAgIG1fZnJlZUxpc3QgPSBNYXJrZWRCbG9jazo6RnJlZUxpc3QoKTsKKyAgICBtX2Jsb2Nr c1RvU3dlZXAgPSBzdGF0aWNfY2FzdDxNYXJrZWRCbG9jayo+KG1fYmxvY2tMaXN0LmhlYWQoKSk7 CiB9CiAKIGlubGluZSB2b2lkIE1hcmtlZEFsbG9jYXRvcjo6emFwRnJlZUxpc3QoKQo=