92549 2012-07-27 14:44:59 -0700 chromium win compile broken after removing webkit.py 2012-07-30 19:57:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric maruel ojan rniwa tomhudson tony webkit.review.bot oldest_to_newest 681105 0 dpranke 2012-07-27 14:44:59 -0700 chromium win compile broken after removing webkit.py 681108 1 155053 dpranke 2012-07-27 14:46:55 -0700 Created attachment 155053 Patch 681171 2 dpranke 2012-07-27 15:42:58 -0700 filed https://code.google.com/p/chromium/issues/detail?id=139426 for the problem with browser_tests.isolate (a file in chromium) listing files in webkit directly ... 681194 3 abarth 2012-07-27 15:58:52 -0700 I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice. 681196 4 155053 dpranke 2012-07-27 15:59:54 -0700 Comment on attachment 155053 Patch I land-cowboyed this but I guess it didn't update the bug (and I forgot to --no-review it) ... http://trac.webkit.org/changeset/123918 681197 5 dpranke 2012-07-27 16:00:19 -0700 (In reply to comment #3) > I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice. See the comment I just left on the chromium bug; he's not trying to use webkitpy, he's trying to run NRWT. 681199 6 dpranke 2012-07-27 16:01:11 -0700 now, how we're approaching the "sparse checkout" / isolate problem, and how it should interact w/ webkit, on the other hand, is something worth discussing. 681212 7 abarth 2012-07-27 16:11:15 -0700 I commented in the Chromium bug. The summary is that the existence of webkitpy is an implementation detail of WebKit and any mention of webkitpy outside svn.webkit.org can and will be broken without notice. 682559 8 dpranke 2012-07-30 17:25:40 -0700 i believe maruel has fixed the downstream error, so I'm going to remove the stub now ... 682561 9 155406 dpranke 2012-07-30 17:27:14 -0700 Created attachment 155406 Patch 682593 10 dpranke 2012-07-30 18:18:16 -0700 rubber stamp, anyone? 682657 11 155406 webkit.review.bot 2012-07-30 19:57:09 -0700 Comment on attachment 155406 Patch Clearing flags on attachment: 155406 Committed r124158: <http://trac.webkit.org/changeset/124158> 682658 12 webkit.review.bot 2012-07-30 19:57:14 -0700 All reviewed patches have been landed. Closing bug. 155053 2012-07-27 14:46:55 -0700 2012-07-30 17:27:10 -0700 Patch bug-92549-20120727144643.patch text/plain 3147 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDFiZjA4MTE5NTI5NjgwZTlhMmRkNzJjMjhmMjY1ZTRk YTNkYWUwMy4uNjMwZGZiMTA3OGM4M2E3ZTlmYjY0ZmJkYTI4MzhlZDFhNGEzMTRhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTA3LTI3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIGNocm9taXVtIHdpbiBjb21waWxlIGJyb2tlbiBhZnRlciByZW1vdmluZyB3ZWJraXQu cHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgdHVy bnMgb3V0IHRoYXQgdGhpcyBmaWxlIGlzIGxpc3RlZCBpbiB0aGUgY2hyb21pdW0gZG93bnN0cmVh bQorICAgICAgICAnYnJvd3Nlcl90ZXN0cy5pc29sYXRlJyBmaWxlLCBhbmQgc28gZGVsZXRpbmcg aXQgYnJva2UgZ3lwLgorICAgICAgICBBZGRpbmcgYSBzdHViIGZpbGUgYmFjayBpbiB1bnRpbCB3 ZSBjYW4gcmVtb3ZlIHRoZSBlbnRyeSBmcm9tCisgICAgICAgIHRoZSBmaWxlLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6IEFkZGVkLgor CisyMDEyLTA3LTI3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAg ICAgIG5yd3Q6IHJlbW92ZSAnd2Via2l0LnB5JyBhbmQgdGhlICdXZWJLaXRQb3J0JwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NTAKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpuZXcg ZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4wNTg3ODdjNzE1OGNlNTBlODA0YjdjOTNkOTk2MjBlNjVkZTJlMTViCi0tLSAvZGV2 L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHkKQEAgLTAsMCArMSwzNSBAQAorIyEvdXNyL2Jpbi9lbnYgcHl0aG9uCisjIENvcHlyaWdo dCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQg KEMpIDIwMTAgR2Fib3IgUmFwY3NhbnlpIDxyZ2Fib3JAaW5mLnUtc3plZ2VkLmh1PiwgVW5pdmVy c2l0eSBvZiBTemVnZWQKKyMgQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0 OgorIworIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4g dGhlIGFib3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBi aW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBp biB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGgg dGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgR29vZ2xlIG5hbWUgbm9y IHRoZSBuYW1lcyBvZiBpdHMKKyMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ug b3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyMgdGhpcyBzb2Z0d2FyZSB3aXRob3V0 IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJ UyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworIyAi QVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09OVFJJ QlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisj IFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcs IEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBP UiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNT IElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0YgTElB QklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisj IChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBP VVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCisjIEZJWE1FOiB0aGlzIGlzIGEgc3R1YiBm aWxlIG5lZWRlZCB0byBlbnN1cmUgdGhhdCBjaHJvbWUgc3RpbGwgY29tcGlsZXMKKyMgdW50aWwg d2UgY2FuIHJlbW92ZSB0aGlzIGZyb20gdGhlIGJyb3dzZXJfdGVzdHMuaXNvbGF0ZSBmaWxlIGRv d25zdHJlYW0uCisjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI1NDkKK3Bhc3MK 155406 2012-07-30 17:27:14 -0700 2012-07-30 19:57:09 -0700 Patch bug-92549-20120730172658.patch text/plain 2951 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjhmNTdjMzBiNTkxN2RmNTA1NzQ5YzVkMTIxNzA2NDky MTE0YWY3YS4uZmVlMjVlNDkwYTBkM2VhMjAxYmQ3ODkzNzUwODRkNTIyMWUyMmVkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA3LTMwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGNocm9taXVtIHdpbiBjb21waWxlIGJyb2tlbiBhZnRlciByZW1vdmluZyB3ZWJraXQu cHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl IHRoZSBzdHViIGZpbGUgZm9yIHdlYmtpdC5weSBub3cgdGhhdCBpdCdzIG5vIGxvbmdlcgorICAg ICAgICBuZWNlc3NhcnkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3dlYmtpdC5weTogUmVtb3ZlZC4KKwogMjAxMi0wNy0yOCAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBhYmlsaXR5IHRvIGxvYWQgZnJvbSBhIHN0cmlu ZyB0byB0aGUgT2JqQyBXSyBBUEkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDA1 ODc4N2M3MTU4Y2U1MGU4MDRiN2M5M2Q5OTYyMGU2NWRlMmUxNWIuLjAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKKysrIC9kZXYvbnVsbApAQCAtMSwzNSArMCwwIEBACi0j IS91c3IvYmluL2VudiBweXRob24KLSMgQ29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCi0jIENvcHlyaWdodCAoQykgMjAxMCBHYWJvciBSYXBjc2FueWkg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+LCBVbml2ZXJzaXR5IG9mIFN6ZWdlZAotIyBDb3B5cmln aHQgKEMpIDIwMTEsIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotIwotIyBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKLSMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQotIyBtZXQ6Ci0jCi0jICAgICAqIFJlZGlzdHJpYnV0 aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0jIG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l ci4KLSMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNl IHRoZSBhYm92ZQotIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCi0jIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKLSMgZGlzdHJpYnV0aW9uLgotIyAg ICAgKiBOZWl0aGVyIHRoZSBHb29nbGUgbmFtZSBub3IgdGhlIG5hbWVzIG9mIGl0cwotIyBjb250 cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2 ZWQgZnJvbQotIyB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBw ZXJtaXNzaW9uLgotIwotIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklH SFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCi0jICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9S IElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCi0jIExJTUlURUQgVE8sIFRI RSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgot IyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwg VEhFIENPUFlSSUdIVAotIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkg RElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKLSMgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBD T05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAotIyBMSU1JVEVEIFRPLCBQ Uk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwK LSMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQgT04gQU5ZCi0jIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJB Q1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKLSMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0jIE9GIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCi0KLSMgRklYTUU6IHRoaXMgaXMgYSBzdHViIGZpbGUgbmVlZGVkIHRvIGVuc3VyZSB0aGF0 IGNocm9tZSBzdGlsbCBjb21waWxlcwotIyB1bnRpbCB3ZSBjYW4gcmVtb3ZlIHRoaXMgZnJvbSB0 aGUgYnJvd3Nlcl90ZXN0cy5pc29sYXRlIGZpbGUgZG93bnN0cmVhbS4KLSMgU2VlIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjU0OQotcGFzcwo=