92540 2012-07-27 13:03:18 -0700 Web Inspector: workers inspector is broken in the remote debugging mode 2012-07-30 01:58:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi kpiascik loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 681005 0 pfeldman 2012-07-27 13:03:18 -0700 The problem is that worker manager re-uses complete url with query parameters for spin-off worker front-ends. In case of remote debugging, newly created front-end attempts to connect to the same web socket (because of the ws parameter). 681015 1 155035 pfeldman 2012-07-27 13:09:55 -0700 Created attachment 155035 Patch 681047 2 155042 pfeldman 2012-07-27 13:50:44 -0700 Created attachment 155042 Patch 681780 3 155042 webkit.review.bot 2012-07-30 01:58:00 -0700 Comment on attachment 155042 Patch Clearing flags on attachment: 155042 Committed r124005: <http://trac.webkit.org/changeset/124005> 681781 4 webkit.review.bot 2012-07-30 01:58:05 -0700 All reviewed patches have been landed. Closing bug. 155035 2012-07-27 13:09:55 -0700 2012-07-27 13:50:33 -0700 Patch bug-92540-20120728000939.patch text/plain 1641 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ1YTc3MGYwNzYxMGNl NDA0MzAzYTI1OWYzNTEyYTNhYTg4NDk0YS4uOTUxZTgyMWFiYTlkZWU0YzAxZDgzNzAyMjllODQ2 NWM5YjVhYjUxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI3ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHdvcmtlcnMgaW5zcGVjdG9yIGlzIGJyb2tlbiBpbiB0aGUgcmVtb3RlIGRlYnVnZ2luZyBt b2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjU0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBw cm9ibGVtIHdhcyB0aGF0IHdvcmtlciBtYW5hZ2VyIHJlLXVzZWQgY29tcGxldGUgdXJsIHdpdGgg cXVlcnkgcGFyYW1ldGVycworICAgICAgICBmb3Igc3Bpbi1vZmYgd29ya2VyIGZyb250LWVuZHMu IEFzIGEgcmVzdWx0LCBpbiBjYXNlIG9mIHJlbW90ZSBkZWJ1Z2dpbmcsIG5ld2x5CisgICAgICAg IGNyZWF0ZWQgZnJvbnQtZW5kcyB3ZXJlIGNvbm5lY3RpbmcgdG8gdGhlIHNhbWUgd2ViIHNvY2tl dCAoYmVjYXVzZSBvZiB0aGUgd3MgcGFyYW1ldGVyKS4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzOgorCiAyMDEyLTA3LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIx MjM2MjQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2lu c3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9y LmpzCmluZGV4IGMyYTA5N2Y4M2VlOTZlNTY5MTkzZTY0MzQ5ZjJhNzViNjk2OGE0NTAuLmEzMTBj ZGI1MDhkNzRkNjFmOTRhZWIyMzA3ZTk5ZjI0NDNkNTk2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0zOTMsNiArMzkzLDEyIEBA IFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiB7CiAgICAgSW5zcGVjdG9yQmFja2Vu ZC5sb2FkRnJvbUpTT05JZk5lZWRlZCgpOwogCisgICAgaWYgKFdlYkluc3BlY3Rvci5Xb3JrZXJN YW5hZ2VyLmlzV29ya2VyRnJvbnRlbmQoKSkgeworICAgICAgICAvLyBEbyBub3QgY3JlYXRlIHNv Y2tldCBmb3IgdGhlIHdvcmtlciBmcm9udC1lbmQuCisgICAgICAgIFdlYkluc3BlY3Rvci5kb0xv YWRlZERvbmUoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIHZhciB3czsKICAgICBp ZiAoIndzIiBpbiBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3QpCiAgICAgICAgIHdzID0g IndzOi8vIiArIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdC53czsK 155042 2012-07-27 13:50:44 -0700 2012-07-30 01:58:00 -0700 Patch bug-92540-20120728005031.patch text/plain 2506 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ1YTc3MGYwNzYxMGNl NDA0MzAzYTI1OWYzNTEyYTNhYTg4NDk0YS4uNjdkNjU5MTZhNzJlMmE4ZDU1NDAzOTk3NDlmMDcx MDhkNmVhMmNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI3ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHdvcmtlcnMgaW5zcGVjdG9yIGlzIGJyb2tlbiBpbiB0aGUgcmVtb3RlIGRlYnVnZ2luZyBt b2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjU0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBw cm9ibGVtIHdhcyB0aGF0IHdvcmtlciBtYW5hZ2VyIHJlLXVzZWQgY29tcGxldGUgdXJsIHdpdGgg cXVlcnkgcGFyYW1ldGVycworICAgICAgICBmb3Igc3Bpbi1vZmYgd29ya2VyIGZyb250LWVuZHMu IEFzIGEgcmVzdWx0LCBpbiBjYXNlIG9mIHJlbW90ZSBkZWJ1Z2dpbmcsIG5ld2x5CisgICAgICAg IGNyZWF0ZWQgZnJvbnQtZW5kcyB3ZXJlIGNvbm5lY3RpbmcgdG8gdGhlIHNhbWUgd2ViIHNvY2tl dCAoYmVjYXVzZSBvZiB0aGUgd3MgcGFyYW1ldGVyKS4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvV29ya2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Xb3JrZXJN YW5hZ2VyLmlzRGVkaWNhdGVkV29ya2VyRnJvbnRlbmQpOgorICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzOgorCiAyMDEyLTA3LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIx MjM2MjQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dv cmtlck1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dvcmtl ck1hbmFnZXIuanMKaW5kZXggMzdmNDY3OGY3ZjRmOWIxZDM4MTdhMTU0YmFhN2U4MjhlNTNjOWYx Ni4uZWMyOTVkNDQ5YzIwODliY2Q1MDkwZmM1NjYxNjA5NDE2YmVkMjNmMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Xb3JrZXJNYW5hZ2VyLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV29ya2VyTWFuYWdlci5qcwpAQCAt NDQsNiArNDQsMTEgQEAgV2ViSW5zcGVjdG9yLldvcmtlck1hbmFnZXIuaXNXb3JrZXJGcm9udGVu ZCA9IGZ1bmN0aW9uKCkKICAgICAgICAgICAgISFXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmpl Y3RbImlzU2hhcmVkV29ya2VyIl07CiB9CiAKK1dlYkluc3BlY3Rvci5Xb3JrZXJNYW5hZ2VyLmlz RGVkaWNhdGVkV29ya2VyRnJvbnRlbmQgPSBmdW5jdGlvbigpCit7CisgICAgcmV0dXJuICEhV2Vi SW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0WyJkZWRpY2F0ZWRXb3JrZXJJZCJdOworfQorCiBX ZWJJbnNwZWN0b3IuV29ya2VyTWFuYWdlci5sb2FkZWQgPSBmdW5jdGlvbigpCiB7CiAgICAgdmFy IHdvcmtlcklkID0gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0WyJkZWRpY2F0ZWRXb3Jr ZXJJZCJdOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwppbmRleCBjMmEwOTdmODNlZTk2ZTU2OTE5M2U2NDM0OWYyYTc1YjY5NjhhNDUwLi4xNzZj MGM0ZDQ3NmNiOWZlNzZhMDk5MWU2NzZmNjlhMzI4ZTBlN2E0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtMzkzLDYgKzM5MywxMiBA QCBXZWJJbnNwZWN0b3IubG9hZGVkID0gZnVuY3Rpb24oKQogewogICAgIEluc3BlY3RvckJhY2tl bmQubG9hZEZyb21KU09OSWZOZWVkZWQoKTsKIAorICAgIGlmIChXZWJJbnNwZWN0b3IuV29ya2Vy TWFuYWdlci5pc0RlZGljYXRlZFdvcmtlckZyb250ZW5kKCkpIHsKKyAgICAgICAgLy8gRG8gbm90 IGNyZWF0ZSBzb2NrZXQgZm9yIHRoZSB3b3JrZXIgZnJvbnQtZW5kLgorICAgICAgICBXZWJJbnNw ZWN0b3IuZG9Mb2FkZWREb25lKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICB2YXIg d3M7CiAgICAgaWYgKCJ3cyIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0KQogICAg ICAgICB3cyA9ICJ3czovLyIgKyBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3Qud3M7Cg==