92531 2012-07-27 12:09:27 -0700 Build fails because of missing header in GregorianDateTime.h 2012-07-27 14:41:18 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Windows XP RESOLVED FIXED P2 Normal --- 0 tuxator webkit-unassigned paroga oldest_to_newest 680923 0 tuxator 2012-07-27 12:09:27 -0700 WebKit fails to build with MinGW compiler with the following error: In file included from Source/JavaScriptCore/runtime/DateConversion.h:45:0, from Source/JavaScriptCore/runtime/DateConversion.cpp:44: ./Source/WTF/wtf/GregorianDateTime.h:71:14: error: expected type-specifier before 'tm' Source/JavaScriptCore/runtime/DateConversion.cpp: In function 'void JSC::formatTime(const WTF::GregorianDateTime&, char (&)[100])': Source/JavaScriptCore/runtime/DateConversion.cpp:76:21: error: conversion from 'const WTF::GregorianDateTime' to non-scalar type 'tm' requested make[1]: *** [Source/JavaScriptCore/runtime/libjavascriptcoregtk_3_0_la-DateConversion.lo] Error 1 make[1]: Leaving directory `/home/pawel/src/webkit' make: *** [all] Error 2 680937 1 155016 tuxator 2012-07-27 12:16:24 -0700 Created attachment 155016 proposed patch 681048 2 155016 paroga 2012-07-27 13:50:57 -0700 Comment on attachment 155016 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=155016&action=review > Source/WTF/wtf/GregorianDateTime.h:30 > +#if OS(WINDOWS) OS(WINDOWS) isn't needed. time.h should get included everywhere 681065 3 155045 tuxator 2012-07-27 14:03:22 -0700 Created attachment 155045 update 681072 4 155045 paroga 2012-07-27 14:07:45 -0700 Comment on attachment 155045 update View in context: https://bugs.webkit.org/attachment.cgi?id=155045&action=review i'll fix the two issues and land this patch > Source/WTF/ChangeLog:3 > + Build fails because of missing header in GregorianDateTime.h since this happens only with mingw this should be mentioned here > Source/WTF/wtf/GregorianDateTime.h:28 > #include <wtf/text/CString.h> 1) sort order 2) <wtf/text/CString.h> can be replaced with <wtf/Noncopyable.h> 681100 5 paroga 2012-07-27 14:41:18 -0700 Committed r123917: <http://trac.webkit.org/changeset/123917> 155016 2012-07-27 12:16:24 -0700 2012-07-27 14:03:22 -0700 proposed patch buildfix.diff text/plain 911 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDU1NzU5OC4uMzBjN2Y4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wNy0yNyAg UGF3ZcWCIEZvcnlzaXVrICA8dHV4YXRvckBvMi5wbD4KKworICAgICAgICBCdWlsZCBmYWlscyBi ZWNhdXNlIG9mIG1pc3NpbmcgaGVhZGVyIGluIEdyZWdvcmlhbkRhdGVUaW1lLmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTMxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvR3JlZ29yaWFuRGF0 ZVRpbWUuaDogSW5jbHVkZSB0aW1lLmggZm9yIE9TKFdJTkRPV1MpCisKIDIwMTItMDctMjYgIEFy bmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBj b25zdHJ1Y3RpbmcgVHlwZWRBcnJheSBmcm9tIGFub3RoZXIgVHlwZWRBcnJheSBpcyBzbG93CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9HcmVnb3JpYW5EYXRlVGltZS5oIGIvU291cmNlL1dU Ri93dGYvR3JlZ29yaWFuRGF0ZVRpbWUuaAppbmRleCBjN2Q3M2VhLi4zNDA2MmVhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9HcmVnb3JpYW5EYXRlVGltZS5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL0dyZWdvcmlhbkRhdGVUaW1lLmgKQEAgLTI3LDYgKzI3LDEwIEBACiAKICNpbmNsdWRlIDx3 dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNpZiBPUyhXSU5ET1dTKQorI2luY2x1ZGUgPHRpbWUuaD4K KyNlbmRpZgorCiBuYW1lc3BhY2UgV1RGIHsKIAogY2xhc3MgR3JlZ29yaWFuRGF0ZVRpbWUgewo= 155045 2012-07-27 14:03:22 -0700 2012-07-27 14:07:44 -0700 update buildfix.diff text/plain 873 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDU1NzU5OC4uMGEwYzAwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wNy0yNyAg UGF3ZcWCIEZvcnlzaXVrICA8dHV4YXRvckBvMi5wbD4KKworICAgICAgICBCdWlsZCBmYWlscyBi ZWNhdXNlIG9mIG1pc3NpbmcgaGVhZGVyIGluIEdyZWdvcmlhbkRhdGVUaW1lLmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTMxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvR3JlZ29yaWFuRGF0 ZVRpbWUuaDogSW5jbHVkZSB0aW1lLmgKKwogMjAxMi0wNy0yNiAgQXJuYXVkIFJlbmV2aWVyICA8 YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIGNvbnN0cnVjdGluZyBUeXBl ZEFycmF5IGZyb20gYW5vdGhlciBUeXBlZEFycmF5IGlzIHNsb3cKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL0dyZWdvcmlhbkRhdGVUaW1lLmggYi9Tb3VyY2UvV1RGL3d0Zi9HcmVnb3JpYW5E YXRlVGltZS5oCmluZGV4IGM3ZDczZWEuLjdiZDdkMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL0dyZWdvcmlhbkRhdGVUaW1lLmgKKysrIGIvU291cmNlL1dURi93dGYvR3JlZ29yaWFuRGF0 ZVRpbWUuaApAQCAtMjYsNiArMjYsNyBAQAogI2RlZmluZSBXVEZfR3JlZ29yaWFuRGF0ZVRpbWVf aAogCiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgorI2luY2x1ZGUgPHRpbWUuaD4KIAog bmFtZXNwYWNlIFdURiB7CiAK