92523 2012-07-27 11:36:38 -0700 Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled 2012-07-27 15:41:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cmarcelo eric macpherson menard ojan simon.fraser webkit.review.bot oldest_to_newest 680868 0 cdumez 2012-07-27 11:36:38 -0700 We get the following build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled: /home/chris/unencrypted/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2022:12: warning: enumeration value ‘StickyPosition’ not handled in switch [-Wswitch] 680895 1 155004 cdumez 2012-07-27 11:54:51 -0700 Created attachment 155004 Patch 680995 2 155004 simon.fraser 2012-07-27 12:52:04 -0700 Comment on attachment 155004 Patch Why did this warn? I don't want the ENABLE(CSS_STICKY_POSITION) to propagate into style/layout code. 681000 3 cdumez 2012-07-27 12:57:30 -0700 (In reply to comment #2) > (From update of attachment 155004 [details]) > Why did this warn? I don't want the ENABLE(CSS_STICKY_POSITION) to propagate into style/layout code. Well, alternatively, we can change move the #ifdef at Source/WebCore/css/CSSPrimitiveValueMappings.h:2022 so that it does not cover the StickyPosition case, only the code inside the "case". 681001 4 simon.fraser 2012-07-27 12:59:12 -0700 Sorry, I see you pasted the warning. We should fix this in CSSPrimitiveValueMappings.h. 681003 5 155030 cdumez 2012-07-27 13:01:28 -0700 Created attachment 155030 Patch Second attempt. 681168 6 155030 webkit.review.bot 2012-07-27 15:41:27 -0700 Comment on attachment 155030 Patch Clearing flags on attachment: 155030 Committed r123928: <http://trac.webkit.org/changeset/123928> 681169 7 webkit.review.bot 2012-07-27 15:41:32 -0700 All reviewed patches have been landed. Closing bug. 155004 2012-07-27 11:54:51 -0700 2012-07-27 13:01:28 -0700 Patch 92523_warning_fix.patch text/plain 2580 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OWQ2M2YxLi40YTYxZTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDctMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5nIGluIENTU1ByaW1pdGl2ZVZhbHVlTWFwcGlu Z3MuaCB3aGVuIENTU19TVElDS1lfUE9TSVRJT04gaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTIzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgZmV3IG1vcmUgI2lmZGVmcyBm b3IgQ1NTX1NUSUNLWV9QT1NJVElPTiBpbiBvcmRlciB0byBzaWxlbnQKKyAgICAgICAgYSBjb21w aWxhdGlvbiB3YXJuaW5nIGluIENTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCB3aGVuCisgICAg ICAgIENTU19TVElDS1lfUE9TSVRJT04gaXMgZGlzYWJsZWQuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHls ZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldFBvc2l0aW9uT2Zmc2V0VmFs dWUpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oOgor CiAyMDEyLTA3LTI3ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KIAogICAgICAgICBbQmxh Y2tCZXJyeV0gVXBkYXRlIE5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzIHRv IHVzZSBuZXcgZ2V0UHJveHlBZGRyZXNzIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCBhZTI0OGVkLi40ODU5OWE1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9u LmNwcApAQCAtNjA4LDcgKzYwOCwxMSBAQCBzdGF0aWMgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gZ2V0 UG9zaXRpb25PZmZzZXRWYWx1ZShSZW5kZXJTdHlsZSogc3R5bGUsIENTU1Byb3BlcgogICAgICAg ICByZXR1cm4gY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUobCk7CiAgICAgfQogCi0gICAgaWYg KHN0eWxlLT5wb3NpdGlvbigpID09IFJlbGF0aXZlUG9zaXRpb24gfHwgc3R5bGUtPnBvc2l0aW9u KCkgPT0gU3RpY2t5UG9zaXRpb24pIHsKKyAgICBpZiAoc3R5bGUtPnBvc2l0aW9uKCkgPT0gUmVs YXRpdmVQb3NpdGlvbgorI2lmIEVOQUJMRShDU1NfU1RJQ0tZX1BPU0lUSU9OKQorICAgICAgICB8 fCBzdHlsZS0+cG9zaXRpb24oKSA9PSBTdGlja3lQb3NpdGlvbgorI2VuZGlmCisgICAgICAgKSB7 CiAgICAgICAgIC8vIEZJWE1FOiBJdCdzIG5vdCBlbm91Z2ggdG8gc2ltcGx5IHJldHVybiAiYXV0 byIgdmFsdWVzIGZvciBvbmUgb2Zmc2V0IGlmIHRoZSBvdGhlciBzaWRlIGlzIGRlZmluZWQuCiAg ICAgICAgIC8vIEluIG90aGVyIHdvcmRzIGlmIGxlZnQgaXMgYXV0byBhbmQgcmlnaHQgaXMgbm90 IGF1dG8sIHRoZW4gbGVmdCdzIGNvbXB1dGVkIHZhbHVlIGlzIG5lZ2F0aXZlIHJpZ2h0KCkuCiAg ICAgICAgIC8vIFNvIHdlIHNob3VsZCBnZXQgdGhlIG9wcG9zaXRlIGxlbmd0aCB1bml0IGFuZCBz ZWUgaWYgaXQgaXMgYXV0by4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKaW5kZXggMTQ5Y2Q0NC4uYmQyMjlkZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRz LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3Rh bnRzLmgKQEAgLTk0LDcgKzk0LDEwIEBAIGVudW0gRUJvcmRlclByZWNlZGVuY2UgeyBCT0ZGLCBC VEFCTEUsIEJDT0xHUk9VUCwgQkNPTCwgQlJPV0dST1VQLCBCUk9XLCBCQ0VMTCB9CiBlbnVtIE91 dGxpbmVJc0F1dG8geyBBVVRPX09GRiA9IDAsIEFVVE9fT04gfTsKIAogZW51bSBFUG9zaXRpb24g ewotICAgIFN0YXRpY1Bvc2l0aW9uLCBSZWxhdGl2ZVBvc2l0aW9uLCBBYnNvbHV0ZVBvc2l0aW9u LCBGaXhlZFBvc2l0aW9uLCBTdGlja3lQb3NpdGlvbgorICAgIFN0YXRpY1Bvc2l0aW9uLCBSZWxh dGl2ZVBvc2l0aW9uLCBBYnNvbHV0ZVBvc2l0aW9uLCBGaXhlZFBvc2l0aW9uLAorI2lmIEVOQUJM RShDU1NfU1RJQ0tZX1BPU0lUSU9OKQorICAgIFN0aWNreVBvc2l0aW9uCisjZW5kaWYKIH07CiAK IGVudW0gRUZsb2F0IHsK 155030 2012-07-27 13:01:28 -0700 2012-07-27 15:41:27 -0700 Patch 92523_warning_fix.patch text/plain 1483 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OWQ2M2YxLi45ZWFkZTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5nIGluIENTU1ByaW1pdGl2ZVZhbHVlTWFwcGlu Z3MuaCB3aGVuIENTU19TVElDS1lfUE9TSVRJT04gaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNTIzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSAjaWZkZWYgaW4gQ1NTUHJpbWl0 aXZlVmFsdWVNYXBwaW5ncy5oIHRvIHNpbGVudCBjb21waWxhdGlvbiB3YXJuaW5nCisgICAgICAg IHdoZW4gQ1NTX1NUSUNLWV9QT1NJVElPTiBpcyBkaXNhYmxlZC4KKworICAgICAgICBObyBuZXcg dGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVW YWx1ZU1hcHBpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Q1NT UHJpbWl0aXZlVmFsdWUpOgorCiAyMDEyLTA3LTI3ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBkYXRlIE5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0 V2l0aENyZWRlbnRpYWxzIHRvIHVzZSBuZXcgZ2V0UHJveHlBZGRyZXNzIEFQSQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXggYTg4ZjQ5Yy4u Njg1MmMxMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZU1hcHBpbmdzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFw cGluZ3MuaApAQCAtMjAzMiwxMSArMjAzMiwxMSBAQCB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoRVBvc2l0aW9uIGUpCiAgICAgICAgIGNhc2Ug Rml4ZWRQb3NpdGlvbjoKICAgICAgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUZpeGVk OwogICAgICAgICAgICAgYnJlYWs7Ci0jaWYgRU5BQkxFKENTU19TVElDS1lfUE9TSVRJT04pCiAg ICAgICAgIGNhc2UgU3RpY2t5UG9zaXRpb246CisjaWYgRU5BQkxFKENTU19TVElDS1lfUE9TSVRJ T04pCiAgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVXZWJraXRTdGlja3k7Ci0g ICAgICAgICAgICBicmVhazsKICNlbmRpZgorICAgICAgICAgICAgYnJlYWs7CiAgICAgfQogfQog Cg==